[jira] [Commented] (KAFKA-7641) Add `consumer.group.max.size` to cap consumer metadata size on broker

[ https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503356#comment-17503356 ] Justin Jack commented on KAFKA-7641: That's a great explanation. Crystal clear. Thanks a lot for this

[GitHub] [kafka] dajac commented on pull request #11843: MINOR: Correct logging and Javadoc in FetchSessionHandler

dajac commented on pull request #11843: URL: https://github.com/apache/kafka/pull/11843#issuecomment-1062644438 @showuon Can we merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon edited a comment on pull request #11855: MINOR: Clarify producer batch.size in upgrade docs

showuon edited a comment on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1062600064 @peterwanner , since this `removing existing public option` needs KIP discussion/voting, and the v3.2.0 already KIP freezed, I think we should revert the change we did

[GitHub] [kafka] showuon commented on pull request #11855: MINOR: Clarify producer batch.size in upgrade docs

showuon commented on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1062600064 @peterwanner , since this `removing existing public option` needs KIP discussion/voting, and the v3.2.0 already KIP freezed, I think we should revert the change we did in

[GitHub] [kafka] dajac merged pull request #11832: MINOR: Clean up AlterIsrManager code

dajac merged pull request #11832: URL: https://github.com/apache/kafka/pull/11832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11796: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

vamossagar12 commented on a change in pull request #11796: URL: https://github.com/apache/kafka/pull/11796#discussion_r822308654 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -116,14 +123,30 @@ public

[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

ableegoldman commented on pull request #11867: URL: https://github.com/apache/kafka/pull/11867#issuecomment-1062571710 Hey @wcarlson5 @guozhangwang @vvcephei @showuon can I get a very quick review for this ~10 line fix? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ableegoldman opened a new pull request #11867: KAFKA-12648: include IOException and topologyName in the wrapping StreamsException when clearing named topology state fails

ableegoldman opened a new pull request #11867: URL: https://github.com/apache/kafka/pull/11867 Quick fix to make sure we log the actual source of the failure both in the actual log message as well as the StreamsException that we bubble up to the user's exception handler, and also to

[jira] [Comment Edited] (KAFKA-13667) add a constraints in listeners in combined mode

[ https://issues.apache.org/jira/browse/KAFKA-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503248#comment-17503248 ] dengziming edited comment on KAFKA-13667 at 3/9/22, 2:35 AM: - we can't only

[jira] [Commented] (KAFKA-13667) add a constraints in listeners in combined mode

[ https://issues.apache.org/jira/browse/KAFKA-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503248#comment-17503248 ] dengziming commented on KAFKA-13667: we can't only list controller listener here in combined mode

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11817: KAFKA-13438: Replace EasyMock and PowerMock with Mockito in WorkerTest

LiamClarkeNZ commented on a change in pull request #11817: URL: https://github.com/apache/kafka/pull/11817#discussion_r822201244 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java ## @@ -1468,36 +1287,7 @@ private void

[jira] [Assigned] (KAFKA-13649) StandardAuthorizer should not finish loading until it reads up to the high water mark

[ https://issues.apache.org/jira/browse/KAFKA-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-13649: Assignee: Colin McCabe (was: Jose Armando Garcia Sancio) > StandardAuthorizer should

[GitHub] [kafka] infa-rbliznet commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

infa-rbliznet commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1062401482 Is there any progress on it? According to this: https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.2.0 , KIP should be completed by March 2 and Feature

[jira] [Commented] (KAFKA-13683) Transactional Producer - Transaction with key xyz went wrong with exception: Timeout expired after 60000milliseconds while awaiting InitProducerId

[ https://issues.apache.org/jira/browse/KAFKA-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503218#comment-17503218 ] Matthias J. Sax commented on KAFKA-13683: - {quote}We are using kakfa streams 3.0. {quote} Should

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503214#comment-17503214 ] Matthias J. Sax commented on KAFKA-13699: - Seems the only question is, if we need to update the

[jira] [Updated] (KAFKA-13699) ProcessorContext does not expose Stream Time

[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13699: Labels: newbie (was: ) > ProcessorContext does not expose Stream Time >

[jira] [Commented] (KAFKA-6035) Avoid creating changelog topics for state stores that are directly piped to a sink topic

[ https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503213#comment-17503213 ] Matthias J. Sax commented on KAFKA-6035: Even if this ticket is finished, if you call

[GitHub] [kafka] wcarlson5 opened a new pull request #11866: MINOR: Offset Result is separate

wcarlson5 opened a new pull request #11866: URL: https://github.com/apache/kafka/pull/11866 fix a rename issue so that blocking on offset reset is possible ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] vvcephei merged pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

vvcephei merged pull request #11848: URL: https://github.com/apache/kafka/pull/11848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

vvcephei commented on pull request #11848: URL: https://github.com/apache/kafka/pull/11848#issuecomment-1062155813 Thanks for the review, @mjsax ! I like your suggestion about reordering that expression, but I think I'll go ahead and merge, rather than waiting for CIT again. The

[GitHub] [kafka] vvcephei commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

vvcephei commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r822019343 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] wcarlson5 closed pull request #11859: MINOR: fix the query prefix to not have an extra "-"

wcarlson5 closed pull request #11859: URL: https://github.com/apache/kafka/pull/11859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

vincent81jiang commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r821986892 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1003,6 +1003,9 @@ void

[jira] [Updated] (KAFKA-13715) Add "generation" field into consumer protocol

[ https://issues.apache.org/jira/browse/KAFKA-13715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13715: -- Fix Version/s: 3.3.0 > Add "generation" field into consumer protocol >

[GitHub] [kafka] hachikuji commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

hachikuji commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1062078780 @showuon Thanks for the update. What do you think about modifying the heartbeating logic so that we do not advertise an offset to the controller until it has been published?

[GitHub] [kafka] dajac edited a comment on pull request #11861: MINOR: Fix flaky test cases SocketServerTest.remoteCloseWithoutBufferedReceives and SocketServerTest.remoteCloseWithIncompleteBufferedRe

dajac edited a comment on pull request #11861: URL: https://github.com/apache/kafka/pull/11861#issuecomment-1062056198 Failed tests are not related. Merging to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on pull request #11861: MINOR: Fix flaky test cases SocketServerTest.remoteCloseWithoutBufferedReceives and SocketServerTest.remoteCloseWithIncompleteBufferedReceive

dajac commented on pull request #11861: URL: https://github.com/apache/kafka/pull/11861#issuecomment-1062063421 @vincent81jiang Thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

mjsax commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r821935971 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

mjsax commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r821933290 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

mjsax commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r821933290 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

mjsax commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r821932810 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

mjsax commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r821932309 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] dajac merged pull request #11861: MINOR: Fix flaky test cases SocketServerTest.remoteCloseWithoutBufferedReceives and SocketServerTest.remoteCloseWithIncompleteBufferedReceive

dajac merged pull request #11861: URL: https://github.com/apache/kafka/pull/11861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11861: MINOR: Fix flaky test cases SocketServerTest.remoteCloseWithoutBufferedReceives and SocketServerTest.remoteCloseWithIncompleteBufferedReceive

dajac commented on pull request #11861: URL: https://github.com/apache/kafka/pull/11861#issuecomment-1062056198 Failed tests are not related. Merging to trunk and to 3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

dajac commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r821929304 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1003,6 +1003,9 @@ void

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

vincent81jiang commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r821926244 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1003,6 +1003,9 @@ void

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

vincent81jiang commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r821924997 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1003,6 +1003,9 @@ void

[GitHub] [kafka] mimaison commented on a change in pull request #11833: KAFKA-13671: Add ppc64le build stage

mimaison commented on a change in pull request #11833: URL: https://github.com/apache/kafka/pull/11833#discussion_r821892267 ## File path: Jenkinsfile ## @@ -178,6 +178,24 @@ pipeline { echo 'Skipping Kafka Streams archetype test for ARM build' }

[GitHub] [kafka] mimaison opened a new pull request #11865: Switch ARM and PowerPC builds to Scala 2.13

mimaison opened a new pull request #11865: URL: https://github.com/apache/kafka/pull/11865 todo: - Set java version explicitly - Rename stages ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] vvcephei merged pull request #11411: MINOR: Clarify acceptable recovery lag config doc

vvcephei merged pull request #11411: URL: https://github.com/apache/kafka/pull/11411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] fvaleri commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

fvaleri commented on pull request #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1061881629 @mimaison looks like it works, but topic's partitions without data are not replicated like before. Not sure it is intended behavior. ### Reproducer procedure

[GitHub] [kafka] showuon commented on a change in pull request #11616: MINOR: update the description in Kraft example properties file

showuon commented on a change in pull request #11616: URL: https://github.com/apache/kafka/pull/11616#discussion_r821648236 ## File path: config/kraft/server.properties ## @@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093 # Socket

[GitHub] [kafka] dengziming commented on a change in pull request #11616: MINOR: update the description in Kraft example properties file

dengziming commented on a change in pull request #11616: URL: https://github.com/apache/kafka/pull/11616#discussion_r821561398 ## File path: config/kraft/server.properties ## @@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093 # Socket

[GitHub] [kafka] dengziming commented on a change in pull request #9754: KAFKA-10856: Convert sticky assignor userData schemas to use generated protocol

dengziming commented on a change in pull request #9754: URL: https://github.com/apache/kafka/pull/9754#discussion_r546640844 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/StickyAssignor.java ## @@ -222,51 +204,50 @@ protected MemberData

[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r821511042 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -103,59 +104,76 @@ object GetOffsetShell { throw new

[jira] [Commented] (KAFKA-13718) kafka-topics describe topic with default config will show `segment.bytes` overridden config

[ https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502835#comment-17502835 ] Luke Chen commented on KAFKA-13718: --- >  I get the same behavior with 2.2.0. Oh, really! > it

[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r821507541 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -189,22 +209,26 @@ object GetOffsetShell { val topicFilter =

[GitHub] [kafka] dengziming removed a comment on pull request #10830: KAFKA-12902: Add unit32 type in generator

dengziming removed a comment on pull request #10830: URL: https://github.com/apache/kafka/pull/10830#issuecomment-1020819384 ping @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-13718) kafka-topics describe topic with default config will show `segment.bytes` overridden config

[ https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502828#comment-17502828 ] Mickael Maison commented on KAFKA-13718: This has been the case for many releases, I get the

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1061509859 @mjsax , @ableegoldman , @guozhangwang , @showuon one quick question here. I was able to add the expiration changes at the inner store level. Had a doubt on CachingStore

[GitHub] [kafka] ableegoldman merged pull request #11857: KAFKA-12648: fix bug where thread is re-added to TopologyMetadata when shutting down

ableegoldman merged pull request #11857: URL: https://github.com/apache/kafka/pull/11857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: