[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-05-12 Thread GitBox
dengziming commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r872006433 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-05-12 Thread GitBox
vamossagar12 commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r871988254 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends

[GitHub] [kafka] dengziming commented on pull request #12109: KAFKA-13863: Prevent null config value when create topic in KRaft mode

2022-05-12 Thread GitBox
dengziming commented on PR #12109: URL: https://github.com/apache/kafka/pull/12109#issuecomment-1125579394 > Are you saying that in KRaft, we ignore null config values instead of failing topic creation? Yes, We will pass the topic configs to `ConfigurationControlManager` in which

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871910034 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -927,6 +984,29 @@ private void appendRaftEvent(String name, Runnable runnable) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871908541 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -53,7 +55,7 @@ public class ClusterConfig { ClusterConfig(Type type, int brokers, int controllers,

[GitHub] [kafka] hachikuji commented on pull request #12109: KAFKA-13863: Prevent null config value when create topic in KRaft mode

2022-05-12 Thread GitBox
hachikuji commented on PR #12109: URL: https://github.com/apache/kafka/pull/12109#issuecomment-1125508412 @dengziming I didn't quite follow this: > Yeah, it's unnecessary to change `ReplicationControlManager`, however, there is still a difference, in KRaft mode, the null config value

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871856970 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -17,32 +17,73 @@ package org.apache.kafka.controller; +import

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871853134 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -324,7 +324,8 @@ class BrokerServer( time,

[GitHub] [kafka] jsancio commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
jsancio commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871808351 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871852945 ## core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala: ## @@ -102,6 +102,10 @@ class RawMetaProperties(val props: Properties = new Properties()) { }

[GitHub] [kafka] jsancio commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
jsancio commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871793140 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698 ## core/src/main/scala/kafka/server/BrokerFeatures.scala: ## @@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var supportedFeatures: Features[Supporte

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698 ## core/src/main/scala/kafka/server/BrokerFeatures.scala: ## @@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var supportedFeatures: Features[Supporte

[GitHub] [kafka] cmccabe closed pull request #11636: MINOR: enable KRaft in LogOffsetTest

2022-05-12 Thread GitBox
cmccabe closed pull request #11636: MINOR: enable KRaft in LogOffsetTest URL: https://github.com/apache/kafka/pull/11636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] cmccabe commented on pull request #11636: MINOR: enable KRaft in LogOffsetTest

2022-05-12 Thread GitBox
cmccabe commented on PR #11636: URL: https://github.com/apache/kafka/pull/11636#issuecomment-1125462878 merged into #12155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe commented on pull request #11639: MINOR: enable KRaft in EndToEndClusterIdTest

2022-05-12 Thread GitBox
cmccabe commented on PR #11639: URL: https://github.com/apache/kafka/pull/11639#issuecomment-1125462571 merged into #12155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe closed pull request #11639: MINOR: enable KRaft in EndToEndClusterIdTest

2022-05-12 Thread GitBox
cmccabe closed pull request #11639: MINOR: enable KRaft in EndToEndClusterIdTest URL: https://github.com/apache/kafka/pull/11639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe merged pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

2022-05-12 Thread GitBox
cmccabe merged PR #11969: URL: https://github.com/apache/kafka/pull/11969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #11640: MINOR: enable KRaft on ListConsumerGroupTest

2022-05-12 Thread GitBox
cmccabe commented on PR #11640: URL: https://github.com/apache/kafka/pull/11640#issuecomment-1125462073 merged into #12155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe closed pull request #11640: MINOR: enable KRaft on ListConsumerGroupTest

2022-05-12 Thread GitBox
cmccabe closed pull request #11640: MINOR: enable KRaft on ListConsumerGroupTest URL: https://github.com/apache/kafka/pull/11640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-05-12 Thread Manuel Garcia Cabrera (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535020#comment-17535020 ] Manuel Garcia Cabrera edited comment on KAFKA-12495 at 5/12/22 9:59 PM:

[GitHub] [kafka] cmccabe opened a new pull request, #12155: MINOR: convert some tests to KRaft

2022-05-12 Thread GitBox
cmccabe opened a new pull request, #12155: URL: https://github.com/apache/kafka/pull/12155 Convert EndToEndClusterIdTest, ConsumerGroupCommandTest, ListConsumerGroupTest, and LogOffsetTest to test KRaft mode. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-05-12 Thread GitBox
guozhangwang commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r871816260 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends

[GitHub] [kafka] jsancio commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
jsancio commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871793140 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe closed pull request #11634: MINOR: enable KRaft in TopicCommandIntegrationTest

2022-05-12 Thread GitBox
cmccabe closed pull request #11634: MINOR: enable KRaft in TopicCommandIntegrationTest URL: https://github.com/apache/kafka/pull/11634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe commented on pull request #11634: MINOR: enable KRaft in TopicCommandIntegrationTest

2022-05-12 Thread GitBox
cmccabe commented on PR #11634: URL: https://github.com/apache/kafka/pull/11634#issuecomment-1125411622 This has now already been done by a different PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] hachikuji commented on a diff in pull request #12153: MINOR: Clarify impact of num.replica.fetchers

2022-05-12 Thread GitBox
hachikuji commented on code in PR #12153: URL: https://github.com/apache/kafka/pull/12153#discussion_r871786929 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -894,7 +894,7 @@ object KafkaConfig { "record batch size accepted by the broker is defined via

[GitHub] [kafka] HorizonNet opened a new pull request, #12154: KAFKA-12828 Remove deprecated methods in KeyQueryMetadata

2022-05-12 Thread GitBox
HorizonNet opened a new pull request, #12154: URL: https://github.com/apache/kafka/pull/12154 *Remove the deprecated `getActiveHost()`, `getStandbyHosts()` and `getPartition()` methods in `KeyQueryMetadata`* *Summary of testing strategy (including rationale) for the feature or bug

[GitHub] [kafka] jsancio merged pull request #12141: MINOR; DeleteTopics version tests

2022-05-12 Thread GitBox
jsancio merged PR #12141: URL: https://github.com/apache/kafka/pull/12141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12153: MINOR: Clarify impact of num.replica.fetchers

2022-05-12 Thread GitBox
divijvaidya commented on code in PR #12153: URL: https://github.com/apache/kafka/pull/12153#discussion_r871713953 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -894,7 +894,7 @@ object KafkaConfig { "record batch size accepted by the broker is defined via

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

2022-05-12 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r871712580 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,11 @@ object KafkaConfig { /* Authorizer Configuration ***/ val

[GitHub] [kafka] joel-hamill commented on pull request #12153: MINOR: Clarify impact of num.replica.fetchers

2022-05-12 Thread GitBox
joel-hamill commented on PR #12153: URL: https://github.com/apache/kafka/pull/12153#issuecomment-1125308244 cc @guozhangwang @hachikuji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] joel-hamill opened a new pull request, #12153: MINOR: Clarify impact of num.replica.fetchers

2022-05-12 Thread GitBox
joel-hamill opened a new pull request, #12153: URL: https://github.com/apache/kafka/pull/12153 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] milindmantri opened a new pull request, #12152: MINOR: Fix DSL typo in streams docs

2022-05-12 Thread GitBox
milindmantri opened a new pull request, #12152: URL: https://github.com/apache/kafka/pull/12152 Minor typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] Richard-Cranium commented on a diff in pull request #11712: WIP: Put failed tasks to end of processing list

2022-05-12 Thread GitBox
Richard-Cranium commented on code in PR #11712: URL: https://github.com/apache/kafka/pull/11712#discussion_r871688180 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -270,6 +278,23 @@ Task task(final TaskId taskId) { return

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

2022-05-12 Thread GitBox
junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r871593948 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -376,8 +381,10 @@ class LogManager(logDirs: Seq[File],

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

2022-05-12 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r871644131 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1509,4 +1512,29 @@ class KafkaConfigTest {

[jira] [Commented] (KAFKA-13745) Flaky kafka.network.SocketServerTest.testNoOpActionResponseWithThrottledChannelWhereThrottlingAlreadyDone

2022-05-12 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536230#comment-17536230 ] Sagar Rao commented on KAFKA-13745: --- [~guozhang] , i looked at few of the builds happening across the

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536221#comment-17536221 ] ASF GitHub Bot commented on KAFKA-13882: mimaison commented on code in PR #410: URL:

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536220#comment-17536220 ] ASF GitHub Bot commented on KAFKA-13882: mimaison commented on code in PR #410: URL:

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536212#comment-17536212 ] ASF GitHub Bot commented on KAFKA-13882: qingwei91 commented on code in PR #410: URL:

[jira] [Assigned] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-12 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel reassigned KAFKA-13888: -- Assignee: Niket Goel > KIP-836: Addition of Information in DescribeQuorumResponse about

[jira] [Commented] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-12 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536210#comment-17536210 ] Niket Goel commented on KAFKA-13888: Hi [~Jack-Lee],   Thanks for the suggestion. I think your

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536197#comment-17536197 ] ASF GitHub Bot commented on KAFKA-13882: mimaison commented on code in PR #410: URL:

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871495442 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871494219 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -927,6 +981,31 @@ private void appendRaftEvent(String name, Runnable runnable) {

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871491412 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871404277 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[jira] [Created] (KAFKA-13896) Support unsafe downgrades in KRaft

2022-05-12 Thread David Arthur (Jira)
David Arthur created KAFKA-13896: Summary: Support unsafe downgrades in KRaft Key: KAFKA-13896 URL: https://issues.apache.org/jira/browse/KAFKA-13896 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] showuon commented on a diff in pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-12 Thread GitBox
showuon commented on code in PR #12087: URL: https://github.com/apache/kafka/pull/12087#discussion_r871398002 ## core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-12 Thread GitBox
divijvaidya commented on code in PR #12087: URL: https://github.com/apache/kafka/pull/12087#discussion_r871397465 ## core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-12 Thread GitBox
divijvaidya commented on code in PR #12087: URL: https://github.com/apache/kafka/pull/12087#discussion_r871396306 ## core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871392227 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-12 Thread GitBox
divijvaidya commented on code in PR #12087: URL: https://github.com/apache/kafka/pull/12087#discussion_r871388325 ## core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt:

[GitHub] [kafka] showuon merged pull request #12112: MINOR: Fix flaky testDescribeUnderReplicatedPartitions

2022-05-12 Thread GitBox
showuon merged PR #12112: URL: https://github.com/apache/kafka/pull/12112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13895) Fix javadocs build with JDK < 12

2022-05-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536097#comment-17536097 ] Ismael Juma commented on KAFKA-13895: - I see. If you can think of a way to tighten this, that would

[jira] [Commented] (KAFKA-13895) Fix javadocs build with JDK < 12

2022-05-12 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536084#comment-17536084 ] Tom Bentley commented on KAFKA-13895: - It does. Mickael has subsequently pointed me to KAFKA-12782

[jira] [Commented] (KAFKA-13895) Fix javadocs build with JDK < 12

2022-05-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536082#comment-17536082 ] Ismael Juma commented on KAFKA-13895: - I thought the release script requested Java 17 for this

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536055#comment-17536055 ] ASF GitHub Bot commented on KAFKA-13882: qingwei91 commented on PR #410: URL:

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536054#comment-17536054 ] ASF GitHub Bot commented on KAFKA-13882: qingwei91 opened a new pull request, #410: URL:

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536037#comment-17536037 ] Lim Qing Wei commented on KAFKA-13882: -- Hi [~tombentley] , I am picking this up, I am able to get

[GitHub] [kafka] showuon commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-12 Thread GitBox
showuon commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r871177514 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -232,11 +240,10 @@ private void refreshIdleConsumerGroupOffset() {

[jira] [Created] (KAFKA-13895) Fix javadocs build with JDK < 12

2022-05-12 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13895: --- Summary: Fix javadocs build with JDK < 12 Key: KAFKA-13895 URL: https://issues.apache.org/jira/browse/KAFKA-13895 Project: Kafka Issue Type: Task

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870770149 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mimaison commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2022-05-12 Thread GitBox
mimaison commented on PR #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-1124743001 I see 2 committers approved the changes but this was not merged. @C0urante can you rebase to fix the conflicts ? Thanks -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] dajac commented on pull request #12147: MINOR: Rename remaining `zkVersion` to `partitionEpoch` in `PartitionTest`

2022-05-12 Thread GitBox
dajac commented on PR #12147: URL: https://github.com/apache/kafka/pull/12147#issuecomment-1124713446 @dengziming Good catch, thanks. I have renamed those as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] vamossagar12 commented on pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-05-12 Thread GitBox
vamossagar12 commented on PR #12104: URL: https://github.com/apache/kafka/pull/12104#issuecomment-1124705707 > Thanks @vamossagar12 , the failed tests still contains

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-05-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535936#comment-17535936 ] Luke Chen commented on KAFKA-12495: --- [~mcabrera] , thanks for the sharing. Looks like you already

[jira] [Commented] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

2022-05-12 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535931#comment-17535931 ] Bruno Cadonna commented on KAFKA-12657: --- I do not know the specifics of the build environment and

[GitHub] [kafka] showuon merged pull request #12151: MINOR: parameter name fix for maxScalacThreads

2022-05-12 Thread GitBox
showuon merged PR #12151: URL: https://github.com/apache/kafka/pull/12151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13568) org.apache.kafka.common.errors.TimeoutException

2022-05-12 Thread Vrinda Halarnkar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535902#comment-17535902 ] Vrinda Halarnkar commented on KAFKA-13568: -- Is there any workaround for this issue? >

[jira] [Assigned] (KAFKA-13882) Dockerfile for previewing website

2022-05-12 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lim Qing Wei reassigned KAFKA-13882: Assignee: Lim Qing Wei > Dockerfile for previewing website >

[GitHub] [kafka] showuon commented on pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-05-12 Thread GitBox
showuon commented on PR #11775: URL: https://github.com/apache/kafka/pull/11775#issuecomment-1124596650 Thanks for your reminder. Merged into trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon merged pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-05-12 Thread GitBox
showuon merged PR #11775: URL: https://github.com/apache/kafka/pull/11775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-13763) Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-05-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13763: -- Fix Version/s: 3.3.0 > Improve unit testing coverage and flexibility for >