showuon merged PR #12251:
URL: https://github.com/apache/kafka/pull/12251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rohit k created KAFKA-13960:
---
Summary: ERROR Shutdown broker because all log dirs in
c:\kafka\kafka-logs have failed (kafka.log.LogManager)
Key: KAFKA-13960
URL: https://issues.apache.org/jira/browse/KAFKA-13960
[
https://issues.apache.org/jira/browse/KAFKA-13960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rohit k updated KAFKA-13960:
Issue Type: Test (was: Bug)
> ERROR Shutdown broker because all log dirs in c:\kafka\kafka-logs have
[
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547818#comment-17547818
]
Derek Troy-West commented on KAFKA-13598:
-
Very happy to [~showuon] I will just copy points 1-4
ocadaruma commented on code in PR #12251:
URL: https://github.com/apache/kafka/pull/12251#discussion_r889457352
##
docs/streams/tutorial.html:
##
@@ -490,25 +490,25 @@ Writing a th
Processor: KSTREAM-FLATMAPVALUES-01(stores: []) -->
KSTREAM-KEY-SELECT-02
[
https://issues.apache.org/jira/browse/KAFKA-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kumud Kumar Srivatsava Tirupati resolved KAFKA-13926.
-
Resolution: Won't Fix
Dropping in favor of improving
showuon commented on code in PR #12251:
URL: https://github.com/apache/kafka/pull/12251#discussion_r889451065
##
docs/streams/tutorial.html:
##
@@ -490,25 +490,25 @@ Writing a th
Processor: KSTREAM-FLATMAPVALUES-01(stores: []) -->
KSTREAM-KEY-SELECT-02 <--
[
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547813#comment-17547813
]
Luke Chen commented on KAFKA-13598:
---
[~d-t-w] , yes, adding a note to notable changes in 3.2.0 section
[
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547803#comment-17547803
]
Derek Troy-West commented on KAFKA-13598:
-
This represents a breaking change where:
# Broker
[
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547803#comment-17547803
]
Derek Troy-West edited comment on KAFKA-13598 at 6/4/22 2:02 AM:
-
This
dengziming commented on PR #12236:
URL: https://github.com/apache/kafka/pull/12236#issuecomment-1146478325
> @dengziming I merge `trunk` to try to kick off a build.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dengziming commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889424223
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dengziming commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889423970
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4833,6 +4879,92 @@ public void testDescribeFeaturesFailure() {
}
ocadaruma opened a new pull request, #12251:
URL: https://github.com/apache/kafka/pull/12251
- Fix inconsistency in store name in streams tutorial
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
[
https://issues.apache.org/jira/browse/KAFKA-13935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13935:
-
Summary: Factor out static IBP usages from broker (was: Factor out IBP
from Partition and Log
guozhangwang commented on code in PR #12244:
URL: https://github.com/apache/kafka/pull/12244#discussion_r889363536
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -548,14 +549,18 @@ public boolean poll(Timer timer, boolean
guozhangwang commented on code in PR #12244:
URL: https://github.com/apache/kafka/pull/12244#discussion_r889361765
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -514,9 +514,50 @@ public void
ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r889358327
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##
@@ -388,6 +401,40 @@ private String
[
https://issues.apache.org/jira/browse/KAFKA-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547157#comment-17547157
]
Jose Armando Garcia Sancio commented on KAFKA-13944:
Looks like this issue is
jsancio commented on PR #12236:
URL: https://github.com/apache/kafka/pull/12236#issuecomment-1146366630
@dengziming I merge `trunk` to try to kick off a build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
guozhangwang commented on code in PR #12244:
URL: https://github.com/apache/kafka/pull/12244#discussion_r889351949
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -514,9 +514,50 @@ public void
guozhangwang commented on code in PR #12244:
URL: https://github.com/apache/kafka/pull/12244#discussion_r889350182
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -553,8 +554,8 @@ public boolean poll(Timer timer, boolean
[
https://issues.apache.org/jira/browse/KAFKA-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Hughes updated KAFKA-13873:
---
Fix Version/s: 3.3.0
> Add ability to Pause / Resume KafkaStreams Topologies
>
aartigao closed pull request #10929: KAFKA-12995 [WIP] Allow old Broker
compatibility for Metadata calls
URL: https://github.com/apache/kafka/pull/10929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jsancio commented on code in PR #12245:
URL: https://github.com/apache/kafka/pull/12245#discussion_r889255627
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -162,7 +163,7 @@ Found problem:
val stream = new ByteArrayOutputStream()
[
https://issues.apache.org/jira/browse/KAFKA-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17546695#comment-17546695
]
Jose Armando Garcia Sancio commented on KAFKA-13959:
[~dengziming] [~showuon] Are
[
https://issues.apache.org/jira/browse/KAFKA-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13959:
---
Description:
https://issues.apache.org/jira/browse/KAFKA-13955
jsancio commented on PR #12238:
URL: https://github.com/apache/kafka/pull/12238#issuecomment-1146263145
I merged this PR to fix the tests and I created
https://issues.apache.org/jira/browse/KAFKA-13959.
> @showuon Yes, after we reach a consensus here, we should update the KIP
and
Jose Armando Garcia Sancio created KAFKA-13959:
--
Summary: Controller should unfence Broker with busy metadata log
Key: KAFKA-13959
URL: https://issues.apache.org/jira/browse/KAFKA-13959
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889238615
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4833,6 +4879,92 @@ public void testDescribeFeaturesFailure() {
}
jsancio merged PR #12238:
URL: https://github.com/apache/kafka/pull/12238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio commented on PR #12238:
URL: https://github.com/apache/kafka/pull/12238#issuecomment-1146244214
These are the failing tests:
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testRemovingWorker
Build / JDK 8
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889220152
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4321,6 +4328,91 @@ void handleFailure(Throwable throwable) {
return
[
https://issues.apache.org/jira/browse/KAFKA-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17546407#comment-17546407
]
Matthias J. Sax commented on KAFKA-13936:
-
The docs are in the same repository as the code:
guozhangwang commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r889168252
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##
@@ -388,6 +401,40 @@ private String
cmccabe commented on PR #12238:
URL: https://github.com/apache/kafka/pull/12238#issuecomment-1146163957
> Another solution is to require the broker to only catch up to the last
committed offset when they last sent the heartbeat.
I like this solution too. However, there are some
[
https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17546196#comment-17546196
]
Jun Rao commented on KAFKA-13953:
-
[~abasilbr] : If you have multiple replicas, it's unlikely all
[
https://issues.apache.org/jira/browse/KAFKA-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-13803.
-
Fix Version/s: 3.3.0
Resolution: Fixed
merged the PR to trunk
> Refactor Leader API Access
>
junrao merged PR #12005:
URL: https://github.com/apache/kafka/pull/12005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio opened a new pull request, #12249:
URL: https://github.com/apache/kafka/pull/12249
As part of KIP-835, LastCommittedRecordOffset was added to the
KafkaController metric type. Make sure to test that metric.
### Committer Checklist (excluded from commit message)
- [ ]
mimaison opened a new pull request, #12248:
URL: https://github.com/apache/kafka/pull/12248
…-827)
This implements KIP-827:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-827%3A+Expose+logdirs+total+and+usable+space+via+Kafka+API
Add TotalBytes and UsableBytes to
dajac merged PR #12247:
URL: https://github.com/apache/kafka/pull/12247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #12247:
URL: https://github.com/apache/kafka/pull/12247#issuecomment-1146095417
@AnGg98 Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AnGg98 commented on PR #12247:
URL: https://github.com/apache/kafka/pull/12247#issuecomment-1146080043
Test run successful:
[
https://issues.apache.org/jira/browse/KAFKA-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13883.
Resolution: Fixed
> KIP-835: Monitor Quorum
>
[
https://issues.apache.org/jira/browse/KAFKA-13918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13918.
Resolution: Duplicate
> Schedule or cancel nooprecord write on
vvcephei commented on PR #12235:
URL: https://github.com/apache/kafka/pull/12235#issuecomment-1146046545
@ableegoldman , you might want to take a look at the build I cancelled.
Before it got stuck, there were a large number of failures:
vvcephei commented on PR #12235:
URL: https://github.com/apache/kafka/pull/12235#issuecomment-1146044849
The prior build was hung. I cancelled it so the latest commit could be built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on code in PR #12244:
URL: https://github.com/apache/kafka/pull/12244#discussion_r889014500
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -514,9 +514,50 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Richard Joerger reassigned KAFKA-13908:
---
Assignee: Richard Joerger
> RuntimeException will be thrown in
Moovlin commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1146034275
@showuon You were correct. I went and added the "Configs:" column to the
quickstart output. Great catch!
--
This is an automated message from the Apache Git Service.
To respond to the
C0urante commented on PR #11779:
URL: https://github.com/apache/kafka/pull/11779#issuecomment-1146012029
Given that all merge conflicts have been resolved and
https://github.com/apache/kafka/pull/11778 has already been approved, marking
this as ready for review.
--
This is an automated
Moovlin commented on PR #12246:
URL: https://github.com/apache/kafka/pull/12246#issuecomment-1145980276
@showuon Thanks! Happy to help contribute to the project!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545877#comment-17545877
]
Richard Joerger commented on KAFKA-13875:
-
The Jira which was blocking this previously has been
showuon commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1145979453
@Moovlin , IIRC, even if there's no any overridden configs, the `configs:`
column will still be displayed. Could you confirm it by running the command
once with the latest code? Thank
dajac commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r888913198
##
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##
@@ -1446,6 +1446,35 @@ default DescribeFeaturesResult describeFeatures() {
*/
Moovlin commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1145959126
@dengziming I went and submitted a PR for KAFKA-13718 which has since been
merged into trunk. The PR (12246) keeps the kafka-topics.sh command from
printing the segment.bytes values when
[
https://issues.apache.org/jira/browse/KAFKA-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Richard Joerger reassigned KAFKA-13875:
---
Assignee: Richard Joerger
> update docs to include topoicId for kafka-topics.sh
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545865#comment-17545865
]
Richard Joerger commented on KAFKA-13718:
-
There was a question on if segment.bytes should be
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1145952034
Hey @showuon , just looking to see if you have any input on the last commit
I made to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545846#comment-17545846
]
Prashanth Joseph Babu commented on KAFKA-13936:
---
[~mjsax] sure ! I'd love to ! I'm not
Mickael Maison created KAFKA-13958:
--
Summary: Expose logdirs total and usable space via Kafka API
Key: KAFKA-13958
URL: https://issues.apache.org/jira/browse/KAFKA-13958
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545837#comment-17545837
]
Aldan Brito commented on KAFKA-13953:
-
hi [~junrao] ,
there is no evidence of data corruption on
[
https://issues.apache.org/jira/browse/KAFKA-13957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545833#comment-17545833
]
A. Sophie Blee-Goldman commented on KAFKA-13957:
Failed again
> Flaky Test
showuon commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r27862
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -679,10 +679,11 @@ private long
acsaki commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r22004
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -976,8 +975,11 @@ public void testChannelCloseWhileProcessingReceives()
throws
acsaki commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r21809
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -781,14 +781,13 @@ public void testConnectDisconnectDuringInSinglePoll()
throws
acsaki commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r17853
##
build.gradle:
##
@@ -1243,7 +1243,7 @@ project(':clients') {
testImplementation libs.bcpkix
testImplementation libs.junitJupiter
-testImplementation
acsaki commented on PR #12179:
URL: https://github.com/apache/kafka/pull/12179#issuecomment-1145812750
> Nice tests! Thank you. Left some comments. Also, I found there are many
tests failed with the error:
>
> ```
> org.opentest4j.AssertionFailedError: Topic [__consumer_offsets]
acsaki commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r12184
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -679,10 +679,11 @@ private long
ableegoldman commented on PR #12235:
URL: https://github.com/apache/kafka/pull/12235#issuecomment-1145785669
@cadonna ok this is ready for another pass -- besides addressing your
comments I made two changes worth noting:
1. I moved the produced/consumed metrics to a new `TopicMetrics`
ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r888782190
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetricsTest.java:
##
@@ -114,6 +116,63 @@ public void
showuon commented on PR #12238:
URL: https://github.com/apache/kafka/pull/12238#issuecomment-1145703278
> should we allow the broker to be behind by A records (or time) to unfence
the broker?
I've similar solution came out yesterday, but then, I don't think this is a
good solution
showuon merged PR #12243:
URL: https://github.com/apache/kafka/pull/12243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna merged PR #12210:
URL: https://github.com/apache/kafka/pull/12210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12210:
URL: https://github.com/apache/kafka/pull/12210#issuecomment-1145660378
Build failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna commented on PR #12210:
URL: https://github.com/apache/kafka/pull/12210#issuecomment-1145659280
Passing system test run:
ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r888672094
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -199,6 +201,7 @@ public void send(final String topic,
ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r888670820
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -199,6 +201,7 @@ public void send(final String topic,
AnGg98 opened a new pull request, #12247:
URL: https://github.com/apache/kafka/pull/12247
Replace ACL_AUTHORIZER attribute with ZK_ACL_AUTHORIZER in tests. Required
after the changes merged with https://github.com/apache/kafka/pull/12190
--
This is an automated message from the Apache
80 matches
Mail list logo
