vamossagar12 commented on code in PR #12297:
URL: https://github.com/apache/kafka/pull/12297#discussion_r916462553
##
docs/upgrade.html:
##
@@ -19,6 +19,56 @@
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13152:
Labels: kip (was: needs-kip)
> Replace "buffered.records.per.partition" with
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-13152:
-
> Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
>
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13152:
Fix Version/s: (was: 3.3.0)
> Replace "buffered.records.per.partition" with
guozhangwang commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916385802
##
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##
@@ -55,6 +55,10 @@ SessionStore buildSessionStore(final long
guozhangwang opened a new pull request, #12391:
URL: https://github.com/apache/kafka/pull/12391
Should only be reviewed after https://github.com/apache/kafka/pull/12387.
Needs discussion on KIPs.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
lihaosky commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916381888
##
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##
@@ -55,6 +55,10 @@ SessionStore buildSessionStore(final long
ijuma commented on PR #12380:
URL: https://github.com/apache/kafka/pull/12380#issuecomment-1178420987
+1 for removing these builds from PRs. Generally, we should only include
widely used platforms where we also have stable build machines.
--
This is an automated message from the Apache
guozhangwang commented on PR #12370:
URL: https://github.com/apache/kafka/pull/12370#issuecomment-1178363643
@lihaosky Thanks for your PR, I made a pass on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
guozhangwang commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916291502
##
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##
@@ -55,6 +55,10 @@ SessionStore buildSessionStore(final long
etolbakov commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r916314304
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1112,9 +1121,10 @@ public synchronized RequestFuture
jnh5y commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1178280579
> > @etolbakov Thanks for the PR. When the jira is assigned, it usually
means that someone is working on it. In this case, I know that @jnh5y wanted to
fix this. @jnh5y If you haven't
etolbakov commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r916314304
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1112,9 +1121,10 @@ public synchronized RequestFuture
etolbakov commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1178254261
> @etolbakov Thanks for the PR. When the jira is assigned, it usually means
that someone is working on it. In this case, I know that @jnh5y wanted to fix
this. @jnh5y If you haven't
[
https://issues.apache.org/jira/browse/KAFKA-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-14050.
-
Resolution: Not A Problem
I'm going to close this since the incompatible schema change
hachikuji opened a new pull request, #12390:
URL: https://github.com/apache/kafka/pull/12390
When cleaning a topic with transactional data, if the keys used in the user
data happen to conflict with the keys in the transaction markers, it is
possible for the markers to get removed before
mjsax commented on PR #12091:
URL: https://github.com/apache/kafka/pull/12091#issuecomment-1178222919
Thanks for the PR! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax merged PR #12091:
URL: https://github.com/apache/kafka/pull/12091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1178218780
I am not familiar with Connect code -- @rhauch @kkonstantine @mimaison
should be able to help.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mjsax commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916256345
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImpl.java:
##
@@ -289,7 +289,10 @@ private StoreBuilder>
materialize(final
[
https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563944#comment-17563944
]
Marco Lotz commented on KAFKA-12943:
The PR was raised in April and approved twice. Is there
vineethgn commented on PR #9188:
URL: https://github.com/apache/kafka/pull/9188#issuecomment-1178145392
Based on the discussion in https://github.com/apache/kafka/pull/5785/, i
tried the fix in this PR, it didnt work for me.
I tried to reproduce the issue and i can reproduce the
[
https://issues.apache.org/jira/browse/KAFKA-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-14055:
---
Assignee: Jason Gustafson
> Transaction markers may be lost during cleaning if
Jason Gustafson created KAFKA-14055:
---
Summary: Transaction markers may be lost during cleaning if data
keys conflict with marker keys
Key: KAFKA-14055
URL: https://issues.apache.org/jira/browse/KAFKA-14055
guozhangwang merged PR #12297:
URL: https://github.com/apache/kafka/pull/12297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on code in PR #12297:
URL: https://github.com/apache/kafka/pull/12297#discussion_r916180825
##
docs/upgrade.html:
##
@@ -19,6 +19,56 @@
pjmagee commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1178051631
@mjsax I can see you are recently doing some things, is there any way we can
get @mnegodaev PR merged?
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r916162985
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1050,10 +1051,18 @@ public synchronized void requestRejoin(final
dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r916166251
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1112,9 +1121,10 @@ public synchronized RequestFuture
rayokota commented on PR #12126:
URL: https://github.com/apache/kafka/pull/12126#issuecomment-1178039321
The fix is not quite correct. You need to conditionally call
`struct.getWithoutDefault(field.name())`. You should also add a test using a
struct. See the corresponding fix for the
dajac commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1178035300
@etolbakov Thanks for the PR. When the jira is assigned, it usually means
that someone is working on it. In this case, I know that @jnh5y wanted to fix
this. @jnh5y If you haven't started
lihaosky commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916160977
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImpl.java:
##
@@ -289,7 +289,10 @@ private StoreBuilder>
materialize(final
mjsax merged PR #12383:
URL: https://github.com/apache/kafka/pull/12383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on PR #12383:
URL: https://github.com/apache/kafka/pull/12383#issuecomment-1178024477
Thanks @mjsax , LGTM! Please feel free to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jsancio commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1177949852
> I havn't flesh it, the basic idea is shown in this PR, only read up to
Isolation.COMMITTED when reading from observer and invoke
fetchPurgatory.maybeComplete(highWatermark.offset,
methodmissing commented on PR #12385:
URL: https://github.com/apache/kafka/pull/12385#issuecomment-1177916112
Thanks! I'll draft something
> I forgot to mention that AuthorizableRequestContext is a public interface
so we need a KIP for this change. The process is described here:
methodmissing commented on PR #12385:
URL: https://github.com/apache/kafka/pull/12385#issuecomment-1177906495
@dajac thanks for the prompt reply. We at Shopify currently have a custom
authoriser deployed where we log context like `principal`, `clientId`, `topic`
etc. to producer and
dajac commented on PR #12385:
URL: https://github.com/apache/kafka/pull/12385#issuecomment-1177901616
@methodmissing I forgot to mention that `AuthorizableRequestContext` is a
public interface so we need a KIP for this change. The process is described
here:
jsancio commented on code in PR #12265:
URL: https://github.com/apache/kafka/pull/12265#discussion_r916060600
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -117,26 +117,32 @@ class BrokerMetadataListener(
} finally {
tombentley commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r916044426
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -307,6 +313,22 @@ class LogManager(logDirs: Seq[File],
log
}
+ import
tombentley commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r916026938
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -186,11 +186,18 @@ class LogCleaner(initialConfig: CleanerConfig,
}
/**
-* Reconfigure log clean
[
https://issues.apache.org/jira/browse/KAFKA-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563831#comment-17563831
]
Travis Bischel commented on KAFKA-14048:
>From a technical perspective, this is a very
jsancio commented on code in PR #12265:
URL: https://github.com/apache/kafka/pull/12265#discussion_r915992223
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -117,26 +117,32 @@ class BrokerMetadataListener(
} finally {
Donald created KAFKA-14054:
--
Summary: Unexpected client shutdown as TimeoutException is thrown
as IllegalStateException
Key: KAFKA-14054
URL: https://issues.apache.org/jira/browse/KAFKA-14054
Project: Kafka
dajac commented on PR #12385:
URL: https://github.com/apache/kafka/pull/12385#issuecomment-1177681675
@methodmissing Thanks for the PR. Could you elaborate a little more on the
motivation for this change? Also, don't we need to extend the
`AuthorizableRequestContext` if you want to get the
singhnama commented on code in PR #12359:
URL: https://github.com/apache/kafka/pull/12359#discussion_r915906279
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -209,6 +213,9 @@ class AclAuthorizer extends Authorizer with Logging {
throw
showuon commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r915850442
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -1856,7 +1856,7 @@ class LogCleanerTest {
@Test
def
tyamashi-oss commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r915753889
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -1854,6 +1853,33 @@ class LogCleanerTest {
} finally logCleaner.shutdown()
}
+ @Test
+
pch8388 opened a new pull request, #12389:
URL: https://github.com/apache/kafka/pull/12389
Removes duplicate result strings and avoids mistakes when changing the
string format
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-14053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-14053:
-
Description:
When a batch fails due to delivery timeout, it is possible that the batch is
Daniel Urban created KAFKA-14053:
Summary: Transactional producer should bump the epoch when a batch
encounters delivery timeout
Key: KAFKA-14053
URL: https://issues.apache.org/jira/browse/KAFKA-14053
omkreddy commented on code in PR #12359:
URL: https://github.com/apache/kafka/pull/12359#discussion_r915675978
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -209,6 +213,9 @@ class AclAuthorizer extends Authorizer with Logging {
throw new
divijvaidya commented on PR #12381:
URL: https://github.com/apache/kafka/pull/12381#issuecomment-1177319338
> Sorry, looks like the `match` case still needs default case:
>
> ```
> [Error]
elkkhan commented on PR #12320:
URL: https://github.com/apache/kafka/pull/12320#issuecomment-1177283596
@C0urante thanks, addressed the comments. hopefully checkstyle is all good
now - I wasn't able to run the gradle task locally for some reason, it kept
getting stuck, but now it's working
elkkhan commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r915638083
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation
elkkhan commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r915637537
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation
elkkhan commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r915637006
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation
elkkhan commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r915628889
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563626#comment-17563626
]
Hang HOU commented on KAFKA-6221:
-
I met this problem again in kafka 0.10.0. one last thing is if I
showuon commented on PR #12381:
URL: https://github.com/apache/kafka/pull/12381#issuecomment-1177230649
Sorry, looks like the `match` case still needs default case:
```
[Error]
dengziming commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1177222867
> Do you have a diff for this solution?
@jsancio I havn't flesh it, the basic idea is shown in this PR, only read
up to `Isolation.COMMITTED` when reading from observer and invoke
zigarn commented on PR #12175:
URL: https://github.com/apache/kafka/pull/12175#issuecomment-1177208913
@dajac KIP is now accepted. Next step is to validate this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r915565817
##
core/src/main/scala/kafka/tools/ConsoleConsumer.scala:
##
@@ -248,6 +248,10 @@ object ConsoleConsumer extends Logging {
.withRequiredArg
etolbakov opened a new pull request, #12388:
URL: https://github.com/apache/kafka/pull/12388
Hello David @dajac ,
I found an open JIRA ticket -
https://issues.apache.org/jira/browse/KAFKA-14013
and decided to come up with a suggestion.
Could you please take a look if you have a
dajac merged PR #12382:
URL: https://github.com/apache/kafka/pull/12382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dengziming commented on code in PR #12265:
URL: https://github.com/apache/kafka/pull/12265#discussion_r915532837
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala:
##
@@ -45,26 +45,37 @@ class BrokerMetadataSnapshotter(
*/
private var
dengziming commented on code in PR #12265:
URL: https://github.com/apache/kafka/pull/12265#discussion_r915514842
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala:
##
@@ -45,26 +45,37 @@ class BrokerMetadataSnapshotter(
*/
private var
67 matches
Mail list logo
