stan-confluent commented on PR #12120:
URL: https://github.com/apache/kafka/pull/12120#issuecomment-1180978870
Passed:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1180951825
No worries, I am just a bit unfamiliar with the process for KIP's. Also
letting you know the KIP was accepted into the 3.3 release so I do believe it
needs to be backported as well?
C0urante commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1180923772
I ran the tests locally when I first wrote them. In the year since then,
enough has changed (including getting a new laptop) that I'm no longer able to
run them locally. Attempts to do
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565173#comment-17565173
]
Chris Egerton edited comment on KAFKA-14058 at 7/11/22 8:17 PM:
Hi
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565173#comment-17565173
]
Chris Egerton edited comment on KAFKA-14058 at 7/11/22 8:16 PM:
Hi
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565173#comment-17565173
]
Chris Egerton commented on KAFKA-14058:
---
Hi Chris! I assigned these three to myself because they
mimaison commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1180809834
@mdedetrich Sorry for the delay. I hope to review your PR in the coming days.
Please keep it again trunk, if we also want it in 3.3, we'll backport it.
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565164#comment-17565164
]
Greg Harris commented on KAFKA-14067:
-
This bug is addressed by the fix in
Greg Harris created KAFKA-14067:
---
Summary: Sink connector override.consumer.group.id can conflict
with worker group.id
Key: KAFKA-14067
URL: https://issues.apache.org/jira/browse/KAFKA-14067
Project:
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1180742598
@jsancio Now that you have created the 3.3.0 release branch do I need to
change the base branch of this PR to the new 3.3.0 branch or should it remain
on trunk?
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565138#comment-17565138
]
Jun Rao commented on KAFKA-13953:
-
[~doguscan] : The broker verifies the batch level CRC before
Taha Ismail created KAFKA-14066:
---
Summary: local-confluent-platform fails to start: due to
hobo-register-dns not found error
Key: KAFKA-14066
URL: https://issues.apache.org/jira/browse/KAFKA-14066
fvaleri opened a new pull request, #12401:
URL: https://github.com/apache/kafka/pull/12401
This is a minor change required to align the documentation to the current
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565062#comment-17565062
]
ASF GitHub Bot commented on KAFKA-13436:
mimaison merged PR #417:
URL:
mimaison commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1180548955
@pjmagee Thanks for the contribution!
As @rhauch mentioned above SMTs are part of the API so in order to add new
configurations we need a KIP.
The process is documented in
[
https://issues.apache.org/jira/browse/KAFKA-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov resolved KAFKA-13821.
---
Resolution: Fixed
> Update Kafka Streams WordCount demo to new Processor API
>
blcksrx opened a new pull request, #12400:
URL: https://github.com/apache/kafka/pull/12400
This issue happens cause the `cluster.startup()` invoked already and the
solution is just check the `clusterConfig.isAutoStart` in the
`BeforeTestExecutionCallback`.
In addition I believe
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565049#comment-17565049
]
Christo Lolov commented on KAFKA-14058:
---
Hello! I have been trying to move streams from JUnit 4 to
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565049#comment-17565049
]
Christo Lolov edited comment on KAFKA-14058 at 7/11/22 3:06 PM:
Hello! I
[
https://issues.apache.org/jira/browse/KAFKA-14065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lifa updated KAFKA-14065:
-
Description:
kafka-clients version 2.3.0 can not process message with lz4 compression type
*1.set message
lifa created KAFKA-14065:
Summary: kafka-clients version 2.3.0 can not process lz4
compression type
Key: KAFKA-14065
URL: https://issues.apache.org/jira/browse/KAFKA-14065
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evgeny Tolbakov reassigned KAFKA-14013:
---
Assignee: Evgeny Tolbakov (was: David Jacot)
> Limit the length of the `reason`
etolbakov commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1180434338
@dajac great news!
Thank you very much for your help & review, David!
my Jira handle `etolbakov`, probably need some permissions to be able to
assign tickets to myself.
--
dajac commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1180420597
@etolbakov Could you assign
https://issues.apache.org/jira/browse/KAFKA-14013 to yourself? If you don't
have Jira setup, could you give me your userid and I will set it up for you.
--
etolbakov commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r917938399
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java:
##
@@ -70,6 +70,21 @@ public static void validateGroupInstanceId(String id) {
showuon commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1180411188
@C0urante , I'll take a look this week. Before that, I'd like to know if you
have run these system tests locally?
--
This is an automated message from the Apache Git Service.
To
dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r917915339
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1300,7 +1304,9 @@ class GroupCoordinator(val brokerId: Int,
dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r917912085
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java:
##
@@ -70,6 +70,21 @@ public static void validateGroupInstanceId(String id) {
etolbakov commented on PR #12388:
URL: https://github.com/apache/kafka/pull/12388#issuecomment-1180388125
Thank you for the feedback @dajac!
sorry for the indentation issues, will re-read the contributor
recommendations on that matter and make sure it won't be the case again.
--
This
etolbakov commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r917905764
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1432,4 +1432,17 @@ public static String[] enumOptions(Class> enumClass) {
divijvaidya commented on PR #12381:
URL: https://github.com/apache/kafka/pull/12381#issuecomment-1180373398
Hey @showuon
How do we make the decision on what version do we want to backport a bug to?
This bug exists in versions >= 2.7.
--
This is an automated message from the Apache
rajinisivaram commented on PR #10964:
URL: https://github.com/apache/kafka/pull/10964#issuecomment-1180354994
After discussing with @skaundinya15 offline, I have rebased and made some
changes to the PR to get it ready to merge into 3.3.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564941#comment-17564941
]
Sayed Mohammad Hossein Torabi commented on KAFKA-12617:
---
I would like to work on
dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r917780526
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1432,4 +1432,17 @@ public static String[] enumOptions(Class> enumClass) {
clolov commented on PR #12399:
URL: https://github.com/apache/kafka/pull/12399#issuecomment-1180186207
Hello! This looks like a very interesting find. Could you write a test which
tests this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
clolov commented on PR #12302:
URL: https://github.com/apache/kafka/pull/12302#issuecomment-1180175166
Politely bumping for a review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
clolov commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1180174715
Politely bumping the review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
clolov commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1180174990
Politely bumping for a review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
David Dufour created KAFKA-14064:
Summary: MirrorMaker2 stops task when record is too big
Key: KAFKA-14064
URL: https://issues.apache.org/jira/browse/KAFKA-14064
Project: Kafka
Issue Type:
pch8388 commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180088134
Thanks for the good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180087325
Good point. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pch8388 commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180087281
That's my mistake.
I should say it's a simple refactoring.
I'll edit the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon commented on PR #12347:
URL: https://github.com/apache/kafka/pull/12347#issuecomment-1180086966
@tombentley , I've updated the PR in this commit:
https://github.com/apache/kafka/pull/12347/commits/1d04b6dc30f525cbbe6d3daf9c7c5e5a331896cb
. Please take a look again. Thanks.
--
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917648253
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +437,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917646894
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +437,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917646481
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917645850
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +442,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the
ijuma commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180083712
The PR description says "Fix...". Are we saying it's not a fix, it's simply
a refactoring? We should make it clear if so.
--
This is an automated message from the Apache Git Service.
To
showuon commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180078726
@ijuma , thanks for the reminder. But I've checked and confirmed there is
already a unit test covered this change: `ConfigDefTest#testNiceMemoryUnits`. I
should have mentioned it in the
pch8388 commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180070556
Thanks for the review.
How do I add changes to a merged PR?
Need to open a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180049917
@showuon Whenever reviewing PRs for fixes, we should generally include at
least a unit test. There needs to be a strong reason to merge a fix without any
test changes/additions.
--
This
ijuma commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180049398
Thanks for the PR. Can you please include a unit test for this fix? Also,
`String.format` performs worse than string concatenation. Seems ok here, but
worth keeping in mind for areas where
pch8388 commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180015725
Thanks for the review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
53 matches
Mail list logo
