[GitHub] [kafka] stan-confluent opened a new pull request, #12402: remove min_cluster_size() calls

2022-07-12 Thread GitBox
stan-confluent opened a new pull request, #12402: URL: https://github.com/apache/kafka/pull/12402 This ducktape PR - https://github.com/confluentinc/ducktape/pull/336 - deprecates min_cluster_spec() method which was the only method in ducktape framework which was actually calling

[GitHub] [kafka] dengziming commented on pull request #12265: KAFKA-13968: Fix 3 major bugs of KRaft snapshot generating

2022-07-12 Thread GitBox
dengziming commented on PR #12265: URL: https://github.com/apache/kafka/pull/12265#issuecomment-1182684922 KAFKA-14073 is created for log improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-14073) Logging the reason for creating a snapshot

2022-07-12 Thread dengziming (Jira)
dengziming created KAFKA-14073: -- Summary: Logging the reason for creating a snapshot Key: KAFKA-14073 URL: https://issues.apache.org/jira/browse/KAFKA-14073 Project: Kafka Issue Type:

[GitHub] [kafka] hachikuji commented on a diff in pull request #12394: Minor : Improve Exception log

2022-07-12 Thread GitBox
hachikuji commented on code in PR #12394: URL: https://github.com/apache/kafka/pull/12394#discussion_r919541236 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1154,8 +1154,9 @@ class Partition(val topicPartition: TopicPartition, // Avoid writing to

[GitHub] [kafka] junrao commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-12 Thread GitBox
junrao commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r919529062 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -366,25 +392,30 @@ class LogManager(logDirs: Seq[File], val numLogsLoaded = new AtomicInteger(0)

[GitHub] [kafka] stan-confluent commented on a diff in pull request #12120: Add mini test

2022-07-12 Thread GitBox
stan-confluent commented on code in PR #12120: URL: https://github.com/apache/kafka/pull/12120#discussion_r919525413 ## tests/kafkatest/tests/core/mini_test.py: ## @@ -0,0 +1,18 @@ +from ducktape.tests.test import Test +from ducktape.mark.resource import cluster + +from

[GitHub] [kafka] ahuang98 commented on pull request #12395: Run MessageFormatChangeTest in ZK mode only

2022-07-12 Thread GitBox
ahuang98 commented on PR #12395: URL: https://github.com/apache/kafka/pull/12395#issuecomment-1182579211 Thanks @dajac for the help! Here's the link to the passing test - https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5022/ -- This is an automated message from the

[GitHub] [kafka] junrao commented on a diff in pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-12 Thread GitBox
junrao commented on code in PR #12365: URL: https://github.com/apache/kafka/pull/12365#discussion_r919479183 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1465,13 +1465,15 @@ public boolean isDone() { private class AppendCallbacks

[GitHub] [kafka] C0urante commented on a diff in pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-07-12 Thread GitBox
C0urante commented on code in PR #11783: URL: https://github.com/apache/kafka/pull/11783#discussion_r919448768 ## tests/kafkatest/tests/connect/connect_distributed_test.py: ## @@ -519,6 +535,105 @@ def test_bounce(self, clean, connect_protocol): assert success,

[jira] [Commented] (KAFKA-14020) Performance regression in Producer

2022-07-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566017#comment-17566017 ] John Roesler commented on KAFKA-14020: -- Hey [~alivshits] , thanks for your work on

[GitHub] [kafka] vvcephei commented on pull request #12342: KAFKA-10888: Revert #12049 f7db603

2022-07-12 Thread GitBox
vvcephei commented on PR #12342: URL: https://github.com/apache/kafka/pull/12342#issuecomment-1182501741 No need to revert, since this is being fixed in https://github.com/apache/kafka/pull/12365 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vvcephei closed pull request #12342: KAFKA-10888: Revert #12049 f7db603

2022-07-12 Thread GitBox
vvcephei closed pull request #12342: KAFKA-10888: Revert #12049 f7db603 URL: https://github.com/apache/kafka/pull/12342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] vvcephei commented on pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-12 Thread GitBox
vvcephei commented on PR #12365: URL: https://github.com/apache/kafka/pull/12365#issuecomment-1182501381 Hey @artemlivshits , I just re-ran the Streams benchmarks that originally found the regression. It looks like it's resolved, as of your latest commit! As a reminder, this was the

[GitHub] [kafka] guozhangwang merged pull request #12370: KAFKA-13785: [10/N][emit final] more unit test for session store and disable cache for emit final sliding window

2022-07-12 Thread GitBox
guozhangwang merged PR #12370: URL: https://github.com/apache/kafka/pull/12370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #12370: KAFKA-13785: [10/N][emit final] more unit test for session store and disable cache for emit final sliding window

2022-07-12 Thread GitBox
guozhangwang commented on PR #12370: URL: https://github.com/apache/kafka/pull/12370#issuecomment-1182129925 LGTM! I'm merging to trunk now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-14071) Kafka request handler threads saturated when moving a partition

2022-07-12 Thread Qinghui Xu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated KAFKA-14071: --- Description: *Kafka version:* 2.7.1   *Our scenario:* Each server has 72 cores, and running with

[jira] [Updated] (KAFKA-14071) Kafka request handler threads saturated when moving a partition

2022-07-12 Thread Qinghui Xu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated KAFKA-14071: --- Description: *Kafka version:* 2.7.1 {*}Our scenarios:{*}{*}{*} Each server has 72 cores, and

[jira] [Updated] (KAFKA-14071) Kafka request handler threads saturated when moving a partition

2022-07-12 Thread Qinghui Xu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated KAFKA-14071: --- Description: *Kafka version:* 2.7.1 {*}Our scenarios:{*}{*}{*} Each server has 72 cores, and

[jira] [Resolved] (KAFKA-13968) Broker should not generator snapshot until been unfenced

2022-07-12 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-13968. Resolution: Fixed > Broker should not generator snapshot until

[jira] [Updated] (KAFKA-14072) Crashed MirrorCheckpointConnector appears as running in REST API

2022-07-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14072: --- Affects Version/s: 3.1.0 > Crashed MirrorCheckpointConnector appears as running in REST API

[jira] [Created] (KAFKA-14072) Crashed MirrorCheckpointConnector appears as running in REST API

2022-07-12 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14072: -- Summary: Crashed MirrorCheckpointConnector appears as running in REST API Key: KAFKA-14072 URL: https://issues.apache.org/jira/browse/KAFKA-14072 Project: Kafka

[GitHub] [kafka] jsancio merged pull request #12265: KAFKA-13968: Fix 3 major bugs of KRaft snapshot generating

2022-07-12 Thread GitBox
jsancio merged PR #12265: URL: https://github.com/apache/kafka/pull/12265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison merged pull request #12313: MINOR: Add the change statement of reload4j in Notable changes of 3.1.1

2022-07-12 Thread GitBox
mimaison merged PR #12313: URL: https://github.com/apache/kafka/pull/12313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14071) Kafka request handler threads saturated when moving a partition

2022-07-12 Thread Qinghui Xu (Jira)
Qinghui Xu created KAFKA-14071: -- Summary: Kafka request handler threads saturated when moving a partition Key: KAFKA-14071 URL: https://issues.apache.org/jira/browse/KAFKA-14071 Project: Kafka

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-12 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Description: When using key-value state stores with Processor API, one can add key-value state

[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController

2022-07-12 Thread GitBox
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1181806166 @mumrah could you review this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-12 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Summary: Improve documentation for queryMetadataForKey (was: queryMetadataForKey) > Improve

[jira] [Created] (KAFKA-14070) queryMetadataForKey

2022-07-12 Thread Balaji Rao (Jira)
Balaji Rao created KAFKA-14070: -- Summary: queryMetadataForKey Key: KAFKA-14070 URL: https://issues.apache.org/jira/browse/KAFKA-14070 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918831524 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java: ## @@ -82,16 +69,30 @@ public AdminApiLookupStrategy

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918830156 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java: ## @@ -82,16 +69,30 @@ public AdminApiLookupStrategy

[GitHub] [kafka] mimaison commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-12 Thread GitBox
mimaison commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1181607849 @mdedetrich The KIP was accepted in 3.3 but we assumed it would get merged before feature freeze. Feature freeze happened last week (see

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918820604 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java: ## @@ -17,33 +17,72 @@ package org.apache.kafka.clients.admin;

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918813192 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java: ## @@ -17,33 +17,72 @@ package org.apache.kafka.clients.admin;

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918811781 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -915,23 +916,56 @@ default ListConsumerGroupsResult listConsumerGroups() { /**

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918807471 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -915,23 +916,56 @@ default ListConsumerGroupsResult listConsumerGroups() { /**

[jira] [Created] (KAFKA-14069) Allow custom configuration of foreign key join internal topics

2022-07-12 Thread Emmanuel Brard (Jira)
Emmanuel Brard created KAFKA-14069: -- Summary: Allow custom configuration of foreign key join internal topics Key: KAFKA-14069 URL: https://issues.apache.org/jira/browse/KAFKA-14069 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-12 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r918715411 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java: ## @@ -17,33 +17,72 @@ package org.apache.kafka.clients.admin; +import

[jira] [Created] (KAFKA-14068) add node advertised listeners when AdminClient can not connect to the node

2022-07-12 Thread Justinwins (Jira)
Justinwins created KAFKA-14068: -- Summary: add node advertised listeners when AdminClient can not connect to the node Key: KAFKA-14068 URL: https://issues.apache.org/jira/browse/KAFKA-14068 Project:

[GitHub] [kafka] omkreddy merged pull request #12398: KAFKA-14062: OAuth client token refresh fails with SASL extensions

2022-07-12 Thread GitBox
omkreddy merged PR #12398: URL: https://github.com/apache/kafka/pull/12398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] pjmagee commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-07-12 Thread GitBox
pjmagee commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-1181487955 @mnegodaev It looks like this is something you would add to this PR a link to a KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] etolbakov commented on pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-12 Thread GitBox
etolbakov commented on PR #12388: URL: https://github.com/apache/kafka/pull/12388#issuecomment-1181458638 @dajac David, thanks again for your review! I'd be very grateful if you could point me to any other (unassigned ) ticket that I can take a look at and help with? -- This is an

[GitHub] [kafka] dajac commented on pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-12 Thread GitBox
dajac commented on PR #12388: URL: https://github.com/apache/kafka/pull/12388#issuecomment-1181429377 Merged to trunk, 3.3 and 3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac merged pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-12 Thread GitBox
dajac merged PR #12388: URL: https://github.com/apache/kafka/pull/12388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on a diff in pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-07-12 Thread GitBox
showuon commented on code in PR #11783: URL: https://github.com/apache/kafka/pull/11783#discussion_r918628386 ## tests/kafkatest/tests/connect/connect_distributed_test.py: ## @@ -519,6 +535,105 @@ def test_bounce(self, clean, connect_protocol): assert success, "Found

[GitHub] [kafka] showuon commented on a diff in pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-07-12 Thread GitBox
showuon commented on code in PR #11783: URL: https://github.com/apache/kafka/pull/11783#discussion_r918618483 ## tests/kafkatest/tests/connect/connect_distributed_test.py: ## @@ -519,6 +535,105 @@ def test_bounce(self, clean, connect_protocol): assert success, "Found

[GitHub] [kafka] showuon commented on pull request #12381: KAFKA-13474: Allow reconfiguration of SSL certs for broker to controller connection

2022-07-12 Thread GitBox
showuon commented on PR #12381: URL: https://github.com/apache/kafka/pull/12381#issuecomment-1181370970 @divijvaidya , usually we backported to the previous version only since patch release usually has one only. I just backported back to 3.1 branch, too. It took me some time to fix the