artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189805608
Looked at the failed tests, seem unrelated and pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r925138410
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,17 +1300,79 @@ public void
Gao Fei created KAFKA-14088:
---
Summary: KafkaChannel memory leak
Key: KAFKA-14088
URL: https://issues.apache.org/jira/browse/KAFKA-14088
Project: Kafka
Issue Type: Bug
Components: network
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-14024.
---
Resolution: Fixed
> Consumer stuck during cooperative rebalance for Commit offset in onJoinPrepare
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568783#comment-17568783
]
Luke Chen commented on KAFKA-14024:
---
> In this way we would not need a separate timer inside the
showuon commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1189724526
Backport to 3.3 and 3.2. cc @jsancio @mumrah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon merged PR #12349:
URL: https://github.com/apache/kafka/pull/12349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1189713426
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
kafka.server.DynamicBrokerReconfigurationTest.testKeyStoreAlter()
```
--
This is an automated message from the
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189712085
> Are the test failures related to the PR?
Yes, just pushed the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
junrao commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189657885
@artemlivshits : Are the test failures related to the PR?
@ijuma : Do you have any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r925034851
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -652,6 +652,11 @@ void write(KafkaChannel channel) throws IOException {
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r925034643
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -652,6 +652,11 @@ void write(KafkaChannel channel) throws IOException {
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r925034172
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,97 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests
kirktrue closed pull request #12327: WIP - DO NOT MERGE - KIP-714 #718
URL: https://github.com/apache/kafka/pull/12327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r924957846
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r924957060
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568732#comment-17568732
]
Guozhang Wang commented on KAFKA-14024:
---
Thanks to [~aiquestion] for filing this and also
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-14024:
--
Reviewer: Luke Chen
> Consumer stuck during cooperative rebalance for Commit offset in
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-14024:
-
Assignee: Guozhang Wang
> Consumer stuck during cooperative rebalance for Commit
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-14024:
-
Assignee: Shawn Wang (was: Guozhang Wang)
> Consumer stuck during cooperative
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568731#comment-17568731
]
Guozhang Wang commented on KAFKA-14024:
---
Hello [~mumrah], I took a look at the ticket and also the
jsancio commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1189538831
> @jsancio I think the last question is that there may be more than one
registration record for each broker after restarting it, so can we rely on the
broker epoch? I think I need some
ableegoldman commented on PR #12324:
URL: https://github.com/apache/kafka/pull/12324#issuecomment-1189528697
Also cherrypicked back to the 3.3 branch still code freeze deadline is
tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on PR #12324:
URL: https://github.com/apache/kafka/pull/12324#issuecomment-1189526095
Merged to trunk, thanks @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman merged PR #12324:
URL: https://github.com/apache/kafka/pull/12324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #12324:
URL: https://github.com/apache/kafka/pull/12324#issuecomment-1189524621
Test failures are unrelated, ARM build did time out but I've seen this
happen on other PRs recently and the build page shows the actual test steps
passing (error message in failed
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r924908020
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,97 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests
[
https://issues.apache.org/jira/browse/KAFKA-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-12463:
-
Assignee: (was: Chris Egerton)
> Update default consumer partition assignor for
[
https://issues.apache.org/jira/browse/KAFKA-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-12476:
-
Assignee: (was: Chris Egerton)
> Worker can block for longer than scheduled
[
https://issues.apache.org/jira/browse/KAFKA-8299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-8299:
Assignee: (was: Chris Egerton)
> Add type-safe instantiation of generic classes to
C0urante commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r924890270
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -144,10 +149,6 @@ public void subscribe(String path, Set
C0urante commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1189451124
I made a small adjustment to the shutdown logic for the tests, which ensures
that the worker process is actually dead before trying to bring up a new one.
This should not affect the
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r924838158
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924818200
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,21 @@ public boolean isDone() {
private class AppendCallbacks
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1189398064
@dengziming I have made the changes requested. I have also made the changes
in `QuorumController.maybeGenerateSnapshot` to log the reason for the snapshot
being generated.
ashmeet13 commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r924807677
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -89,6 +89,12 @@ class BrokerMetadataListener(
*/
private var
guozhangwang commented on PR #12391:
URL: https://github.com/apache/kafka/pull/12391#issuecomment-1189383814
@cadonna please lmk wdyt about the proposed metric changes in the
descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
artemlivshits commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924801253
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,21 @@ public boolean isDone() {
private class
mjsax commented on PR #12421:
URL: https://github.com/apache/kafka/pull/12421#issuecomment-1189369026
Thanks for the PR.
Merged to `trunk` and cherry-picked to `3.3`, `3.2` branches. (Did not
cherry-pick cleanly to `3.1` -- can you do a follow up PR to backport it?)
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568659#comment-17568659
]
Matthias J. Sax commented on KAFKA-12887:
-
This feature broke some stuff, and we revert it:
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r924785404
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924779033
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,21 @@ public boolean isDone() {
private class AppendCallbacks
jsancio commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189361061
> @jsancio : We plan to cherry-pick this to 3.3 branch since this fixes a
performance issue in
[KAFKA-10888](https://issues.apache.org/jira/browse/KAFKA-10888).
Sounds good
[
https://issues.apache.org/jira/browse/KAFKA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14020:
---
Fix Version/s: 3.3.0
> Performance regression in Producer
>
[
https://issues.apache.org/jira/browse/KAFKA-14087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Livshits updated KAFKA-14087:
---
Description:
Something like this
{code:java}
Map configs = new HashMap<>();
Artem Livshits created KAFKA-14087:
--
Summary: Add jmh benchmark for producer with MockClient
Key: KAFKA-14087
URL: https://issues.apache.org/jira/browse/KAFKA-14087
Project: Kafka
Issue
artemlivshits commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924715457
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,17 @@ public boolean isDone() {
private class
Artem Livshits created KAFKA-14086:
--
Summary: Cleanup PlaintextConsumerTest.testInterceptors to not
pass null record
Key: KAFKA-14086
URL: https://issues.apache.org/jira/browse/KAFKA-14086
Project:
Artem Livshits created KAFKA-14085:
--
Summary: Clean up usage of asserts in KafkaProducer
Key: KAFKA-14085
URL: https://issues.apache.org/jira/browse/KAFKA-14085
Project: Kafka
Issue Type:
guozhangwang commented on PR #12387:
URL: https://github.com/apache/kafka/pull/12387#issuecomment-1189321338
Thanks @cadonna , I've incorporated your comments and merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang merged PR #12387:
URL: https://github.com/apache/kafka/pull/12387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r924732715
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -723,6 +723,106 @@ private void
guozhangwang commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r924731119
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -428,6 +456,113 @@ private void
dengziming commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1189293753
@jsancio I think the last question is that there may be more than one
registration record for each broker after restarting it, so can we rely on the
broker epoch? I think I need some
clolov commented on PR #12409:
URL: https://github.com/apache/kafka/pull/12409#issuecomment-1189292431
Oh, apologies, I didn't get a notification for this. Yep, I will review it
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
clolov commented on PR #12422:
URL: https://github.com/apache/kafka/pull/12422#issuecomment-1189290301
@C0urante I believe you might have the required context to review this pull
request :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
clolov opened a new pull request, #12422:
URL: https://github.com/apache/kafka/pull/12422
Addressing https://issues.apache.org/jira/browse/KAFKA-13982.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mjsax merged PR #12421:
URL: https://github.com/apache/kafka/pull/12421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568626#comment-17568626
]
Randall Hauch commented on KAFKA-14079:
---
Following up with some additional detail:
This issue can
rhauch commented on PR #12412:
URL: https://github.com/apache/kafka/pull/12412#issuecomment-1189234384
As you know, the AK project is actively working on a 3.2.1 release; see the
[Dev List thread](https://lists.apache.org/list?d...@kafka.apache.org:2022-7).
I've responded to the thread
aiquestion commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1189224423
@showuon Thanks a lot for your comment.
i think i've fixed all the comment. And yes, i can start a new PR to do it
if you think 'current code is okay to merge, and need some
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924677278
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,6 +1377,178 @@ public void
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924676827
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,6 +1377,178 @@ public void
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924676541
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1251,6 +1252,83 @@ public void
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924676347
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -969,6 +973,89 @@ class PlaintextConsumerTest extends BaseConsumerTest {
}
}
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924676087
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -740,24 +746,59 @@ private void
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924675152
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -740,24 +746,59 @@ private void
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924674693
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -191,7 +191,7 @@ public AbstractCoordinator(GroupRebalanceConfig
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924670900
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -740,24 +746,59 @@ private void
junrao commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924667928
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if
MPeli commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1189166900
I also had a problem with Kraft which did not start on Windows. The latest
commit fixes
https://github.com/apache/kafka/pull/12331/commits/f7cc920771735576d9cfba2afe6f26fdcfb2ccd4
it. The
splett2 commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r923930734
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,97 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924600012
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1251,6 +1252,83 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568598#comment-17568598
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #420:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568584#comment-17568584
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #420:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568573#comment-17568573
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #420:
URL:
nicolasguyomar commented on PR #12378:
URL: https://github.com/apache/kafka/pull/12378#issuecomment-1189066691
Hello @jolshan , this is a Confluent Bundle 7.2.0 console producer output,
producing a "test" message in topic "nicolas"
You'll see that upon receiving the first Metadata
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568566#comment-17568566
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #424:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568565#comment-17568565
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya opened a new pull request, #424:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568535#comment-17568535
]
ASF GitHub Bot commented on KAFKA-13868:
showuon commented on PR #420:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568515#comment-17568515
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison merged PR #421:
URL:
viktorsomogyi commented on PR #11886:
URL: https://github.com/apache/kafka/pull/11886#issuecomment-1188969830
@rajinisivaram @omkreddy can you help in getting this reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568483#comment-17568483
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #420:
URL:
cshannon commented on PR #12412:
URL: https://github.com/apache/kafka/pull/12412#issuecomment-1188913781
@rhauch - Great, thanks for merging this so quickly. I've been running a
custom build with this fix for a couple days and it has looked good so far so
it will be nice to get 3.2.1 out
[
https://issues.apache.org/jira/browse/KAFKA-14074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568465#comment-17568465
]
Adrian Preston commented on KAFKA-14074:
Thanks for pointing out KAFKA-13972, [~jolshan].
fvaleri commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1188894824
@showuon is it fine? Do you have any more feedback on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
divijvaidya commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1188878088
@ijuma, would like to take a look at this or perhaps tag a committer who
would be most suited to look into this one? (note that we can review this PR
from the lens of change the file
vamossagar12 commented on PR #12309:
URL: https://github.com/apache/kafka/pull/12309#issuecomment-1188874838
@showuon could you plz review/merge this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vamossagar12 commented on PR #12321:
URL: https://github.com/apache/kafka/pull/12321#issuecomment-1188874392
@showuon could you plz review/merge this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1188867448
I'm afraid I have no experience running Kafka on Windows so I'm not familiar
with the issues on that platform.
--
This is an automated message from the Apache Git Service.
To respond
cadonna commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r924277101
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -723,6 +723,106 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568439#comment-17568439
]
ASF GitHub Bot commented on KAFKA-13868:
showuon commented on PR #420:
URL:
cadonna commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r924276012
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -428,6 +456,113 @@ private void shouldRemoveStatefulTask(final
divijvaidya commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1188795126
@mimaison perhaps you might be interested in looking at this one? I have
done an initial review.
--
This is an automated message from the Apache Git Service.
To respond to the
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924206144
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568411#comment-17568411
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #420:
URL:
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924191711
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,17 @@ public boolean isDone() {
private class AppendCallbacks
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924191711
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1465,13 +1465,17 @@ public boolean isDone() {
private class AppendCallbacks
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r924189300
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568395#comment-17568395
]
ASF GitHub Bot commented on KAFKA-13868:
showuon commented on PR #420:
URL:
1 - 100 of 103 matches
Mail list logo
