Stephan14 commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r937373327
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1300,7 +1304,9 @@ class GroupCoordinator(val brokerId: Int,
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575018#comment-17575018
]
Sagar Rao commented on KAFKA-12495:
---
Thanks [~ChrisEgerton] . I would take a look. I had another idea
guozhangwang commented on code in PR #12458:
URL: https://github.com/apache/kafka/pull/12458#discussion_r937261885
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -251,8 +264,9 @@ def test_broker_type_bounce_at_start(self, failure_mode,
broker_type,
guozhangwang commented on code in PR #12458:
URL: https://github.com/apache/kafka/pull/12458#discussion_r937256375
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -205,11 +212,17 @@ def collect_results(self, sleep_time_secs):
return data
guozhangwang commented on PR #12458:
URL: https://github.com/apache/kafka/pull/12458#issuecomment-1204622110
> In addition to addressing the review comments, can you post a link to the
system test results with this change? It would be good to verify the impact
before merging.
+1.
[
https://issues.apache.org/jira/browse/KAFKA-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-14140:
--
Assignee: Justine Olshan
> Ensure a fenced or in-controlled-shutdown replica is not
[
https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13299:
---
Fix Version/s: 3.4.0
(was: 3.3.0)
> Accept
[
https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574967#comment-17574967
]
Jose Armando Garcia Sancio commented on KAFKA-13299:
I am going to replace 3.3.0
Justine Olshan created KAFKA-14140:
--
Summary: Ensure a fenced or in-controlled-shutdown replica is not
eligible to become leader in ZK mode
Key: KAFKA-14140
URL: https://issues.apache.org/jira/browse/KAFKA-14140
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-14139:
Description:
We have been thinking about disk failure cases recently. Suppose that a disk
Jason Gustafson created KAFKA-14139:
---
Summary: Replaced disk can lead to loss of committed data even
with non-empty ISR
Key: KAFKA-14139
URL: https://issues.apache.org/jira/browse/KAFKA-14139
guozhangwang merged PR #12476:
URL: https://github.com/apache/kafka/pull/12476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe merged PR #12380:
URL: https://github.com/apache/kafka/pull/12380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on PR #12476:
URL: https://github.com/apache/kafka/pull/12476#issuecomment-1204551176
I'm merging in this PR now since it includes a hotfix on
[StreamTaskTest.java] to turn the build to green.
--
This is an automated message from the Apache Git Service.
To respond
cmccabe commented on PR #12380:
URL: https://github.com/apache/kafka/pull/12380#issuecomment-1204549585
Yeah, these builds are out of control, failing all the time. It's probably
more appropriate to make these nightly builds anyway
--
This is an automated message from the Apache Git
Guozhang Wang created KAFKA-14138:
-
Summary: The Exception Throwing Behavior of Transactional Producer
is Inconsistent
Key: KAFKA-14138
URL: https://issues.apache.org/jira/browse/KAFKA-14138
Project:
cmccabe commented on PR #12483:
URL: https://github.com/apache/kafka/pull/12483#issuecomment-1204544001
Can we do this just for the broker configs? We don't have this behavior for
topic configs or other types of configs...
LGTM other than that.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574945#comment-17574945
]
Jose Armando Garcia Sancio commented on KAFKA-1:
{quote} I can file a separate
niket-goel commented on code in PR #12457:
URL: https://github.com/apache/kafka/pull/12457#discussion_r937164272
##
raft/src/test/java/org/apache/kafka/raft/internals/RecordsIteratorTest.java:
##
@@ -85,18 +88,41 @@ public void testFileRecords(
FileRecords fileRecords
mumrah opened a new pull request, #12483:
URL: https://github.com/apache/kafka/pull/12483
This patch changes the AlterConfigs behavior in KRaft mode to match that of
ZK. When we receive a LegacyAlterConfig or IncrementalAlterConfig that does
_not_ change a value for a key, we will still
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574928#comment-17574928
]
Guozhang Wang commented on KAFKA-13840:
---
I think this issue is indeed fixed in the latest release
ijuma commented on PR #12482:
URL: https://github.com/apache/kafka/pull/12482#issuecomment-1204477274
Please disregard, wrong PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma opened a new pull request, #12482:
URL: https://github.com/apache/kafka/pull/12482
> $ git merge-base apache-github/3.3 apache-github/trunk
> 23c92ce79366e86ca719e5e51c550c27324acd83
> $ git show 23c92ce79366e86ca719e5e51c550c27324acd83
> commit
ijuma closed pull request #12482: Merge up to Apache Kafka 3.3 branching point
URL: https://github.com/apache/kafka/pull/12482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574920#comment-17574920
]
Matthew de Detrich commented on KAFKA-13530:
So I ran the tests inside a docker container to
mdedetrich commented on code in PR #12281:
URL: https://github.com/apache/kafka/pull/12281#discussion_r937115822
##
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecordingTrigger.java:
##
@@ -32,12 +32,12 @@ public
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13840:
Priority: Critical (was: Major)
> KafkaConsumer is unable to recover connection to group
venkat created KAFKA-14137:
--
Summary: Security Vulnerabilities reported in CVE-2021-45046 and
CVE-2021-45046
Key: KAFKA-14137
URL: https://issues.apache.org/jira/browse/KAFKA-14137
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574909#comment-17574909
]
Kyle R Stehbens commented on KAFKA-13840:
-
[~guozhang] In this instance, flink is continually
dplavcic commented on PR #12449:
URL: https://github.com/apache/kafka/pull/12449#issuecomment-1204406842
@ableegoldman, @cadonna could you please help review this changes in the
streams test domain?
--
This is an automated message from the Apache Git Service.
To respond to the message,
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r937067118
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -287,7 +279,7 @@ public void
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1204360460
Hi @jsancio, I have defined an enum in the raft module for `SnapshotReason`
and have used it in place of string messages that were being passed previously.
I am working on making
jsancio commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r937029349
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -129,16 +129,17 @@ class BrokerMetadataListener(
}
}
- private def
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r937028065
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
dplavcic commented on code in PR #12476:
URL: https://github.com/apache/kafka/pull/12476#discussion_r937020156
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RackAwarenessStreamsPartitionAssignorTest.java:
##
@@ -0,0 +1,582 @@
+/*
+ * Licensed to the
jsancio commented on code in PR #12457:
URL: https://github.com/apache/kafka/pull/12457#discussion_r936987763
##
raft/src/test/java/org/apache/kafka/raft/internals/RecordsIteratorTest.java:
##
@@ -85,18 +88,41 @@ public void testFileRecords(
FileRecords fileRecords =
dplavcic commented on PR #12459:
URL: https://github.com/apache/kafka/pull/12459#issuecomment-1204331217
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
David Arthur created KAFKA-14136:
Summary: AlterConfigs in KRaft does not generate records for
unchanged values
Key: KAFKA-14136
URL: https://issues.apache.org/jira/browse/KAFKA-14136
Project: Kafka
guozhangwang commented on PR #7670:
URL: https://github.com/apache/kafka/pull/7670#issuecomment-1204324571
Hello @gitlw @garyrussell @kkolyan sorry for getting late on you. There's a
concern which is not recorded on the PR here, which is that printing the stack
trace on each ApiException
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574893#comment-17574893
]
Guozhang Wang commented on KAFKA-13840:
---
[~kyle.stehbens] Just to clarify, when the retriable
[
https://issues.apache.org/jira/browse/KAFKA-14111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14111:
-
Fix Version/s: 3.3.0
3.4.0
> Dynamic config update fails for "password"
[
https://issues.apache.org/jira/browse/KAFKA-14111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-14111.
--
Resolution: Fixed
> Dynamic config update fails for "password" configs in KRaft
>
mumrah commented on PR #12455:
URL: https://github.com/apache/kafka/pull/12455#issuecomment-1204298550
Manually cherry-picked to 3.3 as a687d4d3f687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
premkamal23 opened a new pull request, #12481:
URL: https://github.com/apache/kafka/pull/12481
[KAFKA-14115] Password configs are logged in plaintext in KRaft
While updating the config for a broker ConfigurationControlManager is
logging sensitive config values
mumrah merged PR #12455:
URL: https://github.com/apache/kafka/pull/12455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on PR #12455:
URL: https://github.com/apache/kafka/pull/12455#issuecomment-1204262912
After latest commit, only test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
guozhangwang commented on code in PR #12476:
URL: https://github.com/apache/kafka/pull/12476#discussion_r936948546
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RackAwarenessStreamsPartitionAssignorTest.java:
##
@@ -0,0 +1,582 @@
+/*
+ * Licensed to the
mimaison opened a new pull request, #12480:
URL: https://github.com/apache/kafka/pull/12480
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
clolov commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1204186138
Thank you for the review @C0urante! I will have a look and aim to provide
answers (+ new commits) in the next couple of days.
--
This is an automated message from the Apache Git
niket-goel commented on PR #12457:
URL: https://github.com/apache/kafka/pull/12457#issuecomment-1204185885
The build failures are a little cryptic. The same tests all pass locally,
and the failing step in the build only complains of the script exiting with a
non-zero status, but there are
[
https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13877.
---
Resolution: Fixed
> Flaky
>
guozhangwang merged PR #12468:
URL: https://github.com/apache/kafka/pull/12468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936828320
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574771#comment-17574771
]
Chris Egerton commented on KAFKA-12495:
---
[~sagarrao] yes, it's unassigned so anyone can feel free
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574767#comment-17574767
]
Sagar Rao commented on KAFKA-12495:
---
[~showuon] , is this still open? I can take a stab at it. Let me
ahuang98 opened a new pull request, #12479:
URL: https://github.com/apache/kafka/pull/12479
DeleteTopicRequestTest and DeleteTopicsRequestWithDeletionDisabledTest are
still a work in progress
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1204027403
Got it, working on these changes. Taking a bit of time to go through the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574748#comment-17574748
]
Yash Mayya commented on KAFKA-13952:
[~jmalek] this definitely looks like a bug in the
yashmayya opened a new pull request, #12478:
URL: https://github.com/apache/kafka/pull/12478
- https://issues.apache.org/jira/browse/KAFKA-13952:
RetryWithToleranceOperator doesn't respect infinite retries config - i.e. when
`errors.retry.timeout` is set to `-1`
- From
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574735#comment-17574735
]
Luke Chen commented on KAFKA-13840:
---
I'll take a look.
> KafkaConsumer is unable to recover
see-quick opened a new pull request, #12477:
URL: https://github.com/apache/kafka/pull/12477
Signed-off-by: morsak
This PR updates scala versions inside `bin/scripts` (i.e.,
`kafka-run-class.sh`). https://github.com/apache/kafka/pull/12273 fix modified
only inside
[
https://issues.apache.org/jira/browse/KAFKA-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Nagy updated KAFKA-14135:
---
Description:
As mentioned in the summary, the value `sasl.server.callback.handler.class` is
set to
Gábor Nagy created KAFKA-14135:
--
Summary: KafkaConfig value sasl.server.callback.handler.class is
set to null even when custom class is used
Key: KAFKA-14135
URL: https://issues.apache.org/jira/browse/KAFKA-14135
divijvaidya commented on code in PR #12476:
URL: https://github.com/apache/kafka/pull/12476#discussion_r936500749
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RackAwarenessStreamsPartitionAssignorTest.java:
##
@@ -0,0 +1,582 @@
+/*
+ * Licensed to the
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936511846
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936511846
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936511846
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r936497559
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -236,31 +198,23 @@ public void connectorStatus() {
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r936496903
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +141,51 @@ public class AbstractHerderTest {
private
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574595#comment-17574595
]
Christo Lolov edited comment on KAFKA-14132 at 8/3/22 10:01 AM:
Great,
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
divijvaidya commented on PR #12474:
URL: https://github.com/apache/kafka/pull/12474#issuecomment-1203704542
> #12473 got here first, closing this one :)
Ah duplicated effort! Please assign the JIRA to yourself (or add a comment)
if you beginning to work on something. I helps avoid
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r936433188
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends
divijvaidya commented on PR #12230:
URL: https://github.com/apache/kafka/pull/12230#issuecomment-1203693391
@mimaison kindly review when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
divijvaidya commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936426643
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}There are tests which use both PowerMock and EasyMock. I have
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574604#comment-17574604
]
Christo Lolov commented on KAFKA-14133:
---
I wanted to collect all tests which are remaining so we
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574595#comment-17574595
]
Christo Lolov commented on KAFKA-14132:
---
Great, thank you, I will put your alias next to the in
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574561#comment-17574561
]
Yash Mayya commented on KAFKA-14133:
Hi [~christo_lolov], are you planning to work on migrating all
yashmayya commented on PR #12472:
URL: https://github.com/apache/kafka/pull/12472#issuecomment-1203578055
Thanks for the reviews @divijvaidya and @C0urante! I've incorporated your
feedback, could you please take another look?
--
This is an automated message from the Apache Git Service.
mdedetrich commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-1203547014
@divijvaidya This is one of the first PR's in adding the linting/formatting
using scalafmt/scalafix for the Scala sources within Kafka if you want to have
a look. @cadonna Do you want
showuon commented on PR #12452:
URL: https://github.com/apache/kafka/pull/12452#issuecomment-1203545154
Thanks @divijvaidya for fixing it! Thanks for @mimaison 's review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
83 matches
Mail list logo
