ijuma merged PR #12163:
URL: https://github.com/apache/kafka/pull/12163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213640348
Merged to trunk, 3.3, 3.2, 3.1 and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ijuma merged PR #12260:
URL: https://github.com/apache/kafka/pull/12260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
d-t-w commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213596640
Hi @ijuma yes it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ijuma commented on code in PR #12260:
URL: https://github.com/apache/kafka/pull/12260#discussion_r944939422
##
docs/upgrade.html:
##
@@ -67,6 +67,9 @@ Notable changes in 3
which meant that idempotence remained disabled unless the user had
explicitly set enable.idem
ijuma commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213588315
@d-t-w I tweaked it a bit. Does this look OK to you? Basically, I wanted to
include this note in the main bullet point regarding the change.
--
This is an automated message from the Apach
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r944910841
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -29,22 +32,72 @@
* NOTE: This class is intended for INTERNAL usage only within Kafka.
*/
[
https://issues.apache.org/jira/browse/KAFKA-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579155#comment-17579155
]
Vincent Jiang commented on KAFKA-14096:
---
I have two questions about this issue:
1.
ijuma commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r944877645
##
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##
@@ -147,11 +147,14 @@ public ReplicaManagerBuilder setThreadNamePrefix(String
threadNamePrefix)
ijuma commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r944877032
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java:
##
@@ -342,6 +342,7 @@ public void reauthenticate(ReauthenticationCon
ijuma commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r944876379
##
clients/src/main/java/org/apache/kafka/common/network/PlaintextChannelBuilder.java:
##
@@ -54,12 +54,18 @@ public void configure(Map configs) throws
KafkaException {
ijuma opened a new pull request, #12511:
URL: https://github.com/apache/kafka/pull/12511
There was unnecessary duplication and one of the overloads
did not set the size field for no good reason.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implem
dplavcic commented on code in PR #12509:
URL: https://github.com/apache/kafka/pull/12509#discussion_r944801602
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/RootResourceTest.java:
##
@@ -20,21 +20,20 @@
import org.apache.kafka.common.utils.App
dplavcic commented on code in PR #12505:
URL: https://github.com/apache/kafka/pull/12505#discussion_r944784869
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##
@@ -280,12 +276,9 @@ private StreamsConfig streamsConfigM
dplavcic commented on code in PR #12505:
URL: https://github.com/apache/kafka/pull/12505#discussion_r944781108
##
streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java:
##
@@ -126,27 +121,15 @@ public void shouldThrowNullPointerIfInnerIsNul
dplavcic commented on code in PR #12492:
URL: https://github.com/apache/kafka/pull/12492#discussion_r944765384
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatTransformValuesTest.java:
##
@@ -68,69 +72,60 @@ public void
shouldTransformInputRecordT
dplavcic commented on code in PR #12492:
URL: https://github.com/apache/kafka/pull/12492#discussion_r944750815
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamPrintTest.java:
##
@@ -31,11 +33,15 @@
import static org.junit.Assert.assertEquals;
+@Ru
dplavcic commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r944710092
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToAddW
[
https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579079#comment-17579079
]
Ismael Juma commented on KAFKA-13639:
-
Thanks for the report. [~mrMigles] What Java
vamossagar12 commented on PR #12306:
URL: https://github.com/apache/kafka/pull/12306#issuecomment-1213341834
@tombentley / @mimaison Plz review this PR whenever you get the chance..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
vamossagar12 commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1213341039
@wcarlson5 , @guozhangwang , @lihaosky Would it be possible to review this
PR? This has gone through multiple changes I think should be ok to review now.
Plz let me know. Thanks!
-
vamossagar12 commented on PR #9292:
URL: https://github.com/apache/kafka/pull/9292#issuecomment-1213339858
@dajac , @stanislavkozlovski, @ijuma I was closing out on some old PRs of
mine and found this one. Do you think this is still useful or should I just
close it?
--
This is an autom
[
https://issues.apache.org/jira/browse/KAFKA-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13959.
Resolution: Fixed
> Controller should unfence Broker with busy met
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944652522
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -296,6 +296,75 @@ public void shouldAddTasksToStateUpdater() {
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944641632
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -296,6 +296,75 @@ public void shouldAddTasksToStateUpdater() {
jolshan commented on PR #12501:
URL: https://github.com/apache/kafka/pull/12501#issuecomment-1213313811
> Do we need a test that validates the producer id expiration without
transactions?
> I was also wondering if we could add better unit tests to test the various
scenarios and ensur
[
https://issues.apache.org/jira/browse/KAFKA-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13959:
---
Description:
https://issues.apache.org/jira/browse/KAFKA-13955 showe
jsancio merged PR #12274:
URL: https://github.com/apache/kafka/pull/12274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579032#comment-17579032
]
Sylwester Kras commented on KAFKA-13887:
Hi all,
thanks for this post. As [~cad
jsancio commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1213269855
Build failed with test errors. Rerunning:
```
[Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testOffsetSyncsTopicsOnTa
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944588391
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -656,6 +657,71 @@ boolean tryToCompleteRestoration(final long now, final
j
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944588391
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -656,6 +657,71 @@ boolean tryToCompleteRestoration(final long now, final
j
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944585976
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -296,6 +296,75 @@ public void shouldAddTasksToStateUpdater() {
[
https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579022#comment-17579022
]
Gian Luca edited comment on KAFKA-14081 at 8/12/22 3:29 PM:
[
https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579022#comment-17579022
]
Gian Luca commented on KAFKA-14081:
---
Hi Rens and Bruno, thanks for the explanation, no
cadonna merged PR #12497:
URL: https://github.com/apache/kafka/pull/12497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12497:
URL: https://github.com/apache/kafka/pull/12497#issuecomment-1213210962
Failures are unrelated:
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()
Bu
[
https://issues.apache.org/jira/browse/KAFKA-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579004#comment-17579004
]
Bruno Cadonna edited comment on KAFKA-13514 at 8/12/22 2:58 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579004#comment-17579004
]
Bruno Cadonna commented on KAFKA-13514:
---
Happened again:
{code:java}
[2022-08-12
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Affects Version/s: 3.2.1
> ConfigTransformer.DEFAULT_PATTERN fails on Windows platform
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Component/s: config
> ConfigTransformer.DEFAULT_PATTERN fails on Windows platform
>
cadonna commented on PR #12228:
URL: https://github.com/apache/kafka/pull/12228#issuecomment-1213162695
@divijvaidya @jsancio The Streams related changes LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dajac commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r944479620
##
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##
@@ -105,6 +105,36 @@ class TransactionsExpirationTest extends
KafkaServerTestHarness {
ijuma commented on PR #12501:
URL: https://github.com/apache/kafka/pull/12501#issuecomment-1213156822
Do we need a test that validates the producer id expiration without
transactions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944502639
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -296,6 +296,75 @@ public void shouldAddTasksToStateUpdater() {
cadonna opened a new pull request, #12510:
URL: https://github.com/apache/kafka/pull/12510
We recently added a builder to create task mocks for unit
tests. This PR adds the functionality to add input partitions
to task mocks when the builder is used.
### Committer Checklist (excl
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Description:
When a configuration Map which has an entry with a key "someKey" and a value
"${fi
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Description:
When a configuration Map which has an entry with a key "someKey" and a value
"${fi
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Description:
When a configuration Map which has an entry with a key "someKey" and a value
"${fi
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Andras updated KAFKA-14165:
-
Description:
When a configuration Map which has an entry with a key "someKey" and a value
"${[f
Gabor Andras created KAFKA-14165:
Summary: ConfigTransformer.DEFAULT_PATTERN fails on Windows
platform
Key: KAFKA-14165
URL: https://issues.apache.org/jira/browse/KAFKA-14165
Project: Kafka
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r944439546
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -316,20 +313,22 @@ public void handleAssignment(final Map> activeTasks,
cadonna commented on code in PR #12492:
URL: https://github.com/apache/kafka/pull/12492#discussion_r944375842
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/MaterializedInternalTest.java:
##
@@ -73,11 +71,11 @@ public void shouldUseProvidedStoreNameWhenSet()
vamossagar12 commented on PR #12502:
URL: https://github.com/apache/kafka/pull/12502#issuecomment-1212990235
Thanks. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
clolov commented on PR #12505:
URL: https://github.com/apache/kafka/pull/12505#issuecomment-1212874952
I am aware checkstyle is complaining about some indentation which I will fix
later throughout the day.
--
This is an automated message from the Apache Git Service.
To respond to the mes
yashmayya commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r944228193
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HoistFieldTest.java:
##
@@ -58,4 +59,17 @@ public void withSchema() {
assertEquals(42,
vamossagar12 commented on PR #12502:
URL: https://github.com/apache/kafka/pull/12502#issuecomment-1212851206
Thanks @yashmayya . I had a minor comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vamossagar12 commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r944222388
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HoistFieldTest.java:
##
@@ -58,4 +59,17 @@ public void withSchema() {
assertEquals(
yashmayya opened a new pull request, #12509:
URL: https://github.com/apache/kafka/pull/12509
- This PR replaces `EasyMock` with `Mockito` in the remaining Connect tests
from https://issues.apache.org/jira/browse/KAFKA-14133
- The Connect tests which still use `EasyMock` are ones which als
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14133:
---
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put those
mdedetrich commented on PR #12505:
URL: https://github.com/apache/kafka/pull/12505#issuecomment-1212822560
Thanks, will review today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
62 matches
Mail list logo
