ableegoldman merged PR #12594:
URL: https://github.com/apache/kafka/pull/12594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #12594:
URL: https://github.com/apache/kafka/pull/12594#issuecomment-1271097851
> Wow every single test passed. Don't see that very often on a pr
Yeah that is legitimately amazing. Love to see it! Maybe things are turning
around...heh...
--
This is
ableegoldman commented on code in PR #12594:
URL: https://github.com/apache/kafka/pull/12594#discussion_r989672094
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java:
##
@@ -389,22 +389,18 @@ private List
showuon opened a new pull request, #12723:
URL: https://github.com/apache/kafka/pull/12723
Fix some typos in javadoc
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
jsancio commented on code in PR #12715:
URL: https://github.com/apache/kafka/pull/12715#discussion_r989546700
##
metadata/src/main/java/org/apache/kafka/image/ImageWriter.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
vvcephei merged PR #12676:
URL: https://github.com/apache/kafka/pull/12676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on PR #12676:
URL: https://github.com/apache/kafka/pull/12676#issuecomment-1270858535
These test failures are not related:
```
[Build / JDK 8 and Scala 2.12 /
mdedetrich commented on PR #12722:
URL: https://github.com/apache/kafka/pull/12722#issuecomment-1270675307
@C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mdedetrich commented on PR #12721:
URL: https://github.com/apache/kafka/pull/12721#issuecomment-1270674528
@C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mdedetrich opened a new pull request, #12722:
URL: https://github.com/apache/kafka/pull/12722
The variables must be used, otherwise the leaders will not be pleased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mdedetrich opened a new pull request, #12721:
URL: https://github.com/apache/kafka/pull/12721
Currently the testCreateConnectorWithoutHeaderAuthorization and
testCreateConnectorWithHeaderAuthorization tests within ConnectorsResourceTest
aren't actually anything. This is because in reality
Matthew de Detrich created KAFKA-14283:
--
Summary: Fix connector creation authorization tests not doing
anything
Key: KAFKA-14283
URL: https://issues.apache.org/jira/browse/KAFKA-14283
Project:
rishiraj88 commented on PR #12718:
URL: https://github.com/apache/kafka/pull/12718#issuecomment-1270616837
Thanks, @mimaison .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vvcephei commented on code in PR #12676:
URL: https://github.com/apache/kafka/pull/12676#discussion_r989427267
##
streams/src/test/java/org/apache/kafka/streams/integration/SelfJoinUpgradeIntegrationTest.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software
Ge commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r989362523
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java:
##
@@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,
cmccabe opened a new pull request, #12720:
URL: https://github.com/apache/kafka/pull/12720
Add builders for LocalLogManagerTestEnv and QuorumControllerTestEnv, since
the constructor overloads were starting to get unwieldy.
Make indentation more consistent in QuorumControllerTest.
[
https://issues.apache.org/jira/browse/KAFKA-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613717#comment-17613717
]
José Armando García Sancio commented on KAFKA-14279:
Yes [~hoping]. Feel free to
ijuma commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1270343163
@C0urante You mentioned in your PR that we could potentially adjust the
`Exit` classes, but it would not solve the problem as well. Is the main issue
that we have System.exit/halt calls
nicktelford commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r989161053
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java:
##
@@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,
mimaison merged PR #11373:
URL: https://github.com/apache/kafka/pull/11373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #12718:
URL: https://github.com/apache/kafka/pull/12718#issuecomment-1269975501
Thanks, I backported it to 3.3 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison merged PR #12718:
URL: https://github.com/apache/kafka/pull/12718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #12719:
URL: https://github.com/apache/kafka/pull/12719#issuecomment-1269909503
@cadonna would you want to have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lucasbru opened a new pull request, #12719:
URL: https://github.com/apache/kafka/pull/12719
Quickstart examples didn't produce any console output, since it was missing
a logger implementation in the classpath.
Also some minor cleanups.
Tested by creating a test project and
viktorsomogyi commented on PR #11373:
URL: https://github.com/apache/kafka/pull/11373#issuecomment-1269821887
@mimaison would you please check this quickly? (I think the test failures
are unrelated as this only affects the command line)
--
This is an automated message from the Apache Git
mimaison opened a new pull request, #12718:
URL: https://github.com/apache/kafka/pull/12718
See https://github.com/apache/kafka-site/pull/457
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Bruckner updated KAFKA-14282:
---
Description:
Since we upgrade from version 3.2.0 to 3.3.1 we see a lot of
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Bruckner updated KAFKA-14282:
---
Description:
Since we upgrade from version 3.2.0 to 3.3.1 we see a lot of
Sebastian Bruckner created KAFKA-14282:
--
Summary: RecordCollector throws exception on message processing
Key: KAFKA-14282
URL: https://issues.apache.org/jira/browse/KAFKA-14282
Project: Kafka
mimaison commented on PR #12713:
URL: https://github.com/apache/kafka/pull/12713#issuecomment-1269606715
Thanks! Backported to 3.3 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison merged PR #12713:
URL: https://github.com/apache/kafka/pull/12713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
31 matches
Mail list logo