hachikuji merged PR #12796:
URL: https://github.com/apache/kafka/pull/12796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1295446037
Previously, the controller logic wasn't single threaded. So, this check is
probably just to prevent concurrent actions. Now that all logic in the
controller runs in a single thread, this
ijuma commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1295433463
@junrao Was there an underlying reason not to allow this previously?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hachikuji commented on code in PR #12796:
URL: https://github.com/apache/kafka/pull/12796#discussion_r1008405909
##
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java:
##
@@ -698,6 +714,21 @@ public void testCreateTopicsWithPolicy() throws
hachikuji commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1295396711
Thanks for all the discussion here and sorry for the late arrival. I have
seen this issue in practice as well, often in the context of hanging
transactions. The late-arriving `Produce`
jsancio commented on code in PR #12796:
URL: https://github.com/apache/kafka/pull/12796#discussion_r1008380883
##
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java:
##
@@ -698,6 +714,21 @@ public void testCreateTopicsWithPolicy() throws
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1295343296
It turns out that the `testReplication` flakiness persisted in Jenkins, and
was not solved by increasing timeouts.
Instead, the root of the problem was a change in the Connect
gharris1727 commented on code in PR #12791:
URL: https://github.com/apache/kafka/pull/12791#discussion_r1008326288
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java:
##
@@ -50,16 +52,15 @@ public void setUp() throws Exception {
@Test
gharris1727 commented on code in PR #12791:
URL: https://github.com/apache/kafka/pull/12791#discussion_r1008325977
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java:
##
@@ -116,16 +117,20 @@ public void testNoBackoffTimeAndSucceed() throws
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1008323698
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1008321714
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1295299541
i've benchmarked the change in our internal infrastructure and stressed the
number of topic partitions. there were no noticeable differences (lock
contention/cpu/load) and confirmed
gharris1727 commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1008315241
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -192,6 +193,41 @@ public void testConnectorStatus() {
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1008309856
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1008302178
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
justinrlee opened a new pull request, #12797:
URL: https://github.com/apache/kafka/pull/12797
This is a relatively minor quality of life change.
Currently, some of the various `kafka-X` commands (which wrap various Kafka
admin calls) require that `--bootstrap-server` (or,
hachikuji merged PR #12790:
URL: https://github.com/apache/kafka/pull/12790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji opened a new pull request, #12796:
URL: https://github.com/apache/kafka/pull/12796
This patch adds a unit test for topic recreation with colliding characters
(such as `.`). This was broken up until
https://github.com/apache/kafka/pull/12790.
### Committer Checklist
lucasbru commented on PR #12795:
URL: https://github.com/apache/kafka/pull/12795#issuecomment-1295197667
@cadonna Could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasbru opened a new pull request, #12795:
URL: https://github.com/apache/kafka/pull/12795
The original state updater code path put tasks into an "initialization
queue", with created, but not initialized tasks. These are later, during the
event-loop, initialized and added to the state
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
mimaison merged PR #12692:
URL: https://github.com/apache/kafka/pull/12692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14314.
Fix Version/s: 3.4.0
Resolution: Fixed
> MirrorSourceConnector throwing NPE during
mimaison merged PR #12769:
URL: https://github.com/apache/kafka/pull/12769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nicktelford commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r1008188697
##
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java:
##
@@ -73,16 +75,25 @@ public class
lucasbru commented on code in PR #12773:
URL: https://github.com/apache/kafka/pull/12773#discussion_r1008181271
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -1070,6 +1071,11 @@ public void shouldTransitState() {
lucasbru commented on code in PR #12773:
URL: https://github.com/apache/kafka/pull/12773#discussion_r1008163226
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##
@@ -990,6 +991,10 @@ public void unregister(final Collection
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008151429
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -82,15 +84,17 @@ public void testClientConfigProperties() {
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008151052
##
clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java:
##
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lucasbru commented on code in PR #12772:
URL: https://github.com/apache/kafka/pull/12772#discussion_r1008150108
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -353,19 +353,21 @@ public static StreamThread create(final
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008149257
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java:
##
@@ -56,7 +58,11 @@ public class MirrorClientConfig extends
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008147190
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+ *
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008147190
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+ *
cowlike commented on code in PR #12769:
URL: https://github.com/apache/kafka/pull/12769#discussion_r1008128725
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java:
##
@@ -319,4 +320,17 @@ public void
LinShunKang commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1008120362
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -263,6 +264,16 @@ public String deserialize(String topic, byte[] data) {
LinShunKang commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1008118806
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1413,22 +1414,19 @@ private ConsumerRecord parseRecord(TopicPartition
sudeshwasnik commented on PR #12784:
URL: https://github.com/apache/kafka/pull/12784#issuecomment-1295033345
@C0urante @vamossagar12 quick dumb question - if there is an Async failure
(detected after offsets are dispatched to producer), won't
producer.commitTransaction also throw exception
mdedetrich commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1008075576
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -262,127 +254,96 @@ public void
mdedetrich commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1008075576
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -262,127 +254,96 @@ public void
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008074680
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -82,15 +84,17 @@ public void testClientConfigProperties() {
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008071035
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -82,15 +84,17 @@ public void testClientConfigProperties() {
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008071035
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -82,15 +84,17 @@ public void testClientConfigProperties() {
mimaison commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008070254
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1008052072
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -319,35 +318,28 @@ public void
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1008047026
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+ *
C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1008043521
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java:
##
@@ -171,4 +175,28 @@ public static ConnectException maybeWrap(Throwable t,
C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1008040282
##
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##
@@ -106,6 +108,7 @@ public Connect startConnect(Map
workerProps) {
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1008030917
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -123,91 +134,91 @@ private enum SourceSink {
mimaison commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1007859820
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -82,15 +84,17 @@ public void testClientConfigProperties() {
C0urante commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1294775103
I'm not opposed to improving error messages, but I'd like to ask again which
version of Kafka Connect / MirrorMaker 2 you were running when you encountered
this issue. We've already
[
https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625551#comment-17625551
]
David Jacot edited comment on KAFKA-14016 at 10/28/22 9:30 AM:
---
> The
[
https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625551#comment-17625551
]
David Jacot edited comment on KAFKA-14016 at 10/28/22 9:29 AM:
---
> The
[
https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14339:
-
Assignee: Sudesh Wasnik (was: Chris Egerton)
> producer commits-transaction even if
[
https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14339:
-
Assignee: Chris Egerton
> producer commits-transaction even if offsetWriter faces
[
https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625551#comment-17625551
]
David Jacot commented on KAFKA-14016:
-
> The sticky assignment algorithm should account for this and
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625542#comment-17625542
]
David Jacot commented on KAFKA-13419:
-
[~showuon] Thanks for confirming.
> sync group failed with
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625541#comment-17625541
]
Luke Chen commented on KAFKA-13419:
---
[~dajac] , you're right. We don't use owned partitions in old
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625532#comment-17625532
]
David Jacot commented on KAFKA-13419:
-
[~ableegoldman] [~showuon] Looking at the code in
mimaison commented on code in PR #12769:
URL: https://github.com/apache/kafka/pull/12769#discussion_r1007784731
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java:
##
@@ -319,4 +320,17 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-14281:
Labels: cloudera (was: )
> Multi-level rack awareness
>
[
https://issues.apache.org/jira/browse/KAFKA-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-14250:
Labels: cloudera (was: )
> Exception during normal operation in MirrorSourceTask
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1007760016
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest {
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1007759537
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest {
shirenchuang closed pull request #12793: [KAFKA-14328]: KafkaAdminClient should
be Changing the exception level …
URL: https://github.com/apache/kafka/pull/12793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
shirenchuang closed pull request #11445: createTopic need sort brokerMetadata
URL: https://github.com/apache/kafka/pull/11445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shirenchuang closed pull request #11453: createTopic need sort brokerMetadata
URL: https://github.com/apache/kafka/pull/11453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-14328:
-
Assignee: shizhenzhen
> KafkaAdminClient should be Changing the exception level When an
showuon commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007703640
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007698554
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007700113
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007698554
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007696954
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
74 matches
Mail list logo