[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027051707 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGro

[GitHub] [kafka] ableegoldman commented on pull request #12869: KAFKA-14382: wait for current rebalance to complete before triggering followup

2022-11-18 Thread GitBox
ableegoldman commented on PR #12869: URL: https://github.com/apache/kafka/pull/12869#issuecomment-1320825312 Cherrypicked all the way back to 3.0...whew! Had to resolve a few minor merge conflicts along the way but it was generally smooth (I did make a small mistake on the 3.3 resolut

[jira] [Updated] (KAFKA-14382) StreamThreads can miss rebalance events when processing records during a rebalance

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14382: --- Fix Version/s: 3.1.3 3.0.3 > StreamThreads can miss rebal

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027049468 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -21,11 +21,10 @@ import java.io.{File, IOException} import java.net.{InetAddress, SocketTimeoutException} i

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027049342 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroupRe

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027049080 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroupRe

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636116#comment-17636116 ] A. Sophie Blee-Goldman commented on KAFKA-14362: Well I mean, regardless

[jira] [Updated] (KAFKA-14382) StreamThreads can miss rebalance events when processing records during a rebalance

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14382: --- Fix Version/s: 3.3.2 3.2.4 > StreamThreads can miss rebal

[jira] [Updated] (KAFKA-14382) StreamThreads can miss rebalance events when processing records during a rebalance

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14382: --- Labels: rebalancing (was: ) > StreamThreads can miss rebalance events when

[GitHub] [kafka] ableegoldman merged pull request #12869: KAFKA-14382: wait for current rebalance to complete before triggering followup

2022-11-18 Thread GitBox
ableegoldman merged PR #12869: URL: https://github.com/apache/kafka/pull/12869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman commented on pull request #12869: KAFKA-14382: wait for current rebalance to complete before triggering followup

2022-11-18 Thread GitBox
ableegoldman commented on PR #12869: URL: https://github.com/apache/kafka/pull/12869#issuecomment-1320817093 Test failures are all unrelated -- merging this now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027036420 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGro

[GitHub] [kafka] ableegoldman merged pull request #12842: KAFKA-14406: Fix double iteration of restoring records

2022-11-18 Thread GitBox
ableegoldman merged PR #12842: URL: https://github.com/apache/kafka/pull/12842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman commented on pull request #12842: KAFKA-14406: Fix double iteration of restoring records

2022-11-18 Thread GitBox
ableegoldman commented on PR #12842: URL: https://github.com/apache/kafka/pull/12842#issuecomment-1320799136 test failures are unrelated, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027026027 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1455,30 +1523,56 @@ private void replay(ApiMessage message, Optional snapshotId, lo

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027024757 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1376,6 +1413,37 @@ private void cancelNextWriteNoOpRecord() { queue.cancelD

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027024702 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,14 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027024629 ## raft/src/main/java/org/apache/kafka/raft/RaftClient.java: ## @@ -229,4 +229,15 @@ default void beginShutdown() {} * or less than the log start offset.

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027024376 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -986,6 +1012,13 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027022584 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[jira] [Created] (KAFKA-14407) Able to access offset index memory map even after memory map flag is turned off

2022-11-18 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14407: Summary: Able to access offset index memory map even after memory map flag is turned off Key: KAFKA-14407 URL: https://issues.apache.org/jira/browse/KAFKA-14407 Project: Kafk

[GitHub] [kafka] jeffkbkim opened a new pull request, #12877: KAFKA-14372: choose replicas only from isr for preferred read replica

2022-11-18 Thread GitBox
jeffkbkim opened a new pull request, #12877: URL: https://github.com/apache/kafka/pull/12877 The default replica selector chooses a replica on whether the broker.rack matches the client.rack in the fetch request and whether the offset exists in the follower. If the follower is not in the IS

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027019732 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12859: KAFKA-14325: Fix NPE on Processor Parameters toString

2022-11-18 Thread GitBox
ableegoldman commented on code in PR #12859: URL: https://github.com/apache/kafka/pull/12859#discussion_r1027007714 ## streams/src/test/resources/log4j.properties: ## @@ -27,7 +27,7 @@ log4j.logger.org.apache.kafka.clients=ERROR # These are the only logs we will likely ever fin

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12859: KAFKA-14325: Fix NPE on Processor Parameters toString

2022-11-18 Thread GitBox
ableegoldman commented on code in PR #12859: URL: https://github.com/apache/kafka/pull/12859#discussion_r1027007076 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java: ## @@ -130,7 +129,8 @@ public String processorName() { @Ov

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12859: KAFKA-14325: Fix NPE on Processor Parameters toString

2022-11-18 Thread GitBox
ableegoldman commented on code in PR #12859: URL: https://github.com/apache/kafka/pull/12859#discussion_r1027007003 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java: ## @@ -114,13 +114,12 @@ KTableSource kTableSourceSupplier() {

[jira] [Assigned] (KAFKA-14325) NullPointer in ProcessorParameters.toString

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-14325: -- Assignee: Jorge Esteban Quilcate Otoya (was: A. Sophie Blee-Goldman)

[jira] [Resolved] (KAFKA-14406) Double iteration of records in batches to be restored

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-14406. Resolution: Fixed > Double iteration of records in batches to be restored

[jira] [Created] (KAFKA-14406) Double iteration of records in batches to be restored

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14406: -- Summary: Double iteration of records in batches to be restored Key: KAFKA-14406 URL: https://issues.apache.org/jira/browse/KAFKA-14406 Project: Kaf

[jira] [Created] (KAFKA-14405) Log a warning when users attempt to set a config controlled by Streams

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14405: -- Summary: Log a warning when users attempt to set a config controlled by Streams Key: KAFKA-14405 URL: https://issues.apache.org/jira/browse/KAFKA-14405

[jira] [Updated] (KAFKA-14404) Fix & update docs on client configs controlled by Streams

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14404: --- Summary: Fix & update docs on client configs controlled by Streams (was: Im

[jira] [Created] (KAFKA-14404) Improve dWarn that the ProducerConfig partitioner.class cannot be used in Streams

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14404: -- Summary: Improve dWarn that the ProducerConfig partitioner.class cannot be used in Streams Key: KAFKA-14404 URL: https://issues.apache.org/jira/browse/KAFKA-14

[GitHub] [kafka] niket-goel commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
niket-goel commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027000889 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long dela

[GitHub] [kafka] niket-goel commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
niket-goel commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1027000889 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long dela

[GitHub] [kafka] niket-goel commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
niket-goel commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026985550 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,14 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] hachikuji commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
hachikuji commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026995028 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delay

[GitHub] [kafka] gharris1727 opened a new pull request, #12876: KAFKA-12476: Prevent herder tick thread from sleeping excessively after slow operations

2022-11-18 Thread GitBox
gharris1727 opened a new pull request, #12876: URL: https://github.com/apache/kafka/pull/12876 The current method of computing the member poll duration does not take into account the time spent on connector operations in tick(), which may be significant. This can cause a worker to sleep for

[jira] [Assigned] (KAFKA-12476) Worker can block for longer than scheduled rebalance delay and/or session key TTL

2022-11-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-12476: --- Assignee: Greg Harris > Worker can block for longer than scheduled rebalance delay and/or s

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026974492 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1455,30 +1523,56 @@ private void replay(ApiMessage message, Optional snapshotId, lo

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026974404 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,12 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026965577 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -986,6 +1012,13 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026965577 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -986,6 +1012,13 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026963407 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[jira] [Created] (KAFKA-14403) Snapshot failure metrics

2022-11-18 Thread Jira
José Armando García Sancio created KAFKA-14403: -- Summary: Snapshot failure metrics Key: KAFKA-14403 URL: https://issues.apache.org/jira/browse/KAFKA-14403 Project: Kafka Issue Ty

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026957838 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026950932 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1157,6 +1164,7 @@ object KafkaConfig { * KRaft mode configs. */ .define(MetadataSna

[GitHub] [kafka] wcarlson5 commented on pull request #12842: MINOR: Fix double iteration of restoring records

2022-11-18 Thread GitBox
wcarlson5 commented on PR #12842: URL: https://github.com/apache/kafka/pull/12842#issuecomment-1320560081 I think this might need a ticket. If you don't mind creating one. It would be good to track this to see when we get the fix in and what branches it's on -- This is an automated messag

[jira] [Updated] (KAFKA-14372) RackAwareReplicaSelector should choose a replica from the isr

2022-11-18 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-14372: - Description: The default replica selector chooses a replica on whether the broker.rack matches the clie

[GitHub] [kafka] jolshan commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-11-18 Thread GitBox
jolshan commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1320546110 @urbandan By the way, KIP-890 is now available to review 😄 https://cwiki.apache.org/confluence/display/KAFKA/KIP-890%3A+Transactions+Server-Side+Defense -- This is an automated mess

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026894950 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroup

[jira] [Created] (KAFKA-14402) Transactions Server Side Defense

2022-11-18 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14402: -- Summary: Transactions Server Side Defense Key: KAFKA-14402 URL: https://issues.apache.org/jira/browse/KAFKA-14402 Project: Kafka Issue Type: Task

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026881513 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroupRe

[GitHub] [kafka] hachikuji commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-18 Thread GitBox
hachikuji commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026780591 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,12 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] jolshan commented on a diff in pull request #12848: KAFKA-14367; Add `Heartbeat` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12848: URL: https://github.com/apache/kafka/pull/12848#discussion_r1026784250 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2806,6 +2806,100 @@ class KafkaApisTest { } } + @ParameterizedTest Review Comment: W

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026780137 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroup

[jira] [Resolved] (KAFKA-14320) Upgrade Jackson for CVE fix

2022-11-18 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-14320. --- Resolution: Fixed > Upgrade Jackson for CVE fix > --- > > Ke

[GitHub] [kafka] C0urante commented on pull request #12784: KAFKA-14339 : Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

2022-11-18 Thread GitBox
C0urante commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1320363284 @sudeshwasnik are you still working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] omkreddy closed pull request #12766: KAFKA-14320: Upgrade Jackson for CVE Fix

2022-11-18 Thread GitBox
omkreddy closed pull request #12766: KAFKA-14320: Upgrade Jackson for CVE Fix URL: https://github.com/apache/kafka/pull/12766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] omkreddy commented on pull request #12766: KAFKA-14320: Upgrade Jackson for CVE Fix

2022-11-18 Thread GitBox
omkreddy commented on PR #12766: URL: https://github.com/apache/kafka/pull/12766#issuecomment-1320352617 closing as duplicate https://github.com/apache/kafka/pull/12840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] omkreddy merged pull request #12840: KAFKA-14320: Updated Jackson to version 2.13.4 for fixing CVE-2022-42004

2022-11-18 Thread GitBox
omkreddy merged PR #12840: URL: https://github.com/apache/kafka/pull/12840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] jolshan commented on a diff in pull request #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12847: URL: https://github.com/apache/kafka/pull/12847#discussion_r1024400644 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -135,4 +133,71 @@ class GroupCoordinatorAdapterTest { assertEquals(exp

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026687239 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026684714 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -21,11 +21,10 @@ import java.io.{File, IOException} import java.net.{InetAddress, SocketTimeoutException}

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-18 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1026680653 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroup

[jira] [Updated] (KAFKA-14401) Connector/Tasks reading offsets can get stuck if underneath WorkThread dies

2022-11-18 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-14401: -- Description: When a connector or task tries to read the offsets from the offsets topic, it issues `Of

[jira] [Created] (KAFKA-14401) Connector/Tasks reading offsets can get stuck if underneath WorkThread dies

2022-11-18 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14401: - Summary: Connector/Tasks reading offsets can get stuck if underneath WorkThread dies Key: KAFKA-14401 URL: https://issues.apache.org/jira/browse/KAFKA-14401 Project: Kafka

[GitHub] [kafka] C0urante commented on pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic

2022-11-18 Thread GitBox
C0urante commented on PR #12863: URL: https://github.com/apache/kafka/pull/12863#issuecomment-1320238030 @NLincoln It looks like this issue was already assigned to @jsancio on Jira; it's best to find tickets that either have not yet been assigned, or have not been worked on in a while.

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-18 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635921#comment-17635921 ] Mikael commented on KAFKA-14362: No, no errors or warnings related to rebalancing. I'm c

[GitHub] [kafka] C0urante commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-11-18 Thread GitBox
C0urante commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1320186592 Backported to 3.3 (with the new test disabled) in https://github.com/apache/kafka/commit/80e4f42bb3c8f6843b8e3aa2823e38b1a6269a38 -- This is an automated message from the Apache Git Se

[jira] [Updated] (KAFKA-13586) ConfigExceptions thrown by FileConfigProvider during connector/task startup crash worker

2022-11-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13586: -- Fix Version/s: 3.3.2 > ConfigExceptions thrown by FileConfigProvider during connector/task sta

[GitHub] [kafka] ijuma commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-18 Thread GitBox
ijuma commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1026569181 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -214,14 +214,14 @@ object TestUtils extends Logging { enableToken: Boolean = false, numPartitions

[GitHub] [kafka] ijuma commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-18 Thread GitBox
ijuma commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1026569181 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -214,14 +214,14 @@ object TestUtils extends Logging { enableToken: Boolean = false, numPartitions

[GitHub] [kafka] lucasbru commented on pull request #12875: KAFKA-12679: Handle lock exceptions in state updater

2022-11-18 Thread GitBox
lucasbru commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-1320135097 @cadonna Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] lucasbru opened a new pull request, #12875: MINOR: Enable state updater in smoke test

2022-11-18 Thread GitBox
lucasbru opened a new pull request, #12875: URL: https://github.com/apache/kafka/pull/12875 In this change, we enable backing off when the state directory is still locked during initialization of a task. For this, we introduce a new queue inside the state updater, that keeps all task

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-11-18 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1320112618 Thanks @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-13586) ConfigExceptions thrown by FileConfigProvider during connector/task startup crash worker

2022-11-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13586. --- Resolution: Fixed > ConfigExceptions thrown by FileConfigProvider during connector/task star

[GitHub] [kafka] C0urante merged pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-11-18 Thread GitBox
C0urante merged PR #12295: URL: https://github.com/apache/kafka/pull/12295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-13586) ConfigExceptions thrown by FileConfigProvider during connector/task startup crash worker

2022-11-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13586: -- Fix Version/s: 3.4.0 > ConfigExceptions thrown by FileConfigProvider during connector/task sta

[GitHub] [kafka] lucasbru commented on pull request #12801: KAFKA-14343: Upgrade tests for state updater

2022-11-18 Thread GitBox
lucasbru commented on PR #12801: URL: https://github.com/apache/kafka/pull/12801#issuecomment-1320051193 CI test failures are unrelated. Passing system test run 10x for the new upgrade / downgrade test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5206/

[GitHub] [kafka] jeqo commented on pull request #12859: KAFKA-14325: Fix NPE on Processor Parameters toString

2022-11-18 Thread GitBox
jeqo commented on PR #12859: URL: https://github.com/apache/kafka/pull/12859#issuecomment-131111 cc @ableegoldman @bbejeck @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Updated] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-18 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-14400: - Description: In Kafka-streams 3.1.1 : When using +JoinWindows.ofTimeDifferenceW

[jira] [Created] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-18 Thread Victor van den Hoven (Jira)
Victor van den Hoven created KAFKA-14400: Summary: KStream - KStream - LeftJoin() does not call ValueJoiner with null value Key: KAFKA-14400 URL: https://issues.apache.org/jira/browse/KAFKA-14400

[jira] [Assigned] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2022-11-18 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Sobeh reassigned KAFKA-6579: -- Assignee: Ahmed Sobeh > Consolidate window store and session store unit tests into a single cl

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635833#comment-17635833 ] A. Sophie Blee-Goldman commented on KAFKA-14362: Do you ever see anythin

[jira] [Commented] (KAFKA-14374) Kafka streams losing messages in State Store during first launch of app

2022-11-18 Thread Youcef Sebiat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635805#comment-17635805 ] Youcef Sebiat commented on KAFKA-14374: --- Thanks for your answer. I will try to ela

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-11-18 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1026242726 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -614,12 +613,103 @@ class AbstractFetcherThreadTest { assertEquals(0L, replicaState

[GitHub] [kafka] showuon merged pull request #12872: KAFKA-14303 Producer.send without record key and batch.size=0 goes into infinite loop

2022-11-18 Thread GitBox
showuon merged PR #12872: URL: https://github.com/apache/kafka/pull/12872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12872: KAFKA-14303 Producer.send without record key and batch.size=0 goes into infinite loop

2022-11-18 Thread GitBox
showuon commented on PR #12872: URL: https://github.com/apache/kafka/pull/12872#issuecomment-1319776013 Failed tests are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.server.KRaftClusterTest.testIncrementalAlterConfigs() Build / JDK 17 and Scala 2.13 / kafka.server.K

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-11-18 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1026150319 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -169,4 +181,140 @@ class ReplicaFetcherThread(name: String, partition.truncateFullyAndStartAt

[jira] [Created] (KAFKA-14399) ERROR Processor got uncaught exception: Java heap space OutOfMemory

2022-11-18 Thread evan.zhao (Jira)
evan.zhao created KAFKA-14399: - Summary: ERROR Processor got uncaught exception: Java heap space OutOfMemory Key: KAFKA-14399 URL: https://issues.apache.org/jira/browse/KAFKA-14399 Project: Kafka

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-11-18 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1025959204 ## clients/src/test/java/org/apache/kafka/common/record/RemoteLogInputStreamTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und