[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637589#comment-17637589
]
Sagar Rao commented on KAFKA-14401:
---
There are a couple of routes that can be taken here:
1) As
jeffkbkim opened a new pull request, #12897:
URL: https://github.com/apache/kafka/pull/12897
The consumer (fetcher) refreshes the preferred read replica only on three
conditions:
1. the consumer receives an OFFSET_OUT_OF_RANGE error
2. the follower does not exist in the client's
showuon commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1029965479
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1581,6 +1581,26 @@ public void commitAsync(final Map offsets, Of
* is
showuon commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1029963513
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1581,6 +1581,26 @@ public void commitAsync(final Map offsets, Of
* is
pprovenzano closed pull request #12838: [DO NOT MERGE]
SaslPlainSslEndToEndAuthorizationTest
URL: https://github.com/apache/kafka/pull/12838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pprovenzano opened a new pull request, #12896:
URL: https://github.com/apache/kafka/pull/12896
All EndToEndAuthorizationTests pass in both modes, but
SCRAM and Delegation are not implemented for KRAFT yet
so they emit a message to stderr and pass the test.
### Committer
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Summary: Producer doesn't handle REQUEST_TIMED_OUT for
InitProducerIdRequest, treats as
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Description:
In TransactionManager we have a handler for InitProducerIdRequests
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-14417:
--
Assignee: Justine Olshan
> Producer doesn't handle REQUEST_TIMED_OUT for
Justine Olshan created KAFKA-14417:
--
Summary: Producer doesn't handle REQUEST_TIMED_OUT for
InitProducerIdRequest
Key: KAFKA-14417
URL: https://issues.apache.org/jira/browse/KAFKA-14417
Project:
gharris1727 opened a new pull request, #12895:
URL: https://github.com/apache/kafka/pull/12895
Signed-off-by: Greg Harris
There are currently no descriptions of packages in the javadocs, which can
be intimidating to new users that look at the documentation and see a wall of
raw
jeffkbkim commented on code in PR #12877:
URL: https://github.com/apache/kafka/pull/12877#discussion_r1029900199
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -84,9 +84,58 @@ class FetchFromFollowerIntegrationTest extends
Dharin-shah opened a new pull request, #12894:
URL: https://github.com/apache/kafka/pull/12894
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
jeffkbkim commented on code in PR #12877:
URL: https://github.com/apache/kafka/pull/12877#discussion_r1029885511
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4174,11 +4244,14 @@ class ReplicaManagerTest {
class MockReplicaSelector extends
jeffkbkim commented on code in PR #12877:
URL: https://github.com/apache/kafka/pull/12877#discussion_r1029885511
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4174,11 +4244,14 @@ class ReplicaManagerTest {
class MockReplicaSelector extends
[
https://issues.apache.org/jira/browse/KAFKA-13881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-13881:
---
Assignee: Greg Harris
> Add package.java for public package javadoc
>
jeffkbkim commented on code in PR #12877:
URL: https://github.com/apache/kafka/pull/12877#discussion_r1029884348
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -1279,6 +1280,75 @@ class ReplicaManagerTest {
Greg Harris created KAFKA-14416:
---
Summary: org.apache.kafka.common.config.internals classes should
be relocated
Key: KAFKA-14416
URL: https://issues.apache.org/jira/browse/KAFKA-14416
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-14176.
-
Resolution: Fixed
> Reduce visibility of WorkerConfig.lookupKafkaClusterId
>
[
https://issues.apache.org/jira/browse/KAFKA-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-14176:
---
Assignee: Greg Harris
> Reduce visibility of WorkerConfig.lookupKafkaClusterId
>
[
https://issues.apache.org/jira/browse/KAFKA-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637481#comment-17637481
]
Greg Harris commented on KAFKA-14176:
-
This has been addressed as part of
Cerchie opened a new pull request, #12893:
URL: https://github.com/apache/kafka/pull/12893
As a result of "[14260: InMemoryKeyValueStore iterator still throws
ConcurrentModificationException](https://issues.apache.org/jira/browse/KAFKA-14260)",
I'm adding `synchronized` to `prefixScan` as
[
https://issues.apache.org/jira/browse/KAFKA-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-14307:
--
Assignee: José Armando García Sancio (was: Colin McCabe)
>
[
https://issues.apache.org/jira/browse/KAFKA-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-14307.
Resolution: Fixed
> KRaft controller time based snapshots
>
[
https://issues.apache.org/jira/browse/KAFKA-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637404#comment-17637404
]
Ron Dagostino commented on KAFKA-14394:
---
As per
[
https://issues.apache.org/jira/browse/KAFKA-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino resolved KAFKA-14394.
---
Resolution: Not A Problem
> BrokerToControllerChannelManager has 2 separate timeouts
>
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikael updated KAFKA-14362:
---
Attachment:
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1029683189
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -91,7 +91,8 @@ object AlterPartitionManager {
config = config,
channelName =
andymg3 opened a new pull request, #12892:
URL: https://github.com/apache/kafka/pull/12892
### JIRA
https://issues.apache.org/jira/browse/KAFKA-14386
### Summary
This changes the `ReplicaPlacer` interface to return a class instead of a
list of list of integers. There are two
gharris1727 commented on PR #12830:
URL: https://github.com/apache/kafka/pull/12830#issuecomment-1324049223
@stanislavkozlovski @lbradstreet @Kvicii do you think you could help review
this test stabilization change?
--
This is an automated message from the Apache Git Service.
To respond
lucasbru commented on PR #12875:
URL: https://github.com/apache/kafka/pull/12875#issuecomment-1324030274
Let's not merge this yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hachikuji commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023134907
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRequestContext.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
C0urante commented on code in PR #12805:
URL: https://github.com/apache/kafka/pull/12805#discussion_r1029585009
##
connect/runtime/src/test/resources/test-plugins/read-version-from-resource-v1/test/plugins/ReadVersionFromResource.java:
##
@@ -35,22 +38,37 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14415:
Component/s: streams
> ThreadCache is getting slower with every additional state store
>
divijvaidya opened a new pull request, #12891:
URL: https://github.com/apache/kafka/pull/12891
The impact of trace logging is normally small, however this adds up with
trace is called multiple times per produce request in the produce request hot
path.
This PR adds a conditional
C0urante merged PR #12889:
URL: https://github.com/apache/kafka/pull/12889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-14415:
---
Description:
There are a few lines in `ThreadCache` that I think should be optimized.
Lucas Brutschy created KAFKA-14415:
--
Summary: `ThreadCache` is getting slower with every additional
state store
Key: KAFKA-14415
URL: https://issues.apache.org/jira/browse/KAFKA-14415
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-14415:
--
Assignee: Lucas Brutschy
> ThreadCache is getting slower with every additional state
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-14415:
---
Summary: ThreadCache is getting slower with every additional state store
(was:
dajac commented on PR #12845:
URL: https://github.com/apache/kafka/pull/12845#issuecomment-1323781375
@jeffkbkim @jolshan @showuon Thanks for your comments. I have addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on PR #12845:
URL: https://github.com/apache/kafka/pull/12845#issuecomment-1323780346
> I left a comment about leaving more comments on tests, not a big deal
either way, but just wanted to remind.
@jolshan Thanks. I thought about this and I feel like the test is self
divijvaidya commented on PR #12890:
URL: https://github.com/apache/kafka/pull/12890#issuecomment-1323654501
@clolov please review when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
divijvaidya opened a new pull request, #12890:
URL: https://github.com/apache/kafka/pull/12890
## Motivation
We create an instance of ObjectSerializationCache at
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/network/RequestChannel.scala#L113
which does not get
divijvaidya opened a new pull request, #12889:
URL: https://github.com/apache/kafka/pull/12889
Change made on basis on conversation at
https://github.com/apache/kafka/pull/12233#discussion_r1023143304
@C0urante please review.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637240#comment-17637240
]
Victor van den Hoven commented on KAFKA-14400:
--
Thank you for taking the time to explain
[
https://issues.apache.org/jira/browse/KAFKA-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14414:
Assignee: Divij Vaidya
> Remove unnecessary usage of ObjectSerializationCache
>
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1029216062
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1581,6 +1581,23 @@ public void commitAsync(final Map offsets, Of
* is
clolov commented on PR #12818:
URL: https://github.com/apache/kafka/pull/12818#issuecomment-1323491682
Hello @wcarlson5 . Divij Vaidya mentioned he worked on a couple of pull
requests and you reviewed them so I was hoping you would be willing to go over
this one to get
clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1323475825
Hello @bbejeck! I have seen you collaborate with Divij Vaidya on a few pull
requests and I was hoping you would lend us a hand in reviewing this pull
request to get
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
clolov commented on PR #12505:
URL: https://github.com/apache/kafka/pull/12505#issuecomment-1323460811
Yay , thank you for your help in reviewing, approving and merging this
@cadonna!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1029114602
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRequestContext.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
ableegoldman merged PR #12887:
URL: https://github.com/apache/kafka/pull/12887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #12887:
URL: https://github.com/apache/kafka/pull/12887#issuecomment-1323365401
Java11 & 16 tests passed, Java 8 had a build failure (likely due to calling
System.exit in the system test) but had already run and passed the relevant
StreamThreadTest, so this
[
https://issues.apache.org/jira/browse/KAFKA-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-14212:
--
Fix Version/s: 3.3.2
> Fetch error response when hitting public OAuth/OIDC provider
>
Scanteianu commented on PR #12753:
URL: https://github.com/apache/kafka/pull/12753#issuecomment-1323280448
> @Scanteianu , thanks for the update. Left some comments.
@showuon thank you so much for circling back, addressed them!
--
This is an automated message from the Apache Git
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1028998832
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1581,6 +1581,23 @@ public void commitAsync(final Map offsets, Of
* is
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1028990203
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -672,7 +672,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
@Test
66 matches
Mail list logo
