[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171246205 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171245421 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171242181 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171240495 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1273,17 +1328,45 @@ class ReplicaManager(val config: KafkaConfig, _:

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1171232959 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most

[GitHub] [kafka] vamossagar12 commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1514537520 @yashmayya , @C0urante can you also review this small PR whenever you get the chance? Thanlks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

vamossagar12 commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1171175052 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +219,12 @@ public void

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

mdedetrich commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1514497721 So one part of the CI seems to be failing, i.e. for `JDK 8 and Scala 2.12` (see

[jira] [Created] (KAFKA-14921) Avoid non numeric values for metrics

Mickael Maison created KAFKA-14921: -- Summary: Avoid non numeric values for metrics Key: KAFKA-14921 URL: https://issues.apache.org/jira/browse/KAFKA-14921 Project: Kafka Issue Type:

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most

[GitHub] [kafka] machi1990 commented on pull request #13612: MINOR: fix noticed typo in raft and metadata projects

machi1990 commented on PR #13612: URL: https://github.com/apache/kafka/pull/13612#issuecomment-1514430594 Hi @showuon can you've a look at this PR as well when you've some time? It is a an extension of what I started doing yesterday in https://github.com/apache/kafka/pull/13593 as I am

[GitHub] [kafka] machi1990 opened a new pull request, #13612: MINOR: fix noticed typo in raft and metadata projects

machi1990 opened a new pull request, #13612: URL: https://github.com/apache/kafka/pull/13612 I noticed a few typos in the `raft` and `metadata` projects and I thought I could open a quick minor PR to fix them. *More detailed description of your change, if necessary. The PR title

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171070403 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14709) Move content in connect/mirror/README.md to the docs

[ https://issues.apache.org/jira/browse/KAFKA-14709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-14709: - Assignee: Gantigmaa Selenge > Move content in connect/mirror/README.md to the

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

machi1990 commented on PR #13611: URL: https://github.com/apache/kafka/pull/13611#issuecomment-1514361633 Hi @cmccabe @jsancio can you've a look at this, thanks? /cc @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713979#comment-17713979 ] Mickael Maison commented on KAFKA-14084: [~cmccabe]/[~pprovenzano] Do you have an update on

[GitHub] [kafka] machi1990 opened a new pull request, #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

machi1990 opened a new pull request, #13611: URL: https://github.com/apache/kafka/pull/13611 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r1170988090 ## docs/upgrade.html: ## @@ -26,6 +26,8 @@ Notable changes in 3 trying to create an already existing metric. (See

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170981380 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

dajac commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1170980408 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools

[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713966#comment-17713966 ] Federico Valeri commented on KAFKA-14586: - Thanks [~sagarrao]. When the redirection is merged,

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Remove tools redirections and deprecations (was: Remove all tools redirections

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1170939326 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

vamossagar12 commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1170934924 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +219,12 @@ public void

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

vamossagar12 commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1170934924 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +219,12 @@ public void

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170897060 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java: ## @@ -70,6 +71,23 @@ */ ApiResult handleResponse(Node

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1170888493 ## tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java: ## @@ -193,8 +181,7 @@ static String levelToString(String feature, short level) { static void

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1170929319 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java: ## @@ -705,12 +711,304 @@ public void

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1170924158 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -1294,4 +1307,11 @@ private KTable doJoinOnForeignKey(final KTable forei

[GitHub] [kafka] urbandan commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

urbandan commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1170921037 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +219,12 @@ public void

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170905273 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12545: KIP-863: Reduce CompletedFetch#parseRecord() memory copy

LinShunKang commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1170903894 ## clients/src/main/java/org/apache/kafka/common/serialization/DoubleDeserializer.java: ## @@ -35,4 +41,22 @@ public Double deserialize(String topic, byte[] data)

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13496: KAFKA-14834: [1/N] Add timestamped get to KTableValueGetter

vcrfxia commented on code in PR #13496: URL: https://github.com/apache/kafka/pull/13496#discussion_r1163422597 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableValueGetter.java: ## @@ -25,5 +25,21 @@ ValueAndTimestamp get(K key); +/** +

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170899662 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -1098,7 +1101,7 @@ private KTable doJoinOnForeignKey(final KTable forei

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170899662 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -1098,7 +1101,7 @@ private KTable doJoinOnForeignKey(final KTable forei

[GitHub] [kafka] vcrfxia opened a new pull request, #13610: MINOR: update comment for FK join processor renames

vcrfxia opened a new pull request, #13610: URL: https://github.com/apache/kafka/pull/13610 Minor follow-up to https://github.com/apache/kafka/pull/13589. This PR fixes a few comments where the old class names are still being used, to use the new class names instead. ### Committer

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12545: KIP-863: Reduce CompletedFetch#parseRecord() memory copy

LinShunKang commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1170898685 ## clients/src/main/java/org/apache/kafka/common/serialization/DoubleDeserializer.java: ## @@ -35,4 +41,22 @@ public Double deserialize(String topic, byte[] data)

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170897060 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java: ## @@ -70,6 +71,23 @@ */ ApiResult handleResponse(Node

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170894940 ## streams/src/test/java/org/apache/kafka/streams/integration/TableTableJoinIntegrationTest.java: ## @@ -446,14 +482,18 @@ public void

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170894062 ## streams/src/test/java/org/apache/kafka/streams/integration/TableTableJoinIntegrationTest.java: ## @@ -215,14 +226,19 @@ public void testInnerWithVersionedStores() {

[GitHub] [kafka] jlprat commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

jlprat commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r1170881445 ## docs/upgrade.html: ## @@ -26,6 +26,8 @@ Notable changes in 3 trying to create an already existing metric. (See

[GitHub] [kafka] jlprat commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

jlprat commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1514217231 Hi @mimaison, the current unit tests present in the PR seem that they will cover the case of a potential involuntary regression for this feature. So I'm fine adding the change as it

[GitHub] [kafka] showuon commented on a diff in pull request #12545: KIP-863: Reduce CompletedFetch#parseRecord() memory copy

showuon commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1170874370 ## clients/src/main/java/org/apache/kafka/common/serialization/DoubleDeserializer.java: ## @@ -35,4 +41,22 @@ public Double deserialize(String topic, byte[] data) {

[GitHub] [kafka] showuon commented on a diff in pull request #12545: KIP-863: Reduce CompletedFetch#parseRecord() memory copy

showuon commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1170872007 ## clients/src/main/java/org/apache/kafka/common/serialization/DoubleDeserializer.java: ## @@ -35,4 +41,22 @@ public Double deserialize(String topic, byte[] data) {

[GitHub] [kafka] showuon commented on a diff in pull request #12545: KIP-863: Reduce CompletedFetch#parseRecord() memory copy

showuon commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1170872007 ## clients/src/main/java/org/apache/kafka/common/serialization/DoubleDeserializer.java: ## @@ -35,4 +41,22 @@ public Double deserialize(String topic, byte[] data) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170869917 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java: ## @@ -97,6 +95,27 @@ public KTableKTableJoinMerger joinMerger() {

[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools

[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713911#comment-17713911 ] Sagar Rao commented on KAFKA-14586: --- [~mjsax] , I can add the redirection for this. I have read

<    1   2