[GitHub] [kafka] DengShuaiSimon opened a new pull request, #13730: Feature/shuai add comment

2023-05-17 Thread via GitHub
DengShuaiSimon opened a new pull request, #13730: URL: https://github.com/apache/kafka/pull/13730 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] vamossagar12 commented on pull request #13726: KAFKA-13109: SourceTask#poll not enforcing retries in case of RetriableException

2023-05-17 Thread via GitHub
vamossagar12 commented on PR #13726: URL: https://github.com/apache/kafka/pull/13726#issuecomment-1552416862 Test failures seem unrelated. Couple of failing connect related tests are being fixed via separate JIRA tickets -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] aaron-ai commented on pull request #13710: MINOR: Fix the outdated comments of ConfigDef

2023-05-17 Thread via GitHub
aaron-ai commented on PR #13710: URL: https://github.com/apache/kafka/pull/13710#issuecomment-1552382217 @jlprat @showuon @C0urante @dajac Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (KAFKA-14833) ZK migration cannot start if a ZK controller was not previously elected

2023-05-17 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-14833: --- Assignee: HaiyuanZhao > ZK migration cannot start if a ZK controller was not previously

[jira] [Assigned] (KAFKA-14846) Fix overly large record batches in ZkMigrationClient

2023-05-17 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-14846: --- Assignee: HaiyuanZhao > Fix overly large record batches in ZkMigrationClient >

[jira] [Assigned] (KAFKA-14939) Only expose ZkMigrationState metric if metadata.version supports it

2023-05-17 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-14939: --- Assignee: HaiyuanZhao > Only expose ZkMigrationState metric if metadata.version supports

[GitHub] [kafka] satishd merged pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-17 Thread via GitHub
satishd merged PR #13535: URL: https://github.com/apache/kafka/pull/13535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] AmareshB commented on a diff in pull request #6247: KAFKA-7466: Add IncrementalAlterConfigs API (KIP-339)

2023-05-17 Thread via GitHub
AmareshB commented on code in PR #6247: URL: https://github.com/apache/kafka/pull/6247#discussion_r1197203647 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java: ## @@ -388,6 +388,48 @@ public AlterConfigsResult alterConfigs(Map configs) { */

[GitHub] [kafka] AmareshB commented on a diff in pull request #6247: KAFKA-7466: Add IncrementalAlterConfigs API (KIP-339)

2023-05-17 Thread via GitHub
AmareshB commented on code in PR #6247: URL: https://github.com/apache/kafka/pull/6247#discussion_r1197203647 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java: ## @@ -388,6 +388,48 @@ public AlterConfigsResult alterConfigs(Map configs) { */

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

2023-05-17 Thread via GitHub
artemlivshits commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1197145142 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -41,18 +42,35 @@ public class ProducerStateEntry { private

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-17 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1552142480 > [ea81e99](https://github.com/apache/kafka/commit/ea81e99e5980c807414651034a8c60426a158ca4) added TransitionToUninitialized. Can we confirm this has the behavior we expect? I believe

[jira] [Updated] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

2023-05-17 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-14970: -- Fix Version/s: 3.5.0 > Dual write mode testing for SCRAM and Quota >

[GitHub] [kafka] pprovenzano opened a new pull request, #13729: KAFKA-14970: Dual write mode testing for SCRAM and Quota

2023-05-17 Thread via GitHub
pprovenzano opened a new pull request, #13729: URL: https://github.com/apache/kafka/pull/13729 Add two tests for dual write mode for ZK to KRaft migration. These test updating SCRAM records while in dual write mode and validate that the records are written to ZK. Fixed a bug

[GitHub] [kafka] JimGalasyn commented on pull request #13728: Add default configs for internal topics

2023-05-17 Thread via GitHub
JimGalasyn commented on PR #13728: URL: https://github.com/apache/kafka/pull/13728#issuecomment-1551916913 cc @mjsax ![image](https://github.com/apache/kafka/assets/12521043/c20f1d07-eb2d-43f5-bf7e-8bbc20dfbbc6) -- This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-15006) kafka-get-offsets.sh returns 0 for earliest offset on a compacted topic

2023-05-17 Thread Christopher Auston (Jira)
Christopher Auston created KAFKA-15006: -- Summary: kafka-get-offsets.sh returns 0 for earliest offset on a compacted topic Key: KAFKA-15006 URL: https://issues.apache.org/jira/browse/KAFKA-15006

[GitHub] [kafka] satishd commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-17 Thread via GitHub
satishd commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1551837017 Thanks @junrao for the latest comments, addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] philipnee commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-17 Thread via GitHub
philipnee commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1551778364 @erikvanoosten - Thanks for following up on this PR, I think we are really closed here. Also apologize about the misleading comment. I left a few comments above. -- This is an

[GitHub] [kafka] cmccabe commented on pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

2023-05-17 Thread via GitHub
cmccabe commented on PR #13727: URL: https://github.com/apache/kafka/pull/13727#issuecomment-1551766740 merged, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] cmccabe closed pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

2023-05-17 Thread via GitHub
cmccabe closed pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot URL: https://github.com/apache/kafka/pull/13727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-17 Thread via GitHub
philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1196816858 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -668,6 +695,7 @@ public void onFailure(RuntimeException e,

[jira] [Updated] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-17 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15005: Description: Our MM2 is running version 2.5.1. After a rebalance of our MM2 source tasks, we found there

[jira] [Updated] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-17 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15005: Description: Our MM2 is running version 2.5.1. After a rebalance of our MM2 source tasks, we found there

[jira] [Updated] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-17 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15005: Description: After a rebalance of our MM2 source tasks, we found there were several tasks always in

[jira] [Updated] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-17 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15005: Description: After a rebalance of our MM2 source tasks, we found there were several tasks always in

[jira] [Created] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-17 Thread Yu Wang (Jira)
Yu Wang created KAFKA-15005: --- Summary: Status of KafkaConnect task not correct Key: KAFKA-15005 URL: https://issues.apache.org/jira/browse/KAFKA-15005 Project: Kafka Issue Type: Bug

[GitHub] [kafka] splett2 opened a new pull request, #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

2023-05-17 Thread via GitHub
splett2 opened a new pull request, #13727: URL: https://github.com/apache/kafka/pull/13727 This PR tries to make it explicit that `handleSnapshot` is handling the loading of a snapshot. To someone who is not familiar with the code or KRaft's design, `handleSnapshot` may sound like the

[GitHub] [kafka] junrao commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-17 Thread via GitHub
junrao commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1196786120 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1175,49 +1260,78 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus +=

[jira] [Created] (KAFKA-15004) Topic config changes are not synced during zk to kraft migration (dual-write)

2023-05-17 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-15004: - Summary: Topic config changes are not synced during zk to kraft migration (dual-write) Key: KAFKA-15004 URL: https://issues.apache.org/jira/browse/KAFKA-15004

[jira] [Created] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

2023-05-17 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-15003: - Summary: TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic Key: KAFKA-15003 URL:

[jira] [Created] (KAFKA-15002) Moderate vulnerability in org.bitbucket.b_c_jose4j

2023-05-17 Thread Arushi Rai (Jira)
Arushi Rai created KAFKA-15002: -- Summary: Moderate vulnerability in org.bitbucket.b_c_jose4j Key: KAFKA-15002 URL: https://issues.apache.org/jira/browse/KAFKA-15002 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-15001) Medium vulnerabilities in Jetty

2023-05-17 Thread Arushi Rai (Jira)
Arushi Rai created KAFKA-15001: -- Summary: Medium vulnerabilities in Jetty Key: KAFKA-15001 URL: https://issues.apache.org/jira/browse/KAFKA-15001 Project: Kafka Issue Type: Task Affects

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-05-17 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723502#comment-17723502 ] Manyanda Chitimbo commented on KAFKA-15000: --- Hi [~arushir] I've no idea but let me tag along

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-05-17 Thread Arushi Rai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723489#comment-17723489 ] Arushi Rai commented on KAFKA-15000: Hi [~manyanda]  Thank you for the response.  I do not see

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-05-17 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723486#comment-17723486 ] Manyanda Chitimbo commented on KAFKA-15000: --- The PR

[jira] [Created] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-05-17 Thread Arushi Rai (Jira)
Arushi Rai created KAFKA-15000: -- Summary: High vulnerability PRISMA-2023-0067 reported in jackson-core Key: KAFKA-15000 URL: https://issues.apache.org/jira/browse/KAFKA-15000 Project: Kafka

[GitHub] [kafka] dengziming commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-05-17 Thread via GitHub
dengziming commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1196474288 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] satishd merged pull request #13718: MINOR: move ControlRecordTest to correct directory

2023-05-17 Thread via GitHub
satishd merged PR #13718: URL: https://github.com/apache/kafka/pull/13718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Reopened] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-17 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reopened KAFKA-12384: > Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch >

[jira] [Commented] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-17 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723454#comment-17723454 ] Satish Duggana commented on KAFKA-12384: Reopening as these tests are still flaky and failing in

[GitHub] [kafka] hudeqi commented on pull request #13696: KAFKA-14979:Incorrect lag was calculated when markPartitionsForTruncation in ReplicaAlterLogDirsThread

2023-05-17 Thread via GitHub
hudeqi commented on PR #13696: URL: https://github.com/apache/kafka/pull/13696#issuecomment-1551312847 hi, do you have time to review this issue? @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] vamossagar12 opened a new pull request, #13726: KAFKA-13109: SourceTask#poll not enforcing retries in case of RetriableException

2023-05-17 Thread via GitHub
vamossagar12 opened a new pull request, #13726: URL: https://github.com/apache/kafka/pull/13726 AbstractWorkerSourceTask is not enforcing the errors.retry.timeout and errors.retry.delay.max.ms parameters in case of a RetriableException during task.poll(). [KIP-298

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-17 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1551304423 Hi, do you have time to help review this? @dajac @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-14999) Kafka Clients not able to publish message when one of broker is shut downed

2023-05-17 Thread Sheriff (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sheriff updated KAFKA-14999: Description: Three  kafka brokers system (three VMs and each VM contains one kafka broker). One of the

[GitHub] [kafka] satishd commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-17 Thread via GitHub
satishd commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1551099626 Thanks @junrao for the updated review. Addressed your latest minor review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-14999) Kafka Clients not able to publish message when one of broker is shut downed

2023-05-17 Thread Sheriff (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sheriff updated KAFKA-14999: Description: Three  kafka brokers system (three VMs and each VM contains one kafka broker). One of the

[jira] [Created] (KAFKA-14999) Kafka Clients not able to publish message when one of broker is shut downed

2023-05-17 Thread Sheriff (Jira)
Sheriff created KAFKA-14999: --- Summary: Kafka Clients not able to publish message when one of broker is shut downed Key: KAFKA-14999 URL: https://issues.apache.org/jira/browse/KAFKA-14999 Project: Kafka

[GitHub] [kafka] jlprat commented on a diff in pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration

2023-05-17 Thread via GitHub
jlprat commented on code in PR #13723: URL: https://github.com/apache/kafka/pull/13723#discussion_r1196222089 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java: ## @@ -43,7 +43,8 @@ protected TestMirrorConnectorConfig(Map props) {

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-17 Thread via GitHub
erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1196205881 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-17 Thread via GitHub
erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1196205881 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void

[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-17 Thread via GitHub
hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1196003399 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val