[GitHub] [kafka] mjsax commented on a diff in pull request #13914: KAFKA-14972: Support async runtimes in consumer

mjsax commented on code in PR #13914: URL: https://github.com/apache/kafka/pull/13914#discussion_r1249992063 ## clients/src/main/java/org/apache/kafka/clients/consumer/ThreadAccessKey.java: ## @@ -0,0 +1,8 @@ +package org.apache.kafka.clients.consumer; Review Comment:

[jira] [Resolved] (KAFKA-15135) RLM listener configurations passed but ignored by RLMM

[ https://issues.apache.org/jira/browse/KAFKA-15135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15135. --- Fix Version/s: 3.6.0 Resolution: Fixed > RLM listener configurations passed but ignored by

[GitHub] [kafka] showuon merged pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM

showuon merged PR #13938: URL: https://github.com/apache/kafka/pull/13938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM

showuon commented on PR #13938: URL: https://github.com/apache/kafka/pull/13938#issuecomment-1617082170 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 /

[jira] [Resolved] (KAFKA-8982) Admin.deleteRecords should retry when failing to fetch metadata

[ https://issues.apache.org/jira/browse/KAFKA-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-8982. -- Fix Version/s: 3.6.0 Resolution: Fixed > Admin.deleteRecords should retry when failing to fetch

[GitHub] [kafka] showuon merged pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

showuon merged PR #13760: URL: https://github.com/apache/kafka/pull/13760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

showuon commented on PR #13760: URL: https://github.com/apache/kafka/pull/13760#issuecomment-1617075103 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] hgeraldino opened a new pull request, #13951: KAFKA-14684 Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskThreadedTest

hgeraldino opened a new pull request, #13951: URL: https://github.com/apache/kafka/pull/13951 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] LinShunKang commented on pull request #12685: KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying

LinShunKang commented on PR #12685: URL: https://github.com/apache/kafka/pull/12685#issuecomment-1616603443 > > Add @deprecated annotation for Utils#murmur2(byte[]) > > We should anyways start using murmur3 starting Kafka 4.x. Also perhaps the endia-ness neutral version of it

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12685: KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying

LinShunKang commented on code in PR #12685: URL: https://github.com/apache/kafka/pull/12685#discussion_r1249416755 ## clients/src/main/java/org/apache/kafka/common/serialization/ByteBufferSerializer.java: ## @@ -50,4 +51,29 @@ public byte[] serialize(String topic, ByteBuffer

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12685: KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying

LinShunKang commented on code in PR #12685: URL: https://github.com/apache/kafka/pull/12685#discussion_r1249416231 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -517,6 +519,50 @@ public static int murmur2(final byte[] data) { return h; }

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1249388374 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] DL1231 opened a new pull request, #13950: KAFKA-15140: Improve TopicCommandIntegrationTest to be less flaky

DL1231 opened a new pull request, #13950: URL: https://github.com/apache/kafka/pull/13950 https://issues.apache.org/jira/browse/KAFKA-15140 Tests in TopicCommandIntegrationTest get flaky from time to time. The objective of the task is to make them more robust. ### Committer

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12685: KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying

LinShunKang commented on code in PR #12685: URL: https://github.com/apache/kafka/pull/12685#discussion_r1249312027 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java: ## @@ -321,13 +322,20 @@ public int partition() { } }