[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255324708 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -409,6 +411,43 @@ private String getBrokerSideConfigValue(final

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255322606 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java: ## @@ -279,6 +279,28 @@ public CreateTopicsResult createTopics(fin

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255320753 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -0,0 +1,264 @@ +package org.apache.kafka.streams

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255321572 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -0,0 +1,264 @@ +package org.apache.kafka.streams

[jira] [Commented] (KAFKA-15158) Add metrics for RemoteRequestsPerSec

[ https://issues.apache.org/jira/browse/KAFKA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740890#comment-17740890 ] Jorge Esteban Quilcate Otoya commented on KAFKA-15158: -- Thanks [~di

[jira] [Commented] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740888#comment-17740888 ] Vikash Mishra commented on KAFKA-15160: --- As confirmed in sprint community that it

[jira] [Created] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

Vikash Mishra created KAFKA-15160: - Summary: Message bytes duplication in Kafka headers when compression is enabled Key: KAFKA-15160 URL: https://issues.apache.org/jira/browse/KAFKA-15160 Project: Kaf

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

vamossagar12 commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1255253840 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void testTopicCreateSucceedsWh

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

vamossagar12 commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1255252249 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void testTopicCreateSucceedsWh

[GitHub] [kafka] vamossagar12 commented on pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1624726819 `MirrorConnectorsIntegrationBaseTest#testOffsetTranslationBehindReplicationFlow` is the only test which is relevant wrt the changes in this PR. I ran it locally a couple of times an

[jira] [Commented] (KAFKA-14207) Add a 6.10 section for KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740864#comment-17740864 ] Luke Chen commented on KAFKA-14207: --- Thanks for the info, [~gharris1727] ! > Add a 6.

[GitHub] [kafka] showuon commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

showuon commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255129114 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -16,6 +16,9 @@ */ package org.apache.kafka.storage.internals.log; +imp

[GitHub] [kafka] showuon commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

showuon commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255120355 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,581 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jeffkbkim commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1255022451 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean canTransitionFrom(CoordinatorS

[GitHub] [kafka] ijuma commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

ijuma commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255034976 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -16,6 +16,9 @@ */ package org.apache.kafka.storage.internals.log; +impor

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1255017069 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -893,4 +1041,250 @@ public void testOnNewMetadataImage(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1254999681 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1087,1348 @@ public void replay( consumerG

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254998634 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254998634 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254995855 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorTimer.java: ## @@ -16,12 +16,26 @@ */ package org.apache.kafka.coordinator.g

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254976555 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254986327 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254986327 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Updated] (KAFKA-14426) Add documentation for Kraft limtations that have open KIPs

[ https://issues.apache.org/jira/browse/KAFKA-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14426: Description: Currently there are a number of limitations for Kraft, which are described as the mo

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254981176 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Commented] (KAFKA-14207) Add a 6.10 section for KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740818#comment-17740818 ] Greg Harris commented on KAFKA-14207: - [~showuon] The only accompanying information

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254976555 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Updated] (KAFKA-14426) Add documentation for Kraft limtations that have open KIPs

[ https://issues.apache.org/jira/browse/KAFKA-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14426: Description: Currently there are a number of limitations for Kraft, which are described as the mo

[GitHub] [kafka] junrao commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

junrao commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1254942551 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -16,6 +16,9 @@ */ package org.apache.kafka.storage.internals.log; +impo

[GitHub] [kafka] gaurav-narula commented on a diff in pull request #13949: KAFKA-15141: init logger statically on hot codepaths

gaurav-narula commented on code in PR #13949: URL: https://github.com/apache/kafka/pull/13949#discussion_r1254921844 ## core/src/main/scala/kafka/server/DelayedProduce.scala: ## @@ -58,6 +62,8 @@ class DelayedProduce(delayMs: Long, lockOpt: Option[Lock] = N

[jira] [Comment Edited] (KAFKA-15144) MM2 Checkpoint downstreamOffset stuck to 1

[ https://issues.apache.org/jira/browse/KAFKA-15144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740748#comment-17740748 ] Edoardo Comar edited comment on KAFKA-15144 at 7/6/23 8:56 PM: ---

[jira] [Comment Edited] (KAFKA-15148) Some integration tests are running as unit tests

[ https://issues.apache.org/jira/browse/KAFKA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740696#comment-17740696 ] Ezio Xie edited comment on KAFKA-15148 at 7/6/23 8:05 PM: -- I fi

[GitHub] [kafka] eziosudo opened a new pull request, #13973: exclude integration tests in "./gradlew unitTest" by adding @Tag("integration") and @Category(IntegrationTest.class)

eziosudo opened a new pull request, #13973: URL: https://github.com/apache/kafka/pull/13973 Change these tests by adding @Tag("integration") and @Category(IntegrationTest.class). ` ./streams/build/reports/tests/unitTest/classes/org.apache.kafka.streams.integration.MetricsReporterInteg

[jira] [Comment Edited] (KAFKA-15148) Some integration tests are running as unit tests

[ https://issues.apache.org/jira/browse/KAFKA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740696#comment-17740696 ] Ezio Xie edited comment on KAFKA-15148 at 7/6/23 7:56 PM: -- I fi

[GitHub] [kafka] aneelkkhatri opened a new pull request, #13972: Fix one typo in javadoc

aneelkkhatri opened a new pull request, #13972: URL: https://github.com/apache/kafka/pull/13972 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] joobisb commented on pull request #13862: KAFKA-15050: format the prompts in the quickstart

joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-1624188820 @tombentley could you please have a look, have addressed the comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254819460 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[GitHub] [kafka] philipnee commented on pull request #13914: KAFKA-14972: Support async runtimes in consumer

philipnee commented on PR #13914: URL: https://github.com/apache/kafka/pull/13914#issuecomment-1624179241 @erikvanoosten - I'll try to help you out on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254807923 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740751#comment-17740751 ] ASF GitHub Bot commented on KAFKA-14995: stevenbooke commented on PR #521: URL:

[jira] [Commented] (KAFKA-15144) MM2 Checkpoint downstreamOffset stuck to 1

[ https://issues.apache.org/jira/browse/KAFKA-15144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740748#comment-17740748 ] Edoardo Comar commented on KAFKA-15144: --- I'll rather rewrite our test expecting th

[GitHub] [kafka] erikvanoosten commented on pull request #13914: KAFKA-14972: Support async runtimes in consumer

erikvanoosten commented on PR #13914: URL: https://github.com/apache/kafka/pull/13914#issuecomment-1624147284 > Have you gotten much feedback from the discussion thread yet? Not a single comment. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254792945 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254790531 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254782962 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254778449 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254741731 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254740479 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Resolved] (KAFKA-15069) Refactor scanning hierarchy out of DelegatingClassLoader

[ https://issues.apache.org/jira/browse/KAFKA-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15069. - Reviewer: Chris Egerton Resolution: Fixed > Refactor scanning hierarchy out of DelegatingC

[GitHub] [kafka] satishd commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1254737901 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,581 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740736#comment-17740736 ] ASF GitHub Bot commented on KAFKA-14995: stevenbooke commented on PR #521: URL:

[jira] [Updated] (KAFKA-15069) Refactor scanning hierarchy out of DelegatingClassLoader

[ https://issues.apache.org/jira/browse/KAFKA-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15069: Fix Version/s: 3.6.0 > Refactor scanning hierarchy out of DelegatingClassLoader >

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254735232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[GitHub] [kafka] gharris1727 opened a new pull request, #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

gharris1727 opened a new pull request, #13971: URL: https://github.com/apache/kafka/pull/13971 Add the ServiceLoaderScanner, a companion to the ReflectionScanner which does not use reflection to discover plugins. This will be utilized later in the Plugins class for the configurable-d

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254733078 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorState

[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1624048937 Committed the suggestions, thanks again for reviewing @C0urante! BTW, I also opened https://github.com/apache/kafka/pull/13951 to have `WorkerSinkTaskThreadedTest` migrated. Ther

[jira] [Commented] (KAFKA-15144) MM2 Checkpoint downstreamOffset stuck to 1

[ https://issues.apache.org/jira/browse/KAFKA-15144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740732#comment-17740732 ] Greg Harris commented on KAFKA-15144: - Yes [~ecomar] I think the documentation about

[GitHub] [kafka] C0urante merged pull request #13821: KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner

C0urante merged PR #13821: URL: https://github.com/apache/kafka/pull/13821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254713760 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254711785 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Commented] (KAFKA-15155) Follow PEP 8 best practice in Python to check if a container is empty

[ https://issues.apache.org/jira/browse/KAFKA-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740713#comment-17740713 ] Yi-Sheng Lien commented on KAFKA-15155: --- Hi [~divijvaidya] , I'm interested in th

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254698316 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1254697080 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,118 @@ boolean canTransitionFrom(CoordinatorSta

[jira] [Commented] (KAFKA-15148) Some integration tests are running as unit tests

[ https://issues.apache.org/jira/browse/KAFKA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740696#comment-17740696 ] Ezio Xie commented on KAFKA-15148: -- I filtered integration tests by (find . -name "*.*i

[GitHub] [kafka] C0urante commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

C0urante commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1254675710 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -739,62 +693,42 @@ public void testSlowTaskStart() throws Exception

[GitHub] [kafka] C0urante commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

C0urante commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1254656021 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void testTopicCreateSucceedsWhenCr

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740686#comment-17740686 ] ASF GitHub Bot commented on KAFKA-14995: mimaison commented on PR #521: URL: htt

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740683#comment-17740683 ] ASF GitHub Bot commented on KAFKA-14995: stevenbooke commented on PR #521: URL:

[GitHub] [kafka] hudeqi commented on a diff in pull request #13959: KAFKA-15129;[5/N] Remove metrics in ControllerChannelManager when broker shutdown

hudeqi commented on code in PR #13959: URL: https://github.com/apache/kafka/pull/13959#discussion_r1254636348 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -537,6 +537,7 @@ class KafkaController(val config: KafkaConfig, private def removeMetrics(): Un

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1623905234 @kirktrue thanks for taking over this. @junrao - would you be up for another round of review? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1623903798 Also we need to update the `LICENSE-binary` file as mentioned in https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L73-L74 -- This is an automated message from the

[GitHub] [kafka] philipnee commented on pull request #13914: KAFKA-14972: Support async runtimes in consumer

philipnee commented on PR #13914: URL: https://github.com/apache/kafka/pull/13914#issuecomment-1623900690 Hey from the first look, I think I think this is a reasonable suggestion. Have you gotten much feedback from the discussion thread yet? -- This is an automated message from the Apach

[GitHub] [kafka] hudeqi commented on a diff in pull request #13960: KAFKA-15129;[6/N] Remove metrics in ControllerStats when broker shutdown

hudeqi commented on code in PR #13960: URL: https://github.com/apache/kafka/pull/13960#discussion_r1254619269 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -537,6 +538,7 @@ class KafkaController(val config: KafkaConfig, private def removeMetrics(): Un

[jira] [Updated] (KAFKA-15159) Update minor dependencies in preparation for 3.5.1

[ https://issues.apache.org/jira/browse/KAFKA-15159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15159: - Fix Version/s: 3.5.1 > Update minor dependencies in preparation for 3.5.1 >

[jira] [Updated] (KAFKA-15159) Update minor dependencies in preparation for 3.5.1

[ https://issues.apache.org/jira/browse/KAFKA-15159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15159: - Description: Go through the list of dependencies in dependencies.gradle. Check if newer minor v

[jira] [Created] (KAFKA-15159) Update minor dependencies in preparation for 3.5.1

Divij Vaidya created KAFKA-15159: Summary: Update minor dependencies in preparation for 3.5.1 Key: KAFKA-15159 URL: https://issues.apache.org/jira/browse/KAFKA-15159 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740663#comment-17740663 ] Chris Egerton commented on KAFKA-15102: --- 💯 [~omnia_h_ibrahim] I've assigned you th

[jira] [Assigned] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-15102: - Assignee: Omnia Ibrahim > Mirror Maker 2 - KIP690 backward compatibility >

[jira] [Assigned] (KAFKA-15157) Print startup time for RemoteIndexCache

[ https://issues.apache.org/jira/browse/KAFKA-15157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-15157: Assignee: Lan Ding > Print startup time for RemoteIndexCache > --

[GitHub] [kafka] DL1231 opened a new pull request, #13970: KAFKA-15157: Print startup time for RemoteIndexCache

DL1231 opened a new pull request, #13970: URL: https://github.com/apache/kafka/pull/13970 https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-15157 Print startup time for RemoteIndexCache. ### Committer Checklist (excluded from commit message) - [ ] Verify design and imple

[GitHub] [kafka] hudeqi commented on a diff in pull request #13929: KAFKA-15129;[3/N] Remove metrics in AbstractFetcherManager when fetcher manager instance shutdown

hudeqi commented on code in PR #13929: URL: https://github.com/apache/kafka/pull/13929#discussion_r1254581656 ## core/src/main/scala/kafka/server/AbstractFetcherManager.scala: ## @@ -226,6 +240,29 @@ abstract class AbstractFetcherManager[T <: AbstractFetcherThread](val name: St

[jira] [Updated] (KAFKA-15153) Use Python `is` instead of `==` to compare for None

[ https://issues.apache.org/jira/browse/KAFKA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15153: - Fix Version/s: 3.6.0 > Use Python `is` instead of `==` to compare for None > --

[jira] [Resolved] (KAFKA-15153) Use Python `is` instead of `==` to compare for None

[ https://issues.apache.org/jira/browse/KAFKA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15153. -- Reviewer: Divij Vaidya Resolution: Fixed > Use Python `is` instead of `==` to compare f

[GitHub] [kafka] divijvaidya merged pull request #13964: KAFKA-15153: Use Python 'is' instead of '==' to compare for None

divijvaidya merged PR #13964: URL: https://github.com/apache/kafka/pull/13964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Commented] (KAFKA-12969) Add cluster or broker level config for topic level tiered storage confgs.

[ https://issues.apache.org/jira/browse/KAFKA-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740642#comment-17740642 ] Divij Vaidya commented on KAFKA-12969: -- Please ensure that we also add validations

[GitHub] [kafka] vamossagar12 commented on pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1623807270 Thanks @yashmayya . I addressed the rest of the comments that you had. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Updated] (KAFKA-15158) Add metrics for RemoteRequestsPerSec

[ https://issues.apache.org/jira/browse/KAFKA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15158: - Description: Add the following metrics for better observability into the RemoteLog related acti

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1254544674 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -16,23 +16,36 @@ */ package org.apache.kafka.connect.stora

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1254543662 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -192,6 +209,236 @@ public void testCancelAfterAwaitFlush() th

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1254543055 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -192,6 +209,236 @@ public void testCancelAfterAwaitFlush() th

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1254542495 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[jira] [Updated] (KAFKA-15149) Fix not sending UMR and LISR RPCs in dual-write mode when there are new partitions

[ https://issues.apache.org/jira/browse/KAFKA-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-15149: - Fix Version/s: 3.5.1 > Fix not sending UMR and LISR RPCs in dual-write mode when there are new

[jira] [Created] (KAFKA-15158) Add metrics for RemoteRequestsPerSec

Divij Vaidya created KAFKA-15158: Summary: Add metrics for RemoteRequestsPerSec Key: KAFKA-15158 URL: https://issues.apache.org/jira/browse/KAFKA-15158 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-14509) Add ConsumerGroupDescribe API

[ https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14509: Description: The goal of this task is to implement the ConsumerGroupDescribe API as described [h

[GitHub] [kafka] hudeqi commented on pull request #13958: MINOR:Fix modification exception introduced in KAFKA-15129;[1/N]

hudeqi commented on PR #13958: URL: https://github.com/apache/kafka/pull/13958#issuecomment-1623755996 > Could we please update the description/title to clearly state that this is fixing a regression introduced in [#13924 (comment)](https://github.com/apache/kafka/pull/13924#discussion_r125

[GitHub] [kafka] hudeqi commented on a diff in pull request #13958: MINOR:Refactor variable name for code specification

hudeqi commented on code in PR #13958: URL: https://github.com/apache/kafka/pull/13958#discussion_r1254494044 ## core/src/main/scala/kafka/log/LogCleanerManager.scala: ## @@ -549,7 +550,7 @@ private[log] class LogCleanerManager(val logDirs: Seq[File], def removeMetrics(): U

[jira] [Created] (KAFKA-15157) Print startup time for RemoteIndexCache

Divij Vaidya created KAFKA-15157: Summary: Print startup time for RemoteIndexCache Key: KAFKA-15157 URL: https://issues.apache.org/jira/browse/KAFKA-15157 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-14509) Add ConsumerGroupDescribe API

[ https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14509: Description: The goal of this task is to implement the > Add ConsumerGroupDescribe API >

[jira] [Assigned] (KAFKA-15154) Potential bug: We don't acquire lock when reading checkQuotas

[ https://issues.apache.org/jira/browse/KAFKA-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-15154: Assignee: Lan Ding > Potential bug: We don't acquire lock when reading checkQuotas >

[GitHub] [kafka] DL1231 opened a new pull request, #13969: KAFKA-15154: Acquire lock when reading checkQuotas

DL1231 opened a new pull request, #13969: URL: https://github.com/apache/kafka/pull/13969 https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-15154 Acquire lock when reading checkQuotas. ### Committer Checklist (excluded from commit message) - [ ] Verify design and impleme

  1   2   >