[jira] [Assigned] (KAFKA-15159) Update minor dependencies in preparation for 3.5.1

2023-07-08 Thread Ezio Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ezio Xie reassigned KAFKA-15159: Assignee: Ezio Xie > Update minor dependencies in preparation for 3.5.1 >

[GitHub] [kafka] DL1231 commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-08 Thread via GitHub
DL1231 commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1257413847 ## clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java: ## @@ -250,7 +250,16 @@ public void checkQuotas() { checkQuotas(time.milliseconds());

[GitHub] [kafka] DL1231 commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-08 Thread via GitHub
DL1231 commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1257413803 ## clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java: ## @@ -366,4 +368,60 @@ public void testUpdatingMetricConfigIsReflectedInTheSensor() {

[GitHub] [kafka] eziosudo commented on a diff in pull request #13973: KAFKA-15148: Some integration tests are running as unit tests

2023-07-08 Thread via GitHub
eziosudo commented on code in PR #13973: URL: https://github.com/apache/kafka/pull/13973#discussion_r1257387868 ## streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java: ## @@ -68,6 +69,7 @@ @Timeout(600) @Category({IntegrationTest.class})

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257340916 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -158,23 +164,34 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257340916 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -158,23 +164,34 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,

[jira] [Updated] (KAFKA-15166) Add deletePartition API to the RemoteStorageManager

2023-07-08 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15166: - Description: Remote Storage Manager exposes {{deleteLogSegmentData}} API to

[jira] [Updated] (KAFKA-15168) Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-08 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15168: - Description: For a partition p0 and a given leader epoch, the remote log

[GitHub] [kafka] abhijeetk88 commented on pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on PR #13944: URL: https://github.com/apache/kafka/pull/13944#issuecomment-1627472927 @showuon adding tests for those gauge metrics requires significant changes. We will need to obtain a handle for the underlying threadpool, submit tasks to the threadpool, make sure

[jira] [Created] (KAFKA-15168) Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-08 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15168: Summary: Handle overlapping remote log segments in RemoteLogMetadata cache Key: KAFKA-15168 URL: https://issues.apache.org/jira/browse/KAFKA-15168

[jira] [Created] (KAFKA-15167) Tiered Storage Test Harness Framework

2023-07-08 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15167: Summary: Tiered Storage Test Harness Framework Key: KAFKA-15167 URL: https://issues.apache.org/jira/browse/KAFKA-15167 Project: Kafka Issue

[jira] [Updated] (KAFKA-15166) Add deletePartition API to the RemoteStorageManager

2023-07-08 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15166: - Parent: KAFKA-7739 Issue Type: Sub-task (was: Task) > Add

[jira] [Assigned] (KAFKA-12969) Add cluster or broker level config for topic level tiered storage confgs.

2023-07-08 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-12969: Assignee: Kamal Chandraprakash (was: Satish Duggana) > Add cluster or

[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager

2023-07-08 Thread via GitHub
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1627469910 @showuon @divijvaidya Addressed your review comments. Please take another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257337628 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -277,6 +277,11 @@ class BrokerTopicMetrics(name: Option[String]) {

[jira] [Created] (KAFKA-15166) Add deletePartition API to the RemoteStorageManager

2023-07-08 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15166: Summary: Add deletePartition API to the RemoteStorageManager Key: KAFKA-15166 URL: https://issues.apache.org/jira/browse/KAFKA-15166 Project: Kafka

[jira] [Created] (KAFKA-15165) Handle Kafka client certificate failures without impacting brokers

2023-07-08 Thread Sandeep (Jira)
Sandeep created KAFKA-15165: --- Summary: Handle Kafka client certificate failures without impacting brokers Key: KAFKA-15165 URL: https://issues.apache.org/jira/browse/KAFKA-15165 Project: Kafka

[GitHub] [kafka] fvaleri commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-07-08 Thread via GitHub
fvaleri commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1627395334 Hi @OmniaGM. > Move TopicFilter out of core. (This is part of https://issues.apache.org/jira/browse/KAFKA-14647 which seems not moving for a while ) I think #13158 is

[GitHub] [kafka] fvaleri commented on pull request #13310: KAFKA-14587: Move AclCommand to tools [WIP]

2023-07-08 Thread via GitHub
fvaleri commented on PR #13310: URL: https://github.com/apache/kafka/pull/13310#issuecomment-1627393355 This is one of the tools that requires multiple PRs, starting from core's dependencies migrations. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-14953) Add metrics for tiered storage

2023-07-08 Thread Abhijeet Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741313#comment-17741313 ] Abhijeet Kumar commented on KAFKA-14953: [~jeqo] Adding the additional metric for

[GitHub] [kafka] fvaleri commented on a diff in pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

2023-07-08 Thread via GitHub
fvaleri commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1257293747 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] fvaleri commented on a diff in pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

2023-07-08 Thread via GitHub
fvaleri commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1257293747 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-14591) Move DeleteRecordsCommand to tools

2023-07-08 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14591: Fix Version/s: 3.6.0 > Move DeleteRecordsCommand to tools >

[GitHub] [kafka] ijuma commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

2023-07-08 Thread via GitHub
ijuma commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1257288831 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +131,103 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[jira] [Commented] (KAFKA-14730) Move AdminOperationException to server-commons

2023-07-08 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741308#comment-17741308 ] Federico Valeri commented on KAFKA-14730: - [~nizhikov] it looks like the PR is closed and

[GitHub] [kafka] kamalcph commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-08 Thread via GitHub
kamalcph commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1257268739 ## clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java: ## @@ -366,4 +368,60 @@ public void testUpdatingMetricConfigIsReflectedInTheSensor() {

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257264600 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java: ## @@ -41,6 +44,19 @@ public String logPrefix() {

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257264233 ## core/src/test/java/kafka/log/remote/RemoteLogReaderTest.java: ## @@ -61,15 +74,20 @@ public void testRemoteLogReaderWithoutError() throws

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257257624 ## core/src/test/java/kafka/log/remote/RemoteLogReaderTest.java: ## @@ -40,18 +42,29 @@ import static org.mockito.Mockito.when; public class

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-08 Thread via GitHub
abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257256097 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -951,6 +970,10 @@ public Thread newThread(Runnable r) { return threadPool;

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13973: KAFKA-15148: Some integration tests are running as unit tests

2023-07-08 Thread via GitHub
divijvaidya commented on code in PR #13973: URL: https://github.com/apache/kafka/pull/13973#discussion_r1257227758 ## streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java: ## @@ -68,6 +69,7 @@ @Timeout(600)

[jira] [Resolved] (KAFKA-15157) Print startup time for RemoteIndexCache

2023-07-08 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15157. -- Resolution: Fixed > Print startup time for RemoteIndexCache >

[jira] [Updated] (KAFKA-15157) Print startup time for RemoteIndexCache

2023-07-08 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15157: - Fix Version/s: 3.6.0 > Print startup time for RemoteIndexCache >

[GitHub] [kafka] divijvaidya merged pull request #13970: KAFKA-15157: Print startup time for RemoteIndexCache

2023-07-08 Thread via GitHub
divijvaidya merged PR #13970: URL: https://github.com/apache/kafka/pull/13970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya merged pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

2023-07-08 Thread via GitHub
divijvaidya merged PR #13936: URL: https://github.com/apache/kafka/pull/13936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

2023-07-08 Thread via GitHub
divijvaidya commented on PR #13936: URL: https://github.com/apache/kafka/pull/13936#issuecomment-1627102695 Unrelated test failures in CI. Merging this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

2023-07-08 Thread via GitHub
divijvaidya commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255762594 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13976: MINOR: Check for thread leak at the end of @AfterEach, not at beginning

2023-07-08 Thread via GitHub
divijvaidya commented on code in PR #13976: URL: https://github.com/apache/kafka/pull/13976#discussion_r1257220370 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -113,10 +113,11 @@ class ReplicaManagerTest { @AfterEach def tearDown(): Unit = {

[GitHub] [kafka] rishiraj88 commented on pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

2023-07-08 Thread via GitHub
rishiraj88 commented on PR #13564: URL: https://github.com/apache/kafka/pull/13564#issuecomment-1626943287 Thanks, @vcrfxia and @mjsax for insights. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hudeqi opened a new pull request, #13979: MINOR:Move TROGDOR.md to trogdor module

2023-07-08 Thread via GitHub
hudeqi opened a new pull request, #13979: URL: https://github.com/apache/kafka/pull/13979 move TROGDOR.md in root dir to trogdor module, and rename to README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-08 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1257110479 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,40 @@ public ExactlyOnceSupport exactlyOnceSupport(Map