[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270547364 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270547163 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +102,25 @@ public static void prettyPrintTable( printRow(columnLength

[jira] [Updated] (KAFKA-15229) Increase default value of task.shutdown.graceful.timeout.ms

[ https://issues.apache.org/jira/browse/KAFKA-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-15229: -- Description: The Kafka Connect config [task.shutdown.graceful.timeout.ms. |https://kafka.apache.org/d

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270544580 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270544839 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Updated] (KAFKA-15229) Increase default value of task.shutdown.graceful.timeout.ms

[ https://issues.apache.org/jira/browse/KAFKA-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-15229: -- Description: The Kafka Connect config [task.shutdown.graceful.timeout.ms. |https://kafka.apache.org/d

[GitHub] [kafka] nizhikov commented on a diff in pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on code in PR #13278: URL: https://github.com/apache/kafka/pull/13278#discussion_r1270532744 ## tools/src/main/java/org/apache/kafka/tools/DeleteRecordsCommand.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Created] (KAFKA-15229) Increase default value of task.shutdown.graceful.timeout.ms

Sagar Rao created KAFKA-15229: - Summary: Increase default value of task.shutdown.graceful.timeout.ms Key: KAFKA-15229 URL: https://issues.apache.org/jira/browse/KAFKA-15229 Project: Kafka Issue

[GitHub] [kafka] mimaison commented on a diff in pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

mimaison commented on code in PR #13278: URL: https://github.com/apache/kafka/pull/13278#discussion_r1270529100 ## tools/src/main/java/org/apache/kafka/tools/DeleteRecordsCommand.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] mimaison commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

mimaison commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1269440979 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +102,25 @@ public static void prettyPrintTable( printRow(columnLengt

[GitHub] [kafka] jeqo commented on pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

jeqo commented on PR #14045: URL: https://github.com/apache/kafka/pull/14045#issuecomment-1645331949 It seems to, force-pushed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270484492 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions": "0+",

[GitHub] [kafka] showuon commented on pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

showuon commented on PR #14049: URL: https://github.com/apache/kafka/pull/14049#issuecomment-1645313546 I'll take a look next week. Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

showuon commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1645291705 Let me think about it and get back to you. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

divijvaidya commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1270455571 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -327,6 +327,17 @@ public void onStopPart

[jira] [Comment Edited] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745507#comment-17745507 ] Said BOUDJELDA edited comment on KAFKA-15217 at 7/21/23 9:24 AM: -

[jira] [Commented] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745507#comment-17745507 ] Said BOUDJELDA commented on KAFKA-15217: [~divijvaidya]  Thank you, I assigned t

[jira] [Assigned] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA reassigned KAFKA-15217: -- Assignee: Said BOUDJELDA > Consider usage of Gradle toolchain to specify Java version

[GitHub] [kafka] vamossagar12 commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

vamossagar12 commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1645282242 hey Luke, sorry to bother you again on this one. I tried just clearing the `remoteReplicasMap` and then trying to do a fetchFollower within the `testUpdateFollowerFetchState` but I s

[jira] [Commented] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745505#comment-17745505 ] Divij Vaidya commented on KAFKA-15217: -- Sure thing. No one else have volunteered fo

[jira] [Reopened] (KAFKA-14581) Move GetOffsetShell to tools

[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reopened KAFKA-14581: - > Move GetOffsetShell to tools > > > Key: KAFKA

[GitHub] [kafka] divijvaidya merged pull request #14061: MINOR: Add jdk 20 to list of jdks that can build scala in README.md file

divijvaidya merged PR #14061: URL: https://github.com/apache/kafka/pull/14061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Resolved] (KAFKA-15222) Upgrade zinc scala incremental compiler plugin version to a latests stable fit version (1.9.2)

[ https://issues.apache.org/jira/browse/KAFKA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15222. -- Fix Version/s: 3.6.0 Resolution: Fixed > Upgrade zinc scala incremental compiler plugin

[GitHub] [kafka] divijvaidya merged pull request #14060: KAFKA-15222: Upgrade zinc Scala incremental compiler plugin version to a latests stable fit version (1.9.2)

divijvaidya merged PR #14060: URL: https://github.com/apache/kafka/pull/14060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1270405127 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] divijvaidya commented on pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

divijvaidya commented on PR #14057: URL: https://github.com/apache/kafka/pull/14057#issuecomment-1645220469 Seems like we have compilation errors: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14057/2/pipeline/9 Please fix them. Tag me here. Once

[GitHub] [kafka] satishd merged pull request #14065: MINOR Fix the build failure.

satishd merged PR #14065: URL: https://github.com/apache/kafka/pull/14065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14065: MINOR Fix the build failure.

satishd commented on PR #14065: URL: https://github.com/apache/kafka/pull/14065#issuecomment-1645204010 A few tests failed in the Jenkins job but they are not related to the changes in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1645092579 > @muralibasani thanks, this is just a first pass. > > Looks like there are still some checkstyle errors to fix and a couple of errors on KafkaClusterTestKit. Can you also avoi

<    1   2