abhijeetk88 opened a new pull request, #14127:
URL: https://github.com/apache/kafka/pull/14127
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
satishd commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1278245511
##
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##
@@ -62,13 +63,17 @@ class LogConfigTest {
kafkaProps.put(KafkaConfig.LogRollTimeJitterHoursProp,
github-actions[bot] commented on PR #12781:
URL: https://github.com/apache/kafka/pull/12781#issuecomment-1656539350
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748778#comment-17748778
]
Chris Egerton edited comment on KAFKA-15252 at 7/29/23 3:12 AM:
I think
[
https://issues.apache.org/jira/browse/KAFKA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748778#comment-17748778
]
Chris Egerton commented on KAFKA-15252:
---
I think this is caused by KAFKA-15090. [~nikita.krasnov]
C0urante commented on PR #14101:
URL: https://github.com/apache/kafka/pull/14101#issuecomment-165657
There's also
[KAFKA-15090](https://issues.apache.org/jira/browse/KAFKA-15090), which gives
some context on why we stopped invoking `SourceTask::stop` on the herder thread
(which is the
ahuang98 commented on PR #14109:
URL: https://github.com/apache/kafka/pull/14109#issuecomment-1656471910
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14109/2/pipeline/12
looks pretty good but I'll retrigger another build
--
This is an automated
junrao commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1278072179
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1488,9 +1500,10 @@ public void run() {
}
[
https://issues.apache.org/jira/browse/KAFKA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-15271:
Assignee: Colin McCabe
> Historicalterator can exposes elements that are too new
>
philipnee commented on PR #14123:
URL: https://github.com/apache/kafka/pull/14123#issuecomment-1656346526
Umm build failures for jdk 8 plus some non-related test failures:
```
Build / JDK 20 and Scala 2.13 / testSyncTopicConfigs() –
philipnee commented on PR #14123:
URL: https://github.com/apache/kafka/pull/14123#issuecomment-1656345210
We don't. Do you know when was is introduced? Is it in your inflight PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jeffkbkim commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1656328786
Thanks, I will take a look next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1656325056
@riedelmax Thanks for the PR. I am on vacations during the next three weeks
so I won’t be able to look at this one. @jeffkbkim Could you help @riedelmax?
As a first step, @riedelmax
mumrah opened a new pull request, #14126:
URL: https://github.com/apache/kafka/pull/14126
This was introduced in #14115. I added this as part of a small tweak after
the last Jenkins job. I ran `./gradlew check -x test` before committing, but
apparently the issue was only present in Scala
[
https://issues.apache.org/jira/browse/KAFKA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-15271:
-
Summary: Historicalterator can exposes elements that are too new (was:
[
https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748724#comment-17748724
]
Max Riedel edited comment on KAFKA-14509 at 7/28/23 7:51 PM:
-
[~dajac]
[
https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748724#comment-17748724
]
Max Riedel edited comment on KAFKA-14509 at 7/28/23 7:50 PM:
-
[~dajac]
[
https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748724#comment-17748724
]
Max Riedel commented on KAFKA-14509:
[~dajac] Thanks for the helpful comments. Please see my PR for
riedelmax opened a new pull request, #14124:
URL: https://github.com/apache/kafka/pull/14124
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
gharris1727 commented on PR #14101:
URL: https://github.com/apache/kafka/pull/14101#issuecomment-1656189960
Hey thanks @akitoshka for giving some attention to this issue.
Unfortunately the fix as-is can't be merged, for the reasons that @yashmayya
and @vamossagar12 raised above.
[
https://issues.apache.org/jira/browse/KAFKA-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-15263.
--
Resolution: Fixed
> KRaftMigrationDriver can run the migration twice
>
gharris1727 merged PR #14091:
URL: https://github.com/apache/kafka/pull/14091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14091:
URL: https://github.com/apache/kafka/pull/14091#issuecomment-1656157411
Flaky test failures appear unrelated, and the JDK8 build succeeded with no
failures!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15263:
-
Affects Version/s: 3.5.1
3.5.0
> KRaftMigrationDriver can run the
jolshan merged PR #14117:
URL: https://github.com/apache/kafka/pull/14117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15263:
-
Fix Version/s: 3.6.0
3.5.2
> KRaftMigrationDriver can run the migration
[
https://issues.apache.org/jira/browse/KAFKA-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14702.
-
Fix Version/s: 3.6.0
Resolution: Fixed
> Extend server side assignor to support rack
dajac commented on PR #14099:
URL: https://github.com/apache/kafka/pull/14099#issuecomment-1656057225
The build for JDK 17 is stuck... The three others look good. I have seen a
few build stuck this week in other PRs so this is clearly not related to
changes made in this one. Moreover, we
philipnee commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1277840446
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -153,12 +153,14 @@ public void
philipnee commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1277835494
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/OffsetFetchApplicationEvent.java:
##
@@ -19,25 +19,33 @@
import
philipnee opened a new pull request, #14123:
URL: https://github.com/apache/kafka/pull/14123
**Summary**
I discovered the committed() API timeout during the integration test. After
investigation, this is because the future was not completed in the
ApplicationEventProcessor. I also
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277811461
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277803779
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277800358
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
mumrah merged PR #14115:
URL: https://github.com/apache/kafka/pull/14115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on PR #14115:
URL: https://github.com/apache/kafka/pull/14115#issuecomment-1656019490
Test failures look unrelated
https://github.com/apache/kafka/assets/55116/a8e1f6db-57ef-4450-b595-a54c164db524;>
--
This is an automated message from the Apache Git Service.
dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277792665
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277792665
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
[
https://issues.apache.org/jira/browse/KAFKA-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748684#comment-17748684
]
jianbin.chen commented on KAFKA-14257:
--
[~cokutan] You'll want to use the same meta.properties,
[
https://issues.apache.org/jira/browse/KAFKA-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jianbin.chen updated KAFKA-15264:
-
Description:
I was preparing to upgrade from 1.1.0 to 3.5.1 kraft mode (new cluster
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
jeffkbkim opened a new pull request, #14122:
URL: https://github.com/apache/kafka/pull/14122
This patch makes the styling consistent inside GroupMetadataManagerTest.java.
Also, it adds `JoinResult` to simplify the JoinGroup API responses in the
tests.
### Committer Checklist
fvaleri commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277749103
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
junrao merged PR #14086:
URL: https://github.com/apache/kafka/pull/14086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on code in PR #14117:
URL: https://github.com/apache/kafka/pull/14117#discussion_r1277712647
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1014,7 +1013,7 @@ public void onHighWatermarkUpdated(
dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277683057
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection
partitions) {
public void
[
https://issues.apache.org/jira/browse/KAFKA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-15271:
Description:
Example:
{code:java}
@Test
public void bug() {
SnapshotRegistry
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655850239
Zoning in on ControllerIntegrationTest#testControllerMoveOnTopicCreation:
```
...
val event = appender.getMessages.find(e => e.getLevel == Level.INFO
&&
David Jacot created KAFKA-15271:
---
Summary: TimelineHashMap.entrySet yield unexpected results with
nested TimelineHashMap
Key: KAFKA-15271
URL: https://issues.apache.org/jira/browse/KAFKA-15271
Project:
[
https://issues.apache.org/jira/browse/KAFKA-15270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15270:
--
Assignee: Lianet Magrans
> Integration tests for AsyncConsumer simple consume case
>
Lianet Magrans created KAFKA-15270:
--
Summary: Integration tests for AsyncConsumer simple consume case
Key: KAFKA-15270
URL: https://issues.apache.org/jira/browse/KAFKA-15270
Project: Kafka
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655821383
At least on a first look it appears something changed/is wrong with the
loggers:
```
[2023-02-22T17:35:34.655Z] Gradle Test Run :core:unitTest > Gradle Test
Executor 136 >
José Armando García Sancio created KAFKA-15269:
--
Summary: Clean up the RaftClient interface
Key: KAFKA-15269
URL: https://issues.apache.org/jira/browse/KAFKA-15269
Project: Kafka
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655753598
At least the below tests have started to continuously fail. I am still
looking as to why:
```
Gradle Test Run :core:test > Gradle Test Executor 3 >
ControllerIntegrationTest >
[
https://issues.apache.org/jira/browse/KAFKA-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-15089:
---
Assignee: (was: David Jacot)
> Consolidate all the group coordinator configs
>
[
https://issues.apache.org/jira/browse/KAFKA-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-15225:
---
Assignee: (was: David Jacot)
> Define constants for record types
>
[
https://issues.apache.org/jira/browse/KAFKA-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-15061:
---
Assignee: (was: David Jacot)
> CoordinatorPartitionWriter should reuse buffer
>
[
https://issues.apache.org/jira/browse/KAFKA-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-15225:
Priority: Minor (was: Major)
> Define constants for record types
>
David Jacot created KAFKA-15268:
---
Summary: Consider replacing Subscription Metadata by a hash
Key: KAFKA-15268
URL: https://issues.apache.org/jira/browse/KAFKA-15268
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748614#comment-17748614
]
David Jacot commented on KAFKA-14509:
-
[~riedelmax] I left a few comments in your comment.
> Add
[
https://issues.apache.org/jira/browse/KAFKA-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748613#comment-17748613
]
David Jacot commented on KAFKA-14509:
-
[~riedelmax] There are no error codes in requests so I am not
[
https://issues.apache.org/jira/browse/KAFKA-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14501.
-
Fix Version/s: 3.6.0
Reviewer: David Jacot
Resolution: Fixed
> Implement
dajac merged PR #14056:
URL: https://github.com/apache/kafka/pull/14056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fvaleri opened a new pull request, #14121:
URL: https://github.com/apache/kafka/pull/14121
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dajac commented on code in PR #14056:
URL: https://github.com/apache/kafka/pull/14056#discussion_r1277524963
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -843,15 +886,19 @@ public JoinGroupResponseData
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-15267:
--
Labels: tiered-storage (was: )
> Cluster-wide disablement of Tiered Storage
>
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-15267:
--
Description:
h2. Summary
KIP-405 defines the configuration
Christo Lolov created KAFKA-15267:
-
Summary: Cluster-wide disablement of Tiered Storage
Key: KAFKA-15267
URL: https://issues.apache.org/jira/browse/KAFKA-15267
Project: Kafka
Issue Type:
dajac commented on code in PR #14117:
URL: https://github.com/apache/kafka/pull/14117#discussion_r1277523528
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorBuilderSupplier.java:
##
@@ -17,14 +17,14 @@
package
jeffkbkim commented on code in PR #14117:
URL: https://github.com/apache/kafka/pull/14117#discussion_r1277519026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorBuilderSupplier.java:
##
@@ -17,14 +17,14 @@
package
[
https://issues.apache.org/jira/browse/KAFKA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15246.
-
Fix Version/s: 3.6.0
Reviewer: Justine Olshan
Resolution: Fixed
>
dajac opened a new pull request, #14120:
URL: https://github.com/apache/kafka/pull/14120
This patch implements the OffsetFetch API in the new group coordinator.
I found out that implementing the `RequireStable` flag is hard (to not say
impossible) in the current model. For the
amangandhi94 opened a new pull request, #14119:
URL: https://github.com/apache/kafka/pull/14119
This change ensures that values stored in "non-primary" synonyms is
respected when altering configs. Currently if "non-primary" synonyms have a
static config set up then it gets deleted from the
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748555#comment-17748555
]
Tomonari Yamashita commented on KAFKA-15259:
Hi [~mjsax],
I think the stacktrace can be
[
https://issues.apache.org/jira/browse/KAFKA-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aman Harish Gandhi updated KAFKA-15266:
---
Summary: Log configs ignore static configs set for non primary synonyms
(was: Log
Aman Harish Gandhi created KAFKA-15266:
--
Summary: Log configs ignore static configs set non primary synonyms
Key: KAFKA-15266
URL: https://issues.apache.org/jira/browse/KAFKA-15266
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14967:
--
Fix Version/s: 3.6.0
Assignee: James Shaw
Resolution: Fixed
>
mimaison merged PR #13671:
URL: https://github.com/apache/kafka/pull/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vamossagar12 commented on PR #14101:
URL: https://github.com/apache/kafka/pull/14101#issuecomment-1655210284
> This is exactly our case: we have long source polling (in our case it's
jdbc source task), each restarting doesn't break previous task (we get Graceful
Shutdown failed), but
dajac commented on PR #14117:
URL: https://github.com/apache/kafka/pull/14117#issuecomment-1655195050
> can you point me to where the log context includes the topic partition
info?
Sure. It is right
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1655170419
thx @ableegoldman
I reduce partitions num and increase consumers num, I think all tests
influenced by this pr should be PASSED now.
--
This is an automated message from the
muralibasani commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1655168025
@fvaleri would like to take a look at this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
88 matches
Mail list logo
