Owen-CH-Leung commented on PR #14136:
URL: https://github.com/apache/kafka/pull/14136#issuecomment-1661525755
Hello @divijvaidya , I'm still in the process of writing the PR and would
like to ask something :
For this ticket, in order to reuse the metadata cache inside broker (which
philipnee commented on PR #14123:
URL: https://github.com/apache/kafka/pull/14123#issuecomment-1661525036
@junrao - Thank you so much for the reviews. The latest commit addressed
your comments. Let me know if you have more.
--
This is an automated message from the Apache Git Service.
To
riedelmax commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1281414899
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1281412776
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -35,8 +39,12 @@ class BaseAsyncConsumerTest extends AbstractConsumerTest {
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750101#comment-17750101
]
Luke Chen edited comment on KAFKA-15267 at 8/2/23 5:22 AM:
---
For option (4),
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750101#comment-17750101
]
Luke Chen commented on KAFKA-15267:
---
For option (4),
It looks like we can want to validate one of the
philipnee commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1281407606
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -150,15 +151,33 @@ public void
satishd commented on PR #14128:
URL: https://github.com/apache/kafka/pull/14128#issuecomment-1661492281
Unrelated test failures in Jenkins jobs, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
riedelmax commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1281390210
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
riedelmax commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1281390210
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
github-actions[bot] commented on PR #13667:
URL: https://github.com/apache/kafka/pull/13667#issuecomment-1661437886
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281346254
##
build.gradle:
##
@@ -1634,6 +1634,8 @@ project(':storage:api') {
dependencies {
implementation project(':clients')
+implementation
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281346254
##
build.gradle:
##
@@ -1634,6 +1634,8 @@ project(':storage:api') {
dependencies {
implementation project(':clients')
+implementation
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281344968
##
core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[ https://issues.apache.org/jira/browse/KAFKA-12829 ]
Junyao Huang deleted comment on KAFKA-12829:
--
was (Author: pegasas):
[~josep.prat]
I am new to kafka contribution,
seeing other threads replies, I am willing to track this issue,
Would
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1281300901
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java:
##
@@ -156,6 +163,38 @@ public boolean
jeffkbkim commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1281259172
##
clients/src/main/java/org/apache/kafka/common/requests/ConsumerGroupDescribeRequest.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation
mjsax merged PR #14097:
URL: https://github.com/apache/kafka/pull/14097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-9597:
-
Component/s: clients
> Flaky Test KafkaProducerTest#testInitTransactionTimeout
>
[
https://issues.apache.org/jira/browse/KAFKA-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13514:
--
Component/s: consumer
> Flaky test StickyAssignorTest
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-2933:
-
Component/s: consumer
> Failure in kafka.api.PlaintextConsumerTest.testMultiConsumerDefaultAssignment
>
[
https://issues.apache.org/jira/browse/KAFKA-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8589:
-
Summary: Flaky test
ResetConsumerGroupOffsetTest#testResetOffsetsExistingTopic (was: Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13514:
--
Summary: Flaky test StickyAssignorTest (was: Flakey test
StickyAssignorTest)
> Flaky test
[
https://issues.apache.org/jira/browse/KAFKA-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-10663:
--
Summary: Flaky test ConsumerBounceTest#testSeekAndCommitWithBrokerFailures
(was: Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-10663:
--
Component/s: clients
unit tests
> Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8529:
-
Summary: Flaky test ConsumerBounceTest#testCloseDuringRebalance (was:
Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8529:
-
Labels: clients consumer flaky-test unit-test (was: flaky-test)
> Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-10663:
--
Labels: clients consumer flaky-test unit-test (was: flaky-test)
> Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13421:
--
Labels: clients consumer flaky-test unit-test (was: flaky-test)
> Fix
>
[
https://issues.apache.org/jira/browse/KAFKA-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8459:
-
Labels: flaky-test (was: )
> Flakey test BaseQuotaTest#testThrottledRequest
>
[
https://issues.apache.org/jira/browse/KAFKA-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8645:
-
Labels: flaky-test (was: )
> Flakey test
[
https://issues.apache.org/jira/browse/KAFKA-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8462:
-
Labels: flaky-test (was: )
> flakey test RestServerTest#testCORSEnabled
>
[
https://issues.apache.org/jira/browse/KAFKA-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8720:
-
Labels: flaky-test (was: )
> Flakey test AdminClientIntegrationTest
>
[
https://issues.apache.org/jira/browse/KAFKA-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-8502:
-
Labels: flaky-test (was: )
> Flakey test
kirktrue commented on PR #13990:
URL: https://github.com/apache/kafka/pull/13990#issuecomment-1661230252
@junrao It doesn't seem that our [test
history](https://ge.apache.org/scans/tests?search.relativeStartTime=P90D=kafka=America/Los_Angeles)
goes back much further than a few weeks, so
lihaosky opened a new pull request, #14139:
URL: https://github.com/apache/kafka/pull/14139
## Description
Use rack aware task assignor in HAAssignor. This is on top of
https://github.com/apache/kafka/pull/14108
## Test
TODO
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eike Thaden updated KAFKA-15273:
Labels: PatchAvailable (was: )
> Log common name of expired client certificate
>
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1661218798
@ijuma
@tombentley
@mimaison I rewrite `ReassignPartitionsCommand` and all tests belong to it.
All tests regarding `ReassignPartitionsCommand.java` pass.
The only link to
junrao commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1281188661
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -106,12 +106,18 @@ private boolean process(final
[
https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15292:
--
Summary: Flaky test
IdentityReplicationIntegrationTest#testReplicateSourceDefault() (was: Test
[
https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15292:
--
Issue Type: Bug (was: Test)
> Test IdentityReplicationIntegrationTest#testReplicateSourceDefault()
[
https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15292:
--
Description:
The test testReplicateSourceDefault in
Kirk True created KAFKA-15292:
-
Summary: Test
IdentityReplicationIntegrationTest#testReplicateSourceDefault() is flaky
Key: KAFKA-15292
URL: https://issues.apache.org/jira/browse/KAFKA-15292
Project:
[
https://issues.apache.org/jira/browse/KAFKA-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15020:
--
Labels: flaky-test (was: )
>
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1661163878
@divijvaidya Are you interested in reviewing this? This is a KIP-less
alternative to solve the flakiness in this test.
--
This is an automated message from the Apache Git Service.
Greg Harris created KAFKA-15291:
---
Summary: Implemented Versioned interfaces in common Connect plugins
Key: KAFKA-15291
URL: https://issues.apache.org/jira/browse/KAFKA-15291
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15197:
--
Labels: flaky-test (was: flaky)
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15197:
--
Labels: flaky (was: )
> Flaky test
>
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1661121133
> Hmmm... getting an NPE when I try to run the command now:
I've fixed that, sorry. I've also added tests that would catch that NPE.
> made a note of any collisions that
junrao commented on PR #13990:
URL: https://github.com/apache/kafka/pull/13990#issuecomment-1661118945
@kirktrue : For consistent infra issues, we could file an infra jira for the
ASF infra team to help. For transient test failures, if we could identify when
the test failure first occurred
see-quick commented on PR #14011:
URL: https://github.com/apache/kafka/pull/14011#issuecomment-1661048470
@ijuma. It also passed with Java 11 and Java 8 :) So I think it is good to
go :) WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
CalvinConfluent opened a new pull request, #14138:
URL: https://github.com/apache/kafka/pull/14138
When the leader becomes the follower, we first remove the ISR and then reset
the leader. If we call isUnderMinIsr in between, we will get an answer with
true which is a race bug.
--
This
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1280981876
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -124,7 +124,7 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
gharris1727 commented on PR #14055:
URL: https://github.com/apache/kafka/pull/14055#issuecomment-1660818460
> LGTM assuming the two small remaining comments (tweaking language in
Plugins::maybeReportHybridDiscoveryIssue and using lowercase values in docs for
plugin.discovery.mode property)
C0urante commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1660814545
Hmmm... getting an NPE when I try to run the command now:
```
Cannot invoke "java.util.Set.removeIf(java.util.function.Predicate)" because
the return value of
C0urante commented on PR #14055:
URL: https://github.com/apache/kafka/pull/14055#issuecomment-1660769007
> I don't think it's possible to make the classpath and plugins behave the
consistently in this case... Do you think this behavior is worth changing?
Absolutely not! Haha, I'm
C0urante commented on code in PR #14055:
URL: https://github.com/apache/kafka/pull/14055#discussion_r1280925188
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##
@@ -63,16 +67,72 @@ public Plugins(Map props) {
// VisibleForTesting
gharris1727 merged PR #14089:
URL: https://github.com/apache/kafka/pull/14089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14089:
URL: https://github.com/apache/kafka/pull/14089#issuecomment-1660748446
CI failures appear unrelated, and the JDK8 tests all passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-15229:
--
Description:
The Kafka Connect config [task.shutdown.graceful.timeout.ms.
[
https://issues.apache.org/jira/browse/KAFKA-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-15229:
--
Description:
The Kafka Connect config [task.shutdown.graceful.timeout.ms.
[
https://issues.apache.org/jira/browse/KAFKA-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-15229:
--
Labels: (was: needs-kip)
> Increase default value of task.shutdown.graceful.timeout.ms
>
kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1280887247
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1280887247
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
divijvaidya commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1280547981
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -124,7 +124,7 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest
[
https://issues.apache.org/jira/browse/KAFKA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-15290:
-
Parent: KAFKA-7739
Issue Type: Sub-task (was: Task)
> Add support to
Kamal Chandraprakash created KAFKA-15290:
Summary: Add support to onboard existing topics to tiered storage
Key: KAFKA-15290
URL: https://issues.apache.org/jira/browse/KAFKA-15290
Project:
AndrewJSchofield commented on PR #14111:
URL: https://github.com/apache/kafka/pull/14111#issuecomment-1660648111
>
Yes, I agree that it needs more work for the cases that you mentioned. I'm
looking at the Sender/RecordAccumulator next.
--
This is an automated message from the
philipnee commented on PR #14123:
URL: https://github.com/apache/kafka/pull/14123#issuecomment-1660477317
latest test failures are unrelated
```
New failing - 10
Build / JDK 17 and Scala 2.13 /
testBumpTransactionalEpoch(String).quorum=kraft – kafka.api.TransactionsTest
1m 17s
Cerchie opened a new pull request, #14137:
URL: https://github.com/apache/kafka/pull/14137
Change in response to
[KIP-941](https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Range+queries+to+accept+null+lower+and+upper+bounds).
New PR due to merge issue.
Changes
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280742713
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280718946
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -393,6 +413,7 @@ public boolean equals(Object o) {
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280718863
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -169,6 +176,11 @@ public final class RemoteLogManagerConfig {
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280710406
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280708300
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
divijvaidya merged PR #13260:
URL: https://github.com/apache/kafka/pull/13260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1660410928
Unrelated test failures at
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13260/9/pipeline/
. Merging this one.
--
This is an automated message
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1280704854
##
core/src/main/java/kafka/log/remote/CustomMetadataSizeLimitExceededException.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280704453
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude
Owen-CH-Leung opened a new pull request, #14136:
URL: https://github.com/apache/kafka/pull/14136
PR in response to
[KAFKA-15038](https://issues.apache.org/jira/browse/KAFKA-15038). This PR
incorporates `MetaDataCache` into `RemoteLogManager` and refactor all other
relevant codes
divijvaidya commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280702334
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude
clolov commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280697282
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
clolov commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280697282
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
clolov commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280689006
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
[
https://issues.apache.org/jira/browse/KAFKA-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749773#comment-17749773
]
Mickael Maison commented on KAFKA-15258:
This needs a KIP to decide whether it should be made
yashmayya commented on PR #13530:
URL: https://github.com/apache/kafka/pull/13530#issuecomment-1660303528
Hey Chris, thanks for the reviews and apologies for the late response.
> Honestly, I think the biggest obstacle to preventing pause/resume for
connectors that have failed to
divijvaidya commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280597042
##
build.gradle:
##
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude
divijvaidya commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280583213
##
core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749709#comment-17749709
]
Christo Lolov commented on KAFKA-15267:
---
Heya [~showuon] and thank you for the comment! I will
fvaleri commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1280546556
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
showuon commented on PR #14133:
URL: https://github.com/apache/kafka/pull/14133#issuecomment-1660201278
@divijvaidya @kamalcph , thanks for the comments. PR updated. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280543902
##
core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280542689
##
core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280542403
##
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##
@@ -179,6 +180,7 @@ public ReplicaManager build() {
if (metadataCache == null)
divijvaidya commented on code in PR #13847:
URL: https://github.com/apache/kafka/pull/13847#discussion_r1280542310
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig,
// pause cleaning
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280529448
##
core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1280526285
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
fvaleri commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1280446002
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
kamalcph commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280432985
##
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##
@@ -179,6 +180,7 @@ public ReplicaManager build() {
if (metadataCache == null)
ruslankrivoshein commented on PR #1348:
URL: https://github.com/apache/kafka/pull/1348#issuecomment-1660030396
Is this PR not going to be considered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
1 - 100 of 128 matches
Mail list logo
