[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286066810 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286064263 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060966 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060584 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060074 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1286059074 ## core/src/main/scala/kafka/server/KafkaBroker.scala: ## @@ -19,6 +19,7 @@ package kafka.server import com.yammer.metrics.core.MetricName import kafka.log.LogMana

[GitHub] [kafka] lucasbru commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

lucasbru commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1286049066 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

lucasbru commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1286048632 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

lucasbru commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1286048380 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {

[jira] [Commented] (KAFKA-14747) FK join should record discarded subscription responses

[ https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751702#comment-17751702 ] Koma Zhang commented on KAFKA-14747: [~mjsax] Sorry for late reply. But how can i co

[GitHub] [kafka] mimaison commented on a diff in pull request #14096: KAFKA-14595 AdminUtils rewritten in java

mimaison commented on code in PR #14096: URL: https://github.com/apache/kafka/pull/14096#discussion_r1285890587 ## core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala: ## @@ -607,7 +608,8 @@ object ReassignPartitionsCommand extends Logging { groupedByTopic.forKe

[GitHub] [kafka] fvaleri commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig

fvaleri commented on PR #14106: URL: https://github.com/apache/kafka/pull/14106#issuecomment-1668014997 @muralibasani sorry for the delay. As I wrote [here](https://github.com/apache/kafka/pull/13417#pullrequestreview-1548110301), you need to remove the Scala code that you are migra

[jira] [Commented] (KAFKA-15259) Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once

[ https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751698#comment-17751698 ] Tomonari Yamashita commented on KAFKA-15259: Hi [~mjsax], Thank you for sha

[GitHub] [kafka] cadonna commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

cadonna commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1285936281 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {

[GitHub] [kafka] mdedetrich closed pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich closed pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest URL: https://github.com/apache/kafka/pull/12781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mdedetrich commented on pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on PR #12781: URL: https://github.com/apache/kafka/pull/12781#issuecomment-1667959813 @bachmanity1 I don't have time to finish this off right now so I will close the PR, thanks for taking the time on this. -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] bachmanity1 commented on pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

bachmanity1 commented on PR #12781: URL: https://github.com/apache/kafka/pull/12781#issuecomment-1667866734 Hi @mdedetrich, I believe I may have accidentally created a duplicate of the work addressed here in #14153. If you plan to complete this PR, would you kindly let me know so I can

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1285865061 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -347,15 +353,16 @@ public void onLeadershipChange(Set partitionsBecomeLeader, public voi

[GitHub] [kafka] ijuma merged pull request #14011: MINOR: Fix MiniKdc Java 17 issue in system tests

ijuma merged PR #14011: URL: https://github.com/apache/kafka/pull/14011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1285857919 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -144,8 +145,9 @@ public class RemoteLogManager implements Closeable { private final Con

[GitHub] [kafka] ijuma commented on pull request #14011: MINOR: Fix MiniKdc Java 17 issue in system tests

ijuma commented on PR #14011: URL: https://github.com/apache/kafka/pull/14011#issuecomment-1667844651 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] muralibasani commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig

muralibasani commented on PR #14106: URL: https://github.com/apache/kafka/pull/14106#issuecomment-1667819639 @mimaison would like to take a look at this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1285716790 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -216,6 +216,14 @@ object TestUtils extends Logging { (new Broker(id, host, port, ListenerName.forS

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1285715433 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java: ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1285713904 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] divijvaidya commented on pull request #12806: KAFKA-14345: Fix flakiness with more accurate bound in (Dynamic)ConnectionQuotaTest

divijvaidya commented on PR #12806: URL: https://github.com/apache/kafka/pull/12806#issuecomment-1667637704 Hi @gharris1727 I am afraid that fixing only the tests hides the real problem/bug with the quotas implementation. If we merge this PR, yes the tests will not be flaky but aren

[GitHub] [kafka] divijvaidya commented on pull request #14073: KAFKA-15094: RemoteIndexCache stats

divijvaidya commented on PR #14073: URL: https://github.com/apache/kafka/pull/14073#issuecomment-1667613200 Also, please add the metrics in the centralized file to track all remote storage metrics added in https://github.com/apache/kafka/commit/748175ce62ea68d2a99ff9f96c7e349e1d0e1b96 --

[GitHub] [kafka] mimaison commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

mimaison commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285670300 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths, headers, ou

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

divijvaidya commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1285556220 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] kamalcph commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

kamalcph commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285671465 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

divijvaidya commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1283058109 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -144,8 +145,9 @@ public class RemoteLogManager implements Closeable { private final Concu

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751580#comment-17751580 ] Christo Lolov commented on KAFKA-15267: --- Okay, I shall raise a pull request in the

[jira] [Commented] (KAFKA-15291) Implement Versioned interfaces in common Connect plugins

[ https://issues.apache.org/jira/browse/KAFKA-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751525#comment-17751525 ] Aindriú Lavelle commented on KAFKA-15291: - PR [https://github.com/apache/kafka/p

[GitHub] [kafka] aindriu-aiven opened a new pull request, #14159: Kafka 15291 connect plugins implement versioned

aindriu-aiven opened a new pull request, #14159: URL: https://github.com/apache/kafka/pull/14159 As Per https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-15291 Following https://issues.apache.org/jira/browse/KAFKA-14863 the plugin scanning logic was updated to allow plugins t

[GitHub] [kafka] AndrewJSchofield commented on pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

AndrewJSchofield commented on PR #14111: URL: https://github.com/apache/kafka/pull/14111#issuecomment-1667332484 Build clean. A handful of unrelated test failures, primarily to do with EOS and Kafka Connect. -- This is an automated message from the Apache Git Service. To respond to the me

<    1   2