[GitHub] [kafka] divijvaidya commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

divijvaidya commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1294768292 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,80 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** *

[jira] [Updated] (KAFKA-15346) Single-Key_single-multi-timestamp IQs with versioned state stores

[ https://issues.apache.org/jira/browse/KAFKA-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi updated KAFKA-15346: - Description: [KIP-960|https://cwiki.apache.org/confluence/display/KAFKA/KIP-960%3A+Support+singl

[jira] [Assigned] (KAFKA-15346) Single-Key_single-multi-timestamp IQs with versioned state stores

[ https://issues.apache.org/jira/browse/KAFKA-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-15346: Assignee: Alieh Saeedi > Single-Key_single-multi-timestamp IQs with versioned state store

[jira] [Created] (KAFKA-15346) Single-Key_single-multi-timestamp IQs with versioned state stores

Alieh Saeedi created KAFKA-15346: Summary: Single-Key_single-multi-timestamp IQs with versioned state stores Key: KAFKA-15346 URL: https://issues.apache.org/jira/browse/KAFKA-15346 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294846904 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -0,0 +1,331 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294843843 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -152,16 +152,42 @@ class UnifiedLog(@volatile var logStartOffset: Long, locally { initializePartitionMe

[jira] [Assigned] (KAFKA-15319) Upgrade rocksdb to fix CVE-2022-37434

[ https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15319: --- Assignee: Lucas Brutschy > Upgrade rocksdb to fix CVE-2022-37434 >

[jira] [Updated] (KAFKA-15319) Upgrade rocksdb to fix CVE-2022-37434

[ https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15319: Fix Version/s: 3.6.0 > Upgrade rocksdb to fix CVE-2022-37434 > ---

[jira] [Updated] (KAFKA-15338) The metric group documentation for metrics added in KAFKA-13945 is incorrect

[ https://issues.apache.org/jira/browse/KAFKA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15338: Labels: beginner newbie (was: ) > The metric group documentation for metrics added in KAF

[GitHub] [kafka] jeqo commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

jeqo commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294829317 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1033,6 +1365,35 @@ public void close() { } } +private static class RetentionSizeDa

[GitHub] [kafka] AndrewJSchofield commented on pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

AndrewJSchofield commented on PR #14111: URL: https://github.com/apache/kafka/pull/14111#issuecomment-1679210703 @junrao Rebased and rebuilt. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] lucasbru commented on a diff in pull request #13927: [DO NOT MERGE] KAFKA-10199: Enable state updater by default

lucasbru commented on code in PR #13927: URL: https://github.com/apache/kafka/pull/13927#discussion_r1294820451 ## streams/src/test/java/org/apache/kafka/streams/integration/PurgeRepartitionTopicIntegrationTest.java: ## @@ -212,10 +213,11 @@ public void shouldRestoreState() thro

[GitHub] [kafka] C0urante commented on a diff in pull request #14195: KAFKA-15228: Add sync-manifests command to connect-plugin-path (KIP-898)

C0urante commented on code in PR #14195: URL: https://github.com/apache/kafka/pull/14195#discussion_r1294779885 ## tools/src/test/java/org/apache/kafka/tools/ConnectPluginPathTest.java: ## @@ -204,24 +353,25 @@ private static void assertPluginsAreCompatible(Map> table

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294766805 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -173,11 +173,14 @@ public enum MetadataVersion { // Adds replica epoc

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

viktorsomogyi commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294548060 ## core/src/main/scala/kafka/server/metadata/DelegationTokenPublisher.scala: ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] C0urante commented on a diff in pull request #14195: KAFKA-15228: Add sync-manifests command to connect-plugin-path (KIP-898)

C0urante commented on code in PR #14195: URL: https://github.com/apache/kafka/pull/14195#discussion_r1294750935 ## tools/src/main/java/org/apache/kafka/tools/ManifestWorkspace.java: ## @@ -0,0 +1,573 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] cadonna commented on a diff in pull request #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist

cadonna commented on code in PR #14214: URL: https://github.com/apache/kafka/pull/14214#discussion_r1294745792 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -838,15 +841,15 @@ private void transitRestoredTaskToRunning(final Task ta

[GitHub] [kafka] C0urante commented on a diff in pull request #14195: KAFKA-15228: Add sync-manifests command to connect-plugin-path (KIP-898)

C0urante commented on code in PR #14195: URL: https://github.com/apache/kafka/pull/14195#discussion_r1294745531 ## tools/src/main/java/org/apache/kafka/tools/ManifestWorkspace.java: ## @@ -0,0 +1,573 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] cadonna commented on a diff in pull request #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist

cadonna commented on code in PR #14214: URL: https://github.com/apache/kafka/pull/14214#discussion_r1294742218 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TasksRegistry.java: ## @@ -53,9 +53,11 @@ public interface TasksRegistry { void addPendingT

[GitHub] [kafka] cadonna commented on a diff in pull request #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist

cadonna commented on code in PR #14214: URL: https://github.com/apache/kafka/pull/14214#discussion_r1294741387 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TasksRegistry.java: ## @@ -53,9 +53,11 @@ public interface TasksRegistry { void addPendingT

[GitHub] [kafka] cadonna opened a new pull request, #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist

cadonna opened a new pull request, #14214: URL: https://github.com/apache/kafka/pull/14214 A stream thread should only change to RUNNING if there are no active tasks in restoration in the state updater and if there are no pending tasks to recycle and to init. Usually all pending task

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294681683 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -0,0 +1,331 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] jsancio opened a new pull request, #14213: KAFKA-15345; KRaft leader notifies when listener reaches epoch start

jsancio opened a new pull request, #14213: URL: https://github.com/apache/kafka/pull/14213 In a non-empty log the KRaft leader only notifies the listener of leadership when it has read to the leader's epoch start offset. This guarantees that the leader epoch has been committed and that the

[jira] [Created] (KAFKA-15345) KRaft leader should notify the listener only when it has read up to the leader's epoch

José Armando García Sancio created KAFKA-15345: -- Summary: KRaft leader should notify the listener only when it has read up to the leader's epoch Key: KAFKA-15345 URL: https://issues.apache.org/jira/br

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294681683 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -0,0 +1,331 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1679031173 @kamalcph tests are still failing [RemoteTopicCrudTest.testCreateRemoteTopicWithValidRetentionTime(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-1417

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

divijvaidya commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294668715 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294653156 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestReport.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] kamalcph commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1679001860 @divijvaidya Addressed most of your comments and marked them as resolved. Please take a look that those comments are addressed as expected. Thanks! -- This is an automated mess

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294648669 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -186,57 +133,28 @@ class DelegationTokenManager(val config: KafkaConfig, val tokenMaxLife

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294640475 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294624738 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +847,75 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def ha

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294623852 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +847,75 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def ha

[GitHub] [kafka] nikramakrishnan opened a new pull request, #14212: MINOR: Add test case for follower fetch

nikramakrishnan opened a new pull request, #14212: URL: https://github.com/apache/kafka/pull/14212 This PR adds a test case for follower fetch when segments are archived and expired from remote storage. This test case verifies the following scenario (from [comment](https://github.com/apache

[GitHub] [kafka] jeqo commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

jeqo commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294618085 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1033,6 +1360,35 @@ public void close() { } } +private static class RetentionSizeDa

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294609562 ## storage/src/test/java/org/apache/kafka/tiered/storage/README.md: ## @@ -0,0 +1,9 @@ +Step 1: For every test, setup is done via TieredStorageTestHarness which exten

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294604024 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1003,6 +1015,134 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294603142 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1003,6 +1015,134 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1294602887 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -698,11 +707,329 @@ public void run() { } } +public void handleLogSt

[jira] [Commented] (KAFKA-15201) When git fails, script goes into a loop

[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754643#comment-17754643 ] Gantigmaa Selenge commented on KAFKA-15201: --- Hi [~divijvaidya] I could not rep

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294583210 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] clolov commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

clolov commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1294565080 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -478,23 +498,45 @@ void testMetricsUpdateOnCopyLogSegmentsFailure() throws Exception {

[jira] [Created] (KAFKA-15344) Kafka Streams should include the message leader epoch when committing offsets

David Mao created KAFKA-15344: - Summary: Kafka Streams should include the message leader epoch when committing offsets Key: KAFKA-15344 URL: https://issues.apache.org/jira/browse/KAFKA-15344 Project: Kafk

[GitHub] [kafka] showuon commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

showuon commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294548425 ## storage/src/test/java/org/apache/kafka/tiered/storage/README.md: ## @@ -0,0 +1,9 @@ +Step 1: For every test, setup is done via TieredStorageTestHarness which extend

[GitHub] [kafka] divijvaidya commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

divijvaidya commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1678871025 @kamalcph changes look good to me. Let's focus on CI build now. Could you please fix the checkstyle failures which are causing build failures? -- This is an automated message from t

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

viktorsomogyi commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1294522714 ## metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kamalcph commented on a diff in pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on code in PR #14116: URL: https://github.com/apache/kafka/pull/14116#discussion_r1294503554 ## storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] see-quick opened a new pull request, #14211: MINOR: Add a few test cases to clients

see-quick opened a new pull request, #14211: URL: https://github.com/apache/kafka/pull/14211 This PR adds a few test cases to clients, increasing test coverage a little bit. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ver

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294461075 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294460859 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294460465 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294456594 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandErrorTest.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294456310 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294455955 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1294455490 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson B. updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put those i

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1294052739 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -72,15 +72,17 @@ public TimeIndex(File file, long baseOffset, int maxIndexSize,

[GitHub] [kafka] clolov opened a new pull request, #14210: KAFKA-14133: Move RecordCollectorTest, StateRestoreCallbackAdapterTest and StoreToProcessorContextAdapterTest to Mockito

clolov opened a new pull request, #14210: URL: https://github.com/apache/kafka/pull/14210 This pull requests migrates mocks from RecordCollectorTest, StateRestoreCallbackAdapterTest and StoreToProcessorContextAdapterTest to Mockito. -- This is an automated message from the Apache Git Ser

[jira] [Commented] (KAFKA-15172) Allow exact mirroring of ACLs between clusters

[ https://issues.apache.org/jira/browse/KAFKA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754541#comment-17754541 ] hudeqi commented on KAFKA-15172: This KIP is seldom discussed, what should I do next? [~

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1678700485 @mimaison Is there any change that PR will be reviewed in current shape? Or I should think on how split it? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] clolov opened a new pull request, #14209: Move ActiveTaskCreatorTest, ChangelogTopicsTest and GlobalProcessorContextImplTest to Mockito

clolov opened a new pull request, #14209: URL: https://github.com/apache/kafka/pull/14209 This pull requests migrates mocks from ActiveTaskCreatorTest, ChangelogTopicsTest and GlobalProcessorContextImplTest to Mockito. -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294410814 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -265,7 +266,12 @@ public Optional serverConfigName(String configName) {

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1678685831 @kamalcph Tests from this PR are failing in CI such as `RemoteTopicCrudTest.testEnableRemoteLogOnExistingTopicTest`, see: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

vamossagar12 commented on code in PR #14202: URL: https://github.com/apache/kafka/pull/14202#discussion_r1294406054 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java: ## @@ -32,21 +36,28 @@ public TestConfig(Map originals) {

[GitHub] [kafka] vamossagar12 commented on pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

vamossagar12 commented on PR #14202: URL: https://github.com/apache/kafka/pull/14202#issuecomment-1678684041 Thanks Luke. I corrected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1294403336 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1294402558 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1294402358 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -121,16 +122,18 @@ class PlaintextProducerSendTest extends BaseProducerSendTest

[GitHub] [kafka] divijvaidya merged pull request #14190: KAFKA-7438: Replace Easymock & Powermock with Mockito in RocksDBMetricsRecorderGa…

divijvaidya merged PR #14190: URL: https://github.com/apache/kafka/pull/14190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] showuon commented on a diff in pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

showuon commented on code in PR #14202: URL: https://github.com/apache/kafka/pull/14202#discussion_r1294388761 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java: ## @@ -32,21 +36,28 @@ public TestConfig(Map originals) {

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] vamossagar12 commented on pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

vamossagar12 commented on PR #14202: URL: https://github.com/apache/kafka/pull/14202#issuecomment-1678631384 Thanks @showuon , I made the requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

vamossagar12 commented on code in PR #14202: URL: https://github.com/apache/kafka/pull/14202#discussion_r1294357019 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java: ## @@ -52,6 +54,28 @@ public void testValidConfigs() {

[GitHub] [kafka] cadonna commented on a diff in pull request #13927: [DO NOT MERGE] KAFKA-10199: Enable state updater by default

cadonna commented on code in PR #13927: URL: https://github.com/apache/kafka/pull/13927#discussion_r1294331015 ## streams/src/test/java/org/apache/kafka/streams/integration/PurgeRepartitionTopicIntegrationTest.java: ## @@ -212,10 +213,11 @@ public void shouldRestoreState() throw

[GitHub] [kafka] lucasbru commented on a diff in pull request #13927: [DO NOT MERGE] KAFKA-10199: Enable state updater by default

lucasbru commented on code in PR #13927: URL: https://github.com/apache/kafka/pull/13927#discussion_r1294315120 ## streams/src/test/java/org/apache/kafka/streams/integration/PurgeRepartitionTopicIntegrationTest.java: ## @@ -212,10 +213,11 @@ public void shouldRestoreState() thro

[GitHub] [kafka] showuon commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

showuon commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1294276490 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC to

[GitHub] [kafka] clolov commented on pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

clolov commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1678516932 To provide some clarity, I will just do one more pass for the MetadataCache itself, because I would like to confirm that it is updated when we would expect it to be (as per Divij's comment

[GitHub] [kafka] clolov commented on a diff in pull request #14204: KAFKA-14133: Move mocks from KStreamTransformValuesTest, KTableImplTest and KTableTransformValuesTest to Mockito

clolov commented on code in PR #14204: URL: https://github.com/apache/kafka/pull/14204#discussion_r1294265668 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableTransformValuesTest.java: ## @@ -163,104 +159,74 @@ public void shouldNotSendOldValuesByDefault

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1294263440 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1294261443 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

<    1   2