junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379129447
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379120392
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
jolshan commented on PR #14489:
URL: https://github.com/apache/kafka/pull/14489#issuecomment-1789389956
I'm also waiting for some confirmation from @hachikuji about the transaction
changes. I will look at the build issues in the meantime.
--
This is an automated message from the Apache
jolshan opened a new pull request, #14689:
URL: https://github.com/apache/kafka/pull/14689
Adding the note from the kafka-site repo to the main repo. I also included
the fixed link.
https://github.com/apache/kafka-site/commit/9fa596cbffa3db69e39b8ab06aa61c57c712b61e
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781842#comment-17781842
]
Colin McCabe commented on KAFKA-15754:
--
bq. Going to close this again, even if it's a mistery why
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378458667
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -782,14 +784,15 @@ public void verifyStore() {
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1379080018
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1632,10 +1721,65 @@ public void shouldHandleRangeQuery(
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1379066906
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
msn-tldr commented on PR #14685:
URL: https://github.com/apache/kafka/pull/14685#issuecomment-1789309939
So the CI failures are flaky, unrelated tests.
https://ge.apache.org/s/t6qcbarr56fe2/tests/overview?outcome=FLAKY,FAILED
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1379053726
##
metadata/src/main/java/org/apache/kafka/common/errors/InvalidReplicaDirectoriesException.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation
junrao merged PR #14607:
URL: https://github.com/apache/kafka/pull/14607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1789288736
Thanks for triaging the transient test failures, @alok123t. Will merge the
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1379040427
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +140,230 @@ static class
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1379040148
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +140,230 @@ static class
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1379035559
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -312,6 +364,29 @@ protected QueryResult runKeyQuery(final Query
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1379034752
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
philipnee commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1379033359
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -982,23 +987,6 @@ private boolean
philipnee commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1379033013
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -278,22 +283,22 @@ public PrototypeAsyncConsumer(final Time time,
[
https://issues.apache.org/jira/browse/KAFKA-15711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge reassigned KAFKA-15711:
-
Assignee: Gantigmaa Selenge
> KRaft support in LogRecoveryTest
>
ex172000 opened a new pull request, #14688:
URL: https://github.com/apache/kafka/pull/14688
If we don't sleep until the retry backoff is passed, it's likely to cause
verification failure as the next request will never come.
Verified locally by running it many(10+) times.
*More
pprovenzano commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1789220297
LGTM too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vamossagar12 commented on PR #14674:
URL: https://github.com/apache/kafka/pull/14674#issuecomment-1789218963
@chia7712 , do you ming taking a look at this one plz?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1789209541
> one minor suggestion, otherwise LGTM
Thanks @xvrl, I have added the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message,
xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1378978236
##
build.gradle:
##
@@ -1379,11 +1392,40 @@ project(':clients') {
}
}
- jar {
+ shadowJar {
dependsOn createVersionFile
+// archiveClassifier defines
msn-tldr commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378976609
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -186,6 +193,15 @@ protected void handleFetchSuccess(final Node
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1378929413
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -102,6 +112,8 @@ public Builder setPartitionEpoch(Integer partitionEpoch) {
hudeqi commented on PR #14667:
URL: https://github.com/apache/kafka/pull/14667#issuecomment-1789127927
> I am restarting the CI. There are large number of test failures including
some TS ones. Let's wait to have a saner CI build.
seems new CI failed tests are unrelated. @divijvaidya
GOODBOY008 commented on PR #14683:
URL: https://github.com/apache/kafka/pull/14683#issuecomment-1789096149
@divijvaidya Thank you for your quick review. I made these change just
because these log with exception is not right way.
In presence of multiple parameters, if the last
[
https://issues.apache.org/jira/browse/KAFKA-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781763#comment-17781763
]
Zihao Lin edited comment on KAFKA-15730 at 11/1/23 2:37 PM:
Fixed in
[
https://issues.apache.org/jira/browse/KAFKA-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781763#comment-17781763
]
Zihao Lin commented on KAFKA-15730:
---
Fixed in [ [https://github.com/apache/kafka/pull/14295] |
[
https://issues.apache.org/jira/browse/KAFKA-15731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781761#comment-17781761
]
Zihao Lin commented on KAFKA-15731:
---
Issue fixed in PR.
https://github.com/apache/kafka/pull/14295
>
[
https://issues.apache.org/jira/browse/KAFKA-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781759#comment-17781759
]
Zihao Lin commented on KAFKA-15732:
---
Issue fixed in PR.
alok123t opened a new pull request, #14687:
URL: https://github.com/apache/kafka/pull/14687
In many parameterized tests, the display name is broken. Example -
`testMetadataFetch` appears as `[1] true`, `[2] false`
[
https://issues.apache.org/jira/browse/KAFKA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781758#comment-17781758
]
Zihao Lin commented on KAFKA-15733:
---
This fixed in [PR|https://github.com/apache/kafka/pull/14295]
Hangleton commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1378860641
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -196,12 +197,27 @@ public void remove(Uuid key) {
public void
linzihao1999 opened a new pull request, #14686:
URL: https://github.com/apache/kafka/pull/14686
The tests in ResetConsumerGroupOffsetTest in
core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala update
to support KRaft.
### Committer Checklist (excluded from commit
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781751#comment-17781751
]
Arpit Goyal commented on KAFKA-15388:
-
[~divijvaidya] I am not getting the archival functionality ,
ijuma commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1378853019
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -618,7 +618,7 @@ public ProducerConfig(Map props) {
super(CONFIG, props);
vamossagar12 closed pull request #12512: KAFKA-14138: Wrapping all non-fatal
exceptions in KafkaException and throwing all fata exceptions directly for
producer.send()
URL: https://github.com/apache/kafka/pull/12512
--
This is an automated message from the Apache Git Service.
To respond to
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1789002777
> @apoorvmittal10 : Thanks for the updated PR. Left a few more comments.
Thanks for the feedback @junrao. I have addressed the comments.
--
This is an automated message
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378834332
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -477,6 +479,128 @@ class KafkaApisTest {
testKraftForwarding(ApiKeys.ELECT_LEADERS,
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378834102
##
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##
@@ -101,4 +102,55 @@ class ControllerConfigurationValidatorTest {
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378833820
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378832405
##
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##
@@ -101,4 +102,55 @@ class ControllerConfigurationValidatorTest {
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378831801
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4089,13 +4119,19 @@ public void testIncrementalAlterConfigs() throws
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378830720
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -567,7 +572,8 @@ class KafkaServer(
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378829641
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -106,7 +106,8 @@ class KafkaApis(val requestChannel: RequestChannel,
val clusterId:
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378828818
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378827876
##
core/src/test/java/kafka/metrics/ClientMetricsTestUtils.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378825692
##
core/src/main/java/kafka/metrics/ClientMetricsConfigs.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378824753
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -129,6 +130,25 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig,
ex172000 commented on code in PR #14682:
URL: https://github.com/apache/kafka/pull/14682#discussion_r1378815861
##
docs/ops.html:
##
@@ -3641,7 +3641,6 @@ Limitations
using one of those features, you will not be able to migrate to KRaft
yet.
Review Comment:
Maybe we
ex172000 commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378796519
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -186,6 +193,15 @@ protected void handleFetchSuccess(final Node
laglangyue closed pull request #14606: KAFKA-15556: Remove
NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and
tryConnect
URL: https://github.com/apache/kafka/pull/14606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ex172000 commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378794965
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,92 @@ public synchronized void update(int requestVersion,
MetadataResponse
clolov commented on code in PR #14679:
URL: https://github.com/apache/kafka/pull/14679#discussion_r1378794890
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##
@@ -201,49 +201,37 @@ public void
laglangyue commented on PR #14614:
URL: https://github.com/apache/kafka/pull/14614#issuecomment-1788942302
> @laglangyue can you please rebase with trunk (there are conflicts right
now) before we merge this in. Thanks!
done
--
This is an automated message from the Apache Git
clolov commented on code in PR #14679:
URL: https://github.com/apache/kafka/pull/14679#discussion_r1378784870
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##
@@ -201,49 +201,37 @@ public void
divijvaidya commented on PR #14614:
URL: https://github.com/apache/kafka/pull/14614#issuecomment-1788898213
@laglangyue can you please rebase with trunk before we merge this in. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
divijvaidya commented on code in PR #14679:
URL: https://github.com/apache/kafka/pull/14679#discussion_r1378751617
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##
@@ -201,49 +201,37 @@ public void
divijvaidya commented on PR #14683:
URL: https://github.com/apache/kafka/pull/14683#issuecomment-178945
Hi @GOODBOY008, thank you for the PR.
Could you please help me understand the motivation of the PR? I observed
that you have changed the logging such that instead of complete
msn-tldr opened a new pull request, #14685:
URL: https://github.com/apache/kafka/pull/14685
This implements the leader discovery optimisations for the client on
[KIP-951](https://cwiki.apache.org/confluence/display/KAFKA/KIP-951%3A+Leader+discovery+optimisations+for+the+client).
msn-tldr commented on PR #14564:
URL: https://github.com/apache/kafka/pull/14564#issuecomment-1788826662
Rebasing my fork seems to have removed the PR commits from the remote branch
`kip951_client_changes`, that has *automatically* closed this PR
Something to be careful of in future,
ijuma commented on PR #14623:
URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788808631
Sounds good, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781703#comment-17781703
]
Divij Vaidya commented on KAFKA-15388:
--
[~goyarpit] That is an good observation but I think it
apoorvmittal10 commented on code in PR #14684:
URL: https://github.com/apache/kafka/pull/14684#discussion_r1378677251
##
clients/src/main/java/org/apache/kafka/server/telemetry/ClientTelemetryPayload.java:
##
@@ -22,31 +22,37 @@
import java.nio.ByteBuffer;
+/**
+ * A
divijvaidya commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1788790638
@clolov would you like to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14133:
-
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
divijvaidya merged PR #14623:
URL: https://github.com/apache/kafka/pull/14623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
msn-tldr closed pull request #14564: KAFKA-15627: KIP-951's Leader discovery
optimisations on the client
URL: https://github.com/apache/kafka/pull/14564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
divijvaidya commented on PR #14623:
URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788782355
@ijuma I am merging this in without waiting for your approval since the
changes are straightforward and your comments have been addressed. Please
leave a comment if something is
divijvaidya commented on PR #14623:
URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788780081
Test failures are unrelated:
```
[Build / JDK 11 and Scala 2.13 /
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1378662641
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -198,6 +215,20 @@ protected void handleFetchSuccess(final Node
hudeqi commented on PR #14652:
URL: https://github.com/apache/kafka/pull/14652#issuecomment-1788778264
> Heya @hudeqi, thank you for the contribution! I have been reviewing this
code change and I am a bit uncertain to its purpose so I wanted to ask some
follow up questions. As far as I
divijvaidya commented on PR #14667:
URL: https://github.com/apache/kafka/pull/14667#issuecomment-1788777303
I am restarting the CI. There are large number of test failures including
some TS ones. Let's wait to have a saner CI build.
--
This is an automated message from the Apache Git
AndrewJSchofield commented on code in PR #14684:
URL: https://github.com/apache/kafka/pull/14684#discussion_r1378645692
##
clients/src/main/java/org/apache/kafka/server/telemetry/ClientTelemetryPayload.java:
##
@@ -22,31 +22,37 @@
import java.nio.ByteBuffer;
+/**
+ * A
hudeqi commented on PR #14667:
URL: https://github.com/apache/kafka/pull/14667#issuecomment-1788753329
Can this PR be merged? @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
apoorvmittal10 commented on PR #14575:
URL: https://github.com/apache/kafka/pull/14575#issuecomment-1788732337
> Just catching up (for my own education). -- Left a couple of follow up
comments. Can we address them in follow up PR?
@mjsax Please find the PR to address additional
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1378628400
##
clients/src/main/java/org/apache/kafka/server/telemetry/ClientTelemetryReceiver.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1378628113
##
clients/src/main/java/org/apache/kafka/server/telemetry/ClientTelemetryPayload.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1378627395
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricKey.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1378627878
##
clients/src/main/java/org/apache/kafka/server/telemetry/ClientTelemetry.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 opened a new pull request, #14684:
URL: https://github.com/apache/kafka/pull/14684
This PR is follow-up for minor remaining comments from
https://github.com/apache/kafka/pull/14575
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
fxbing commented on PR #14674:
URL: https://github.com/apache/kafka/pull/14674#issuecomment-1788697027
> Thanks for this PR! @fxbing. I think this deserves a jira to track. And
can you add a unit test?
@hudeqi Thanks for the comments, I've added the jira issue.
But regarding unit
Xiaobing Fang created KAFKA-15771:
-
Summary: ProduceRequest#partitionSizes() is not an atomic
operation
Key: KAFKA-15771
URL: https://issues.apache.org/jira/browse/KAFKA-15771
Project: Kafka
cadonna commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1378591228
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -618,7 +618,7 @@ public ProducerConfig(Map props) {
super(CONFIG,
cadonna commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1378591228
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -618,7 +618,7 @@ public ProducerConfig(Map props) {
super(CONFIG,
clolov commented on PR #14623:
URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788663042
Heya @ijuma and @divijvaidya, none of the test failures are related to the
test being changed in this pull request and the build passes! I hope I have
addressed all of your comments and
cadonna commented on PR #14677:
URL: https://github.com/apache/kafka/pull/14677#issuecomment-1788640979
> Can we just do this? Seems we need to wait for 4.0 release? Created
https://issues.apache.org/jira/browse/KAFKA-15765 for tracking.
We did not keep the metrics. They were
kumarpritam863 commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1788600024
@C0urante I have added the test for both the scenarios:
1. Test failing if the ConsumerRebalanceListener of WorkerSinkTask adopts to
current flow where we update the partition
Owen-CH-Leung commented on code in PR #14645:
URL: https://github.com/apache/kafka/pull/14645#discussion_r1378515252
##
release.py:
##
@@ -730,7 +730,7 @@ def select_gpg_key():
fail("Ok, giving up")
if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
fail("Ok,
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1788570036
@mimaison @jolshan Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1788569671
I update this PR with trunk and rerun utility locally with java version of
`PartitionReassignCommand`. The results still very similary to previous runs:
![Снимок экрана 2023-11-01
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1788547336
Thanks all for the help, review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
linzihao1999 commented on PR #14668:
URL: https://github.com/apache/kafka/pull/14668#issuecomment-1788546638
@dengziming PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781635#comment-17781635
]
Jiahongchao commented on KAFKA-15686:
-
We are using the Kafka cluster managed by another team. A few
[
https://issues.apache.org/jira/browse/KAFKA-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781631#comment-17781631
]
Zihao Lin commented on KAFKA-15111:
---
It seems to be fixed in KAFKA-14752.
> Correction kafka examples
kamalcph commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378464684
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3117,7 +3117,8 @@ class ReplicaManagerTest {
isShuttingDown: AtomicBoolean = new
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378458667
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -782,14 +784,15 @@ public void verifyStore() {
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378458667
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -782,14 +784,15 @@ public void verifyStore() {
101 - 200 of 223 matches
Mail list logo
