Re: [PR] KAFKA-15629: Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery [kafka]

2023-11-01 Thread via GitHub
hanyuzheng7 commented on code in PR #14570: URL: https://github.com/apache/kafka/pull/14570#discussion_r1378458667 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -782,14 +784,15 @@ public void verifyStore() { f

Re: [PR] KAFKA-15432:RLM Stop partitions should not be invoked for non-tiered storage topics [kafka]

2023-11-01 Thread via GitHub
kamalcph commented on code in PR #14667: URL: https://github.com/apache/kafka/pull/14667#discussion_r1378454900 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3117,7 +3117,8 @@ class ReplicaManagerTest { isShuttingDown: AtomicBoolean = new AtomicB

Re: [PR] KAFKA-15432:RLM Stop partitions should not be invoked for non-tiered storage topics [kafka]

2023-11-01 Thread via GitHub
kamalcph commented on code in PR #14667: URL: https://github.com/apache/kafka/pull/14667#discussion_r1378454900 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3117,7 +3117,8 @@ class ReplicaManagerTest { isShuttingDown: AtomicBoolean = new AtomicB

<    1   2   3