Re: [PR] MINOR: Update LICENSE-binary for 3.7.0 [kafka]

2023-11-29 Thread via GitHub
mimaison merged PR #14833: URL: https://github.com/apache/kafka/pull/14833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15140) Improve TopicCommandIntegrationTest to be less flaky

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15140: --- Labels: flaky-test newbie (was: newbie) > Improve TopicCommandIntegrationTest to be less

[jira] [Updated] (KAFKA-15759) Flaky test - testDescribeClusterRequestIncludingClusterAuthorizedOperations - DescribeClusterRequestTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15759: --- Summary: Flaky test - testDescribeClusterRequestIncludingClusterAuthorizedOperations -

[jira] [Updated] (KAFKA-15897) Flaky Test: testWrongIncarnationId() – kafka.server.ControllerRegistrationManagerTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15897: --- Labels: flaky-test (was: ) > Flaky Test: testWrongIncarnationId() – >

[jira] [Updated] (KAFKA-6154) Transient failure TransactionsBounceTest.testBrokerFailure

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-6154: -- Labels: flaky-test (was: ) > Transient failure TransactionsBounceTest.testBrokerFailure >

[jira] [Updated] (KAFKA-14989) Flaky test TransactionsTest.testFailureToFenceEpoch

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14989: --- Priority: Major (was: Minor) > Flaky test TransactionsTest.testFailureToFenceEpoch >

[jira] [Updated] (KAFKA-14989) Flaky test TransactionsTest.testFailureToFenceEpoch

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14989: --- Issue Type: Bug (was: Improvement) > Flaky test TransactionsTest.testFailureToFenceEpoch >

[jira] [Updated] (KAFKA-14989) Flaky test TransactionsTest.testFailureToFenceEpoch

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14989: --- Labels: flaky-test (was: ) > Flaky test TransactionsTest.testFailureToFenceEpoch >

[PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

2023-11-29 Thread via GitHub
mjsax opened a new pull request, #14864: URL: https://github.com/apache/kafka/pull/14864 This PR is still WIP, but wanted to open it on time to collect initial feedback. So far, I only added support for global-consumer client-instance-id. Part of KIP-714 -- This is an

[jira] [Updated] (KAFKA-13966) Flaky test `QuorumControllerTest.testUnregisterBroker`

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-13966: --- Labels: flaky-test (was: ) > Flaky test `QuorumControllerTest.testUnregisterBroker` >

[jira] [Updated] (KAFKA-15786) Flaky Test - testBumpTransactionalEpoch - TransactionsTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15786: --- Summary: Flaky Test - testBumpTransactionalEpoch - TransactionsTest (was: Flaky Test -

[jira] [Updated] (KAFKA-15785) Flaky Test - testTransactionAfterTransactionIdExpiresButProducerIdRemains - ProducerIdExpirationTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15785: --- Summary: Flaky Test - testTransactionAfterTransactionIdExpiresButProducerIdRemains -

[jira] [Updated] (KAFKA-15788) Flaky Test - testDeleteCmdNonExistingGroup - DeleteConsumerGroupsTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15788: --- Summary: Flaky Test - testDeleteCmdNonExistingGroup - DeleteConsumerGroupsTest (was: Flaky

[jira] [Updated] (KAFKA-15786) Flaky Test - testBumpTransactionalEpoch

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15786: --- Labels: flaky-test (was: ) > Flaky Test - testBumpTransactionalEpoch >

[jira] [Updated] (KAFKA-15785) Flaky Test - testTransactionAfterTransactionIdExpiresButProducerIdRemains - ProducerIdExpirationTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15785: --- Labels: flaky-test (was: ) > Flaky Test -

[jira] [Updated] (KAFKA-15790) Flaky Test - testHighWaterMarkAfterPartitionReassignment

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15790: --- Labels: flaky-test (was: ) > Flaky Test - testHighWaterMarkAfterPartitionReassignment >

[jira] [Updated] (KAFKA-15791) Flaky test - MirrorConnectorsWithCustomForwardingAdminIntegrationTest - MirrorConnectorsIntegrationBaseTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15791: --- Labels: flaky-test (was: ) > Flaky test -

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield commented on PR #14835: URL: https://github.com/apache/kafka/pull/14835#issuecomment-1831559902 One of the test failures needs addressing. I'll investigate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409025050 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -55,17 +56,21 @@ class CoordinatorLoaderImpl[T]( * Loads the coordinator by reading

[jira] [Updated] (KAFKA-15788) Flaky Test - testDeleteCmdNonExistingGroup

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15788: --- Labels: flaky-test (was: ) > Flaky Test - testDeleteCmdNonExistingGroup >

[jira] [Updated] (KAFKA-15789) Flaky Test - testTimeouts - QuorumControllerTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15789: --- Labels: flaky-test (was: ) > Flaky Test - testTimeouts - QuorumControllerTest >

[jira] [Updated] (KAFKA-15925) Flaky test - testReplicateSourceDefault - MirrorConnectorsIntegrationTransactionsTest

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15925: --- Summary: Flaky test - testReplicateSourceDefault -

[jira] [Created] (KAFKA-15927) Flaky test - testReplicateSourceDefault - MirrorConnectorsIntegrationExactlyOnceTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15927: -- Summary: Flaky test - testReplicateSourceDefault - MirrorConnectorsIntegrationExactlyOnceTest Key: KAFKA-15927 URL: https://issues.apache.org/jira/browse/KAFKA-15927

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1409010440 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -223,8 +232,65 @@ public void

[jira] [Updated] (KAFKA-15522) Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOneWayReplicationWithFrequentOffsetSyncs

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15522: --- Labels: flaky flaky-test (was: flaky) > Flaky test >

[jira] [Created] (KAFKA-15926) Flaky test - testReplicateSourceDefault - MirrorConnectorsIntegrationSSLTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15926: -- Summary: Flaky test - testReplicateSourceDefault - MirrorConnectorsIntegrationSSLTest Key: KAFKA-15926 URL: https://issues.apache.org/jira/browse/KAFKA-15926

[jira] [Updated] (KAFKA-15523) Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15523: --- Labels: flaky flaky-test (was: flaky) > Flaky test >

[jira] [Created] (KAFKA-15925) Flaky test testReplicateSourceDefault - MirrorConnectorsIntegrationTransactionsTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15925: -- Summary: Flaky test testReplicateSourceDefault - MirrorConnectorsIntegrationTransactionsTest Key: KAFKA-15925 URL: https://issues.apache.org/jira/browse/KAFKA-15925

Re: [PR] KAFKA-15695: Update the local log start offset of a log after rebuilding the auxiliary state [kafka]

2023-11-29 Thread via GitHub
kamalcph commented on PR #14649: URL: https://github.com/apache/kafka/pull/14649#issuecomment-1831525022 > @nikramakrishnan There may be an intermittent issue within the test framework. It needs to be resolved for merging this PR as the `ReassignToEmptyReplicaTest` is introduced as part of

Re: [PR] KAFKA-15426: Process and persist directory assignments [kafka]

2023-11-29 Thread via GitHub
soarez commented on PR #14863: URL: https://github.com/apache/kafka/pull/14863#issuecomment-1831518299 Depends on #14820 and #14838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408986511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -943,4 +944,19 @@ private static Integer decValue(String key,

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield closed pull request #14859: KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer URL: https://github.com/apache/kafka/pull/14859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield commented on PR #14859: URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831514140 Closing and reopening PR to retry failed build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] KAFKA-15426: Process and persist directory assignments [kafka]

2023-11-29 Thread via GitHub
soarez opened a new pull request, #14863: URL: https://github.com/apache/kafka/pull/14863 Handle AssignReplicasToDirs requests, persist metadata changes with new directory assignments and possible leader elections. ### Committer Checklist (excluded from commit message) - [ ]

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14687: URL: https://github.com/apache/kafka/pull/14687#discussion_r1408976485 ## streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java: ## @@ -138,7 +138,7 @@ private void

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14687: URL: https://github.com/apache/kafka/pull/14687#discussion_r1408975349 ## streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java: ## @@ -239,10 +240,8 @@ public static String safeUniqueTestName(final

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14835: URL: https://github.com/apache/kafka/pull/14835#issuecomment-1831495002 @AndrewJSchofield Looks like the test is failing ``` org.mockito.exceptions.misusing.WrongTypeOfReturnValue: Long cannot be returned by poll() poll() should

[jira] [Updated] (KAFKA-15770) org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy is flaky

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15770: --- Labels: flaky-test (was: ) >

[jira] [Updated] (KAFKA-4583) KafkaConsumerTest.testGracefulClose transient failure

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-4583: -- Labels: flaky-test transient-unit-test-failure (was: transient-unit-test-failure) >

[jira] [Updated] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-10251: --- Labels: flaky-test (was: ) > Flaky Test

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831472098 The test is failing in legacy consumer code, and this PR did not touch legacy consumer code. The test failure may be related to the CTR refactoring, but not to this particular

Re: [PR] KAFKA-15887: Ensure FindCoordinatorRequest is sent before closing [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14842: URL: https://github.com/apache/kafka/pull/14842#issuecomment-1831462346 I totally agree on not using spies. That is my opinion and also the Mockito documentation says to be really careful with spies and to just use them if absolutely needed. Spies are mostly

Re: [PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2023-11-29 Thread via GitHub
ocadaruma commented on PR #14242: URL: https://github.com/apache/kafka/pull/14242#issuecomment-1831446770 @junrao Thank you for the suggestion. I resolved the conflict. Also created tickets for flaky tests which don't have corresponding JIRA ticket now. - From [previous

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408928899 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String currentAssignmentSummary()

[jira] [Created] (KAFKA-15924) Flaky test - QuorumControllerTest.testFatalMetadataReplayErrorOnActive

2023-11-29 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15924: Summary: Flaky test - QuorumControllerTest.testFatalMetadataReplayErrorOnActive Key: KAFKA-15924 URL: https://issues.apache.org/jira/browse/KAFKA-15924 Project:

[jira] [Updated] (KAFKA-15924) Flaky test - QuorumControllerTest.testFatalMetadataReplayErrorOnActive

2023-11-29 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-15924: - Attachment: stdout.log > Flaky test - QuorumControllerTest.testFatalMetadataReplayErrorOnActive

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831442687 I am asking because I see the follwing log: ``` [2023-11-23 16:29:05,394] ERROR Asynchronous auto-commit of offsets failed: Commit cannot be completed since the group has already

Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

2023-11-29 Thread via GitHub
fvaleri commented on PR #14847: URL: https://github.com/apache/kafka/pull/14847#issuecomment-1831441198 > The tool calls KafkaConfig.validateValues which runs the full set of configuration validations. Here we only have the ones that makes sense with the tool commands, the rest will be

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408924119 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831439167 @lucasbru Is the following test failure related: ``` org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest.testOutdatedCoordinatorAssignment() ``` -- This

Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14844: URL: https://github.com/apache/kafka/pull/14844#discussion_r1408915256 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -590,12 +590,18 @@ private ApiMessage

Re: [PR] MINOR: Add Uniform assignor to the default config [kafka]

2023-11-29 Thread via GitHub
dajac commented on PR #14826: URL: https://github.com/apache/kafka/pull/14826#issuecomment-1831426940 @jolshan Thanks. I just resolved that conflict. I also looked into the tests and the one that you mentioned are not related to changed made in this PR. -- This is an automated message

[jira] [Created] (KAFKA-15923) Implement changes proposed in KIP-994

2023-11-29 Thread Raman Verma (Jira)
Raman Verma created KAFKA-15923: --- Summary: Implement changes proposed in KIP-994 Key: KAFKA-15923 URL: https://issues.apache.org/jira/browse/KAFKA-15923 Project: Kafka Issue Type: Task

<    1   2   3