Re: [PR] [MINOR] remove meaningless lines [kafka]

2024-03-04 Thread via GitHub
chia7712 closed pull request #14423: [MINOR] remove meaningless lines URL: https://github.com/apache/kafka/pull/14423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: Don't log missing partitions at ERROR level [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #14579: URL: https://github.com/apache/kafka/pull/14579#issuecomment-1977349997 > Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory. That makes sense to me. We can keep only

[jira] [Commented] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2024-03-04 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823303#comment-17823303 ] Greg Harris commented on KAFKA-10582: - Hi [~frankgrimes97] Thanks for finding this ticket. I think

[jira] [Resolved] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2024-03-04 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-10582. - Fix Version/s: 3.5.0 Resolution: Fixed > Mirror Maker 2 not replicating new topics until

[jira] [Updated] (KAFKA-16326) Kafka Connect unable to find javax dependency on Quarkus update to 3.X

2024-03-04 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16326: Fix Version/s: 4.0.0 > Kafka Connect unable to find javax dependency on Quarkus update to 3.X >

[jira] [Commented] (KAFKA-16326) Kafka Connect unable to find javax dependency on Quarkus update to 3.X

2024-03-04 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823300#comment-17823300 ] Greg Harris commented on KAFKA-16326: - Hi [~pauortegatw] ! It looks like this will require Kafka to

Re: [PR] KAFKA-16214: add client info in authentication error log [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15280: URL: https://github.com/apache/kafka/pull/15280#discussion_r1511627095 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslServer.java: ## @@ -143,7 +146,7 @@ public byte[] evaluateResponse(byte[] response)

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-04 Thread via GitHub
kirktrue commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1511613214 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -937,13 +938,14 @@ public Map committed(final Set

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-04 Thread via GitHub
kirktrue commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1511610634 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -177,7 +177,7 @@ private void process(final

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-04 Thread via GitHub
kirktrue commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1511608584 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -153,15 +154,17 @@ public void testMetadataUpdateEvent() {

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-04 Thread via GitHub
kirktrue commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1511608177 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java: ## @@ -29,8 +30,8 @@ public abstract class CommitEvent extends

Re: [PR] MINOR: add 'toString' to classes which are used by logging [kafka]

2024-03-04 Thread via GitHub
chia7712 closed pull request #10246: MINOR: add 'toString' to classes which are used by logging URL: https://github.com/apache/kafka/pull/10246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: avoid duplicate array copying from BufferValue#serialize [kafka]

2024-03-04 Thread via GitHub
chia7712 closed pull request #10171: MINOR: avoid duplicate array copying from BufferValue#serialize URL: https://github.com/apache/kafka/pull/10171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: remove unused helper methods from utils classes [kafka]

2024-03-04 Thread via GitHub
chia7712 closed pull request #10140: MINOR: remove unused helper methods from utils classes URL: https://github.com/apache/kafka/pull/10140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823286#comment-17823286 ] Chia-Ping Tsai commented on KAFKA-16310: {quote}

Re: [PR] MINOR: Upgrade Gradle wrapper to version 8.4 [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #14502: URL: https://github.com/apache/kafka/pull/14502#issuecomment-1977190321 close this PR as version of gradle is 8.6 now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Upgrade Gradle wrapper to version 8.4 [kafka]

2024-03-04 Thread via GitHub
chia7712 closed pull request #14502: MINOR: Upgrade Gradle wrapper to version 8.4 URL: https://github.com/apache/kafka/pull/14502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823280#comment-17823280 ] Jason Gustafson commented on KAFKA-16310: - [~chia7712] Thanks for the analysis. Ironically, my

Re: [PR] MINOR: Log the ZK dual-write time [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #14792: URL: https://github.com/apache/kafka/pull/14792#discussion_r1511576151 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -518,21 +518,27 @@ public void run() throws Exception {

[jira] [Commented] (KAFKA-16319) Wrong broker destinations for DeleteRecords requests when more than one topic is involved and the topics/partitions are led by different brokers

2024-03-04 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823276#comment-17823276 ] Andrew Schofield commented on KAFKA-16319: -- With an AK 3.7 client, I see that the DeleteRecords

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

2024-03-04 Thread via GitHub
clolov commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1977164414 Ah, I remember why I didn't publicize this PR when I opened it @cadonna. I believe the EasyMock/Mockito weirdness will be solved if we first merge

Re: [PR] MINOR: parameterize group-id in GroupMetadataManagerTestContext [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15467: URL: https://github.com/apache/kafka/pull/15467#discussion_r1511553088 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ## @@ -901,7 +901,7 @@ public RebalanceResult

[jira] [Assigned] (KAFKA-16319) Wrong broker destinations for DeleteRecords requests when more than one topic is involved and the topics/partitions are led by different brokers

2024-03-04 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-16319: Assignee: Andrew Schofield > Wrong broker destinations for DeleteRecords

[jira] [Assigned] (KAFKA-16227) Console consumer fails with `IllegalStateException`

2024-03-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16227: - Assignee: Bruno Cadonna (was: Philip Nee) > Console consumer fails with

[jira] [Assigned] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-03-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16224: - Assignee: Bruno Cadonna (was: Lianet Magrans) > Fix handling of deleted topic when

Re: [PR] KAFKA-14589 [3/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1511527711 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823266#comment-17823266 ] Ismael Juma edited comment on KAFKA-16310 at 3/4/24 5:31 PM: - Thanks for

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823266#comment-17823266 ] Ismael Juma commented on KAFKA-16310: - Thanks for confirming that.

Re: [PR] KAFKA-14589 [3/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1511507717 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned() should be called after joining, even if empty

2024-03-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16312: -- Priority: Critical (was: Major) > ConsumerRebalanceListener.onPartitionsAssigned() should be called

[jira] [Assigned] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned() should be called after joining, even if empty

2024-03-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16312: - Assignee: Lucas Brutschy (was: Lianet Magrans) >

Re: [PR] KAFKA-14589 [3/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1511503172 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14589 [3/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1511492912 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14589 [3/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1511471141 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
wernerdv commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1511460897 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { }

[PR] MINOR: parameterize group-id in GroupMetadataManagerTestContext [kafka]

2024-03-04 Thread via GitHub
dongnuo123 opened a new pull request, #15467: URL: https://github.com/apache/kafka/pull/15467 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Created] (KAFKA-16326) Kafka Connect unable to find javax dependency on Quarkus update to 3.X

2024-03-04 Thread Pau Ortega Puig (Jira)
Pau Ortega Puig created KAFKA-16326: --- Summary: Kafka Connect unable to find javax dependency on Quarkus update to 3.X Key: KAFKA-16326 URL: https://issues.apache.org/jira/browse/KAFKA-16326

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

2024-03-04 Thread via GitHub
jeffkbkim commented on code in PR #15447: URL: https://github.com/apache/kafka/pull/15447#discussion_r1511449004 ## raft/src/test/java/org/apache/kafka/raft/internals/TimeRatioTest.java: ## @@ -17,6 +17,7 @@ package org.apache.kafka.raft.internals; import

[jira] [Updated] (KAFKA-16313) Offline group protocol migration

2024-03-04 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16313: Summary: Offline group protocol migration (was: Offline group protocol upgrade) > Offline group

[jira] [Commented] (KAFKA-16325) Add missing producer metrics to documentation

2024-03-04 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823253#comment-17823253 ] Owen C.H. Leung commented on KAFKA-16325: - FYI: https://github.com/apache/kafka/pull/15466 >

[jira] [Assigned] (KAFKA-16325) Add missing producer metrics to documentation

2024-03-04 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen C.H. Leung reassigned KAFKA-16325: --- Assignee: Owen C.H. Leung > Add missing producer metrics to documentation >

[PR] Add missing producer monitoring metrics to doc [kafka]

2024-03-04 Thread via GitHub
Owen-CH-Leung opened a new pull request, #15466: URL: https://github.com/apache/kafka/pull/15466 ### Related Issue [KAFKA-16325](https://issues.apache.org/jira/browse/KAFKA-16325) This PR adds 4 missing producer monitoring metrics to the documentation ### Committer

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823238#comment-17823238 ] Chia-Ping Tsai commented on KAFKA-16310: {quote} It looks like the compressed case had the issue

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976786020 @chia7712 Other PR is #15465 Seems, PR's are reviewable now. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-03-04 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16185: -- Assignee: Lucas Brutschy (was: Lianet Magrans) > Fix client reconciliation of same

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976795668 Hello @mimaison @jolshan @showuon I split PR even more and now all three PR's for a command test seems pretty small. Please, take a look if you have spare cycles. #15365

[PR] KAFKA-14589 [4/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov opened a new pull request, #15465: URL: https://github.com/apache/kafka/pull/15465 This PR is part of https://github.com/apache/kafka/pull/14471 Is contains `ResetConsumerGroupOffsetTest` rewritten in java. Intention of separate PR is to reduce changes and simplify review.

Re: [PR] KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest [kafka]

2024-03-04 Thread via GitHub
Owen-CH-Leung closed pull request #15429: KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest URL: https://github.com/apache/kafka/pull/15429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976763803 @chia7712 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]

2024-03-04 Thread via GitHub
ijuma commented on code in PR #15424: URL: https://github.com/apache/kafka/pull/15424#discussion_r1511284102 ## build.gradle: ## @@ -2333,6 +2333,8 @@ project(':streams:streams-scala') { testImplementation libs.junitJupiter testImplementation libs.easymock +

Re: [PR] MINOR: Remove unused controlPlaneRequestProcessor in BrokerServer. [kafka]

2024-03-04 Thread via GitHub
appchemist commented on PR #15245: URL: https://github.com/apache/kafka/pull/15245#issuecomment-1976754065 @chia7712 Thanks for review! `controlPlaneRequestProcessor` in `BrokerServer` isn't initialized. The `controlPlaneRequestProcessor` is only referenced within the `shutdown`

[jira] [Created] (KAFKA-16325) Add missing producer metrics to documentation

2024-03-04 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-16325: Summary: Add missing producer metrics to documentation Key: KAFKA-16325 URL: https://issues.apache.org/jira/browse/KAFKA-16325 Project: Kafka Issue Type:

Re: [PR] KAFKA-14589 [2/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976745241 > If this patch to big to review I can split it to two. please :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-14589 [2/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976742412 Hello @chia7712 Please, take a look. If this patch to big to review I can split it to two. WDYT? -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976741213 > There are two separate PR's that moves tests of command to tools: oh, sorry that I did not notice that you have tried to make small PRs. will take a look later. > But, if

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976736579 > For example, we can have the new ConsumerGroupCommand supporting only list, and then describe, delete, etc. And the last PR add deprecation information and cleanup. WDYT? I

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976721113 Hello @chia7712 Yes. There are two separate PR's that moves tests of command to `tools`: https://github.com/apache/kafka/pull/15365 - pretty small (+200, -100)

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976703092 @nizhikov thanks for taking over this big issue. I'd like to give a review. However, it is a bit huge. Is it possible to split this PR into small PRs by the "command" of

[jira] [Commented] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2024-03-04 Thread Frank Grimes (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823209#comment-17823209 ] Frank Grimes commented on KAFKA-10582: -- Is this somehow related to (or better yet fixed by)

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823208#comment-17823208 ] Ismael Juma commented on KAFKA-16310: - More recent changes to LogValidator:

Re: [PR] KAFKA-16169: FencedException in commitAsync not propagated without callback [kafka]

2024-03-04 Thread via GitHub
lucasbru commented on PR #15437: URL: https://github.com/apache/kafka/pull/15437#issuecomment-1976699674 Hi @philipnee > Hi @lucasbru - Thanks for the PR. I think it would be good to test if all commit API throws the fenced exception. I believe async commit has already been tested,

Re: [PR] KAFKA-16169: FencedException in commitAsync not propagated without callback [kafka]

2024-03-04 Thread via GitHub
lucasbru commented on code in PR #15437: URL: https://github.com/apache/kafka/pull/15437#discussion_r1511245829 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -792,8 +801,8 @@ public void commitAsync(Map offsets, OffsetCo

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205 ] Ismael Juma edited comment on KAFKA-16310 at 3/4/24 2:23 PM: - By the way,

Re: [PR] KAFKA-16169: FencedException in commitAsync not propagated without callback [kafka]

2024-03-04 Thread via GitHub
lucasbru commented on code in PR #15437: URL: https://github.com/apache/kafka/pull/15437#discussion_r1511245201 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -567,6 +568,28 @@ public void

Re: [PR] MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15289: URL: https://github.com/apache/kafka/pull/15289#discussion_r1511231627 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -137,7 +137,9 @@ object TestUtils extends Logging { val parentFile = new File(parent)

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205 ] Ismael Juma edited comment on KAFKA-16310 at 3/4/24 2:13 PM: - By the way,

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823205#comment-17823205 ] Ismael Juma commented on KAFKA-16310: - By the way, the bug attribution doesn't seem completely

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-03-04 Thread via GitHub
VictorvandenHoven commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1976647985 > @VictorvandenHoven -- it seems `KStreamKStreamIntegrationTest.shouldOuterJoin` fails consistently. Can you take a look? Ouch, didn't test that one. Apparently,

Re: [PR] MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit [kafka]

2024-03-04 Thread via GitHub
gaurav-narula commented on code in PR #15289: URL: https://github.com/apache/kafka/pull/15289#discussion_r1511199142 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -137,7 +137,9 @@ object TestUtils extends Logging { val parentFile = new File(parent)

[PR] KAFKA-16322 [WIP]: upgrade jline [kafka]

2024-03-04 Thread via GitHub
johnnychhsu opened a new pull request, #15464: URL: https://github.com/apache/kafka/pull/15464 ## Context An issue in the component "GroovyEngine.execute" of jline-groovy versions through 3.24.1 allows attackers to cause an OOM (OutofMemory) error. Please refer to [this

[jira] [Comment Edited] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823200#comment-17823200 ] Mickael Maison edited comment on KAFKA-16324 at 3/4/24 1:54 PM: Ahah,

[jira] [Commented] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823200#comment-17823200 ] Mickael Maison commented on KAFKA-16324: Ahah, glad you see you back! > Move

[jira] [Commented] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823199#comment-17823199 ] Chia-Ping Tsai commented on KAFKA-16324: {quote} If you want to help out this effort, there are

[jira] [Commented] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823197#comment-17823197 ] Chia-Ping Tsai commented on KAFKA-16324: [~mimaison] thanks for sharing context. {quote} Since

[jira] [Commented] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823192#comment-17823192 ] Mickael Maison commented on KAFKA-16324: If you want to help out this effort, there are a bunch

[jira] [Commented] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823189#comment-17823189 ] Mickael Maison commented on KAFKA-16324: I don't think we want to move that tool. We had a KIP

[jira] [Commented] (KAFKA-14577) Move ConsoleProducer to tools

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823186#comment-17823186 ] Chia-Ping Tsai commented on KAFKA-14577: [~mimaison] you are right. it seems 4.0 is the only way

[PR] KAFKA-16323[WIP]: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-04 Thread via GitHub
johnnychhsu opened a new pull request, #15463: URL: https://github.com/apache/kafka/pull/15463 ## Context The test testRemoteFetchExpiresPerSecMetric is failing in CI, however it succeeds locally. I can not reproduce this failure in local. ## Solution This is still WIP,

[jira] [Commented] (KAFKA-14577) Move ConsoleProducer to tools

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823180#comment-17823180 ] Chia-Ping Tsai commented on KAFKA-14577: [~mimaison] Maybe we can rewrite the code by java

[jira] [Assigned] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-16324: - Assignee: PoAn Yang > Move BrokerApiVersionsCommand to tools >

[jira] [Created] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-03-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16324: -- Summary: Move BrokerApiVersionsCommand to tools Key: KAFKA-16324 URL: https://issues.apache.org/jira/browse/KAFKA-16324 Project: Kafka Issue Type:

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-03-04 Thread via GitHub
soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1511125756 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2790,7 +2791,6 @@ class ReplicaManager(val config: KafkaConfig, // is unavailable. This is

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823174#comment-17823174 ] Chia-Ping Tsai commented on KAFKA-16310: [~ijuma] thanks for feedback. good to know we are on

[jira] [Assigned] (KAFKA-16318) Add javadoc to KafkaMetric

2024-03-04 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnny Hsu reassigned KAFKA-16318: -- Assignee: Johnny Hsu > Add javadoc to KafkaMetric > -- > >

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16310: -- Priority: Blocker (was: Minor) > ListOffsets doesn't report the offset with maxTimestamp anymore >

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16310: -- Fix Version/s: 3.7.1 > ListOffsets doesn't report the offset with maxTimestamp anymore >

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16310: -- Description: Updated: This is confirmed a regression issue in v3.7.0. The impact of this issue is

[jira] [Assigned] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-16310: - Assignee: (was: Cheng-Kai, Zhang) > ListOffsets doesn't report the offset with

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823151#comment-17823151 ] Luke Chen commented on KAFKA-16310: --- Thanks! Please let us know when the PR is open. > ListOffsets

Re: [PR] MINOR: Remove unused controlPlaneRequestProcessor in BrokerServer. [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #15245: URL: https://github.com/apache/kafka/pull/15245#issuecomment-1976451937 @appchemist nice catch. could you share the context of why it gets unused ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on code in PR #15289: URL: https://github.com/apache/kafka/pull/15289#discussion_r1511059328 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -137,7 +137,9 @@ object TestUtils extends Logging { val parentFile = new File(parent)

Re: [PR] MINOR: simplify ensure topic exists condition [kafka]

2024-03-04 Thread via GitHub
chia7712 merged PR #15458: URL: https://github.com/apache/kafka/pull/15458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

2024-03-04 Thread via GitHub
cadonna merged PR #15426: URL: https://github.com/apache/kafka/pull/15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Updating a comment to match the code. [kafka]

2024-03-04 Thread via GitHub
chia7712 commented on PR #15388: URL: https://github.com/apache/kafka/pull/15388#issuecomment-1976383921 @appchemist thanks for the survey and contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Updating a comment to match the code. [kafka]

2024-03-04 Thread via GitHub
chia7712 merged PR #15388: URL: https://github.com/apache/kafka/pull/15388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-03-04 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1510987276 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java: ## @@ -495,6 +496,16 @@ public void subscribe(Pattern pattern) {

Re: [PR] Add Deletion Reasons in KRaft Snapshot Deletion Logging [kafka]

2024-03-04 Thread via GitHub
hni61223 commented on code in PR #15450: URL: https://github.com/apache/kafka/pull/15450#discussion_r1510985119 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -677,4 +692,20 @@ object KafkaMetadataLog extends Logging { Snapshots.deleteIfExists(logDir,

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
OmniaGM commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1510981252 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { }

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
OmniaGM commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1510969600 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { }

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-04 Thread via GitHub
cadonna commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1510930206 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -177,7 +177,7 @@ private void process(final

<    1   2   3   >