Re: [PR] MINOR: Add read/write all operation [kafka]

2024-03-04 Thread via GitHub
dajac commented on PR #15462: URL: https://github.com/apache/kafka/pull/15462#issuecomment-1976262999 @OmniaGM Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: Add read/write all operation [kafka]

2024-03-04 Thread via GitHub
dajac opened a new pull request, #15462: URL: https://github.com/apache/kafka/pull/15462 There are a few cases in the group coordinator service where we want to read from or write to each of the known coordinators (each of __consumer_offsets partitions). The current implementation needs to

Re: [PR] KAFKA-16310: ListOffsets doesn't report the offset with maxTimestamp anymore [kafka]

2024-03-04 Thread via GitHub
KevinZTW commented on PR #15461: URL: https://github.com/apache/kafka/pull/15461#issuecomment-1976256564 @showuon much thanks for helping me look into this! Base on the information on the Jira ticket, It seems that there are other developers already found the root cause and going to submit

Re: [PR] KAFKA-16310: ListOffsets doesn't report the offset with maxTimestamp anymore [kafka]

2024-03-04 Thread via GitHub
KevinZTW closed pull request #15461: KAFKA-16310: ListOffsets doesn't report the offset with maxTimestamp anymore URL: https://github.com/apache/kafka/pull/15461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

2024-03-04 Thread via GitHub
clolov commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1976222841 I will have a look today, thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-15797: Fix flaky EOS_v2 upgrade test [kafka]

2024-03-04 Thread via GitHub
cadonna commented on PR #15449: URL: https://github.com/apache/kafka/pull/15449#issuecomment-1976189411 FYI: to run only this test on Jenkins, you can replace target `test` with `streams:test` and add `--tests EosV2UpgradeIntegrationTest` to the arguments in method `doTest()` in the Jenkins

Re: [PR] KAFKA-16310: ListOffsets doesn't report the offset with maxTimestamp anymore [kafka]

2024-03-04 Thread via GitHub
showuon commented on PR #15461: URL: https://github.com/apache/kafka/pull/15461#issuecomment-1976165637 This is not an easy one. I need more time to dig into it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-03-04 Thread via GitHub
testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1976121691 @divijvaidya seem like the build is orange! https://github.com/apache/kafka/assets/445123/552aca8e-a9c3-406c-9333-7d1e928190d3";> -- This is an automated message from the Apach

Re: [PR] KAFKA-15625: Do not flush global state store at each commit [kafka]

2024-03-04 Thread via GitHub
cadonna merged PR #15361: URL: https://github.com/apache/kafka/pull/15361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15625: Do not flush global state store at each commit [kafka]

2024-03-04 Thread via GitHub
cadonna commented on PR #15361: URL: https://github.com/apache/kafka/pull/15361#issuecomment-1976090927 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-14747: record discarded FK join subscription responses [kafka]

2024-03-04 Thread via GitHub
AyoubOm commented on PR #15395: URL: https://github.com/apache/kafka/pull/15395#issuecomment-1976087470 > Thanks for the PR! Overall LGTM, but we should add a unit test for the newly added sensor. Thanks @mjsax for your review. I added tests of the dropped record sensor (I believed w

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

2024-03-04 Thread via GitHub
cadonna commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1510774397 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2403,15 +2383,18 @@ public void shouldCloseActiveTasksWhenHandlingLo

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

2024-03-04 Thread via GitHub
cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975962915 From a quick look, both PRs seem to do the same. I will try to have a look into this PR this week. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

2024-03-04 Thread via GitHub
cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975956880 > There is a `1` missing. :) I meant #13897 Ah, OK. Now it makes sense! Let me have a look! -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-15330) Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards

2024-03-04 Thread Roland Sommer (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823067#comment-17823067 ] Roland Sommer commented on KAFKA-15330: --- After the release of kafka 3.7 I reran th

<    1   2   3