[jira] [Commented] (KAFKA-16377) Fix flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2024-03-16 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827766#comment-17827766 ] Kuan Po Tseng commented on KAFKA-16377: --- I'm willing to take over this issue, many

[jira] [Assigned] (KAFKA-16377) Fix flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2024-03-16 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng reassigned KAFKA-16377: - Assignee: Kuan Po Tseng > Fix flaky > HighAvailabilityTaskAssignorIntegrationTest.shou

Re: [PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-16 Thread via GitHub
jinyongchoi commented on code in PR #15495: URL: https://github.com/apache/kafka/pull/15495#discussion_r1527410280 ## docs/streams/developer-guide/memory-mgmt.html: ## @@ -151,6 +151,10 @@ Serdes.Long()) .withCachingEnabled(); Record caches are not supported for v

Re: [PR] KAFKA-16273: Update consumer_bench_test.py to use consumer group protocol [kafka]

2024-03-16 Thread via GitHub
philipnee commented on PR #15548: URL: https://github.com/apache/kafka/pull/15548#issuecomment-2002293547 Hi @lucasbru @kirktrue - This is the ask to add consumer group protocol to the test. It should be pretty straightforward and the results are here: ``` ===

[PR] KAFKA-16273: Update consumer_bench_test.py to use consumer group protocol [kafka]

2024-03-16 Thread via GitHub
philipnee opened a new pull request, #15548: URL: https://github.com/apache/kafka/pull/15548 Adding this as part of the greater effort to modify the system tests to incorporate the use of consumer group protocol from KIP-848. Following is the test results and the tests using protocol = con

Re: [PR] KAFKA-12187: replace assertTrue(obj instanceof X) with assertInstanceOf [kafka]

2024-03-16 Thread via GitHub
chia7712 commented on PR #15512: URL: https://github.com/apache/kafka/pull/15512#issuecomment-2002292346 > should we include this one too ? yep, please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-12187: replace assertTrue(obj instanceof X) with assertInstanceOf [kafka]

2024-03-16 Thread via GitHub
chia7712 commented on code in PR #15512: URL: https://github.com/apache/kafka/pull/15512#discussion_r1527404009 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -850,7 +851,7 @@ public void testMetadataTimeoutWithMissingTopic(boolean isId

[jira] [Commented] (KAFKA-15282) Implement client support for KIP-848 client-side assignors

2024-03-16 Thread clownxc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827765#comment-17827765 ] clownxc commented on KAFKA-15282: - Hi team, if this ticket is open I will pick it up and

[jira] [Commented] (KAFKA-15551) Evaluate conditions for short circuiting consumer API calls

2024-03-16 Thread clownxc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827764#comment-17827764 ] clownxc commented on KAFKA-15551: - It seems not so difficult... Could I pick this up? >

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-16 Thread via GitHub
mjsax commented on code in PR #15510: URL: https://github.com/apache/kafka/pull/15510#discussion_r1527393681 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java: ## @@ -727,7 +801,7 @@ public void testWindowing() { } @

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-03-16 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827763#comment-17827763 ] Phuc Hong Tran commented on KAFKA-15538: [~kirktrue] regarding this comment in K

Re: [PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-16 Thread via GitHub
jinyongchoi commented on code in PR #15495: URL: https://github.com/apache/kafka/pull/15495#discussion_r1527393749 ## docs/streams/developer-guide/memory-mgmt.html: ## @@ -151,6 +151,10 @@ Serdes.Long()) .withCachingEnabled(); Record caches are not supported for v

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

2024-03-16 Thread via GitHub
mjsax commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1527393295 ## streams/src/test/java/org/apache/kafka/streams/integration/GlobalStateReprocessTest.java: ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: fix flaky EosIntegrationTest [kafka]

2024-03-16 Thread via GitHub
mjsax merged PR #15494: URL: https://github.com/apache/kafka/pull/15494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-12187: replace assertTrue(obj instanceof X) with assertInstanceOf [kafka]

2024-03-16 Thread via GitHub
brandboat commented on PR #15512: URL: https://github.com/apache/kafka/pull/15512#issuecomment-2002043253 gentle ping @chia7712, there is another case that could be replaced with assertIsntanceOf (in IntelliJ Find in files with regex `assertTrue\(\n?.*isInstance`) https://github.com/

Re: [PR] KAFKA-12187: replace assertTrue(obj instanceof X) with assertInstanceOf [kafka]

2024-03-16 Thread via GitHub
brandboat commented on code in PR #15512: URL: https://github.com/apache/kafka/pull/15512#discussion_r1527189077 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -850,7 +851,7 @@ public void testMetadataTimeoutWithMissingTopic(boolean isI

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-16 Thread via GitHub
johnnychhsu commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1527123510 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -79,9 +79,34 @@ class ListOffsetsIntegrationTest extends KafkaServerTestHarn

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-16 Thread via GitHub
johnnychhsu commented on PR #15476: URL: https://github.com/apache/kafka/pull/15476#issuecomment-2001881984 test with ``` ./gradlew clean core:test --tests kafka.log.LogSegmentTest ./gradlew clean core:test --tests kafka.log.LocalLogTest ``` and it passed -- This is an auto

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-16 Thread via GitHub
johnnychhsu commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1527119875 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition partition, I

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-16 Thread via GitHub
johnnychhsu commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1527119875 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition partition, I