[
https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15843:
---
Priority: Minor (was: Major)
> Review consumer onPartitionsAssigned called with empty parti
OmniaGM commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1543154424
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
nizhikov commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2025466888
@OmniaGM
@chia7712
@ijuma
CI seems OK for me.
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-10549:
-
Assignee: Omnia Ibrahim
> Add topic ID support to ListOffsets, OffsetForLeaders
> -
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831834#comment-17831834
]
Jun Rao edited comment on KAFKA-16310 at 3/28/24 3:04 PM:
--
[~ch
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r154312
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw, Compr
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1543121911
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##
@@ -132,9 +133,9 @@ public void testCompressDecompress(Compressio
mimaison merged PR #15614:
URL: https://github.com/apache/kafka/pull/15614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831848#comment-17831848
]
Ismael Juma commented on KAFKA-16310:
-
Perfect, thanks!
> ListOffsets doesn't repor
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1543099933
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1543099933
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831845#comment-17831845
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
Team, there are serious issues
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831837#comment-17831837
]
Ismael Juma commented on KAFKA-16310:
-
Team, there are serious issues that are fixed
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831834#comment-17831834
]
Jun Rao commented on KAFKA-16310:
-
[~chia7712] :
{quote}Did you mean that we should chan
lucasbru commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543068952
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1360,6 +1367,9 @@ public void commitSync(Map offsets, Duration
lucasbru commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543066981
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long no
lucasbru commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543063391
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -229,7 +229,11 @@ private GroupRebalanceConfig
buildRebalance
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2025290627
@Owen-CH-Leung Could you add `toString` back? It seems the test is unstable
and we need to dig in it :)
--
This is an automated message from the Apache Git Service.
To respond to the m
mjsax commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1543047190
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepareRepartitionT
lucasbru merged PR #15612:
URL: https://github.com/apache/kafka/pull/15612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chickenchickenlove commented on PR #15573:
URL: https://github.com/apache/kafka/pull/15573#issuecomment-2025128974
> Thanks for the PR. Made a pass.
Aye, i hope so. đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542822737
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542822737
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831747#comment-17831747
]
Chia-Ping Tsai commented on KAFKA-16310:
> Yes, I agree with this method. But th
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831741#comment-17831741
]
Luke Chen edited comment on KAFKA-16310 at 3/28/24 11:45 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831741#comment-17831741
]
Luke Chen commented on KAFKA-16310:
---
{quote}Did you mean that we should change the sch
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepar
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Spiridonov updated KAFKA-16382:
-
Description:
Kafka Streams (KTable) drops null values after full reset.
See
[h
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Spiridonov updated KAFKA-16382:
-
Description:
Kafka Streams (KTable) drops null values after full reset.
See
[h
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542760219
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
})
mjsax commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542738987
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -523,7 +523,17 @@ private RepartitionTopics prepareRepartitionT
FrankYang0529 opened a new pull request, #15616:
URL: https://github.com/apache/kafka/pull/15616
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
cadonna commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2024894127
@clolov That is great! Looking forward to reviewing it! I am on vacation at
the moment. Maybe I can look at it next week or the week after.
--
This is an automated message from the Apac
mimaison merged PR #15373:
URL: https://github.com/apache/kafka/pull/15373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831709#comment-17831709
]
Matthias J. Sax commented on KAFKA-16382:
-
Thanks for clarifying. Seems I did no
lucasbru commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2024835245
@philipnee Okay, thanks for creating the ticket. Not sure if it's blocker
priority though. If it's a quick thing, you could address it in this PR.
Are you going to implement Lianet
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542637640
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1675,6 +1675,15 @@ public static Map
entriesWithPrefix(Map map, String pr
return r
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831704#comment-17831704
]
Matthias J. Sax commented on KAFKA-10409:
-
I don't think anybody worked on this
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542631664
##
core/src/main/scala/kafka/zk/ZkData.scala:
##
@@ -757,8 +757,8 @@ case object ExtendedAclChangeStore extends ZkAclChangeStore
{
object ResourceZNode {
def path
[
https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831701#comment-17831701
]
Matthias J. Sax commented on KAFKA-15951:
-
Sorry for late reply. I was traveling
[
https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15951:
---
Assignee: sanghyeok An
> MissingSourceTopicException should include topic names
> -
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831702#comment-17831702
]
Ayoub Omari commented on KAFKA-16434:
-
I submitted a bug fix for this in the same PR
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542627362
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -486,7 +486,8 @@ object AclCommand extends Logging {
private def validateOperation(opts: AclCommandOpti
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari reassigned KAFKA-16434:
---
Assignee: Ayoub Omari
> ForeignKey INNER join does not unset join result when FK becomes nu
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16434:
External issue URL: (was: https://github.com/apache/kafka/pull/15615)
> ForeignKey INNER join do
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16434:
External issue URL: https://github.com/apache/kafka/pull/15615
> ForeignKey INNER join does not un
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542620928
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831700#comment-17831700
]
Janardhana Gopalachar commented on KAFKA-16344:
---
Hi [~gharris1727]Â
We tr
[
https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16407:
Affects Version/s: 3.3.2
3.2.3
3.1.2
[
https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16407:
Affects Version/s: 3.6.1
3.5.2
3.4.1
> ForeignKey IN
chia7712 commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542616917
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1460,10 +1460,8 @@ class ReplicaManager(val config: KafkaConfig,
warn("Unable to fetch data f
AyoubOm opened a new pull request, #15615:
URL: https://github.com/apache/kafka/pull/15615
This fixes both KAFKA-16407 and KAFKA-16434.
Summary of existing issues:
- We were ignoring new left record when its **previous** FK value is null
- We do not unset foreign key join res
chia7712 commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542590608
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831695#comment-17831695
]
Matthias J. Sax commented on KAFKA-16263:
-
Absolutely. If a ticket is not assign
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-16263:
---
Assignee: Kuan Po Tseng
> Add Kafka Streams docs about available listeners/callback
chia7712 commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2024745523
That’s just my two cents. It is a trivial patch but I'm fine to merge it due
to following reasons.
1. this cleanup does not burn out kafka ( In fact, I feel we do need more
cleanu
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831683#comment-17831683
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}I think the easiest way to fix t
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1542557448
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,13 +52,14 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
@Exte
OmniaGM commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487
##
server-common/src/main/java/org/apache/kafka/server/util/Utils.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1542532419
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,13 +52,14 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
@ExtendWit
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542518584
##
server-common/src/main/java/org/apache/kafka/server/util/Utils.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
aiven-anton commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1542514661
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last hear
OmniaGM commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542488524
##
server-common/src/main/java/org/apache/kafka/server/util/Utils.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542486534
##
server-common/src/main/java/org/apache/kafka/server/util/Utils.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024632660
@OmniaGM Thanks for noticing.
https://github.com/apache/kafka/pull/15614/files prepared
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
nizhikov opened a new pull request, #15614:
URL: https://github.com/apache/kafka/pull/15614
This is clean up for #15075 which renames PROP to CONFIG to make naming
consistent.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ve
OmniaGM commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487
##
server-common/src/main/java/org/apache/kafka/server/util/Utils.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
OmniaGM commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2024620566
rebased the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
OmniaGM commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024606943
@nizhikov it would be nice if we have a followup cleanup on this to change
PROP suffix to CONFIG as this seems to be the pattern for others and am doing
the same for the rest of KafkaConf
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831658#comment-17831658
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
I think the easiest way to fix
nizhikov commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2024577072
@OmniaGM
@ijuma
All comments resolved. Please, take a look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1542439635
##
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
IntegrationTestH
101 - 177 of 177 matches
Mail list logo