[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2024-04-03 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833816#comment-17833816 ] Arpit Goyal commented on KAFKA-12506: - [~kebab-mai-haddi] You can reassign this tick

Re: [PR] Test minor gh review action - this is a test PR, do not review [kafka]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #15123: URL: https://github.com/apache/kafka/pull/15123#issuecomment-2036109173 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16081 Limit number of ssl connections in brokers [kafka]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #15126: URL: https://github.com/apache/kafka/pull/15126#issuecomment-2036109157 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Commented] (KAFKA-16211) Inconsistent config values in CreateTopicsResult and DescribeConfigsResult

2024-04-03 Thread Dung Ha (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833809#comment-17833809 ] Dung Ha commented on KAFKA-16211: - My guess from reading the code is that describeTopics

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-04-03 Thread via GitHub
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2036106373 > > @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could

[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2024-04-03 Thread Aviral Srivastava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833804#comment-17833804 ] Aviral Srivastava commented on KAFKA-12506: --- [~ableegoldman] , I want to work

[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2024-04-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833758#comment-17833758 ] A. Sophie Blee-Goldman commented on KAFKA-12506: [~goyarpit] yes, it see

[jira] [Assigned] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2024-04-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12506: -- Assignee: Arpit Goyal (was: Aviral Srivastava) > Expand AdjustStream

[jira] [Commented] (KAFKA-16458) Add contains method in KeyValue store interface

2024-04-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833749#comment-17833749 ] A. Sophie Blee-Goldman commented on KAFKA-16458: This could be nice to h

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-04-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833744#comment-17833744 ] Philip Nee commented on KAFKA-16389: [^consumer.log] It seems like the consumer rec

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-03 Thread via GitHub
OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2035559842 @fvaleri, @nizhikov @mimaison just rebased the pr and addressed the feedback will wait for this one to be merged before rebasing the other pr for KafkaConfig -- This is an automated m

[jira] [Updated] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-04-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16389: --- Attachment: consumer.log > consumer_test.py’s test_valid_assignment fails with new consumer > --

[jira] [Created] (KAFKA-16469) Metadata Schema Checker

2024-04-03 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16469: Summary: Metadata Schema Checker Key: KAFKA-16469 URL: https://issues.apache.org/jira/browse/KAFKA-16469 Project: Kafka Issue Type: New Feature R

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1550393556 ## clients/src/main/java/org/apache/kafka/common/record/RecordBatch.java: ## @@ -245,4 +246,23 @@ public interface RecordBatch extends Iterable { * @return Whether

Re: [PR] KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout [kafka]

2024-04-03 Thread via GitHub
kirktrue closed pull request #15650: KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout URL: https://github.com/apache/kafka/pull/15650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout [kafka]

2024-04-03 Thread via GitHub
kirktrue opened a new pull request, #15650: URL: https://github.com/apache/kafka/pull/15650 The intention of the CompletableApplicationEvent is for a Consumer to block waiting for the event to complete. The application thread will block for the timeout, but there is not yet a consistent man

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1550273635 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-03 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1550279550 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pattern,

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1550273635 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1550271336 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -56,11 +60,38 @@ class ListOffsetsIntegrationTest extends KafkaServerTestHarnes

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1550270774 ## clients/src/main/java/org/apache/kafka/common/record/RecordBatch.java: ## @@ -245,4 +246,23 @@ public interface RecordBatch extends Iterable { * @return Wheth

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1550270383 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2035323125 > There were 69 test failures and quite a few of them related to ListOffset There is another PR (https://github.com/apache/kafka/pull/15489) encounters same error that listing offs

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-04-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833704#comment-17833704 ] Philip Nee commented on KAFKA-16389: Hi [~kirktrue] Thanks for the initial investiga

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

2024-04-03 Thread via GitHub
dongnuo123 commented on code in PR #15593: URL: https://github.com/apache/kafka/pull/15593#discussion_r1550242669 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1300,6 +1341,68 @@ public Map groupAssignment() { ))

Re: [PR] KAFKA-16359: Corrected manifest file for kafka-clients [kafka]

2024-04-03 Thread via GitHub
apoorvmittal10 commented on code in PR #15532: URL: https://github.com/apache/kafka/pull/15532#discussion_r1550228079 ## build.gradle: ## @@ -1435,10 +1454,10 @@ project(':clients') { implementation libs.opentelemetryProto // libraries which should be added as runtim

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-03 Thread via GitHub
OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2035219431 > @OmniaGM I think this is almost ready, but there are a couple of minor comments to address and some conflicts to fix. Will be addressing this soon after another pr -- This is

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-04-03 Thread via GitHub
lianetm commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1550191029 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -808,16 +808,55 @@ class PlaintextConsumerTest extends BaseConsumerTest { @Paramete

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2035199919 Hi @chia7712 @omkreddy I have delayed backporting either change to 3.6 as we're currently in an ongoing release. If you'd like me to backport it now, I can do that. -- This is an a

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-03 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2035194359 Hey @Phuc-Hong-Tran, thanks for the updates! Left some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-04-03 Thread via GitHub
OmniaGM commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2035191271 > @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could y

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-03 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1550178486 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pattern,

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2035163301 @gharris1727 @omkreddy #15597 and this one have backported to 3.7. see https://github.com/apache/kafka/commit/d9674c6c9a99c0d8a9c32386b0cceaceac92969c and https://github.com/apa

Re: [PR] KAFKA-16439: Update replication_replica_failure_test.py to support KIP-848’s group protocol config [kafka]

2024-04-03 Thread via GitHub
wcarlson5 merged PR #15629: URL: https://github.com/apache/kafka/pull/15629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-16440: Update security_test.py to support KIP-848’s group protocol config [kafka]

2024-04-03 Thread via GitHub
wcarlson5 merged PR #15628: URL: https://github.com/apache/kafka/pull/15628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-16438: Update consumer_test.py’s static tests to support KIP-848’s group protocol config [kafka]

2024-04-03 Thread via GitHub
wcarlson5 merged PR #15627: URL: https://github.com/apache/kafka/pull/15627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-16275: Update kraft_upgrade_test.py to support KIP-848’s group protocol config [kafka]

2024-04-03 Thread via GitHub
wcarlson5 merged PR #15626: URL: https://github.com/apache/kafka/pull/15626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2024-04-03 Thread via GitHub
florin-akermann commented on PR #15189: URL: https://github.com/apache/kafka/pull/15189#issuecomment-2035119703 Hi @mjsax , thanks for the flag. Yes I'll push the necessary changes by the end of the week (Sunday). I hope that's ok. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-04-03 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1550094782 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -808,16 +808,55 @@ class PlaintextConsumerTest extends BaseConsumerTest { @Parame

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1550055646 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp == L

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-03 Thread via GitHub
fvaleri commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2035032922 @OmniaGM I think this is almost ready, but there are a couple of minor comments to address and some conflicts to fix. -- This is an automated message from the Apache Git Service. To res

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034976891 I'll handle the backports later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
omkreddy commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034952210 lets also merge to 3.7 and 3.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r1549916567 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-03 Thread via GitHub
soarez commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r1549909706 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -623,9 +623,12 @@ class BrokerServer( } } - override def shutdown(): Unit = { + override def sh

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-03 Thread via GitHub
soarez commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r1549909351 ## core/src/main/scala/kafka/server/KafkaBroker.scala: ## @@ -93,6 +93,7 @@ trait KafkaBroker extends Logging { def startup(): Unit def awaitShutdown(): Unit de

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-03 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1549895965 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -159,6 +160,224 @@ class PlaintextConsumerTest extends BaseConsumerTest { consumeAn

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-04-03 Thread via GitHub
lianetm commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2034772501 Hey @philipnee, thanks for the updates, just one minor comment left above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-04-03 Thread via GitHub
lianetm commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1549857291 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -808,16 +808,55 @@ class PlaintextConsumerTest extends BaseConsumerTest { @Paramete

Re: [PR] KAFKA-16070: move setReadOnly to Headers [kafka]

2024-04-03 Thread via GitHub
LiangliangSui closed pull request #15097: KAFKA-16070: move setReadOnly to Headers URL: https://github.com/apache/kafka/pull/15097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549840889 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -177,6 +201,78 @@ class RaftManagerTest { assertFalse(fileLocked(lockPath)) } + @Test +

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on PR #15648: URL: https://github.com/apache/kafka/pull/15648#issuecomment-2034709602 I'm going to work on a ducktape test as well. Hopefully I can get that done today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549818474 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -420,6 +420,12 @@ class KafkaServer( isZkBroker = true, logManager.directoryIdsSet

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549817561 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -69,6 +69,36 @@ object KafkaRaftManager { lock } + + /** + * Obtain the file lock and delete the

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549817561 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -69,6 +69,36 @@ object KafkaRaftManager { lock } + + /** + * Obtain the file lock and delete the

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549813667 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -389,7 +389,12 @@ class NodeToControllerRequestThread( debug("Controller isn't cac

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549786977 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -420,6 +420,12 @@ class KafkaServer( isZkBroker = true, logManager.directoryIdsSet

[jira] [Updated] (KAFKA-16468) Listener not found error in SendRPCsToBrokersEvent

2024-04-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16468: - Description: During the ZK to KRaft migration, the controller will send RPCs to the ZK brokers

[jira] [Updated] (KAFKA-16468) Listener not found error in SendRPCsToBrokersEvent

2024-04-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16468: - Description: During the ZK to KRaft migration, the controller will send RPCs to the ZK brokers

[jira] [Created] (KAFKA-16468) Listener not found error in SendRPCsToBrokersEvent

2024-04-03 Thread David Arthur (Jira)
David Arthur created KAFKA-16468: Summary: Listener not found error in SendRPCsToBrokersEvent Key: KAFKA-16468 URL: https://issues.apache.org/jira/browse/KAFKA-16468 Project: Kafka Issue Type

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r1549747480 ## core/src/main/scala/kafka/server/KafkaBroker.scala: ## @@ -93,6 +93,7 @@ trait KafkaBroker extends Logging { def startup(): Unit def awaitShutdown(): Unit

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-03 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1549736126 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends SaslSslAdminIntegrationTe

[jira] [Commented] (KAFKA-13907) Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

2024-04-03 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833568#comment-17833568 ] Igor Soarez commented on KAFKA-13907: - [~chia7712] I've re-opened and updated the PR

[PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-03 Thread via GitHub
soarez opened a new pull request, #12174: URL: https://github.com/apache/kafka/pull/12174 When a controlled shutdown is requested the broker tries to communicate the state change to the controller via a heartbeat request. [1] In this test, the controller is not available so the reques

[jira] [Commented] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2024-04-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833566#comment-17833566 ] Chia-Ping Tsai commented on KAFKA-6527: --- loop the tests 300 times, and all pass. we

[jira] [Resolved] (KAFKA-16413) Add tests for FileLock

2024-04-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16413. Fix Version/s: 3.8.0 Resolution: Fixed > Add tests for FileLock > -

Re: [PR] KAFKA-16413: add FileLockTest [kafka]

2024-04-03 Thread via GitHub
chia7712 merged PR #15624: URL: https://github.com/apache/kafka/pull/15624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16413: add FileLockTest [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15624: URL: https://github.com/apache/kafka/pull/15624#issuecomment-2034576975 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests JmxToolTest.initializationError :connect:runtime:test --tests or

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-03 Thread via GitHub
soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1549709937 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(brokerI

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-03 Thread via GitHub
gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1549695928 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034397405 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful :connect:runtime:test --tests org.apache.kafka.connect.integration.ExactlyOnc

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 merged PR #15639: URL: https://github.com/apache/kafka/pull/15639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-03 Thread via GitHub
OmniaGM commented on code in PR #15335: URL: https://github.com/apache/kafka/pull/15335#discussion_r1549552216 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -289,13 +289,17 @@ class BrokerMetadataPublisher( try { // Start log manag

Re: [PR] KAFKA-16457 Useless import class [kafka]

2024-04-03 Thread via GitHub
chia7712 merged PR #15646: URL: https://github.com/apache/kafka/pull/15646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16467) Add README to docs folder

2024-04-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833498#comment-17833498 ] Chia-Ping Tsai commented on KAFKA-16467: Have you checked the option1? not sure

[jira] [Commented] (KAFKA-16430) The group-metadata-manager thread is always in a loading state and occupies one CPU, unable to end.

2024-04-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833497#comment-17833497 ] Chia-Ping Tsai commented on KAFKA-16430: {quote} what you mean? Is the newer ka

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2034230452 the failed tests pass on my local. ``` ./gradlew cleanTest :streams:test --tests SlidingWindowedKStreamIntegrationTest.shouldRestoreAfterJoinRestart :storage:test --tests Transact

Kafka capabilities

2024-04-03 Thread Kafka Life
Hi Kafka users Does any one have a document or ppt that showcases the capabilities of Kafka along with any cost management capability? i have a customer who is still using IBM MQM and rabbit MQ. I want the client to consider kafka for messaging and data streaming. I wanted to seek your expert help

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-04-03 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2034128217 @divijvaidya can you also have a look at this once https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-12399: Deprecate Log4J Appender [kafka]

2024-04-03 Thread via GitHub
mimaison commented on PR #10244: URL: https://github.com/apache/kafka/pull/10244#issuecomment-2034028295 Yes ideally we need the deprecation to go in 3.8 so we can delete the appender in 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-03 Thread via GitHub
soarez commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1549319336 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -420,6 +420,12 @@ class KafkaServer( isZkBroker = true, logManager.directoryIdsSet

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-04-03 Thread via GitHub
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2034010084 @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could you

Re: [PR] KAFKA-16359: Corrected manifest file for kafka-clients [kafka]

2024-04-03 Thread via GitHub
showuon commented on code in PR #15532: URL: https://github.com/apache/kafka/pull/15532#discussion_r1549312174 ## build.gradle: ## @@ -1435,10 +1454,10 @@ project(':clients') { implementation libs.opentelemetryProto // libraries which should be added as runtime depen