showuon merged PR #15801:
URL: https://github.com/apache/kafka/pull/15801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15801:
URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076455539
The thread leaking failed tests disappeared now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840664#comment-17840664
]
Stanislav Spiridonov commented on KAFKA-16585:
--
# I can use the regular Pro
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840652#comment-17840652
]
Anil Dasari edited comment on KAFKA-16603 at 4/25/24 5:04 AM:
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840652#comment-17840652
]
Anil Dasari commented on KAFKA-16603:
-
Issue is because of out of order acks. So, No
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840639#comment-17840639
]
Matthias J. Sax commented on KAFKA-16584:
-
Yes, it does required to write code.
github-actions[bot] commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-2076286592
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on code in PR #15801:
URL: https://github.com/apache/kafka/pull/15801#discussion_r1578771823
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -171,8 +162,8 @@ private String[] getArgs(Stri
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840631#comment-17840631
]
dujian commented on KAFKA-16584:
hello [~mjsax]
I would like to confirm whether this
FrankYang0529 commented on PR #15801:
URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076141433
@chia7712, thanks for the hotfix. I'm very sorry for the inconvenient. The
fix LGTM. It's better to use try-with-resource to close resource. Thanks.
--
This is an automated messag
chia7712 commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2076135599
> It looks like the previous CI build had an issue with the Java 8/Scala
2.12 pipeline. I rekicked a build.
The root cause is that some services are not closed. I file a PR (#15801
chia7712 opened a new pull request, #15801:
URL: https://github.com/apache/kafka/pull/15801
Some services are not closed, so our CI print following error.
```
org.opentest4j.AssertionFailedError: Found 16 unexpected threads during
@BeforeAll: `kafka-admin-client-thread |
adminclient-2
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16610.
-
Resolution: Resolved
> Replace "Map#entrySet#forEach" by "Map#forEach"
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16610:
Fix Version/s: 3.8.0
> Replace "Map#entrySet#forEach" by "Map#forEach"
> -
soarez merged PR #15795:
URL: https://github.com/apache/kafka/pull/15795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
showuon commented on PR #15796:
URL: https://github.com/apache/kafka/pull/15796#issuecomment-2076114639
@TaiJuWu , thanks for the PR. One comment:
Could you left a comment in this PR to mention you're going to take it over?
https://github.com/apache/kafka/pull/13953 . Otherwise, it's a du
Luke Chen created KAFKA-16617:
-
Summary: Add KRaft info for the `advertised.listeners` doc
description
Key: KAFKA-16617
URL: https://issues.apache.org/jira/browse/KAFKA-16617
Project: Kafka
Issu
jolshan merged PR #15739:
URL: https://github.com/apache/kafka/pull/15739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #15685:
URL: https://github.com/apache/kafka/pull/15685#issuecomment-2076088235
Separately I need to fix the update tool. It will always say the finalized
version is 0 if the tool knows of the feature, even if the broker doesn't
include it in the list of finalized fe
jolshan commented on PR #15685:
URL: https://github.com/apache/kafka/pull/15685#issuecomment-2076086916
I've cleaned up the code to not set the record in the storage tool when the
version is 0. I also cleaned up the log since it is not always the case that
the controller doesn't know the ve
kirktrue commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1578634103
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def __init__(
[
https://issues.apache.org/jira/browse/KAFKA-16164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang reassigned KAFKA-16164:
Assignee: Alyssa Huang
> Pre-Vote
>
>
> Key: KAFKA-16164
>
Alyssa Huang created KAFKA-16616:
Summary: refactor mergeWith in MetadataSnapshot
Key: KAFKA-16616
URL: https://issues.apache.org/jira/browse/KAFKA-16616
Project: Kafka
Issue Type: Improvemen
TaiJuWu commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2076019523
> @TaiJuWu thanks for this contribution. btw, is this check (
>
>
https://github.com/apache/kafka/blob/81c222e9779c3339aa139ab930a74aba2c7c8685/core/src/test/java/kafka/test/junit/C
[
https://issues.apache.org/jira/browse/KAFKA-15924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840596#comment-17840596
]
Igor Soarez commented on KAFKA-15924:
-
Another instance:
{code:java}
org.opentest
[
https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840595#comment-17840595
]
Igor Soarez commented on KAFKA-15146:
-
Another instance
https://ci-builds.apache.or
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1578597252
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -123,8 +123,7 @@ private void processClusterTemplate(ExtensionContext
context, ClusterTemplat
TaiJuWu opened a new pull request, #15800:
URL: https://github.com/apache/kafka/pull/15800
As title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (includ
kirktrue commented on PR #15799:
URL: https://github.com/apache/kafka/pull/15799#issuecomment-2075814568
@lucasbru—would you mind taking a look at this change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
kirktrue opened a new pull request, #15799:
URL: https://github.com/apache/kafka/pull/15799
The format of the 'describe topic' output was changed as part of KAFKA-15585
which required an update in the parsing logic used by system tests.
### Committer Checklist (excluded from commit me
chia7712 commented on code in PR #15797:
URL: https://github.com/apache/kafka/pull/15797#discussion_r1578498362
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfigs.java:
##
@@ -47,7 +47,7 @@
* controller should be able to transition from standby to active without
reload
Dongnuo Lyu created KAFKA-16615:
---
Summary: JoinGroup API for upgrading ConsumerGroup
Key: KAFKA-16615
URL: https://issues.apache.org/jira/browse/KAFKA-16615
Project: Kafka
Issue Type: Sub-task
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16614:
--
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> Disallow `@ClusterTemplate("")`
>
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840545#comment-17840545
]
TaiJuWu commented on KAFKA-16614:
-
Hello [~chia7712] , Could you assign this ticket to m
lianetm commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1578381540
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def __init__(s
Chia-Ping Tsai created KAFKA-16614:
--
Summary: Disallow `@ClusterTemplate("")`
Key: KAFKA-16614
URL: https://issues.apache.org/jira/browse/KAFKA-16614
Project: Kafka
Issue Type: Improvement
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
chia7712 commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075606243
> It looks like the previous CI build had an issue with the Java 8/Scala
2.12 pipeline. I rekicked a build.
oh, I rekicked it too :_
--
This is an automated message from the Apa
OmniaGM opened a new pull request, #15797:
URL: https://github.com/apache/kafka/pull/15797
For context
https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075595461
> > > Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
>
> > This is good point, maybe this can be a followup PR
>
> After
TaiJuWu opened a new pull request, #15796:
URL: https://github.com/apache/kafka/pull/15796
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (includi
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578348187
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java:
##
@@ -40,6 +40,7 @@
import static org.apache.kafka.common.requests.ProduceResponse.INVA
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578346148
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
mimaison commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075580384
It looks like the previous CI build had an issue with the Java 8/Scala 2.12
pipeline. I rekicked a build.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16613.
Fix Version/s: 3.8.0
Resolution: Fixed
> Remove TestUtils#subscribeAndWaitForRecord
chia7712 merged PR #15794:
URL: https://github.com/apache/kafka/pull/15794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075537428
Thanks @CalvinConfluent I will try to take a look sometime today 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
CalvinConfluent commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075521654
@jolshan Updated the PR
1. Reverted the KafkaApi changes. Now if the produce request with the
TransactionV2 supported version, the server will process it no matter what
Transac
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578298683
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(
.setTransactionalId(transa
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578296803
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -402,6 +412,30 @@ public synchronized void maybeAddPartition
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075392820
>> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
> This is good point, maybe this can be a followup PR
After renaming
dajac commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075368110
@jolshan That makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075357578
> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
This is good point, maybe this can be a followup PR
--
This is an automated
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075356299
> It seems org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.KafkaConfig won't happen if the 5 getters are
moved, right?
Sorry I maybe wan't clear `org.ap
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
> I don't think we should merge them with RaftConfig as RaftConfig should be
separate as it is only for the quorum raft and not KRAFT mode which are a bit
different in my option.
jolshan commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075323626
Hey @dajac thanks for taking a look. We didn't include
https://github.com/apache/kafka/commit/a8203f9c7a2c449ee59ee29d775409b2f1e00d07
in 3.7 so I feel like adding this code is extraneou
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840502#comment-17840502
]
Calvin Liu commented on KAFKA-16217:
[~kirktrue] The cherry-pick for the 3.7 is merg
[
https://issues.apache.org/jira/browse/KAFKA-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reopened KAFKA-15743:
---
The {{registerBroker}} function in this test file needs to use the directory
UUIDs assi
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075295917
> KafkaConfig will move out of core and into server, however, for the time
being I don't plan to make raft depend on server for now as far as I can see
the only case I might need to do s
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075270699
> > If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.
chia7712 commented on PR #15696:
URL: https://github.com/apache/kafka/pull/15696#issuecomment-2075243743
> Thanks for the reply. I have tried the following code and received the
results. Each time I run the code, the DescribeTopicsResult gives a different
configurations of the brokers in my
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075158081
> If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.K
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840472#comment-17840472
]
Jakub Scholz commented on KAFKA-16606:
--
Ok, thanks [~soarez] and [~mimaison].
> JB
chia7712 merged PR #15792:
URL: https://github.com/apache/kafka/pull/15792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075131518
> just curios. Why moving to raft module can cause circle dependencies?
Currently raft doesn't depend of core or server but I just fear that mixing
quorum raft and KRaft mode related cl
chia7712 commented on PR #15791:
URL: https://github.com/apache/kafka/pull/15791#issuecomment-2075129365
not sure whether we have 3.6.3 release. It seems we don't have `.3` usually
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reopened KAFKA-16606:
-
Assignee: Igor Soarez
> JBOD support in KRaft does not seem to be gated by the metadata versio
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840469#comment-17840469
]
Igor Soarez commented on KAFKA-16606:
-
I'm inclined to agree, I think we can still d
chia7712 merged PR #15793:
URL: https://github.com/apache/kafka/pull/15793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577998958
##
tests/kafkatest/tests/core/zookeeper_migration_test.py:
##
@@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False,
downgrade_to_zk = False):
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577997204
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -463,6 +463,18 @@ def reconfigure_zk_for_migration(self, kraft_quorum):
# This is not added to "advertised.lis
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: (was: Owen C.H. Leung)
> Remove dependency on Reflections
>
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075082750
> Personally I think the first option (which keep the pr as it is) is easier
to navigate as we know where all the config used by Kafka Raft server (maybe
renaming this to KafkaRaftServer
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: Owen C.H. Leung
> Remove dependency on Reflections
> ---
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2075021540
thanks for the review and suggestions @chia7712 @OmniaGM
let me check and address it
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074952186
> > Note: We have already RaftConfig but it seems to contain limited amount
of configs that only configure controller raft and shouldn't include configs
shared by both broker/controller i
[
https://issues.apache.org/jira/browse/KAFKA-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840439#comment-17840439
]
Walter Hernandez commented on KAFKA-15749:
--
PR is officially stale: [https://gi
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577874954
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerRunnable.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074923817
@brandboat Could you rebase code to trigger QA again? I run those tests on
my local. They pass
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/KAFKA-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16592.
Fix Version/s: 3.8.0
Resolution: Fixed
> ConfigKey constructor update can break cli
chia7712 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2074861414
I don't see any related failure, so I'm going to merge it to trunk and
branch 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074832899
What about moving `KRaftConfig` to raft module? and we can moving all
configs from `RaftConfig` to `KRaftConfig`. With those changes, all
raft-related configs are in `KRaftConfig`. `Raft
FrankYang0529 opened a new pull request, #15794:
URL: https://github.com/apache/kafka/pull/15794
After https://github.com/apache/kafka/pull/15679, we remove most of usage of
`TestUtils#subscribeAndWaitForRecords`. The only remaining case uses it is
`PlaintextAdminIntegrationTest#testDeleteC
PoAn Yang created KAFKA-16613:
-
Summary: Remove TestUtils#subscribeAndWaitForRecords
Key: KAFKA-16613
URL: https://issues.apache.org/jira/browse/KAFKA-16613
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840402#comment-17840402
]
Luke Chen commented on KAFKA-16612:
---
[~cmccabe] , any thoughts about this?
> Talking
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: (was: Luke Chen)
> Talking to controllers via AdminClient requires reconfiguring
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: Luke Chen
> Talking to controllers via AdminClient requires reconfiguring controller
Gantigmaa Selenge created KAFKA-16612:
-
Summary: Talking to controllers via AdminClient requires
reconfiguring controller listener
Key: KAFKA-16612
URL: https://issues.apache.org/jira/browse/KAFKA-16612
chia7712 merged PR #15679:
URL: https://github.com/apache/kafka/pull/15679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16483.
Fix Version/s: 3.8.0
Resolution: Fixed
> Apply `ClusterTestExtensions` to
> Delete
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16610:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Replace "Map#entrySet#forEach" by "Map
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840392#comment-17840392
]
TengYao Chi commented on KAFKA-16610:
-
I can handle this issue :)
> Replace "Map#en
1 - 100 of 129 matches
Mail list logo