Re: [PR] MINOR: Rename `Record` to `CoordinatorRecord` [kafka]

2024-05-14 Thread via GitHub
chia7712 merged PR #15949: URL: https://github.com/apache/kafka/pull/15949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on PR #15958: URL: https://github.com/apache/kafka/pull/15958#issuecomment-2111632709 ``` [2024-05-15T01:51:49.255Z] > Task :core:compileScala [2024-05-15T01:51:49.255Z] [Error]

Re: [PR] MINOR: rewrite TopicBasedRemoteLogMetadataManagerTest by ClusterTestE… [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on PR #15917: URL: https://github.com/apache/kafka/pull/15917#issuecomment-2111631318 @showuon Please take a look if you have free time. I'd like to migrate all tests of storage to new test infra after this PR gets merged. -- This is an automated message from the

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-14 Thread via GitHub
chia7712 merged PR #15885: URL: https://github.com/apache/kafka/pull/15885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Fix TargetAssignmentBuilderBenchmark [kafka]

2024-05-14 Thread via GitHub
chia7712 merged PR #15950: URL: https://github.com/apache/kafka/pull/15950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Fix warnings in streams javadoc [kafka]

2024-05-14 Thread via GitHub
chia7712 merged PR #15955: URL: https://github.com/apache/kafka/pull/15955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-16763) Upgrade to scala 2.12.19 and scala 2.13.14

2024-05-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16763: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Upgrade to scala 2.12.19 and scala 2.13.14 >

[jira] [Resolved] (KAFKA-16671) Revisit SessionedProtocolIntegrationTest.ensureInternalEndpointIsSecured

2024-05-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16671. Fix Version/s: 3.8.0 Resolution: Fixed > Revisit

Re: [PR] KAFKA-16671: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-14 Thread via GitHub
chia7712 merged PR #15868: URL: https://github.com/apache/kafka/pull/15868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-16764: New consumer should throw InvalidTopicException on poll … [kafka]

2024-05-14 Thread via GitHub
appchemist opened a new pull request, #15961: URL: https://github.com/apache/kafka/pull/15961 - If any non-retriable exceptions were encountered during metadata update, clear and throw the exception in new consumer.poll. (like legacy consumer) - If an invalid topic is discovered in

[jira] [Commented] (KAFKA-16764) New consumer should throw InvalidTopicException on poll when invalid topic in metadata

2024-05-14 Thread appchemist (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846483#comment-17846483 ] appchemist commented on KAFKA-16764: Hi [~lianetm]    I would like to take this issue > New

Re: [PR] KAFKA-15050: format the prompts in the quickstart [kafka]

2024-05-14 Thread via GitHub
joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-2111521992 @tombentley @flavray I have addressed all the comments, can we merge this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: update leaderAndEpoch before initializing metadata publishers [kafka]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #15366: URL: https://github.com/apache/kafka/pull/15366#issuecomment-2111516055 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]

2024-05-14 Thread via GitHub
m1a2st commented on PR #15958: URL: https://github.com/apache/kafka/pull/15958#issuecomment-2111504233 @chia7712, This PR please take a look, Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [DO NOT MERGE] KIP-924 rack info API option 1: add #taskIdToPartitionsRackIds and PartitionRackIds [kafka]

2024-05-14 Thread via GitHub
ableegoldman opened a new pull request, #15960: URL: https://github.com/apache/kafka/pull/15960 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [DO NOT MERGE] KIP-924 rack info API option 2: introduce TaskInfo with complete task metadata [kafka]

2024-05-14 Thread via GitHub
ableegoldman opened a new pull request, #15959: URL: https://github.com/apache/kafka/pull/15959 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-16765) NioEchoServer leaks accepted SocketChannel instances due to race condition

2024-05-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846475#comment-17846475 ] Greg Harris commented on KAFKA-16765: - This is also a bug in EchoServer:

[jira] [Updated] (KAFKA-16768) SocketServer leaks accepted SocketChannel instances due to race condition

2024-05-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16768: Description: The SocketServer has threads for Acceptors and Processors. These threads

[jira] [Created] (KAFKA-16768) SocketServer leaks accepted SocketChannel instances due to race condition

2024-05-14 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16768: --- Summary: SocketServer leaks accepted SocketChannel instances due to race condition Key: KAFKA-16768 URL: https://issues.apache.org/jira/browse/KAFKA-16768 Project:

[jira] [Commented] (KAFKA-16763) Upgrade to scala 2.12.19 and scala 2.13.14

2024-05-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846471#comment-17846471 ] 黃竣陽 commented on KAFKA-16763: - I will handle this issue. > Upgrade to scala 2.12.19 and scala 2.13.14 >

Re: [PR] KAFKA-15045: (KIP-924 pt. 3) Implement KafkaStreamsAssignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #15944: URL: https://github.com/apache/kafka/pull/15944#issuecomment-2111377214 Merged to trunk. I'll update the KIP and send out a notice about the change from interface to class and the new APIs -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-15045: (KIP-924 pt. 3) Implement KafkaStreamsAssignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman merged PR #15944: URL: https://github.com/apache/kafka/pull/15944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15045: (KIP-924 pt. 3) Implement KafkaStreamsAssignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #15944: URL: https://github.com/apache/kafka/pull/15944#issuecomment-2111376581 The test env seems pretty unstable right now but we have at least one clean build for each java version if you look at the two latest runs. All test failures are unrelated as well.

Re: [PR] KAFKA-15045: (KIP-924 pt. 2) Implement ApplicationState and KafkaStreamsState [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #15920: URL: https://github.com/apache/kafka/pull/15920#issuecomment-2111374003 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-15045: (KIP-924 pt. 2) Implement ApplicationState and KafkaStreamsState [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #15920: URL: https://github.com/apache/kafka/pull/15920#issuecomment-2111373393 The test env seems pretty unstable right now but we have at least one clean build for each java version if you look at the two latest runs. All test failures are unrelated as well.

Re: [PR] KAFKA-15045: (KIP-924 pt. 2) Implement ApplicationState and KafkaStreamsState [kafka]

2024-05-14 Thread via GitHub
ableegoldman merged PR #15920: URL: https://github.com/apache/kafka/pull/15920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846467#comment-17846467 ] A. Sophie Blee-Goldman edited comment on KAFKA-16361 at 5/15/24 12:24 AM:

[jira] [Commented] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846467#comment-17846467 ] A. Sophie Blee-Goldman commented on KAFKA-16361: Thanks, I think it's safe to say this

[jira] [Updated] (KAFKA-15170) CooperativeStickyAssignor cannot adjust assignment correctly

2024-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-15170: --- Fix Version/s: 3.8.0 3.7.1 > CooperativeStickyAssignor

[jira] [Resolved] (KAFKA-15170) CooperativeStickyAssignor cannot adjust assignment correctly

2024-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-15170. Resolution: Fixed > CooperativeStickyAssignor cannot adjust assignment

Re: [PR] KAFKA-15170: CooperativeStickyAssignor may fail adjust assignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #13965: URL: https://github.com/apache/kafka/pull/13965#issuecomment-2111359637 Merged to trunk and cherrypicked back to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16277: AbstractStickyAssignor - Sort owned TopicPartitions by partition when reassigning [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #15416: URL: https://github.com/apache/kafka/pull/15416#issuecomment-2111358899 FYI I cherrypicked this back to 3.7 while cherrypicking back another sticky assignor fix. Should be in the 3.7.1 release -- This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2024-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-16277: --- Fix Version/s: 3.7.1 > CooperativeStickyAssignor does not spread topics

Re: [PR] KAFKA-15170: CooperativeStickyAssignor may fail adjust assignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman merged PR #13965: URL: https://github.com/apache/kafka/pull/13965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15170: CooperativeStickyAssignor may fail adjust assignment [kafka]

2024-05-14 Thread via GitHub
ableegoldman commented on PR #13965: URL: https://github.com/apache/kafka/pull/13965#issuecomment-2111341726 Test failures are unrelated, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-14 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1600781735 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## Review Comment: I added a test to `AsyncKafkaConsumerTest`.

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-14 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1600781636 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## Review Comment: Oh, the code definitely has smells! 

Re: [PR] improve log description of QuorumController [kafka]

2024-05-14 Thread via GitHub
chickenchickenlove commented on code in PR #15926: URL: https://github.com/apache/kafka/pull/15926#discussion_r160061 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(

Re: [PR] KAFKA-16757: Fix broker re-registration issues around MV 3.7-IV2 [kafka]

2024-05-14 Thread via GitHub
gaurav-narula commented on code in PR #15945: URL: https://github.com/apache/kafka/pull/15945#discussion_r1600768789 ## metadata/src/test/java/org/apache/kafka/image/publisher/BrokerRegistrationTrackerTest.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-14 Thread via GitHub
junrao commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1600483273 ## clients/src/test/java/org/apache/kafka/common/compress/GzipCompressionTest.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-16764) New consumer should throw InvalidTopicException on poll when invalid topic in metadata

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16764: -- Fix Version/s: 3.8.0 > New consumer should throw InvalidTopicException on poll when invalid topic in

[jira] [Created] (KAFKA-16767) KRaft should track HWM outside the log layer

2024-05-14 Thread Jira
José Armando García Sancio created KAFKA-16767: -- Summary: KRaft should track HWM outside the log layer Key: KAFKA-16767 URL: https://issues.apache.org/jira/browse/KAFKA-16767 Project:

[jira] [Commented] (KAFKA-16637) AsyncKafkaConsumer removes offset fetch responses from cache too aggressively

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846446#comment-17846446 ] Lianet Magrans commented on KAFKA-16637: Hey [~chickenchickenlove], sorry I had missed your last

[jira] [Updated] (KAFKA-16766) New consumer offsetsForTimes timeout exception does not have the proper message

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16766: --- Description: If a call to consumer.offsetsForTimes times out, the new AsyncKafkaConsumer

[jira] [Created] (KAFKA-16766) New consumer offsetsForTimes timeout exception does not have the proper message

2024-05-14 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16766: -- Summary: New consumer offsetsForTimes timeout exception does not have the proper message Key: KAFKA-16766 URL: https://issues.apache.org/jira/browse/KAFKA-16766

[jira] [Created] (KAFKA-16765) NioEchoServer leaks accepted SocketChannel instances due to race condition

2024-05-14 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16765: --- Summary: NioEchoServer leaks accepted SocketChannel instances due to race condition Key: KAFKA-16765 URL: https://issues.apache.org/jira/browse/KAFKA-16765 Project:

[jira] [Updated] (KAFKA-16764) New consumer should throw InvalidTopicException on poll when invalid topic in metadata

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16764: --- Description: A call to consumer.poll should throw InvalidTopicException if an invalid topic

[jira] [Created] (KAFKA-16764) New consumer should throw InvalidTopicException on poll when invalid topic in metadata

2024-05-14 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16764: -- Summary: New consumer should throw InvalidTopicException on poll when invalid topic in metadata Key: KAFKA-16764 URL: https://issues.apache.org/jira/browse/KAFKA-16764

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-14 Thread via GitHub
gharris1727 commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1600452206 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -116,6 +125,71 @@ public void start(Map props) {

Re: [PR] KAFKA-16762: SyncGroup API for upgrading ConsumerGroup [kafka]

2024-05-14 Thread via GitHub
dajac commented on code in PR #15954: URL: https://github.com/apache/kafka/pull/15954#discussion_r1600493799 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3898,6 +3994,65 @@ public CoordinatorResult classicGroupSync(

Re: [PR] MINOR: Add classic member session timeout to ClassicMemberMetadata [kafka]

2024-05-14 Thread via GitHub
dajac merged PR #15921: URL: https://github.com/apache/kafka/pull/15921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: revisit LogValidatorTest#checkRecompression [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on PR #15948: URL: https://github.com/apache/kafka/pull/15948#issuecomment-2110831638 @junrao thanks for all your reviews :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16649: Remove lock from DynamicBrokerConfig.removeReconfigurable [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on PR #15838: URL: https://github.com/apache/kafka/pull/15838#issuecomment-2110829824 > The new test seems to be failing: [testReduceNumNetworkThreads() –

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on PR #15885: URL: https://github.com/apache/kafka/pull/15885#issuecomment-2110828020 > looks like we still suffer from thread leaks in CI :( I've rebased from trunk to trigger CI again I have noticed that too. so sad :( -- This is an automated message from the

Re: [PR] MINOR: revisit LogValidatorTest#checkRecompression [kafka]

2024-05-14 Thread via GitHub
junrao commented on code in PR #15948: URL: https://github.com/apache/kafka/pull/15948#discussion_r1600406699 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -497,9 +497,11 @@ class LogValidatorTest { assertEquals(now + 1,

Re: [PR] improve log description of QuorumController [kafka]

2024-05-14 Thread via GitHub
mumrah commented on code in PR #15926: URL: https://github.com/apache/kafka/pull/15926#discussion_r1600407308 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(

[PR] KAFKA-16759: Handle telemetry push response while terminating [kafka]

2024-05-14 Thread via GitHub
AndrewJSchofield opened a new pull request, #15957: URL: https://github.com/apache/kafka/pull/15957 When client telemetry is configured in a cluster, Kafka producers and consumers push metrics to the brokers periodically. There is a special push of metrics that occurs when the client is

Re: [PR] KAFKA-16649: Remove lock from DynamicBrokerConfig.removeReconfigurable [kafka]

2024-05-14 Thread via GitHub
mumrah commented on PR #15838: URL: https://github.com/apache/kafka/pull/15838#issuecomment-2110742012 The new test seems to be failing: [`testReduceNumNetworkThreads() –

[jira] [Updated] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2024-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14567: -- Fix Version/s: 3.8.0 > Kafka Streams crashes after ProducerFencedException >

[jira] [Updated] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2024-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14567: -- Affects Version/s: 3.7.0 (was: 3.8.0) > Kafka Streams crashes

[jira] [Assigned] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2024-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-14567: - Assignee: Kirk True > Kafka Streams crashes after ProducerFencedException >

[jira] [Updated] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2024-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14567: -- Priority: Blocker (was: Major) > Kafka Streams crashes after ProducerFencedException >

[jira] [Updated] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2024-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14567: -- Affects Version/s: 3.8.0 > Kafka Streams crashes after ProducerFencedException >

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-14 Thread via GitHub
gaurav-narula commented on PR #15885: URL: https://github.com/apache/kafka/pull/15885#issuecomment-2110720158 @chia7712 looks like we still suffer from thread leaks in CI :( I've rebased from trunk to trigger CI again -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16757: Fix broker re-registration issues around MV 3.7-IV2 [kafka]

2024-05-14 Thread via GitHub
gaurav-narula commented on code in PR #15945: URL: https://github.com/apache/kafka/pull/15945#discussion_r1600362319 ## metadata/src/main/java/org/apache/kafka/image/publisher/BrokerRegistrationTracker.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software

[PR] KAFKA-15045: (KIP-924 pt. 4) Generify rack graph solving utilities [kafka]

2024-05-14 Thread via GitHub
apourchet opened a new pull request, #15956: URL: https://github.com/apache/kafka/pull/15956 The graph solving utilities are currently hardcoded to work with ClientState, but don't actually depend on anything in those state classes. This change allows the MinTrafficGraphConstructor

[jira] [Commented] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-05-14 Thread Luke D (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846377#comment-17846377 ] Luke D commented on KAFKA-16361: [~ableegoldman] , the bug is not present in 3.4 from our local

[PR] MINOR: Fix warnings in streams javadoc [kafka]

2024-05-14 Thread via GitHub
mimaison opened a new pull request, #15955: URL: https://github.com/apache/kafka/pull/15955 Fixes the following warnings (`./gradlew streams:javadoc`): ``` > Task :streams:javadoc

[jira] [Created] (KAFKA-16763) Upgrade to scala 2.12.19 and scala 2.13.14

2024-05-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16763: -- Summary: Upgrade to scala 2.12.19 and scala 2.13.14 Key: KAFKA-16763 URL: https://issues.apache.org/jira/browse/KAFKA-16763 Project: Kafka Issue Type:

Re: [PR] KAFKA-16762: SyncGroup API for upgrading ConsumerGroup [kafka]

2024-05-14 Thread via GitHub
dongnuo123 commented on code in PR #15954: URL: https://github.com/apache/kafka/pull/15954#discussion_r1600314641 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3898,6 +3994,65 @@ public CoordinatorResult

Re: [PR] KAFKA-16762: SyncGroup API for upgrading ConsumerGroup [kafka]

2024-05-14 Thread via GitHub
dongnuo123 commented on code in PR #15954: URL: https://github.com/apache/kafka/pull/15954#discussion_r1600311785 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3898,6 +3994,65 @@ public CoordinatorResult

[PR] KAFKA-16762: SyncGroup API for upgrading ConsumerGroup [kafka]

2024-05-14 Thread via GitHub
dongnuo123 opened a new pull request, #15954: URL: https://github.com/apache/kafka/pull/15954 This pr implements the sync group api for the consumer groups that are in the mixed mode. In `classicGroupSyncToConsumerGroup`, the `assignedPartitions` calculated in the JoinGroup will be

Re: [PR] KAFKA-16699: Have Streams treat InvalidPidMappingException like a ProducerFencedException [kafka]

2024-05-14 Thread via GitHub
wcarlson5 merged PR #15919: URL: https://github.com/apache/kafka/pull/15919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16762) SyncGroup API for upgrading ConsumerGroup

2024-05-14 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16762: --- Summary: SyncGroup API for upgrading ConsumerGroup Key: KAFKA-16762 URL: https://issues.apache.org/jira/browse/KAFKA-16762 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-16762) SyncGroup API for upgrading ConsumerGroup

2024-05-14 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu reassigned KAFKA-16762: --- Assignee: Dongnuo Lyu > SyncGroup API for upgrading ConsumerGroup >

Re: [PR] KAFKA-16699: Have Streams treat InvalidPidMappingException like a ProducerFencedException [kafka]

2024-05-14 Thread via GitHub
wcarlson5 commented on PR #15919: URL: https://github.com/apache/kafka/pull/15919#issuecomment-2110611187 There were no new or related test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-14 Thread via GitHub
chia7712 commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1600301660 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -314,6 +314,77 @@ class ReplicaManagerTest { } } + @ParameterizedTest(name =

[jira] [Commented] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-05-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846365#comment-17846365 ] David Arthur commented on KAFKA-16539: -- [~chia7712] here's a cherry-pick to 3.7

[PR] Cherry-pick KAFKA-16539 to 3.7 [kafka]

2024-05-14 Thread via GitHub
mumrah opened a new pull request, #15953: URL: https://github.com/apache/kafka/pull/15953 This patch fixes two issues with IncrementalAlterConfigs and the ZK migration. First, it changes the handling of IncrementalAlterConfigs to check if the controller is ZK vs KRaft and only forward for

[jira] [Updated] (KAFKA-16406) Split long-running consumer integration test

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16406: --- Labels: consumer kip-848-client-support (was: ) > Split long-running consumer integration

[jira] [Closed] (KAFKA-16406) Split long-running consumer integration test

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans closed KAFKA-16406. -- > Split long-running consumer integration test > > >

[jira] [Resolved] (KAFKA-16406) Split long-running consumer integration test

2024-05-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-16406. Resolution: Fixed > Split long-running consumer integration test >

[jira] [Commented] (KAFKA-16700) Kafka Streams: possible message loss on KTable-KTable FK Left Join

2024-05-14 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846363#comment-17846363 ] Ayoub Omari commented on KAFKA-16700: - [~stoeckmk] About KIP-962, it's not about null foreign keys,

Re: [PR] KAFKA-16671: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-14 Thread via GitHub
FrankYang0529 commented on code in PR #15868: URL: https://github.com/apache/kafka/pull/15868#discussion_r1600286651 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java: ## @@ -108,8 +110,8 @@ public void

[jira] [Commented] (KAFKA-16759) Invalid client telemetry transition on consumer close

2024-05-14 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846360#comment-17846360 ] Andrew Schofield commented on KAFKA-16759: -- Analysing the transitions, the invalid transition

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-05-14 Thread via GitHub
gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1600269458 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -43,7 +42,7 @@ import static

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-14 Thread via GitHub
mimaison commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1600267022 ## clients/src/main/java/org/apache/kafka/common/compress/ZstdCompression.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15284: -- Fix Version/s: 4.0.0 > Implement ConsumerGroupProtocolVersionResolver to determine consumer group >

[jira] [Updated] (KAFKA-15697) Add local assignor and ensure it cannot be used with server side assignor

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15697: -- Fix Version/s: 4.0.0 > Add local assignor and ensure it cannot be used with server side assignor >

[jira] [Updated] (KAFKA-15282) Implement client support for KIP-848 client-side assignors

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15282: -- Fix Version/s: 4.0.0 > Implement client support for KIP-848 client-side assignors >

[jira] [Updated] (KAFKA-15279) Implement client support for KIP-848 client-side assigner RPCs

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15279: -- Fix Version/s: 4.0.0 > Implement client support for KIP-848 client-side assigner RPCs >

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-14 Thread via GitHub
mimaison commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1600263287 ## clients/src/main/java/org/apache/kafka/common/compress/Lz4Compression.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (KAFKA-16406) Split long-running consumer integration test

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846354#comment-17846354 ] Kirk True commented on KAFKA-16406: --- [~lianetm]—both PRs are closed. Can this be marked as resolved?

[jira] [Updated] (KAFKA-16406) Split long-running consumer integration test

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16406: -- Fix Version/s: 3.8.0 > Split long-running consumer integration test >

[jira] [Updated] (KAFKA-16599) LegacyConsumer: Always await async commit callbacks in commitSync and close

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16599: -- Fix Version/s: 3.8.0 > LegacyConsumer: Always await async commit callbacks in commitSync and close >

[jira] [Updated] (KAFKA-16639) AsyncKafkaConsumer#close does not send heartbeat to leave group

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16639: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer#close does not send heartbeat to leave group >

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-14 Thread via GitHub
mimaison commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1600255317 ## clients/src/main/java/org/apache/kafka/common/compress/NoCompression.java: ## @@ -14,37 +14,48 @@ * See the License for the specific language governing

[jira] [Updated] (KAFKA-16675) Move rebalance callback test for positions to callbacks test file

2024-05-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16675: -- Fix Version/s: 4.0.0 > Move rebalance callback test for positions to callbacks test file >

[jira] [Commented] (KAFKA-16760) alterReplicaLogDirs failed even if responded with none error

2024-05-14 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846351#comment-17846351 ] Igor Soarez commented on KAFKA-16760: - Hey [~showuon] , thanks for sharing this. I'm trying, but

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-14 Thread via GitHub
mimaison commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1600247977 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,6 +173,14 @@ public class TopicConfig { "accepts 'uncompressed' which is

  1   2   >