[
https://issues.apache.org/jira/browse/KAFKA-16076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852659#comment-17852659
]
Ksolves commented on KAFKA-16076:
-
Hi! I am interested in working on this ticket.
Seems
[
https://issues.apache.org/jira/browse/KAFKA-16076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ksolves reassigned KAFKA-16076:
---
Assignee: Ksolves
> RestClient Interrupting the thread in case of InterruptedException
> --
vinay272001 opened a new pull request, #16221:
URL: https://github.com/apache/kafka/pull/16221
related to [KAFKA-16661](https://issues.apache.org/jira/browse/KAFKA-16661),
added a lower `log.initial.task.delay.ms` value to integration test
framework to 500ms
Committer Checklist
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1628876545
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedExcepti
cadonna commented on PR #15513:
URL: https://github.com/apache/kafka/pull/15513#issuecomment-2151536065
Yes, why not? It is a good change to the test, no?
I just did not have time to review it since my last review.
--
This is an automated message from the Apache Git Service.
To respond
showuon commented on code in PR #16203:
URL: https://github.com/apache/kafka/pull/16203#discussion_r1628868196
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -792,6 +792,36 @@ class DynamicBrokerConfigTest {
verifyIncorrectLogLocalRetentionPro
[
https://issues.apache.org/jira/browse/KAFKA-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852651#comment-17852651
]
Vinay Agarwal commented on KAFKA-16661:
---
Sure, on it
> add a lower `log.initial.t
dajac commented on PR #16198:
URL: https://github.com/apache/kafka/pull/16198#issuecomment-2151513652
@chia7712 @jeffkbkim @rreddy-22 Thanks for your comments. I have addressed
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dajac commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628845364
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java:
##
@@ -29,7 +30,7 @@
/**
* An immutable assignment for a member.
*/
-
showuon merged PR #16079:
URL: https://github.com/apache/kafka/pull/16079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16079:
URL: https://github.com/apache/kafka/pull/16079#issuecomment-2151505048
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dajac commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628842567
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/MemberAssignment.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to th
dajac commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628840910
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java:
##
@@ -45,18 +45,18 @@ public interface GroupSpec
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-16541.
-
Fix Version/s: 4.0.0
Resolution: Fixed
Merged the PR to trunk.
> Potential leader epoch checkpoi
junrao merged PR #15993:
URL: https://github.com/apache/kafka/pull/15993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1628819130
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedExcepti
sjhajharia commented on PR #16207:
URL: https://github.com/apache/kafka/pull/16207#issuecomment-2151470915
Thanks @chia7712 for the review. Addressed the comments in the new commit.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
appchemist commented on PR #16043:
URL: https://github.com/apache/kafka/pull/16043#issuecomment-2151383230
Reopen this pr for KAFKA-16764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
appchemist closed pull request #15961: KAFKA-16764: New consumer should throw
InvalidTopicException on poll when invalid topic in metadata.
URL: https://github.com/apache/kafka/pull/15961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kamalcph commented on PR #16199:
URL: https://github.com/apache/kafka/pull/16199#issuecomment-2151378272
We want to update the below configs dynamically:
1. remote.log.manager.copier.thread.pool.size
2. remote.log.manager.expiration.thread.pool.size
3. remote.log.manager.thread.
kamalcph commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1628745306
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##
@@ -16,184 +16,105 @@
*/
package org.apache.kafka.server.log
dajac closed pull request #15355: ignore
URL: https://github.com/apache/kafka/pull/15355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
ocadaruma commented on PR #15993:
URL: https://github.com/apache/kafka/pull/15993#issuecomment-2151361051
@junrao I don't think they relate.
- Confirmed that most of them are succeeded at least either one on JDK8 or
JDK21
- The one which failed both on JDK8/21 is `testFormatEmptyDirect
kamalcph commented on PR #16209:
URL: https://github.com/apache/kafka/pull/16209#issuecomment-2151355843
> Thanks @kamalcph for the PR. Overall LGTM.
>
> How is [KAFKA-15776](https://issues.apache.org/jira/browse/KAFKA-15776)
related to`RemoteLogReaderFetchRateAndTimeMs` metric?
github-actions[bot] commented on PR #15482:
URL: https://github.com/apache/kafka/pull/15482#issuecomment-2151348449
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on PR #15820:
URL: https://github.com/apache/kafka/pull/15820#issuecomment-2151343142
@abhijeetk88 , any update to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628618091
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +79,113 @@
import static org.junit.jupiter.api.Asse
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628611058
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +79,113 @@
import static org.junit.jupiter.api.Asse
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628610328
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -341,6 +356,17 @@ void testRunOnceInvokesReaper() {
[
https://issues.apache.org/jira/browse/KAFKA-16898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852609#comment-17852609
]
PoAn Yang commented on KAFKA-16898:
---
Hi [~chia7712], I'm interested in this ticket. Ma
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628598367
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -341,6 +356,17 @@ void testRunOnceInvokesReaper() {
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596559
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596024
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596024
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628595462
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593481
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593481
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593280
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +79,113 @@
import static org.junit.jupiter.api.Asse
[
https://issues.apache.org/jira/browse/KAFKA-16901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852606#comment-17852606
]
TengYao Chi commented on KAFKA-16901:
-
I will handle this issue 😀
> add unit tests
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628589378
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr
artemlivshits commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1628482592
##
core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala:
##
@@ -75,9 +76,9 @@ object TransactionLog {
.setPartitionIds(partitions.m
jeffkbkim commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628571546
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberSubscriptionAndAssignmentImpl.java:
##
@@ -83,9 +85,10 @@ public int hashCode() {
[
https://issues.apache.org/jira/browse/KAFKA-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852603#comment-17852603
]
黃竣陽 commented on KAFKA-16897:
-
I'm interesting in this issue, I can handle it
> Move Offset
ganesh-sadanala commented on PR #16162:
URL: https://github.com/apache/kafka/pull/16162#issuecomment-2151117769
> With 3 input topic partitions, there should be 3 tasks, one for each
partition. But the application must first join the consumer group and the
rebalancing must finish, before ta
appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1628553681
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundatio
appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1628553681
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundatio
ableegoldman commented on PR #16194:
URL: https://github.com/apache/kafka/pull/16194#issuecomment-2151098903
Merged to trunk and cherrypicked to 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ableegoldman commented on PR #16147:
URL: https://github.com/apache/kafka/pull/16147#issuecomment-2151097972
Cherrypicked to 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
rreddy-22 commented on PR #16198:
URL: https://github.com/apache/kafka/pull/16198#issuecomment-2151090811
Thanks for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
apourchet commented on code in PR #16201:
URL: https://github.com/apache/kafka/pull/16201#discussion_r1628532637
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -53,6 +55,76 @@ public final class TaskAssignmentUtils {
rreddy-22 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628532023
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/SubscribedTopicDescriberImpl.java:
##
@@ -29,14 +29,14 @@
* The subscribed topic meta
rreddy-22 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628529666
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberAssignmentImpl.java:
##
@@ -25,39 +26,39 @@
/**
* The partition assignment for
rreddy-22 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628528056
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/MemberAssignment.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed t
ableegoldman commented on code in PR #16201:
URL: https://github.com/apache/kafka/pull/16201#discussion_r1628527914
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -53,6 +55,76 @@ public final class TaskAssignmentUtils {
rreddy-22 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628526764
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/MemberAssignment.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed t
ableegoldman commented on code in PR #16201:
URL: https://github.com/apache/kafka/pull/16201#discussion_r1628526527
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -53,6 +55,76 @@ public final class TaskAssignmentUtils {
[
https://issues.apache.org/jira/browse/KAFKA-16899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852599#comment-17852599
]
Kirk True commented on KAFKA-16899:
---
[~linu]—you're welcome to take it. Thanks!
> Ren
ocadaruma commented on PR #15993:
URL: https://github.com/apache/kafka/pull/15993#issuecomment-2151075570
@junrao Thank you for your feedbacks. Addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jeffkbkim commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1628486465
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -443,6 +445,81 @@ public int size() {
}
}
rreddy-22 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628521138
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java:
##
@@ -45,18 +45,18 @@ public interface Group
kirktrue commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2151071098
I think that the approach from #16043 is more in line with the approach I
imagined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mjsax commented on PR #15513:
URL: https://github.com/apache/kafka/pull/15513#issuecomment-2151060001
@gharris1727 @cadonna -- do we still want to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax commented on PR #15689:
URL: https://github.com/apache/kafka/pull/15689#issuecomment-2151057059
Thanks for the PR @florin-akermann. Merged to `trunk` and cherry-picked to
`3.8` and `3.7` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message
mjsax merged PR #15689:
URL: https://github.com/apache/kafka/pull/15689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628502331
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -78,64 +81,120 @@
import static org.mockito.Mockito.doAnsw
mjsax commented on PR #15790:
URL: https://github.com/apache/kafka/pull/15790#issuecomment-2151048809
Thanks for the PR @AyoubOm. Merged to `trunk` and cherry-picked to `3.8`
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
soarez merged PR #16216:
URL: https://github.com/apache/kafka/pull/16216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
soarez commented on PR #16216:
URL: https://github.com/apache/kafka/pull/16216#issuecomment-2151043075
Failed tests are unrelated. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1628496087
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundatio
philipnee commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2151036734
@appchemist - was away for a few days so sorry for not responding. there
are two points to address before moving the pr forward
1. we definitely don't need to implement the request m
mjsax merged PR #15790:
URL: https://github.com/apache/kafka/pull/15790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
appchemist commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2151024735
@lianetm No problem, I enjoyed the discussion.
@kirktrue Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
philipnee commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1628483904
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-16899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852591#comment-17852591
]
Linu Shibu commented on KAFKA-16899:
Could I pick this up [~kirktrue] if you are not
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628478358
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -174,4 +194,22 @@ public String toString() {
')';
}
}
+
+
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628475975
##
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##
@@ -40,10 +45,27 @@
{ "name": "CurrentVoters", "type": "[]ReplicaState", "versions
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628475710
##
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##
@@ -40,10 +45,27 @@
{ "name": "CurrentVoters", "type": "[]ReplicaState", "versions
[
https://issues.apache.org/jira/browse/KAFKA-16834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Linu Shibu reassigned KAFKA-16834:
--
Assignee: Linu Shibu
> add the reason for the failure of PartitionRegistration#toRecord
> ---
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628473676
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4424,12 +4427,21 @@ private QuorumInfo createQuorumResult(final
DescribeQuorumRes
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628473245
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +613,46 @@ public void testOffsetFetchRequestErroredR
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628472921
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -29,19 +32,22 @@ public class QuorumInfo {
private final long highWatermark;
pr
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628472263
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -94,21 +104,24 @@ public String toString() {
public static class ReplicaState {
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628471528
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -174,4 +194,22 @@ public String toString() {
')';
}
}
+
+
[
https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-16522.
--
Resolution: Fixed
Implemented by {{KAFKA-16535: Implement AddVoter, RemoveVoter, UpdateVoter
parafiend commented on PR #16220:
URL: https://github.com/apache/kafka/pull/16220#issuecomment-2150998614
I wasn't able to find existing tests covering the specific awaitNodeReady
connection logic, advice for how to test this is welcome.
I think the logging change would help to identi
[
https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-16522:
Assignee: Colin McCabe (was: Quoc Phong Dang)
> Admin client changes for adding and remo
parafiend opened a new pull request, #16220:
URL: https://github.com/apache/kafka/pull/16220
Use the lesser of request.timeout.ms and
socket.connection.setup.timeout.ms when Sender is performing blocking
waits for node readiness.
This ensures faster processing of connection setup
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628462153
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +613,46 @@ public void testOffsetFetchRequestErroredRe
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628462153
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +613,46 @@ public void testOffsetFetchRequestErroredRe
Chia-Ping Tsai created KAFKA-16901:
--
Summary: add unit tests for ConsumerRecords#records(String)
Key: KAFKA-16901
URL: https://issues.apache.org/jira/browse/KAFKA-16901
Project: Kafka
Issue
Graham Campbell created KAFKA-16902:
---
Summary: Sender ignores socket connection timeout when
reconnecting to transaction coordinator
Key: KAFKA-16902
URL: https://issues.apache.org/jira/browse/KAFKA-16902
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1628455890
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -24,7 +24,7 @@ public enum TestFeatureVersion implements FeatureVersion {
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628457770
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +613,46 @@ public void testOffsetFetchRequestErroredR
C0urante commented on code in PR #16053:
URL: https://github.com/apache/kafka/pull/16053#discussion_r1628456824
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -1123,6 +1125,24 @@ private void processTasksCommitRecord(String
lianetm commented on PR #16140:
URL: https://github.com/apache/kafka/pull/16140#issuecomment-2150972168
Hey @brenden20 , thanks for the updates! Left some minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kirktrue commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2150969566
Fixed `TieredStorageTestContext` breakage. Sorry about that 🤦♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628443660
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -353,13 +379,22 @@ void testSendUnsentRequest() {
as
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1628442774
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +613,46 @@ public void testOffsetFetchRequestErroredR
chia7712 commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1628424360
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1335,10 +1335,6 @@ public synchronized void
updateConsumerGroupOffsets(final Map
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628434821
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +52,105 @@
import static org.junit.jupiter.api.Assert
1 - 100 of 327 matches
Mail list logo
