chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632184801
##
build.gradle:
##
@@ -3248,7 +3248,6 @@ project(':connect:runtime') {
testImplementation project(':group-coordinator')
testImplementation libs.junitJ
m1a2st commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632184386
##
build.gradle:
##
@@ -3248,7 +3248,6 @@ project(':connect:runtime') {
testImplementation project(':group-coordinator')
testImplementation libs.junitJup
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2156349665
Hi @chia7712 , I have do some refactors, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
m1a2st commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632175364
##
build.gradle:
##
@@ -540,9 +537,6 @@ subprojects {
exclude testsToExclude
-if (shouldUseJUnit5)
- useJUnitPlatform()
Review Comment:
Sorry, I mi
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156323628
Hi @chia7712, I have do a simple change based on your feedback, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dujian0068 closed pull request #16242: KAFKA-16879 SystemTime should use
singleton mode
URL: https://github.com/apache/kafka/pull/16242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/KAFKA-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853456#comment-17853456
]
A. Sophie Blee-Goldman commented on KAFKA-16903:
[~cadonna] is this real
ableegoldman commented on PR #16245:
URL: https://github.com/apache/kafka/pull/16245#issuecomment-2156285014
Merged to trunk and cherrypicked back to 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ableegoldman merged PR #16245:
URL: https://github.com/apache/kafka/pull/16245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman commented on PR #16245:
URL: https://github.com/apache/kafka/pull/16245#issuecomment-2156284552
Test failures are unrelated and this PR has no overlap with the
recently-merged [PR 18](https://github.com/apache/kafka/pull/16201), so it
should be safe to merge without conflicts
ableegoldman commented on PR #16201:
URL: https://github.com/apache/kafka/pull/16201#issuecomment-2156284386
Merged to trunk and cherrypicked back to 3.8
Note: although this is named "PR 19", it was merged after "PR 18". In other
words, in the actual order of commits, PRs 18 & 19 are
ableegoldman merged PR #16201:
URL: https://github.com/apache/kafka/pull/16201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632146085
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java:
##
@@ -350,16 +350,14 @@ private boolean
assertCo
chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632145884
##
build.gradle:
##
@@ -540,9 +537,6 @@ subprojects {
exclude testsToExclude
-if (shouldUseJUnit5)
- useJUnitPlatform()
Review Comment:
Please ke
chia7712 commented on code in PR #16231:
URL: https://github.com/apache/kafka/pull/16231#discussion_r1632145191
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156257956
Also, please replace `@Category(IntegrationTest.class)` by
`@Tag("integrationTest") for connect module
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16921:
---
Summary: Migrate all junit 4 code to junit 5 for connect module (was:
Migrate all junit 4 a
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16921:
---
Description:
# replace all "org.junit.Assert." by "org.junit.jupiter.api.Assertions.".
# re
chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632143665
##
build.gradle:
##
@@ -3248,7 +3248,6 @@ project(':connect:runtime') {
testImplementation project(':group-coordinator')
testImplementation libs.junitJ
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1632136201
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -211,178 +220,52 @@ public void testResetPositionsProcessFa
abhijeetk88 commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2156228028
@satishd I have addressed your comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632133058
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1179,14 +1181,31 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
soarez merged PR #16252:
URL: https://github.com/apache/kafka/pull/16252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127666
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1195,13 +1214,19 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127500
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1166,7 +1166,9 @@ class DynamicRemoteLogConfig(server: KafkaBroker) extends
BrokerReconfigura
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853444#comment-17853444
]
Hector Geraldino commented on KAFKA-12199:
--
Sorry, what I meant is that the Moc
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16921:
---
Summary: Migrate all junit 4 assert to junit 5 for connect module (was:
Migrate all junit 4
[
https://issues.apache.org/jira/browse/KAFKA-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-15623:
--
Assignee: 黃竣陽
> Migrate remaining tests in streams module to JUnit 5
> --
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853443#comment-17853443
]
Chia-Ping Tsai commented on KAFKA-16921:
the streams module can be addressed by
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1632125146
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedExcepti
abhijeetk88 commented on PR #15820:
URL: https://github.com/apache/kafka/pull/15820#issuecomment-2156212270
@kamalcph I have addressed your comments, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853441#comment-17853441
]
Hector Geraldino commented on KAFKA-12199:
--
Hey [~chia7712],
Now that all conn
[
https://issues.apache.org/jira/browse/KAFKA-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853439#comment-17853439
]
Chia-Ping Tsai commented on KAFKA-16922:
sure, please feel free to take over thi
chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632120413
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory,
private final Te
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1632119543
##
core/src/test/scala/unit/kafka/admin/AclCommandTest.scala:
##
@@ -325,11 +349,15 @@ class AclCommandTest extends QuorumTestHarness with
Logging {
private def
[
https://issues.apache.org/jira/browse/KAFKA-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853438#comment-17853438
]
Muralidhar Basani commented on KAFKA-16922:
---
[~chia7712] seems like there is n
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1632118232
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,88 +16,100 @@
*/
package org.apache.kafka.tools.consumer.grou
[
https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-10787:
--
Assignee: xuanzhang gong (was: Dongjin Lee)
> Introduce an import order in Java sour
[
https://issues.apache.org/jira/browse/KAFKA-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12572:
--
Assignee: xuanzhang gong (was: Dongjin Lee)
> Add import ordering checkstyle rule an
[
https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-10787:
---
Fix Version/s: 3.9.0
> Introduce an import order in Java sources
> -
chia7712 merged PR #16172:
URL: https://github.com/apache/kafka/pull/16172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-16922:
--
Summary: add unit test for NewTopic
Key: KAFKA-16922
URL: https://issues.apache.org/jira/browse/KAFKA-16922
Project: Kafka
Issue Type: Test
R
chia7712 commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156189050
> Out of curiosity, what’s the reason for not returning unmodifiable maps? I
think that we should actually ensure that the admin client does not return
modifiable maps.
I prefer t
dajac commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156186787
Out of curiosity, what’s the reason for not returning unmodifiable maps? I
think that we should actually ensure that the admin client does not return
modifiable maps.
--
This is an autom
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
brandboat commented on PR #16231:
URL: https://github.com/apache/kafka/pull/16231#issuecomment-2156132892
Modified a couple of things in the latest commit:
1. Add computeIfAbsent in each benchmark since in the code base we use both
get and computeIfAbsent in CopyOnWriteMap, and we want to
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156112524
Also, please remove dependency "JUnit Vintage Engine" from connect module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156112376
The junit 4 assertions are not compatible to junit 5, so you ought to fix
the conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-7438.
---
Fix Version/s: 3.9.0
Resolution: Fixed
> Replace EasyMock and PowerMock with Mockito
>
pasharik commented on PR #15830:
URL: https://github.com/apache/kafka/pull/15830#issuecomment-2156108598
> Could you please take a look at failed tests?
`AclCommandTest` seems to be fixed, but there are some other failing tests
for jdk8 and jdk21
--
This is an automated message fro
ijuma commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156096105
> Wow, we're finally doing it! According to
[KAFKA-7438](https://issues.apache.org/jira/browse/KAFKA-7438), it looks like
it almost took us 6 years to do it.
Well done team, this was
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853398#comment-17853398
]
黃竣陽 commented on KAFKA-16921:
-
I'm interesting in this issue, I can handle it. Thank you
>
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853397#comment-17853397
]
Chia-Ping Tsai commented on KAFKA-16921:
There are many files which will get inv
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-14132.
Fix Version/s: 3.9.0
(was: 3.8.0)
Resolution: Fixed
> Remain
[
https://issues.apache.org/jira/browse/KAFKA-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16878.
Fix Version/s: 3.9.0
Resolution: Fixed
> Remove powermock and easymock from code ba
chia7712 merged PR #16236:
URL: https://github.com/apache/kafka/pull/16236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156091519
failed tests pass on my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632067288
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +38,109 @@ public class ConsumerRecordsTest {
@Test
publi
chia7712 commented on code in PR #16250:
URL: https://github.com/apache/kafka/pull/16250#discussion_r1632066886
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3649,7 +3652,7 @@ public DeleteConsumerGroupOffsetsResult
deleteConsumerGroupOff
gaurav-narula commented on PR #16252:
URL: https://github.com/apache/kafka/pull/16252#issuecomment-2156087544
Thanks for the feedback! Force pushed a commit with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156084937
Hi @chia7712, I have replace some `UnmodifiableMap` with `HashMap`, PTAL 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
fanyang commented on PR #16208:
URL: https://github.com/apache/kafka/pull/16208#issuecomment-2156073280
Here's the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1055%3A+Introducing+Round-Robin+Assignment+Strategy+to+ConnectorUtils
--
This is an automated message from the A
[ https://issues.apache.org/jira/browse/KAFKA-16893 ]
Fan Yang deleted comment on KAFKA-16893:
--
was (Author: JIRAUSER305427):
Here's the KIP:
[KIP-1055: Introducing Round-Robin Assignment Strategy to ConnectorUtils -
Apache Kafka - Apache Softwar
[
https://issues.apache.org/jira/browse/KAFKA-16893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853388#comment-17853388
]
Fan Yang commented on KAFKA-16893:
--
Here's the KIP:
[KIP-1055: Introducing Round-Robin
dujian0068 commented on code in PR #16242:
URL: https://github.com/apache/kafka/pull/16242#discussion_r1632056246
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,8 +30,6 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
Review C
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2156063782
Hi @chia7712 , I do some changes based on comments, PTAL 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632055803
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2156061341
> @gongxuanzhang could you please rebase code to include #16249
Okay, next we wait for CI
--
This is an automated message from the Apache Git Service.
To respond to the mess
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632052689
##
storage/src/test/java/org/apache/kafka/server/log/OffsetMapTest.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632052511
##
storage/src/test/java/org/apache/kafka/server/log/OffsetMapTest.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-215601
> @FrankYang0529 please rebase code :)
Thanks for reminder. Rebased it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FrankYang0529 commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156043620
> #16249 is merged. FYI.
Rebased it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FrankYang0529 commented on code in PR #16236:
URL: https://github.com/apache/kafka/pull/16236#discussion_r1632046626
##
build.gradle:
##
@@ -826,7 +819,6 @@ subprojects {
toolVersion = versions.jacoco
}
- // NOTE: Jacoco Gradle plugin does not support "off
gaurav-narula opened a new pull request, #16252:
URL: https://github.com/apache/kafka/pull/16252
Tests in BrokerLifecycleManagerTest do not close BrokerLifecycleManager if
an assertion fails. This change ensures `manager.close()` is always invoked in
a finally block thereby preventing poten
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16667:
Fix Version/s: (was: 3.7.1)
> KRaftMigrationDriver gets stuck after successive failovers
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853377#comment-17853377
]
Igor Soarez commented on KAFKA-16667:
-
I'm removing the 3.7.1 tag for now. Please ad
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632043299
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
chia7712 commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632043139
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-16920:
-
Assignee: Gaurav Narula
> Flaky test testControlledShutdown() - kafka.server.BrokerLife
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853376#comment-17853376
]
Igor Soarez commented on KAFKA-16667:
-
[~davidarthur] is this still relevant for 3.7
soarez merged PR #16232:
URL: https://github.com/apache/kafka/pull/16232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
soarez commented on PR #16232:
URL: https://github.com/apache/kafka/pull/16232#issuecomment-2156032172
@showuon thank you for reviewing this.
Failed tests pass locally, and are unrelated to this change:
* KAFKA-16383
org.apache.kafka.connect.mirror.integration.IdentityReplicati
[
https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853374#comment-17853374
]
Igor Soarez commented on KAFKA-8115:
Failed again
https://ci-builds.apache.org/blue/
[
https://issues.apache.org/jira/browse/KAFKA-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853373#comment-17853373
]
Igor Soarez commented on KAFKA-15789:
-
Failed again in
https://ci-builds.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853371#comment-17853371
]
Igor Soarez commented on KAFKA-16402:
-
Failed again in
https://ci-builds.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-16383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16383:
Component/s: connect
> fix flaky test IdentityReplicationIntegrationTest.testReplicateFromLatest()
[
https://issues.apache.org/jira/browse/KAFKA-16383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853370#comment-17853370
]
Igor Soarez commented on KAFKA-16383:
-
This failed again in
[https://ci-builds.apac
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632040486
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853369#comment-17853369
]
Igor Soarez commented on KAFKA-15197:
-
This failed again in
[https://ci-builds.apac
[
https://issues.apache.org/jira/browse/KAFKA-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853368#comment-17853368
]
Igor Soarez commented on KAFKA-15963:
-
Failed again in
[https://ci-builds.apache.or
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156027791
Hi @chia7712 , I will take look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16920:
Description:
Several tests failed in this pipeline because {{testControlledShutdown}} did
not cle
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16920:
Description:
Several tests failed in this pipeline because {{testControlledShutdown}} did
not cle
Igor Soarez created KAFKA-16920:
---
Summary: Flaky test testControlledShutdown() -
kafka.server.BrokerLifecycleManagerTest
Key: KAFKA-16920
URL: https://issues.apache.org/jira/browse/KAFKA-16920
Project:
1 - 100 of 117 matches
Mail list logo
