[
https://issues.apache.org/jira/browse/KAFKA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hejie updated KAFKA-17918:
--
Description:
In Kafka 3.5.0, producers connect to the Kafka server and use the callback
method to report mess
FrankYang0529 commented on PR #17615:
URL: https://github.com/apache/kafka/pull/17615#issuecomment-2451387560
Hi @chia7712, thanks for review. I addressed all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
smjn commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1825469769
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage new
smjn commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1825469769
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage new
[
https://issues.apache.org/jira/browse/KAFKA-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894770#comment-17894770
]
Chia-Ping Tsai commented on KAFKA-17910:
this jira is from
https://github.com/a
chia7712 commented on PR #17625:
URL: https://github.com/apache/kafka/pull/17625#issuecomment-2451285712
> I think we should not spend time on this, since we're dropping zookeeper
from ducktape in the next release.
I have replied this comment in another PR
https://github.com/apache/k
chia7712 commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2451281344
> Please remember that the first production KRaft version with 3.3, and we
do not support upgrades from versions earlier than that. (We will test older
clients, of course, but clients do
m1a2st commented on PR #17625:
URL: https://github.com/apache/kafka/pull/17625#issuecomment-2451241260
> I think we should not spend time on this, since we're dropping zookeeper
from ducktape in the next release.
> -1
Hello @cmccabe, Thanks for your suggestion, but for e2e testing,
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1825368063
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -174,43 +175,50 @@ private synchronized List
loggers(String namespace) {
frankvicky commented on PR #17549:
URL: https://github.com/apache/kafka/pull/17549#issuecomment-2451153826
I really appreciate everyone's review and patience. Thank you 😺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
[
https://issues.apache.org/jira/browse/KAFKA-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894747#comment-17894747
]
PoAn Yang commented on KAFKA-17910:
---
Hi [~schofielaj], if you're not working on this,
[
https://issues.apache.org/jira/browse/KAFKA-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kangning.li reassigned KAFKA-17904:
---
Assignee: kangning.li
> Flaky testMultiConsumerSessionTimeoutOnClose
>
xijiu opened a new pull request, #17657:
URL: https://github.com/apache/kafka/pull/17657
As title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
[
https://issues.apache.org/jira/browse/KAFKA-17913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894740#comment-17894740
]
kangning.li commented on KAFKA-17913:
-
[~cmccabe] Hi Colin, I will take this iss
[
https://issues.apache.org/jira/browse/KAFKA-17913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kangning.li reassigned KAFKA-17913:
---
Assignee: kangning.li
> Fix KRaft controller count recommendations
> --
bbejeck commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2451044794
> several PRs landed recently:
>
> KAFKA-17609:[3/4]Convert system tests to kraft part 3 (#17327)
> KAFKA-17609:[4/4]Convert system tests to kraft part 4 (#17328)
>KAFKA
[
https://issues.apache.org/jira/browse/KAFKA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Wu updated KAFKA-17915:
-
Description: Update quota, truncation, and client compatibility tests to
use KRaft. Tests that do not in
[
https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Wu updated KAFKA-17917:
-
Description: The downgrade, group mode transactions, security rolling
upgrade, and throttling test shoul
cmccabe commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2451017255
> Looks like we should just convert the streams, connect, and clients tests
to not use ZK 👍
several PRs landed recently:
```
KAFKA-17609:[3/4]Convert system tests to kraft
jolshan commented on code in PR #17576:
URL: https://github.com/apache/kafka/pull/17576#discussion_r1825279500
##
tests/setup.py:
##
@@ -51,7 +51,7 @@ def run_tests(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
- insta
jolshan commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2451016049
Looks like we should just convert the streams, connect, and clients tests to
not use ZK 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jolshan commented on code in PR #17576:
URL: https://github.com/apache/kafka/pull/17576#discussion_r1825279500
##
tests/setup.py:
##
@@ -51,7 +51,7 @@ def run_tests(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
- insta
cmccabe commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2451011828
We are removing zookeeper, so let's not spend time on getting it to run.
Let's just move to jdk11 in the tests for now, and once the removal is fully
done we can go to jdk17 (assumi
[
https://issues.apache.org/jira/browse/KAFKA-17888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894726#comment-17894726
]
Colin McCabe commented on KAFKA-17888:
--
We're dropping zookeeper from the ducktape
cmccabe commented on PR #17625:
URL: https://github.com/apache/kafka/pull/17625#issuecomment-2451009024
I think we should not spend time on this, since we're dropping zookeeper
from ducktape in the next release.
-1
--
This is an automated message from the Apache Git Service.
To res
junrao commented on PR #17528:
URL: https://github.com/apache/kafka/pull/17528#issuecomment-2450987435
@kevin-wu24 : Could you adjust the title of the PR accordingly? The PR
didn't change KafkaMetadataLog#read.
--
This is an automated message from the Apache Git Service.
To respond to the
Kevin Wu created KAFKA-17917:
Summary: Convert Kafka core system tests to use KRaft
Key: KAFKA-17917
URL: https://issues.apache.org/jira/browse/KAFKA-17917
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Wu updated KAFKA-17915:
-
Issue Type: Task (was: Improvement)
> Convert Kafka Client tests to use KRaft
> ---
[
https://issues.apache.org/jira/browse/KAFKA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Wu updated KAFKA-17915:
-
Summary: Convert Kafka Client system tests to use KRaft (was: Convert
Kafka Client tests to use KRaft)
Kevin Wu created KAFKA-17916:
Summary: Convert Kafka Connect system tests to use KRaft
Key: KAFKA-17916
URL: https://issues.apache.org/jira/browse/KAFKA-17916
Project: Kafka
Issue Type: Improveme
Kevin Wu created KAFKA-17915:
Summary: Convert Kafka Client tests to use KRaft
Key: KAFKA-17915
URL: https://issues.apache.org/jira/browse/KAFKA-17915
Project: Kafka
Issue Type: Improvement
cmccabe commented on code in PR #17617:
URL: https://github.com/apache/kafka/pull/17617#discussion_r1825245360
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -956,8 +978,10 @@ void deleteTopic(ControllerRequestContext context, Uuid
i
[
https://issues.apache.org/jira/browse/KAFKA-17625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Wu updated KAFKA-17625:
-
Description:
This change will be done in 2 PRs:
* The first to remove existing ZK test parameterizatio
AndrewJSchofield commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1825211740
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(Metad
AndrewJSchofield commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1825188742
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(Metad
Andrew Schofield created KAFKA-17914:
Summary: Refactor ShareCoordinator.partitionFor to use
SharePartitionKey argument
Key: KAFKA-17914
URL: https://issues.apache.org/jira/browse/KAFKA-17914
Proj
[
https://issues.apache.org/jira/browse/KAFKA-17913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894713#comment-17894713
]
Colin McCabe commented on KAFKA-17913:
--
See KAFKA-17875 (this needs to be reverted)
Colin McCabe created KAFKA-17913:
Summary: Fix KRaft controller count recommendations
Key: KAFKA-17913
URL: https://issues.apache.org/jira/browse/KAFKA-17913
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-17875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894712#comment-17894712
]
Colin McCabe commented on KAFKA-17875:
--
This is actually incorrect. The other doc s
cmccabe merged PR #17604:
URL: https://github.com/apache/kafka/pull/17604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kevin-wu24 commented on PR #17528:
URL: https://github.com/apache/kafka/pull/17528#issuecomment-2450798280
@junrao Thanks for the reviews! Let me know if there's anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
kirktrue commented on PR #17581:
URL: https://github.com/apache/kafka/pull/17581#issuecomment-2450795348
@mumrah—can you take a look at approach in this PR and let me know if it's
correct? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
chia7712 commented on code in PR #17625:
URL: https://github.com/apache/kafka/pull/17625#discussion_r1825052615
##
tests/docker/Dockerfile:
##
@@ -44,7 +64,8 @@ RUN if [ "$KAFKA_MODE" = "native" ]; then \
/build/native/native_command.sh $NATIVE_IMAGE_PATH $NATIVE_CONFIGS_
adixitconfluent commented on PR #17539:
URL: https://github.com/apache/kafka/pull/17539#issuecomment-2450647031
> @adixitconfluent : Thanks for the updated PR. A few more comments. Also,
it seems the previous comments on SharePartition haven't been addressed?
Hi @junrao, I am still in
chia7712 merged PR #17549:
URL: https://github.com/apache/kafka/pull/17549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lianetm commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2450633839
Hey @kirktrue, yes, your sketch does reflect what I described I had in mind
(close => run callbacks no matter timeout/interrupt + best effort to send leave
request). Do you maybe have a t
[
https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17116.
Resolution: Fixed
> New consumer may not send effective leave group if member ID received
chia7712 commented on code in PR #17615:
URL: https://github.com/apache/kafka/pull/17615#discussion_r1825018667
##
build.gradle:
##
@@ -2803,18 +2793,13 @@ project(':streams:streams-scala') {
api project(':streams')
api libs.scalaLibrary
-testImplementation proje
kevin-wu24 commented on PR #17582:
URL: https://github.com/apache/kafka/pull/17582#issuecomment-2450583278
> @kevin-wu24 thanks for this patch!
Thanks for the review @chia7712. I pushed a patch to address some of your
comments. Let me know what you think.
--
This is an automated me
[
https://issues.apache.org/jira/browse/KAFKA-17899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17899.
Fix Version/s: 4.0.0
Resolution: Fixed
> Add more unit tests for NetworkReceive
>
kevin-wu24 commented on code in PR #17582:
URL: https://github.com/apache/kafka/pull/17582#discussion_r1825013396
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -550,8 +550,10 @@ class KRaftMetadataCache(
override def features(): FinalizedFeature
chia7712 merged PR #17637:
URL: https://github.com/apache/kafka/pull/17637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jeffkbkim commented on code in PR #17653:
URL: https://github.com/apache/kafka/pull/17653#discussion_r1825003698
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java:
##
@@ -334,6 +342,13 @@ private void removeStaticMember(Cons
[
https://issues.apache.org/jira/browse/KAFKA-17905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17905.
Fix Version/s: 4.0.0
Resolution: Fixed
> Remove the specified type of using lambda
chia7712 merged PR #17648:
URL: https://github.com/apache/kafka/pull/17648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
kevin-wu24 commented on code in PR #17582:
URL: https://github.com/apache/kafka/pull/17582#discussion_r1824999429
##
test-common/src/main/java/org/apache/kafka/common/test/TestKitNodes.java:
##
@@ -57,8 +57,15 @@ public static class Builder {
private int numBrokerNodes;
AndrewJSchofield commented on PR #17626:
URL: https://github.com/apache/kafka/pull/17626#issuecomment-2449803590
The failing test has just been marked as flaky:
https://github.com/apache/kafka/pull/17649. I suspect an intermittent problem
in a recently merged PR and we are working on a fix.
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1824937560
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -65,6 +70,7 @@ public class DelayedShareFetch extends DelayedOperation {
this.shareFetchD
kevin-wu24 commented on code in PR #17582:
URL: https://github.com/apache/kafka/pull/17582#discussion_r1824931425
##
core/src/main/java/kafka/server/ServerSocketFactory.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
lianetm commented on code in PR #17516:
URL: https://github.com/apache/kafka/pull/17516#discussion_r1824955585
##
core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala:
##
@@ -124,12 +128,56 @@ class GroupAuthorizerIntegrationTest extends
BaseRequestTes
chia7712 commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1824927768
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1824901568
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -174,43 +175,50 @@ private synchronized List
loggers(String namespace) {
}
chia7712 commented on PR #17656:
URL: https://github.com/apache/kafka/pull/17656#issuecomment-2450458900
@AndrewJSchofield nice find. It seems like it could pass sometimes if we're
lucky, as both string representations might end up mapping to the same
partition.
--
This is an automated m
jeffkbkim commented on code in PR #17651:
URL: https://github.com/apache/kafka/pull/17651#discussion_r1824867567
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -166,6 +166,51 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterIns
jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1824727613
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -914,11 +914,23 @@ class TransactionsTest extends IntegrationTestHarness {
// Check th
apoorvmittal10 commented on PR #17656:
URL: https://github.com/apache/kafka/pull/17656#issuecomment-2450454132
Thanks @AndrewJSchofield for the quick fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chia7712 commented on PR #17649:
URL: https://github.com/apache/kafka/pull/17649#issuecomment-2450448090
> It is actually flaky, just extremely so
https://ge.apache.org/scans/tests?search.names=CI%20workflow%2CGit%20repository&search.rootProjectNames=kafka&search.tags=github%2Ctrunk&search.t
apoorvmittal10 commented on PR #17645:
URL: https://github.com/apache/kafka/pull/17645#issuecomment-2450444228
Make sense, thanks @AndrewJSchofield. Once the other PR is merged, I ll
close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
junrao commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1824884805
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -317,7 +317,7 @@ public LogOffsetPosition searchForOffsetWithSize(long
targetOffset, int
mumrah commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1824884317
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage n
AndrewJSchofield commented on PR #17645:
URL: https://github.com/apache/kafka/pull/17645#issuecomment-2450430658
I think this PR fixes the test failure:
https://github.com/apache/kafka/pull/17656.
Whether to handle `NOT_COORDINATOR` as a retriable error in this situation
is another m
AndrewJSchofield opened a new pull request, #17656:
URL: https://github.com/apache/kafka/pull/17656
The recent test failure documented by
https://github.com/apache/kafka/pull/17649 seems to be related to the string
representation of SharePartitionKey. This is a combination of
group-id:topi
mumrah commented on PR #17649:
URL: https://github.com/apache/kafka/pull/17649#issuecomment-2450415915
It is actually flaky, just extremely so
https://ge.apache.org/scans/tests?search.names=CI%20workflow%2CGit%20repository&search.rootProjectNames=kafka&search.tags=github%2Ctrunk&search.tasks
mimaison opened a new pull request, #17655:
URL: https://github.com/apache/kafka/pull/17655
The call to `replace()` was replacing all instances of `KAFKA_`. This was an
issue when handling the `kafka.metrics.reporters` broker configuration as
`KAFKA_KAFKA_METRICS_REPORTERS` was incorrectly
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1824185851
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -174,43 +175,50 @@ private synchronized List
loggers(String namespace) {
}
Andrew Schofield created KAFKA-17912:
Summary: Align string conversion of SharePartitionKey
Key: KAFKA-17912
URL: https://issues.apache.org/jira/browse/KAFKA-17912
Project: Kafka
Issue Ty
Mickael Maison created KAFKA-17911:
--
Summary: Unable to set kafka.metrics.reporter via environment
variables in docker image
Key: KAFKA-17911
URL: https://issues.apache.org/jira/browse/KAFKA-17911
Pr
frankvicky commented on code in PR #17646:
URL: https://github.com/apache/kafka/pull/17646#discussion_r1824298235
##
server-common/src/test/java/org/apache/kafka/admin/AdminRackAwareTest.java:
##
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
AndrewJSchofield commented on code in PR #17626:
URL: https://github.com/apache/kafka/pull/17626#discussion_r1824798591
##
tools/src/test/java/org/apache/kafka/tools/GroupsCommandTest.java:
##
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
chia7712 merged PR #17650:
URL: https://github.com/apache/kafka/pull/17650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on PR #17645:
URL: https://github.com/apache/kafka/pull/17645#issuecomment-2450357889
I think this PR is on the wrong track. The problem seems to be a mismatch
between two pieces of code using the `SharePartitionKey`. There are two
different string representations
Andrew Schofield created KAFKA-17910:
Summary: Create integration tests for Admin.listGroups and
Admin.describeClassicGroups
Key: KAFKA-17910
URL: https://issues.apache.org/jira/browse/KAFKA-17910
CalvinConfluent commented on PR #17619:
URL: https://github.com/apache/kafka/pull/17619#issuecomment-2450262471
@jolshan Can you help take a look? I updated the fix for the second case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm commented on code in PR #17651:
URL: https://github.com/apache/kafka/pull/17651#discussion_r1824701647
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -195,14 +196,23 @@ public void testConsumerHeartbeatRequestVa
AndrewJSchofield commented on PR #17645:
URL: https://github.com/apache/kafka/pull/17645#issuecomment-2450165341
It appears to me that this `NOT_COORDINATOR` is coming from
`CoordinatorRuntime.contextOrThrow`. I don't yet know whether it's an
acceptable thing to just add it to the list of r
fonsdant commented on PR #17198:
URL: https://github.com/apache/kafka/pull/17198#issuecomment-2448785469
I have managed to refactor the tests! 😄
Now, I will just update the Javadocs and Scaladocs again
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-17877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-17877:
---
Description:
{code:java}
java.lang.IllegalStateException: WriteTxnMarkerResponse for
lkc-devcv9jg9n
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1824747173
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -204,7 +202,117 @@ Map
acquirablePartitions() {
return topicPartitionData;
TengYao Chi created KAFKA-17909:
---
Summary: Clean-up RPC#listeners
Key: KAFKA-17909
URL: https://issues.apache.org/jira/browse/KAFKA-17909
Project: Kafka
Issue Type: Task
Reporter: T
[
https://issues.apache.org/jira/browse/KAFKA-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894623#comment-17894623
]
Lianet Magrans commented on KAFKA-17904:
Sure, you can take it, thanks for helpi
apoorvmittal10 commented on code in PR #17645:
URL: https://github.com/apache/kafka/pull/17645#discussion_r1824665806
##
share/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##
@@ -679,6 +679,7 @@ protected void handleRequestResponse(ClientResp
chia7712 commented on PR #17649:
URL: https://github.com/apache/kafka/pull/17649#issuecomment-2450081386
This test isn't flaky, as it consistently fails no matter how many retries
we attempt, correct? If that's the case, we should disable it rather than
quarantine it, since it still breaks
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824606302
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -18,15 +18,15 @@
"type": "request",
"listeners": ["zkBroker", "broker"],
lianetm commented on code in PR #17559:
URL: https://github.com/apache/kafka/pull/17559#discussion_r1821482086
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -873,7 +874,8 @@ public ConsumerRecords poll(final Duration timeout) {
*
chia7712 commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824604318
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -18,15 +18,15 @@
"type": "request",
"listeners": ["zkBroker", "broker"],
apoorvmittal10 commented on PR #17645:
URL: https://github.com/apache/kafka/pull/17645#issuecomment-2450070393
> I remain unconvinced by this PR. There is certainly a problem somewhere in
this area, but I was unable to reproduce it yesterday in spite of trying. I'll
try again today. But I w
chia7712 commented on code in PR #17626:
URL: https://github.com/apache/kafka/pull/17626#discussion_r1824571208
##
tools/src/test/java/org/apache/kafka/tools/GroupsCommandTest.java:
##
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824591348
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -158,10 +157,15 @@ public ConsumerMembershipManager(String
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824570188
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -18,15 +18,15 @@
"type": "request",
"listeners": ["zkBroker", "broker"],
chia7712 commented on code in PR #17626:
URL: https://github.com/apache/kafka/pull/17626#discussion_r1824564383
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) {
return new
1 - 100 of 149 matches
Mail list logo
