adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828852012
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828820632
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
omkreddy merged PR #17537:
URL: https://github.com/apache/kafka/pull/17537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828860825
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828853882
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -207,13 +243,155 @@ Map
acquirablePartitions() {
return topicPartitionData;
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828836294
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -207,13 +243,155 @@ Map
acquirablePartitions() {
return topicPartitionData;
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828831006
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828824435
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -54,18 +59,23 @@ public class DelayedShareFetch extends DelayedOperation {
private f
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828824435
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -54,18 +59,23 @@ public class DelayedShareFetch extends DelayedOperation {
private f
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828824435
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -54,18 +59,23 @@ public class DelayedShareFetch extends DelayedOperation {
private f
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828825732
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -54,18 +59,23 @@ public class DelayedShareFetch extends DelayedOperation {
private f
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828820632
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828820632
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -146,18 +149,51 @@ public void onComplete() {
*/
@Override
public boolean
SArthurX opened a new pull request, #17693:
URL: https://github.com/apache/kafka/pull/17693
This PR fixes a minor typo in the comments of the
`EndToEndAuthorizationTest.scala` file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
mjsax opened a new pull request, #17691:
URL: https://github.com/apache/kafka/pull/17691
Call for review @bbejeck
This should be the last PR for EOSv1 removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828775451
##
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##
@@ -107,23 +109,125 @@ public void
testDelayedShareFetchTryCompleteReturnsFalse() {
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828758874
##
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##
@@ -107,23 +109,125 @@ public void
testDelayedShareFetchTryCompleteReturnsFalse() {
kirktrue opened a new pull request, #17690:
URL: https://github.com/apache/kafka/pull/17690
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade note
frankvicky commented on PR #17249:
URL: https://github.com/apache/kafka/pull/17249#issuecomment-2456201596
Hi @chia7712
I have let it run for a while, here is the result:
```
Reader offset = 14000, writer offset = 14000
Reader offset = 26853, writer offset = 29000
Reader offse
TaiJuWu commented on code in PR #17559:
URL: https://github.com/apache/kafka/pull/17559#discussion_r1828695395
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -873,7 +873,8 @@ public ConsumerRecords poll(final Duration timeout) {
*
TaiJuWu commented on code in PR #17678:
URL: https://github.com/apache/kafka/pull/17678#discussion_r1828682971
##
README.md:
##
@@ -47,6 +47,9 @@ Follow instructions in https://kafka.apache.org/quickstart
### Repeatedly running a particular unit/integration test ###
I=0; w
[
https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895489#comment-17895489
]
Xiao Yang commented on KAFKA-17917:
---
OK, thanks for your guidance, I'll familiarize my
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1828632310
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerInterceptor.java:
##
@@ -86,7 +87,37 @@ public interface ProducerInterceptor extends
Configurabl
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1828631651
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -1099,6 +1104,28 @@ private > void
doTestHeaders(Class serializerCla
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828630429
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala:
##
@@ -478,27 +479,51 @@ class KStreamTest extends TestDriver {
ass
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1828626942
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerInterceptors.java:
##
@@ -82,11 +84,12 @@ public ProducerRecord onSend(ProducerRecord
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1828626827
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerInterceptor.java:
##
@@ -86,7 +87,37 @@ public interface ProducerInterceptor extends
Configurabl
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1828626528
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1552,6 +1552,7 @@ private class AppendCallbacks implements
RecordAccumulator.
[
https://issues.apache.org/jira/browse/KAFKA-17930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895477#comment-17895477
]
TaiJuWu commented on KAFKA-17930:
-
KIP: [KIP-1107: Adding record-level acks for producer
artemlivshits commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1828614890
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -380,50 +417,39 @@ private[transaction] class TransactionMetadata(val
trans
fonsdant commented on PR #17198:
URL: https://github.com/apache/kafka/pull/17198#issuecomment-2456039084
@mjsax, I have removed the adding lines in buildTopologyWithDeduplication in
StandbyTaskEOSIntegrationTest to match the previous implementation with
transform (but still with process). A
rreddy-22 commented on PR #17687:
URL: https://github.com/apache/kafka/pull/17687#issuecomment-2456017190
Thanks for the PR, makes things much more clear and readable!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
xijiu commented on code in PR #17682:
URL: https://github.com/apache/kafka/pull/17682#discussion_r1828594016
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -465,10 +472,8 @@ public void
testClientAuthenticationRequestedNotProvided(Arg
mjsax commented on code in PR #17686:
URL: https://github.com/apache/kafka/pull/17686#discussion_r1828589912
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -1073,10 +1073,13 @@ private void
initializeTaskTimeAndProcessorMetadata(fin
jolshan commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1828582983
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -380,50 +417,39 @@ private[transaction] class TransactionMetadata(val
transaction
apoorvmittal10 commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828579315
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -103,34 +113,27 @@ public void onComplete() {
topicPartitionData, shareFetchD
vincent81jiang commented on PR #17688:
URL: https://github.com/apache/kafka/pull/17688#issuecomment-2455997862
> Thanks @vincent81jiang Please leave a description and let's make sure
tests pass :)
@jolshan, thanks for the review. Description updated.
--
This is an automated message
apoorvmittal10 commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828532884
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -54,18 +59,23 @@ public class DelayedShareFetch extends DelayedOperation {
private fi
fonsdant commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828561620
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala:
##
@@ -222,42 +221,6 @@ class KStreamTest extends TestDriver {
t
fonsdant commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828560503
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -276,61 +274,6 @@ class TopologyTest {
assertEquals(getTopologySc
jolshan commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1828564297
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -380,50 +417,39 @@ private[transaction] class TransactionMetadata(val
transaction
fonsdant commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828560503
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -276,61 +274,6 @@ class TopologyTest {
assertEquals(getTopologySc
kevin-wu24 opened a new pull request, #17689:
URL: https://github.com/apache/kafka/pull/17689
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895467#comment-17895467
]
Matthias J. Sax commented on KAFKA-17584:
-
Thanks. I tried to cherry-pick to 3.7
fonsdant commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828559286
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala:
##
@@ -448,27 +478,27 @@ class KStreamTest extends TestDriver {
artemlivshits commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1828556830
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -380,50 +417,39 @@ private[transaction] class TransactionMetadata(val
trans
[
https://issues.apache.org/jira/browse/KAFKA-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16955:
Fix Version/s: 3.7.2
> ConcurrentModification exception thrown by KafkaStream threadState
vincent81jiang opened a new pull request, #17688:
URL: https://github.com/apache/kafka/pull/17688
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mjsax commented on PR #16337:
URL: https://github.com/apache/kafka/pull/16337#issuecomment-2455948898
Also cherry-picked to `3.7` branch, for 3.7.2 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jolshan commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1828546672
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -380,50 +417,39 @@ private[transaction] class TransactionMetadata(val
transaction
yx9o commented on code in PR #17681:
URL: https://github.com/apache/kafka/pull/17681#discussion_r1828544817
##
clients/src/main/resources/common/message/BeginQuorumEpochResponse.json:
##
@@ -31,14 +31,17 @@
"versions": "0+", "fields": [
{ "name": "Partiti
mjsax commented on code in PR #16988:
URL: https://github.com/apache/kafka/pull/16988#discussion_r1828532147
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -1104,16 +1100,16 @@ public void process(final Record recor
artemlivshits opened a new pull request, #17687:
URL: https://github.com/apache/kafka/pull/17687
This is just a mechanical change to make prepareTransitionTo method use
named parameters instead of positional parameters.
--
This is an automated message from the Apache Git Service.
To r
mjsax commented on code in PR #17190:
URL: https://github.com/apache/kafka/pull/17190#discussion_r1828530363
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##
@@ -1776,27 +1229,6 @@ public void process(final Record record)
{
mjsax commented on code in PR #17190:
URL: https://github.com/apache/kafka/pull/17190#discussion_r1828530061
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##
@@ -312,79 +312,6 @@ public void
testDrivingSimpleTopologyWithDroppi
apoorvmittal10 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1828527303
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -138,17 +138,23 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Cluste
junrao commented on code in PR #17676:
URL: https://github.com/apache/kafka/pull/17676#discussion_r1828515179
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1704,7 +1704,7 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo) throws
[
https://issues.apache.org/jira/browse/KAFKA-17941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Jiang updated KAFKA-17941:
--
Description:
When loading transaction metadata from a transaction log partition, if the
parti
[
https://issues.apache.org/jira/browse/KAFKA-17941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-17941:
--
Assignee: Vincent Jiang
> TransactionStateManager.loadTransactionMetadata method may
Vincent Jiang created KAFKA-17941:
-
Summary: TransactionStateManager.loadTransactionMetadata method
may get stuck in an infinite loop
Key: KAFKA-17941
URL: https://issues.apache.org/jira/browse/KAFKA-17941
[
https://issues.apache.org/jira/browse/KAFKA-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895449#comment-17895449
]
Chia-Ping Tsai commented on KAFKA-17862:
[~hachikuji] FYI
> [buffer pool] corru
[
https://issues.apache.org/jira/browse/KAFKA-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895448#comment-17895448
]
Chia-Ping Tsai commented on KAFKA-17862:
[~bharathv] sorry for late response.
lianetm commented on code in PR #17150:
URL: https://github.com/apache/kafka/pull/17150#discussion_r1828337700
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -198,23 +198,47 @@ private void process(final CreateFe
bbejeck commented on PR #17686:
URL: https://github.com/apache/kafka/pull/17686#issuecomment-2455749760
ping one or two of @mjsax, @cadonna, @lucasbru, @aliehsaeedii for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895432#comment-17895432
]
Bill Bejeck commented on KAFKA-17635:
-
[~herbert.wespi] - I've pushed a new PR
> Lo
bbejeck opened a new pull request, #17686:
URL: https://github.com/apache/kafka/pull/17686
Kafka Streams actively purges records from repartition topics. Prior to
this PR, Kafka Streams would retrieve the offset from the `consumedOffsets`
map, but here are a couple of edge cases where the
vinnybod opened a new pull request, #17685:
URL: https://github.com/apache/kafka/pull/17685
The connect module is just an empty jar and empty pom. It doesn't need to be
published.
[repo1.maven.org/maven2/org/apache/kafka/connect/3.8.1/connect-3.8.1.pom](https://repo1.maven.org/maven2/org
[
https://issues.apache.org/jira/browse/KAFKA-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17910:
--
Assignee: PoAn Yang
> Create integration tests for Admin.listGroups and Admin.describ
[
https://issues.apache.org/jira/browse/KAFKA-16775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16775.
Resolution: Won't Fix
[~perli] thanks for this finding. close it right now
> Fix flaky
>
[
https://issues.apache.org/jira/browse/KAFKA-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895427#comment-17895427
]
Chia-Ping Tsai commented on KAFKA-17910:
[~yangpoan] I have assigned this to you
[
https://issues.apache.org/jira/browse/KAFKA-17920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17920.
Resolution: Won't Fix
> GroupType.parse should return Optional to represent the null or
>
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828382438
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala:
##
@@ -448,27 +478,27 @@ class KStreamTest extends TestDriver {
ass
chia7712 commented on PR #17667:
URL: https://github.com/apache/kafka/pull/17667#issuecomment-2455692010
@Yunyung sorry that `GroupType` is a public class so we can't change it for
now. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the me
chia7712 closed pull request #17667: KAFKA-17920: GroupType.parse should return
Optional to represent the null or empty
URL: https://github.com/apache/kafka/pull/17667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828379738
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##
@@ -2289,34 +2289,29 @@ public void process(final Record
record) {}
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828375999
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:
##
@@ -360,11 +367,9 @@ public KeyValue transform(fina
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828375800
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:
##
@@ -329,26 +330,32 @@ private KafkaStreams buildWit
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828374622
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:
##
@@ -329,26 +330,32 @@ private KafkaStreams buildWit
mjsax commented on code in PR #17198:
URL: https://github.com/apache/kafka/pull/17198#discussion_r1828373616
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:
##
@@ -329,26 +330,32 @@ private KafkaStreams buildWit
chia7712 commented on code in PR #17678:
URL: https://github.com/apache/kafka/pull/17678#discussion_r1828362659
##
README.md:
##
@@ -47,6 +47,9 @@ Follow instructions in https://kafka.apache.org/quickstart
### Repeatedly running a particular unit/integration test ###
I=0;
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828342286
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828340648
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828338335
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828338335
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828333740
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828329410
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828328279
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828305812
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17857.
Fix Version/s: 4.0.0
Resolution: Fixed
> Move AbstractResetIntegrationTest and subc
chia7712 merged PR #17594:
URL: https://github.com/apache/kafka/pull/17594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1828254033
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1576,6 +1582,30 @@ private Optional acknowledgeCompleteBatch(
return Optional.empty();
[
https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895415#comment-17895415
]
Kevin Wu commented on KAFKA-17917:
--
Hey [~yx9o]! Sounds good to me. The changes require
chia7712 commented on code in PR #17682:
URL: https://github.com/apache/kafka/pull/17682#discussion_r1828313353
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -465,10 +472,8 @@ public void
testClientAuthenticationRequestedNotProvided(
jolshan commented on PR #17619:
URL: https://github.com/apache/kafka/pull/17619#issuecomment-2455597512
@jeffkbkim @dajac Any further comments? Looks like the build is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lianetm commented on code in PR #17559:
URL: https://github.com/apache/kafka/pull/17559#discussion_r1828299830
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -873,7 +873,8 @@ public ConsumerRecords poll(final Duration timeout) {
*
chia7712 commented on code in PR #17217:
URL: https://github.com/apache/kafka/pull/17217#discussion_r1828309748
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClientTest.java:
##
@@ -268,26 +270,36 @@ public void testMetadataFailurePropagated
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828309012
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
mjsax commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828305812
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,506 @@
+/*
+ * Licensed to the Ap
apoorvmittal10 commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828303527
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4915,47 +4934,16 @@ public Uuid clientInstanceId(Duration timeout) {
apoorvmittal10 commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1828300874
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4915,47 +4934,16 @@ public Uuid clientInstanceId(Duration timeout) {
1 - 100 of 199 matches
Mail list logo
