Re: [PR] MINOR: document group coordinator metrics [kafka]

2025-05-16 Thread via GitHub
dajac commented on PR #19749: URL: https://github.com/apache/kafka/pull/19749#issuecomment-2888134965 @YutaLin Thanks for the patch. If I remember correctly, there is a section for group coordinator metrics. Are those missing there? -- This is an automated message from the Apache Git Serv

[jira] [Assigned] (KAFKA-19298) Move RuntimeLoggerManager to server module

2025-05-16 Thread Cheng Yi Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Yi Chang reassigned KAFKA-19298: -- Assignee: Cheng Yi Chang (was: Chia-Ping Tsai) > Move RuntimeLoggerManager to server

[PR] MINOR: document group coordinator metrics [kafka]

2025-05-16 Thread via GitHub
YutaLin opened a new pull request, #19749: URL: https://github.com/apache/kafka/pull/19749 As title Reviewers: PoAn Yang [pay...@apache.org](mailto:pay...@apache.org), Ken Huang [s7133...@gmail.com](mailto:s7133...@gmail.com), TengYao Chi [frankvi...@apache.org](mailto:fran

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-16 Thread via GitHub
apalan60 commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2093905499 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,694 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093871881 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093859165 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Kafka 16582 [kafka]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #19455: URL: https://github.com/apache/kafka/pull/19455#issuecomment-2888016488 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093865114 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093859165 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093859165 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-13333) Optimize condition for triggering rebalance after wiping out corrupted task

2025-05-16 Thread Colt McNealy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952316#comment-17952316 ] Colt McNealy commented on KAFKA-1: -- > If the task wasn't caught up on this host

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093356280 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19260: Move LoggingController to server module [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19687: URL: https://github.com/apache/kafka/pull/19687#discussion_r2093853688 ## server/src/main/java/org/apache/kafka/server/logging/Log4jCoreController.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Created] (KAFKA-19298) Move RuntimeLoggerManager to server module

2025-05-16 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19298: -- Summary: Move RuntimeLoggerManager to server module Key: KAFKA-19298 URL: https://issues.apache.org/jira/browse/KAFKA-19298 Project: Kafka Issue Type: Su

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093854538 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2093848474 ## core/src/test/scala/unit/kafka/log/LogConfigTest.scala: ## @@ -52,8 +52,13 @@ class LogConfigTest { assertTrue(LogConfig.configNames.asScala .filter(con

[PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-16 Thread via GitHub
kirktrue opened a new pull request, #19748: URL: https://github.com/apache/kafka/pull/19748 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira

[jira] [Updated] (KAFKA-18573) Add support for OAuth jwt-bearer grant type

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18573: -- Description: The current OAuth implementation allows for only {{client_credentials}} grant types. This

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093828163 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1959,17 +1963,19 @@ public void testCloseShouldBeIdempotent(GroupProtocol group

[jira] [Updated] (KAFKA-18139) AsyncKafkaConsumer's ConsumerNetworkThread loop requires further optimization

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18139: -- Labels: consumer-threading-refactor performance (was: ) > AsyncKafkaConsumer's ConsumerNetworkThread

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093814638 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093812751 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Updated] (KAFKA-18573) Add support for OAuth jwt-bearer grant type

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18573: -- Labels: OAuth2 kip-1139 (was: OAuth2 kip-1139 needs-kip) > Add support for OAuth jwt-bearer grant typ

[jira] [Created] (KAFKA-19297) Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19297: - Summary: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections Key: KAFKA-19297 URL: https://issues.apache.org/jira/browse/KAFKA-19297 Project: Kafka

[jira] [Updated] (KAFKA-19296) Revise AsyncKafkaConsumer event wakeup approach

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19296: -- Description: The {{AsyncKafkaConsumer}} uses an event queue-based mechanism to communicate between the

Re: [PR] KAFKA-19284: Add documentation to clarify the behavior of null values for all partitionsToOffsetAndMetadata methods. [kafka]

2025-05-16 Thread via GitHub
Rancho-7 commented on code in PR #19728: URL: https://github.com/apache/kafka/pull/19728#discussion_r2093810937 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java: ## @@ -66,7 +66,8 @@ public KafkaFuture>> all() { } /** - * R

[jira] [Created] (KAFKA-19296) Revise AsyncKafkaConsumer event wakeup approach

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19296: - Summary: Revise AsyncKafkaConsumer event wakeup approach Key: KAFKA-19296 URL: https://issues.apache.org/jira/browse/KAFKA-19296 Project: Kafka Issue Type: Improve

[jira] [Updated] (KAFKA-19295) Remove AsyncKafkaConsumer event ID generation

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19295: -- Fix Version/s: 4.1.0 > Remove AsyncKafkaConsumer event ID generation > ---

[jira] [Updated] (KAFKA-19295) Remove AsyncKafkaConsumer event ID generation

2025-05-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19295: -- Description: The {{AsyncKafkaConsumer}} uses an event queue-based mechanism to communicate between the

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-16 Thread via GitHub
artemlivshits commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2093786302 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -884,6 +884,50 @@ public void abortTransaction() throws ProducerFencedExcept

[PR] KAFKA-18345: Part two, remove exponential backoff for candidate state [kafka]

2025-05-16 Thread via GitHub
ahuang98 opened a new pull request, #19747: URL: https://github.com/apache/kafka/pull/19747 Replaces exponential backoff for candidate state after losing election with waiting rest of election timeout. We don't need an exponential backoff after PreVote was implemented since candidates t

[jira] [Created] (KAFKA-19295) Remove AsyncKafkaConsumer event ID generation

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19295: - Summary: Remove AsyncKafkaConsumer event ID generation Key: KAFKA-19295 URL: https://issues.apache.org/jira/browse/KAFKA-19295 Project: Kafka Issue Type: Improveme

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 2/N [kafka]

2025-05-16 Thread via GitHub
kirktrue closed pull request #19725: KAFKA-18847: Refactor OAuth layer to improve reusability 2/N URL: https://github.com/apache/kafka/pull/19725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [WIP] JWT bearer grant type support [kafka]

2025-05-16 Thread via GitHub
kirktrue closed pull request #18912: [WIP] JWT bearer grant type support URL: https://github.com/apache/kafka/pull/18912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-16 Thread via GitHub
rreddy-22 commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2093739425 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1332,6 +1332,7 @@ private void completeTransaction() { n

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-16 Thread via GitHub
jolshan commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2093701791 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1332,6 +1332,7 @@ private void completeTransaction() { new

[PR] MINOR:- Edit test in transaction command [kafka]

2025-05-16 Thread via GitHub
rreddy-22 opened a new pull request, #19746: URL: https://github.com/apache/kafka/pull/19746 The test incorrectly used force-terminate instead of forceTerminateTransaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-16 Thread via GitHub
bbejeck merged PR #19691: URL: https://github.com/apache/kafka/pull/19691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on PR #19700: URL: https://github.com/apache/kafka/pull/19700#issuecomment-2887638598 https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-05-16--001.f96ee1ad-1206-44da-ac81-5ba99ca2fb17--1747427122--lucasbru--system_

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-16 Thread via GitHub
junrao commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2887628228 It's useful to check if metadata.log.segment.min.bytes is used in any ducktape tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-19044: Handle tasks that are not present in the current topology [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on code in PR #19722: URL: https://github.com/apache/kafka/pull/19722#discussion_r2093604576 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredSubtopology.java: ## @@ -58,4 +64,6 @@ public StreamsGroupDescribeRespon

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on code in PR #19700: URL: https://github.com/apache/kafka/pull/19700#discussion_r2093593434 ## tests/kafkatest/tests/streams/streams_eos_test.py: ## @@ -160,10 +168,16 @@ def abort_streams(self, keep_alive_processor1, keep_alive_processor2, processor_

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on code in PR #19700: URL: https://github.com/apache/kafka/pull/19700#discussion_r2093593120 ## streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java: ## @@ -248,21 +250,33 @@ public static void verify(final String kafka, final boolean withR

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-16 Thread via GitHub
josefk31 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2093579035 ## clients/src/main/resources/common/message/GetReplicaLogInfoRequest.json: ## @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[PR] KAFKA-19294: Fix BrokerLifecycleManager RPC timeouts [kafka]

2025-05-16 Thread via GitHub
cmccabe opened a new pull request, #19745: URL: https://github.com/apache/kafka/pull/19745 Previously, we could wait for up to half of the broker session timeout for an RPC to complete, and then delay by up to half of the broker session timeout. When taken together, these two delays could l

[jira] [Created] (KAFKA-19294) Fix BrokerLifecycleManager RPC timeouts

2025-05-16 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-19294: Summary: Fix BrokerLifecycleManager RPC timeouts Key: KAFKA-19294 URL: https://issues.apache.org/jira/browse/KAFKA-19294 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-16 Thread via GitHub
junrao commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2093536869 ## core/src/test/scala/unit/kafka/log/LogConfigTest.scala: ## @@ -52,8 +52,13 @@ class LogConfigTest { assertTrue(LogConfig.configNames.asScala .filter(confi

[jira] [Created] (KAFKA-19293) Consolidate writes within GroupCoordinatorService#onPartitionsDeleted

2025-05-16 Thread David Jacot (Jira)
David Jacot created KAFKA-19293: --- Summary: Consolidate writes within GroupCoordinatorService#onPartitionsDeleted Key: KAFKA-19293 URL: https://issues.apache.org/jira/browse/KAFKA-19293 Project: Kafka

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
lianetm commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093503258 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1842,12 +1845,12 @@ public void testOffsetOfPausedPartitions(GroupProtocol gr

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-16 Thread via GitHub
dajac commented on PR #19744: URL: https://github.com/apache/kafka/pull/19744#issuecomment-2887451144 @lianetm @squah-confluent @dongnuo123 Could you please review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
lianetm commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093503258 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1842,12 +1845,12 @@ public void testOffsetOfPausedPartitions(GroupProtocol gr

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-16 Thread via GitHub
dajac commented on code in PR #19744: URL: https://github.com/apache/kafka/pull/19744#discussion_r2093526281 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -527,4 +527,88 @@ class OffsetFetchRequestTest(cluster: ClusterInstance) extends GroupCoordi

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-16 Thread via GitHub
dajac commented on code in PR #19744: URL: https://github.com/apache/kafka/pull/19744#discussion_r2093524420 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -906,7 +907,7 @@ public OffsetFetchResponseData.OffsetFetchRespons

[PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-16 Thread via GitHub
dajac opened a new pull request, #19744: URL: https://github.com/apache/kafka/pull/19744 This patch updates the OffsetFetch API to ensure that a committed offset is returned iff the requested topic id matches the persisted one; the invalid offset is returned otherwise. -- This is an

Re: [PR] KAFKA-19280: Fix NoSuchElementException in UnifiedLog [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on PR #19717: URL: https://github.com/apache/kafka/pull/19717#issuecomment-2887408768 Thanks for the review @mimaison. Ready for re-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-19280: Fix NoSuchElementException in UnifiedLog [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on code in PR #19717: URL: https://github.com/apache/kafka/pull/19717#discussion_r2093505491 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -671,8 +672,9 @@ private LogOffsetMetadata fetchLastStableOffsetMetadata() thro

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-16 Thread via GitHub
bbejeck commented on PR #19691: URL: https://github.com/apache/kafka/pull/19691#issuecomment-2887358874 @lucasbru latest comment addressed and ready for another pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-16 Thread via GitHub
bbejeck commented on PR #19700: URL: https://github.com/apache/kafka/pull/19700#issuecomment-2887305270 Seems the checkstyle check is related. Also, can you post a link for the successful system test run? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-16 Thread via GitHub
bbejeck commented on code in PR #19700: URL: https://github.com/apache/kafka/pull/19700#discussion_r2093435225 ## tests/kafkatest/tests/streams/streams_eos_test.py: ## @@ -160,10 +168,16 @@ def abort_streams(self, keep_alive_processor1, keep_alive_processor2, processor_

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-16 Thread via GitHub
AndrewJSchofield commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2093435595 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -19,41 +19,42 @@ import org.apache.kafka

Re: [PR] KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on PR #19582: URL: https://github.com/apache/kafka/pull/19582#issuecomment-2887236918 @m1a2st could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093388713 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-16 Thread via GitHub
chia7712 merged PR #19579: URL: https://github.com/apache/kafka/pull/19579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2093375272 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Softwar

[jira] [Created] (KAFKA-19292) Introduce soft state for StreamsGroup

2025-05-16 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-19292: --- Summary: Introduce soft state for StreamsGroup Key: KAFKA-19292 URL: https://issues.apache.org/jira/browse/KAFKA-19292 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-19260: Move LoggingController to server module [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19687: URL: https://github.com/apache/kafka/pull/19687#discussion_r2093369859 ## server/src/main/java/org/apache/kafka/server/LoggingController.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19284: Add documentation to clarify the behavior of null values for all partitionsToOffsetAndMetadata methods. [kafka]

2025-05-16 Thread via GitHub
LoganZhuZzz commented on code in PR #19728: URL: https://github.com/apache/kafka/pull/19728#discussion_r2093371056 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java: ## @@ -66,7 +66,8 @@ public KafkaFuture>> all() { } /** -

[PR] KAFKA-18904: Add Admin#listConfigResources (wip) [kafka]

2025-05-16 Thread via GitHub
FrankYang0529 opened a new pull request, #19743: URL: https://github.com/apache/kafka/pull/19743 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add som

Re: [PR] KAFKA-19226: Added test_console_share_consumer.py [kafka]

2025-05-16 Thread via GitHub
AndrewJSchofield merged PR #19708: URL: https://github.com/apache/kafka/pull/19708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Refactor KafkaApis handle methods to return CompletableFuture for consistent error flows [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19724: URL: https://github.com/apache/kafka/pull/19724#discussion_r2093356674 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -384,15 +385,15 @@ class KafkaApis(val requestChannel: RequestChannel, /** * Handle a produce request

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093356280 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-16 Thread via GitHub
chia7712 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2093347402 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Updated] (KAFKA-19282) Update quotaTypesEnabled on quota removal in ClientQuotaManager

2025-05-16 Thread Mahsa Seifikar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahsa Seifikar updated KAFKA-19282: --- Description: In kafka.server.ClientQuotaManager class, quotaTypesEnabled is not updated when

[PR] [KAFKA-19282] Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-16 Thread via GitHub
MahsaSeifikar opened a new pull request, #19742: URL: https://github.com/apache/kafka/pull/19742 In `kafka.server.ClientQuotaManager` class, `quotaTypesEnabled` is not updated when a quota is removed via `removeQuota` method in `DefaultQuotaCallback` class. This field is set when quotas are

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2093294639 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,694 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-05-16 Thread via GitHub
janchilling commented on PR #19275: URL: https://github.com/apache/kafka/pull/19275#issuecomment-2887091400 Hi @cadonna , I think I have completed all, sorry for the delay though. Only one problem remainins. Which is the `StreamThreadTest#testNamedTopologyWithStreamsProtocol` a

Re: [PR] MINOR: Remove unnecessary test conditions where ListOffsetsRequest version is 0 [kafka]

2025-05-16 Thread via GitHub
m1a2st commented on code in PR #19738: URL: https://github.com/apache/kafka/pull/19738#discussion_r2093274004 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -214,13 +214,7 @@ class ListOffsetsRequestTest extends BaseRequestTest { TestUtils.prod

[jira] [Resolved] (KAFKA-19141) Persist topic id in OffsetCommit record

2025-05-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19141. - Fix Version/s: 4.1.0 Resolution: Fixed > Persist topic id in OffsetCommit record > --

Re: [PR] KAFKA-15283:[1/N] Client support for OffsetCommit with topic ID [kafka]

2025-05-16 Thread via GitHub
lianetm commented on code in PR #19577: URL: https://github.com/apache/kafka/pull/19577#discussion_r2093194584 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -730,7 +739,10 @@ public NetworkClientDelegate.UnsentRequest toUn

Re: [PR] MINOR: changed the default value of metadata_quorum in test methods to quorum.isolated_kraft where quorum.zk was used [kafka]

2025-05-16 Thread via GitHub
AndrewJSchofield merged PR #19707: URL: https://github.com/apache/kafka/pull/19707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19231-1: Handle fetch request when share session cache is full [kafka]

2025-05-16 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19701: URL: https://github.com/apache/kafka/pull/19701#discussion_r2088357326 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4824,6 +4824,42 @@ class KafkaApisTest extends Logging { assertEquals(Errors.INVALID_SH

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-16 Thread via GitHub
bbejeck commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2093198358 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1983,18 +1985,24 @@ private CoordinatorResult stream St

Re: [PR] MINOR: migrate MinInSyncReplicasConfigTest to server module [kafka]

2025-05-16 Thread via GitHub
frankvicky merged PR #19727: URL: https://github.com/apache/kafka/pull/19727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[PR] MINOR: assignablePartitions returns all partitions for non-share groups. [kafka]

2025-05-16 Thread via GitHub
smjn opened a new pull request, #19739: URL: https://github.com/apache/kafka/pull/19739 * A bug in `TargetAssignmentBuilder.java` was preventing `SubscribedTopicDescriber.assignablePartitions` from returning set of all partitions the input topicId for non-share groups. * This was because

Re: [PR] KAFKA-19226: Added test_console_share_consumer.py [kafka]

2025-05-16 Thread via GitHub
AndrewJSchofield commented on code in PR #19708: URL: https://github.com/apache/kafka/pull/19708#discussion_r2092562245 ## tests/kafkatest/services/console_consumer.py: ## @@ -313,4 +313,3 @@ def wait_for_offset_reset(self, node, topic, num_partitions): wait_until(

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-16 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2088351150 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,98 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-16 Thread via GitHub
lucasbru commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2087438125 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsRebalanceData.java: ## @@ -355,6 +357,9 @@ public Map subtopologies() { return sub

Re: [PR] MINOR: Cleaning up code for share feature listener [kafka]

2025-05-16 Thread via GitHub
AndrewJSchofield commented on PR #19715: URL: https://github.com/apache/kafka/pull/19715#issuecomment-2879257695 > > @apoorvmittal10 , In KafkaApis, I think you're referring to this [check](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L3995) `c

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-16 Thread via GitHub
dajac commented on PR #19523: URL: https://github.com/apache/kafka/pull/19523#issuecomment-2879230830 @FrankYang0529 Thanks for the update. Could you please also update the description of the PR? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] KAFKA-19274; Group Coordinator Shards are not unloaded when `__consumer_offsets` topic is deleted [kafka]

2025-05-16 Thread via GitHub
dajac opened a new pull request, #19713: URL: https://github.com/apache/kafka/pull/19713 Group Coordinator Shards are not unloaded when `__consumer_offsets` topic is deleted. The unloading is scheduled but it is ignored because the epoch is equal to the current epoch: ``` [2025-05

[jira] [Assigned] (KAFKA-19290) Exploit mapKey optimisation in protocol requests and responses

2025-05-16 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-19290: Assignee: PoAn Yang > Exploit mapKey optimisation in protocol requests and respon

[jira] [Commented] (KAFKA-19290) Exploit mapKey optimisation in protocol requests and responses

2025-05-16 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952080#comment-17952080 ] Andrew Schofield commented on KAFKA-19290: -- Absolutely. That would help a lot.

[jira] [Created] (KAFKA-19291) Increase the timeout of remote storage share fetch requests in purgatory

2025-05-16 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-19291: - Summary: Increase the timeout of remote storage share fetch requests in purgatory Key: KAFKA-19291 URL: https://issues.apache.org/jira/browse/KAFKA-19291 Project: K

[jira] [Commented] (KAFKA-19290) Exploit mapKey optimisation in protocol requests and responses

2025-05-16 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952042#comment-17952042 ] PoAn Yang commented on KAFKA-19290: --- Hi [~schofielaj], if you're not working on this,

[jira] [Created] (KAFKA-19290) Exploit mapKey optimisation in protocol requests and responses

2025-05-16 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19290: Summary: Exploit mapKey optimisation in protocol requests and responses Key: KAFKA-19290 URL: https://issues.apache.org/jira/browse/KAFKA-19290 Project: Kafka

[jira] [Commented] (KAFKA-19044) Handle tasks that are not present in the current topology

2025-05-16 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952033#comment-17952033 ] Lucas Brutschy commented on KAFKA-19044: https://github.com/apache/kafka/pull/19