Re: [PR] KAFKA-19498: Add include argument to ConsumerPerformance tool [kafka]

2025-08-21 Thread via GitHub
fvaleri commented on code in PR #20221: URL: https://github.com/apache/kafka/pull/20221#discussion_r2292863346 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -135,6 +138,30 @@ public static void printErrorAndExit(String message) {

Re: [PR] KAFKA-10357: Refactor makeReady to reduce complexity and support upcoming KIP-698 changes [kafka]

2025-08-21 Thread via GitHub
mjsax commented on PR #20326: URL: https://github.com/apache/kafka/pull/20326#issuecomment-3213070123 It seems `InternalTopicManagerTest` fails. This refactoring should not change the logic though. Can you take a look? Can make another full pass, after the test is back to green :) -- Th

Re: [PR] KAFKA-10357: Refactor makeReady to reduce complexity and support upcoming KIP-698 changes [kafka]

2025-08-21 Thread via GitHub
mjsax commented on code in PR #20326: URL: https://github.com/apache/kafka/pull/20326#discussion_r2292718498 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -578,8 +579,29 @@ private void readyTopics(final Set topicsToCreat

Re: [PR] KAFKA-10357: Refactor makeReady to reduce complexity and support upcoming KIP-698 changes [kafka]

2025-08-21 Thread via GitHub
mjsax commented on code in PR #20326: URL: https://github.com/apache/kafka/pull/20326#discussion_r2292715152 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -527,8 +527,9 @@ private Set computeTopicsToCreate(final Map topic

Re: [PR] KAFKA-10357: Refactor makeReady to reduce complexity and support upcoming KIP-698 changes [kafka]

2025-08-21 Thread via GitHub
mjsax commented on code in PR #20326: URL: https://github.com/apache/kafka/pull/20326#discussion_r2292699761 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,120 +466,119 @@ public Set makeReady(final Map topics) {

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-08-21 Thread via GitHub
sjhajharia commented on code in PR #20348: URL: https://github.com/apache/kafka/pull/20348#discussion_r229268 ## raft/src/main/java/org/apache/kafka/raft/internals/EpochElection.java: ## @@ -28,7 +28,7 @@ * Tracks the votes cast by voters in an election held by a Nominee.

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-21 Thread via GitHub
yunchipang commented on PR #20396: URL: https://github.com/apache/kafka/pull/20396#issuecomment-3212932477 e2e test result ``` SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/opt/kafka-dev/core/build/dependant-testlibs/log4j-slf4j-impl-2.24.3.j

Re: [PR] KAFKA-15038: Replace topicIdByPartitionMap with MetadataCache instance in RemoteLogManager [kafka]

2025-08-21 Thread via GitHub
github-actions[bot] commented on PR #20256: URL: https://github.com/apache/kafka/pull/20256#issuecomment-3212913051 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-08-21 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-3212913871 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17218: let kafka-consumer-groups handle describe groups with deleted topics [kafka]

2025-08-21 Thread via GitHub
github-actions[bot] commented on PR #19029: URL: https://github.com/apache/kafka/pull/19029#issuecomment-3212913794 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-10789 : Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-08-21 Thread via GitHub
github-actions[bot] commented on PR #20353: URL: https://github.com/apache/kafka/pull/20353#issuecomment-3212912841 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Assigned] (KAFKA-19634) document the encoding of nullable struct

2025-08-21 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19634: Assignee: Lan Ding > document the encoding of nullable struct > -

Re: [PR] KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR [kafka]

2025-08-21 Thread via GitHub
DDDFiish commented on PR #10313: URL: https://github.com/apache/kafka/pull/10313#issuecomment-3212771566 > > Is this correct? > > yes, that should be expected. Also, it seems related code were removed already. Thank you for your response, but I still see this error in Kafka 3.9

Re: [PR] [KAFKA-19174] [KAFKA-19591] Gradle version upgrade 8 -->> 9 [kafka]

2025-08-21 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3212837033 _**Few notes for reviewers:**_ - **Gradle team confirms that version 9.0.0 is stable** (regression mentioned above is hitting only **9.1.0-rc-1** version: https://github.com/gradle

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-08-21 Thread via GitHub
johnny94 commented on PR #19793: URL: https://github.com/apache/kafka/pull/19793#issuecomment-3212807078 @chia7712 Thanks. Fixed conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Updated] (KAFKA-19174) Gradle version upgrade 8 -->> 9

2025-08-21 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19174: --- Description: {panel:title=Note: this ticket contains another ticket|borderStyle=das

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version was being referenced [kafka]

2025-08-21 Thread via GitHub
dejan2609 closed pull request #20327: KAFKA-19591 solving issues with `gradlew` content: an old template version was being referenced URL: https://github.com/apache/kafka/pull/20327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version was being referenced [kafka]

2025-08-21 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3212768343 Note: this PR will be closed, but code is moved and can be reviewed in a related PR here :arrow_down: - #19513 -- This is an automated message from the Apache Git Service. To re

[jira] [Resolved] (KAFKA-19618) the `record-size` and `throughput`arguments don't work in TestRaftServer

2025-08-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19618. Fix Version/s: 4.2.0 Resolution: Fixed > the `record-size` and `throughput`argument

[PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-21 Thread via GitHub
apoorvmittal10 opened a new pull request, #20395: URL: https://github.com/apache/kafka/pull/20395 The PR fixes the batch alignment issue when partitions are re-assigned. During initial read of state the batches can be broken arbitrarily. Say the start offset is 10 and cache contains [15-18]

[jira] [Commented] (KAFKA-19634) document the encoding of nullable struct

2025-08-21 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015548#comment-18015548 ] Lan Ding commented on KAFKA-19634: -- Hi [~junrao], if you are not working on this, may i

[PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-21 Thread via GitHub
yunchipang opened a new pull request, #20396: URL: https://github.com/apache/kafka/pull/20396 issue: [KAFKA-19616](https://issues.apache.org/jira/browse/KAFKA-19616) **why**: validate log compaction works correctly with compressed data. **what**: adds compression config options to `

[jira] [Created] (KAFKA-19634) document the encoding of nullable struct

2025-08-21 Thread Jun Rao (Jira)
Jun Rao created KAFKA-19634: --- Summary: document the encoding of nullable struct Key: KAFKA-19634 URL: https://issues.apache.org/jira/browse/KAFKA-19634 Project: Kafka Issue Type: Improvement

[PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-08-21 Thread via GitHub
sjhajharia opened a new pull request, #20393: URL: https://github.com/apache/kafka/pull/20393 This PR aims at cleaning up the`connect:runtime` module further by getting rid of some extra code which can be replaced by record and the relevant changes. -- This is an automated message from th

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
junrao commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2291889455 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

Re: [PR] KAFKA-19574: Improve producer and consumer config files [kafka]

2025-08-21 Thread via GitHub
kirktrue commented on PR #20302: URL: https://github.com/apache/kafka/pull/20302#issuecomment-3212339792 We need someone to add the `ci-approved` label so that we can see it pass the tests, but looks good otherwise. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-19574: Improve producer and consumer config files [kafka]

2025-08-21 Thread via GitHub
kirktrue commented on PR #20302: URL: https://github.com/apache/kafka/pull/20302#issuecomment-3212338442 > I added a couple of tests to ensure that these files remain in sync with config definitions. Perfect! Thanks! -- This is an automated message from the Apache Git Service. To r

Re: [PR] MINOR: Change LogCompactionTester topics parameter to Set [kafka]

2025-08-21 Thread via GitHub
yunchipang commented on code in PR #20372: URL: https://github.com/apache/kafka/pull/20372#discussion_r2292283432 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -246,9 +248,9 @@ public static void main(String[] args) throws Exception { int

Re: [PR] MINOR: Change LogCompactionTester topics parameter to Set [kafka]

2025-08-21 Thread via GitHub
yunchipang commented on code in PR #20372: URL: https://github.com/apache/kafka/pull/20372#discussion_r2292251480 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -430,14 +433,14 @@ record = new ProducerRecord<>(topic, } } -privat

[jira] [Commented] (KAFKA-19629) Deadlock in Kafka Streams when processing Interactive Queries and state store updates concurrently

2025-08-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015527#comment-18015527 ] Matthias J. Sax commented on KAFKA-19629: - Thanks for filing this ticket. Seems

[jira] [Updated] (KAFKA-19629) Deadlock in Kafka Streams when processing Interactive Queries and state store updates concurrently

2025-08-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19629: Affects Version/s: 3.8.0 (was: 3.8.1)

[jira] [Created] (KAFKA-19633) Kafka Connect connectors sent out zombie records during rebalance

2025-08-21 Thread Shichao An (Jira)
Shichao An created KAFKA-19633: -- Summary: Kafka Connect connectors sent out zombie records during rebalance Key: KAFKA-19633 URL: https://issues.apache.org/jira/browse/KAFKA-19633 Project: Kafka

[jira] [Created] (KAFKA-19632) Handle overlap batch alignment on partition reassignment

2025-08-21 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19632: - Summary: Handle overlap batch alignment on partition reassignment Key: KAFKA-19632 URL: https://issues.apache.org/jira/browse/KAFKA-19632 Project: Kafka Is

Re: [PR] KAFKA-19301: Move and rewrite partition state classes to Java in org.apache.kafka.storage.internals.log [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20083: URL: https://github.com/apache/kafka/pull/20083#discussion_r2291641901 ## storage/src/main/java/org/apache/kafka/storage/internals/log/PartitionState.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-19506 : Implement dynamic compression type selection and fallback for client telemetry [kafka]

2025-08-21 Thread via GitHub
apoorvmittal10 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2291882949 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -123,10 +124,24 @@ public void testValidateIntervalMsIn

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2292156273 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

Re: [PR] KAFKA-19598: Command-line arguments for producer perf test [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20361: URL: https://github.com/apache/kafka/pull/20361#discussion_r2292111738 ## tests/kafkatest/services/performance/producer_performance.py: ## @@ -91,7 +91,7 @@ def start_cmd(self, node): cmd += " export KAFKA_LOG4J_OPTS=\"%s%s\";

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
junrao commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2292118740 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version was being referenced [kafka]

2025-08-21 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3212013942 @apoorvmittal10 you are free to review this PR (but it also makes sense to wait for me to bundle all changes for another PR - thing is that these changes are prerequisite for a Gradle v

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2292089211 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

[PR] MINOR: Remove fetchQuotaMetrics and copyQuotaMetrics [kafka]

2025-08-21 Thread via GitHub
jim0987795064 opened a new pull request, #20394: URL: https://github.com/apache/kafka/pull/20394 - Changes: Remove fetchQuotaMetrics and copyQuotaMetrics in RemoteLogManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [WIP] KAFKA-19588: Reduce number of events generated in AsyncKafkaConsumer.poll() [kafka]

2025-08-21 Thread via GitHub
lianetm commented on code in PR #20363: URL: https://github.com/apache/kafka/pull/20363#discussion_r2291474222 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -859,16 +865,19 @@ public ConsumerRecords poll(final Duration timeou

Re: [PR] KAFKA-18699: Cleanup Metadata Module [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20346: URL: https://github.com/apache/kafka/pull/20346#discussion_r2292066790 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -105,56 +103,39 @@ public DescribeUserScramCredentialsResponseData describe(DescribeUserScramC

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version was being referenced [kafka]

2025-08-21 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3211990106 I will have to rebase/force-push in order to sync two PR's (this one and Gradle upgrade 8 -> 9, see above for more details). -- This is an automated message from the Apache Git Servic

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2292051717 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

[PR] KAFKA-19617: ConsumerPerformance#ConsumerPerfRebListener get corrupted value when the number of partitions is increased [kafka]

2025-08-21 Thread via GitHub
DL1231 opened a new pull request, #20388: URL: https://github.com/apache/kafka/pull/20388 With changes to the consumer protocol, rebalance may not necessarily result in a "stop the world". Thus, the method for calculating pause time in `ConsumerPerformance#ConsumerPerfRebListener` needs

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2291935770 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -122,27 +149,44 @@ static void execute(String... args) throws Exception { la

[jira] [Assigned] (KAFKA-19631) Admin#describeReplicaLogDirs does not handle error correctly

2025-08-21 Thread Chang-Yu Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang-Yu Huang reassigned KAFKA-19631: -- Assignee: Chang-Yu Huang (was: Chia-Ping Tsai) > Admin#describeReplicaLogDirs does n

Re: [PR] KAFKA-8350 Fix stack overflow when batch size is larger than cluster max.message.byte [kafka]

2025-08-21 Thread via GitHub
knoxy5467 commented on PR #20358: URL: https://github.com/apache/kafka/pull/20358#issuecomment-3211753722 unclear why the java17 JUnit tests step was cancelled here. Did it reach some sort of timeout? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on PR #10313: URL: https://github.com/apache/kafka/pull/10313#issuecomment-3211763095 > Is this correct? yes, that should be expected. Also, it seems related code were removed already. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-19193 Support rack-aware partitioning for Kafka producer [kafka]

2025-08-21 Thread via GitHub
marcospassos commented on PR #19850: URL: https://github.com/apache/kafka/pull/19850#issuecomment-3211737196 Is there any chance this feature will be included in the next release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20348: URL: https://github.com/apache/kafka/pull/20348#discussion_r2291896856 ## raft/src/main/java/org/apache/kafka/raft/internals/EpochElection.java: ## @@ -28,7 +28,7 @@ * Tracks the votes cast by voters in an election held by a Nominee.

Re: [PR] KAFKA-19582 the current assignments shown by ReassignPartitionsCommand should include the log directories [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20319: URL: https://github.com/apache/kafka/pull/20319#discussion_r2291766406 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -1514,4 +1520,26 @@ static Set alterReplicaLogDirs(Admin adminClient,

[jira] [Created] (KAFKA-19631) Admin#describeReplicaLogDirs does not handle error correctly

2025-08-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19631: -- Summary: Admin#describeReplicaLogDirs does not handle error correctly Key: KAFKA-19631 URL: https://issues.apache.org/jira/browse/KAFKA-19631 Project: Kafka

Re: [PR] KAFKA-19506 : Implement dynamic compression type selection and fallback for client telemetry [kafka]

2025-08-21 Thread via GitHub
k-raina commented on PR #20144: URL: https://github.com/apache/kafka/pull/20144#issuecomment-3211706850 @apoorvmittal10 Rebased branch. Build should pass now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-21 Thread via GitHub
bbejeck commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2291849094 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -535,18 +660,20 @@ public void shouldRecycleStateFro

Re: [PR] KAFKA-19612: Remove Redundant Validation in StripedReplicaPlacer [kafka]

2025-08-21 Thread via GitHub
pjl1070048431 commented on PR #20360: URL: https://github.com/apache/kafka/pull/20360#issuecomment-3211701725 I think either is fine. Let's keep the checks within the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-08-21 Thread via GitHub
sjhajharia commented on code in PR #20348: URL: https://github.com/apache/kafka/pull/20348#discussion_r2291760939 ## raft/src/main/java/org/apache/kafka/raft/internals/EpochElection.java: ## @@ -28,7 +28,7 @@ * Tracks the votes cast by voters in an election held by a Nominee.

Re: [PR] POC: conditional creation of internal topics in Kafka Connect [kafka]

2025-08-21 Thread via GitHub
anton-liauchuk commented on PR #20384: URL: https://github.com/apache/kafka/pull/20384#issuecomment-3211561748 @C0urante, @mimaison, @chia7712 could you take a look at this POC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: Move RaftManager interface to raft module [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20366: URL: https://github.com/apache/kafka/pull/20366#discussion_r2291759002 ## core/src/main/scala/kafka/raft/KafkaRaftManager.scala: ## @@ -292,12 +260,8 @@ class KafkaRaftManager[T]( (controllerListenerName, networkClient) } - ove

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-08-21 Thread via GitHub
sjhajharia commented on code in PR #20348: URL: https://github.com/apache/kafka/pull/20348#discussion_r2291758320 ## raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java: ## @@ -19,47 +19,15 @@ import java.util.Objects; import java.util.OptionalInt; -public class Lea

Re: [PR] KAFKA-19618: the `record-size` and `throughput`arguments don't work in TestRaftServer [kafka]

2025-08-21 Thread via GitHub
chia7712 merged PR #20379: URL: https://github.com/apache/kafka/pull/20379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19432: Add an ERROR log message if broker.heartbeat.interval.ms is too large [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20046: URL: https://github.com/apache/kafka/pull/20046#discussion_r2291616712 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -513,6 +513,11 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) require(repli

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20348: URL: https://github.com/apache/kafka/pull/20348#discussion_r2291631707 ## raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java: ## @@ -19,47 +19,15 @@ import java.util.Objects; import java.util.OptionalInt; -public class Leade

Re: [PR] KAFKA-19630: Reordered OR operands in archiveRecords method for SharePartiton [kafka]

2025-08-21 Thread via GitHub
chirag-wadhwa5 commented on code in PR #20391: URL: https://github.com/apache/kafka/pull/20391#discussion_r2291545734 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -4493,6 +4493,100 @@ public void testLsoMovementForArchivingBatches() { assertN

Re: [PR] KAFKA-19498: Add include argument to ConsumerPerformance tool [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20221: URL: https://github.com/apache/kafka/pull/20221#discussion_r2291554916 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -135,6 +138,30 @@ public static void printErrorAndExit(String message) {

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-21 Thread via GitHub
janchilling commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3211274881 Hi @cadonna , @mjsax , This is the first in a series of PRs to remove the state.updater.enabled flag, since it was requested to create multiple small PRs. The StreamThrea

[PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-21 Thread via GitHub
janchilling opened a new pull request, #20392: URL: https://github.com/apache/kafka/pull/20392 …related flow This change removes the `state.updater.enabled` negation from StreamThread, making the StateUpdater always active by default. As part of this cleanup: - Removed conditio

Re: [PR] KAFKA-19612: Remove Redundant Validation in StripedReplicaPlacer [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on PR #20360: URL: https://github.com/apache/kafka/pull/20360#issuecomment-3211234157 https://github.com/apache/kafka/pull/10823/files#r646142461 @pjl1070048431 Could you please take a look at above comment? it makes sense to me since `RackList` could be access in t

[jira] [Commented] (KAFKA-10093) Replace iteration with call to addAll in Utils

2025-08-21 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015424#comment-18015424 ] Ksolves India Limited commented on KAFKA-10093: --- Hi [~ijuma] / [~jghoman] 

Re: [PR] KAFKA-19630: Reordered OR operands in archiveRecords method for SharePartiton [kafka]

2025-08-21 Thread via GitHub
apoorvmittal10 commented on code in PR #20391: URL: https://github.com/apache/kafka/pull/20391#discussion_r2291025889 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -4493,6 +4493,100 @@ public void testLsoMovementForArchivingBatches() { assertN

[jira] [Comment Edited] (KAFKA-10093) Replace iteration with call to addAll in Utils

2025-08-21 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015424#comment-18015424 ] Ksolves India Limited edited comment on KAFKA-10093 at 8/21/25 12:50 PM: -

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290963237 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

[jira] [Assigned] (KAFKA-10093) Replace iteration with call to addAll in Utils

2025-08-21 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-10093: - Assignee: Ksolves India Limited (was: Can Cecen) > Replace iteration w

[PR] KAFKA-19630: Changed the order of expressions of || in archiveRecords method so that short-circuit does not prevent archiving necessary records / batches [kafka]

2025-08-21 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #20391: URL: https://github.com/apache/kafka/pull/20391 As per the current implementation in archiveRecords, when LSO is updated, if we have multiple record batches before the new LSO, then only the first one gets archived. This is because of the fo

[jira] [Assigned] (KAFKA-18157) Consider UnsupportedVersionException child class to represent the case of unsupported fields

2025-08-21 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-18157: - Assignee: Ksolves India Limited (was: TengYao Chi) > Consider Unsuppor

[jira] [Assigned] (KAFKA-18157) Consider UnsupportedVersionException child class to represent the case of unsupported fields

2025-08-21 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-18157: - Assignee: TengYao Chi (was: Ksolves India Limited) > Consider Unsuppor

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2290635415 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java: ## @@ -61,11 +61,13 @@ public abstract class HeaderFrom> implements Transfor

[jira] [Created] (KAFKA-19630) LSO movement archives only the first available batch not all the ones prior to the new LSO

2025-08-21 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19630: - Summary: LSO movement archives only the first available batch not all the ones prior to the new LSO Key: KAFKA-19630 URL: https://issues.apache.org/jira/browse/KAFKA-19630

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
kamalcph commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290659047 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2290635415 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java: ## @@ -61,11 +61,13 @@ public abstract class HeaderFrom> implements Transfor

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2290633025 ## server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java: ## @@ -79,7 +80,13 @@ public AbstractKafkaConfig(ConfigDef definition, Map originals, M

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2290620056 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290612736 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290589077 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

Re: [PR] MINOR: update TransactionLog#readTxnRecordValue to initialize TransactionMetadata with non-empty topic partitions [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20370: URL: https://github.com/apache/kafka/pull/20370#discussion_r2290558185 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -115,28 +115,25 @@ object TransactionLog { val version = buffer.getShort

Re: [PR] [WIP] KAFKA-19588: Reduce number of events generated in AsyncKafkaConsumer.poll() [kafka]

2025-08-21 Thread via GitHub
AndrewJSchofield commented on code in PR #20363: URL: https://github.com/apache/kafka/pull/20363#discussion_r2290534883 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -859,16 +865,19 @@ public ConsumerRecords poll(final Durati

[jira] [Commented] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015369#comment-18015369 ] PoAn Yang commented on KAFKA-17719: --- Sorry, I don't work on this recently. I remove my

[jira] [Assigned] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17719: - Assignee: (was: PoAn Yang) > Connect may fail to start tasks when reading from a compacted

Re: [PR] MINOR: kafka-stream-groups.sh should fail quickly if the partition leader is unavailable [kafka]

2025-08-21 Thread via GitHub
JimmyWang6 commented on PR #20271: URL: https://github.com/apache/kafka/pull/20271#issuecomment-3209751294 Hi @aliehsaeedii @chia7712 @lucasbru , I was wondering if you could take a look at it when you get a chance. Thanks~ -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread Martin Andersson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015360#comment-18015360 ] Martin Andersson commented on KAFKA-17719: -- [~yangpoan] are you actively workin

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
kamalcph commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290417448 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

[PR] KAFKA-19625: Consistency of command-line arguments for verifiable producer/consumer [kafka]

2025-08-21 Thread via GitHub
JimmyWang6 opened a new pull request, #20390: URL: https://github.com/apache/kafka/pull/20390 As described in [jira](https://issues.apache.org/jira/browse/KAFKA-19625), this PR implements replace `consumer.config` and `producer.config` with `command-config` for kafka-verifiable-producer.sh

Re: [PR] KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully [kafka]

2025-08-21 Thread via GitHub
kamalcph commented on code in PR #20342: URL: https://github.com/apache/kafka/pull/20342#discussion_r2290429757 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -2050,10 +2047,13 @@ public void close() { } finally

[PR] MINOR: Cleanup Connect Module (4/n) [kafka]

2025-08-21 Thread via GitHub
sjhajharia opened a new pull request, #20389: URL: https://github.com/apache/kafka/pull/20389 Now that Kafka support Java 17, this PR makes some changes in connect module. The changes in this PR are limited to only some files. A future PR(s) shall follow. The changes mostly inclu

[jira] [Comment Edited] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread Martin Andersson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015356#comment-18015356 ] Martin Andersson edited comment on KAFKA-17719 at 8/21/25 9:02 AM: ---

[jira] [Comment Edited] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread Martin Andersson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015356#comment-18015356 ] Martin Andersson edited comment on KAFKA-17719 at 8/21/25 9:02 AM: ---

[jira] [Commented] (KAFKA-17719) Connect may fail to start tasks when reading from a compacted config topic

2025-08-21 Thread Martin Andersson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015356#comment-18015356 ] Martin Andersson commented on KAFKA-17719: -- We switched from kafka 3.5.1 to 4.0

Re: [PR] [WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-21 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2290333025 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1887,8 +1887,10 @@ public int deleteOldSegments() throws IOException {

Re: [PR] KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR [kafka]

2025-08-21 Thread via GitHub
DDDFiish commented on PR #10313: URL: https://github.com/apache/kafka/pull/10313#issuecomment-3209492268 I accidentally came across this issue, and I also think it shouldn't be an ERROR. Is this correct? -- This is an automated message from the Apache Git Service. To respond to the messag

  1   2   >