[jira] [Updated] (KAFKA-19622) Limitations of KRAFT Dual Write Mode for Production Support

2025-08-29 Thread Sharad Garg (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharad Garg updated KAFKA-19622: Priority: Critical (was: Major) > Limitations of KRAFT Dual Write Mode for Production Support > -

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-29 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2311808282 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,23 +716,21 @@ public void testInterceptorConstructorClose(GroupProtocol gr

Re: [PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-08-29 Thread via GitHub
sjhajharia commented on code in PR #20393: URL: https://github.com/apache/kafka/pull/20393#discussion_r2311802573 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java: ## @@ -45,59 +46,23 @@ public PluginInfo(PluginDesc plugin) {

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

2025-08-29 Thread via GitHub
github-actions[bot] commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-3238910137 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Update inconsistent description for bootstrap-server in docs and command-line [kafka]

2025-08-29 Thread via GitHub
DL1231 commented on code in PR #20445: URL: https://github.com/apache/kafka/pull/20445#discussion_r2311764627 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -241,7 +241,7 @@ static ArgumentParser argParser() { .action(store())

Re: [PR] KAFKA-15873: Filter topics before sorting [kafka]

2025-08-29 Thread via GitHub
github-actions[bot] commented on PR #19304: URL: https://github.com/apache/kafka/pull/19304#issuecomment-3238910158 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] [WIP] KAFKA-19167: Move RemoteLogManagerConfig out of KafkaConfig [kafka]

2025-08-29 Thread via GitHub
github-actions[bot] commented on PR #19806: URL: https://github.com/apache/kafka/pull/19806#issuecomment-3238910193 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

2025-08-29 Thread via GitHub
github-actions[bot] closed pull request #17981: KAFKA-1826 [1/N]: Introducing GroupStore URL: https://github.com/apache/kafka/pull/17981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2311756677 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -637,30 +637,30 @@ props, new StringSerializer(), new StringSerializer())) {

[jira] [Resolved] (KAFKA-19616) add compression type and level to log_compaction_test.py

2025-08-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19616. Fix Version/s: 4.2.0 Resolution: Fixed > add compression type and level to log_comp

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2311752554 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -77,22 +86,24 @@ static int mainNoExit(String... args) { } // Visible for testing

Re: [PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20393: URL: https://github.com/apache/kafka/pull/20393#discussion_r2311744412 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java: ## @@ -23,12 +23,13 @@ import com.fasterxml.jackson.annotation.JsonIn

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-29 Thread via GitHub
chia7712 merged PR #20396: URL: https://github.com/apache/kafka/pull/20396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on PR #20396: URL: https://github.com/apache/kafka/pull/20396#issuecomment-3238868856 the failed test is already fixed by #20419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-19535: add integration tests for DescribeProducersOptions#brokerId [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20420: URL: https://github.com/apache/kafka/pull/20420#discussion_r2311734116 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DescribeProducersWithBrokerIdTest.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-29 Thread via GitHub
shashankhs11 commented on PR #20408: URL: https://github.com/apache/kafka/pull/20408#issuecomment-3238780295 made the required changes @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-19645: add a lower bound to num.replica.fetchers [kafka]

2025-08-29 Thread via GitHub
FrankYang0529 commented on code in PR #20414: URL: https://github.com/apache/kafka/pull/20414#discussion_r2311694182 ## server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java: ## @@ -147,7 +147,7 @@ public class ReplicationConfigs { .define(REPL

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-29 Thread via GitHub
mjsax commented on code in PR #20408: URL: https://github.com/apache/kafka/pull/20408#discussion_r2311686962 ## docs/streams/developer-guide/datatypes.html: ## @@ -163,6 +164,76 @@ JSONAs shown in the example, you can use JSONSerdes inner classes Serdes.serdeFrom(

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-29 Thread via GitHub
mjsax commented on PR #20408: URL: https://github.com/apache/kafka/pull/20408#issuecomment-3238737507 Yes... Seems this is incorrect for many years... and when we move off hard-coded versions to `{{fullDotVersion}}` we overlooked it, but nobody noticed until now... -- This is an automate

[jira] [Assigned] (KAFKA-19657) Improve RebalanceProtocolMigrationIntegrationTest

2025-08-29 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19657: Assignee: Lan Ding > Improve RebalanceProtocolMigrationIntegrationTest >

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-29 Thread via GitHub
mjsax commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2311684406 ## build.gradle: ## @@ -3362,6 +3362,7 @@ project(':jmh-benchmarks') { tasks.withType(JavaCompile) { // Suppress warning caused by code generated by jmh: `warning

Re: [PR] MINOR: add missing section to TOC [kafka]

2025-08-29 Thread via GitHub
mjsax commented on PR #20305: URL: https://github.com/apache/kafka/pull/20305#issuecomment-3238729109 We got new RC for both 4.0.1 and 4.1.0. We are good here :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2311455806 ## build.gradle: ## @@ -3362,6 +3362,7 @@ project(':jmh-benchmarks') { tasks.withType(JavaCompile) { // Suppress warning caused by code generated by jmh: `warn

[jira] [Created] (KAFKA-19657) Improve RebalanceProtocolMigrationIntegrationTest

2025-08-29 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19657: --- Summary: Improve RebalanceProtocolMigrationIntegrationTest Key: KAFKA-19657 URL: https://issues.apache.org/jira/browse/KAFKA-19657 Project: Kafka Issue

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-08-29 Thread via GitHub
mjsax commented on PR #19400: URL: https://github.com/apache/kafka/pull/19400#issuecomment-3238432137 Just talked to @bbejeck about this, and he will prioritize KIP-1153 to make sure we get is merged. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-08-29 Thread via GitHub
mjsax commented on PR #19400: URL: https://github.com/apache/kafka/pull/19400#issuecomment-3238419918 High level comment: Is it wise to complete this PR before https://github.com/apache/kafka/pull/19955 ? -- It seems we should only remove the internal config, after we got the public API cha

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2311409416 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServerConfig.java: ## @@ -139,12 +139,12 @@ public abstract class RestServerConfig extends

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-29 Thread via GitHub
yunchipang commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2311337890 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -395,12 +407,29 @@ private static void require(boolean requirement, String message) {

Re: [PR] MINOR: Prepend steams to group configs specific to Kafka Streams groups [kafka]

2025-08-29 Thread via GitHub
bbejeck merged PR #20448: URL: https://github.com/apache/kafka/pull/20448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Prepend steams to group configs specific to Kafka Streams groups [kafka]

2025-08-29 Thread via GitHub
bbejeck commented on PR #20448: URL: https://github.com/apache/kafka/pull/20448#issuecomment-3238258699 merged #20448 to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2311260676 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -395,12 +407,29 @@ private static void require(boolean requirement, String message) {

[PR] MINOR: Prepend steams to group configs specific to Kafka Streams groups [kafka]

2025-08-29 Thread via GitHub
bbejeck opened a new pull request, #20448: URL: https://github.com/apache/kafka/pull/20448 In the 4.1 `upgrade-guide` describing the new KIP-1071 protocol it would be helpful to display the configs you can set via `kafka-configs.sh` with `streams` pre-pended to the configs, the command will

[PR] KAFKA-19656: Ensure share consumer polling does not stall [kafka]

2025-08-29 Thread via GitHub
AndrewJSchofield opened a new pull request, #20447: URL: https://github.com/apache/kafka/pull/20447 In the async consumer, it has been observed that repeated polls sometimes stall when actually a fetch should be sent to the broker. Since the design of the share consumer is similar, this PR

[PR] MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes [kafka]

2025-08-29 Thread via GitHub
josefk31 opened a new pull request, #20446: URL: https://github.com/apache/kafka/pull/20446 The original name is confusing which could cause engineers to make a mistake and confuse the `batchSize` with some other unit like number of records. -- This is an automated message from the Ap

Re: [PR] KAFKA-19478 [3/N]: Use heaps to discover the least loaded process [kafka]

2025-08-29 Thread via GitHub
bbejeck commented on code in PR #20172: URL: https://github.com/apache/kafka/pull/20172#discussion_r2310750473 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -171,38 +173,43 @@ private void assignActive(final

[jira] [Updated] (KAFKA-19650) Add message key to org.apache.kafka.clients.producer.RecordMetadata

2025-08-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19650: Component/s: streams > Add message key to org.apache.kafka.clients.producer.RecordMetadata

[jira] [Commented] (KAFKA-19650) Add message key to org.apache.kafka.clients.producer.RecordMetadata

2025-08-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017101#comment-18017101 ] Matthias J. Sax commented on KAFKA-19650: - Not sure if adding the key to RecordM

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310747296 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -842,6 +846,7 @@ public void handleException(Throwable exception) { @Ov

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
MahsaSeifikar commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310741050 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -75,13 +82,15 @@ public class QuorumControllerMetrics implements

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310715836 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -75,13 +82,15 @@ public class QuorumControllerMetrics implements A

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310698746 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -75,13 +82,15 @@ public class QuorumControllerMetrics implements A

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
kirktrue commented on PR #20324: URL: https://github.com/apache/kafka/pull/20324#issuecomment-3237712843 Thanks for the review @AndrewJSchofield! > Overall, I think my main observation about the PR is that it makes the class diagram even more peculiar than it was before. The classes k

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2310690119 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1847,11 +1871,21 @@ private Fetch collectFetch() { *

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2310677853 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SharedConsumerState.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2310674430 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SharedConsumerState.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] MINOR: Update inconsistent description for bootstrap-server in docs and command-line [kafka]

2025-08-29 Thread via GitHub
Yunyung commented on PR #20445: URL: https://github.com/apache/kafka/pull/20445#issuecomment-3237634083 ### For kafka-streams-application-reset.sh Before: https://github.com/user-attachments/assets/616dbd94-0364-4aae-9217-4f6da5bf036b"; /> After: https://github.com/us

[PR] MINOR: Update inconsistent description for bootstrap-server in docs and command-line [kafka]

2025-08-29 Thread via GitHub
Yunyung opened a new pull request, #20445: URL: https://github.com/apache/kafka/pull/20445 ### **kafka-streams-application-reset.sh** - Update docs `--bootstrap-servers` has been removed. - Fix `--bootstrap-server` is required but not apply to StreamsResetter.java. ### **kafka-pr

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2310625719 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SharedConsumerState.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310544483 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -842,6 +846,7 @@ public void handleException(Throwable exception) { @Ov

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
MahsaSeifikar commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310507716 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -842,6 +846,7 @@ public void handleException(Throwable exception) {

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-29 Thread via GitHub
MahsaSeifikar commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2310507716 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -842,6 +846,7 @@ public void handleException(Throwable exception) {

[jira] [Updated] (KAFKA-19654) [Gradle 9] Parsing JUnit test results ("flaky/new" job matrix) fails - while successful with Gradle 8

2025-08-29 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19654: --- Summary: [Gradle 9] Parsing JUnit test results ("flaky/new" job matrix) fails - whil

[PR] Kstreams 7247 debug [kafka]

2025-08-29 Thread via GitHub
lucliu1108 opened a new pull request, #20444: URL: https://github.com/apache/kafka/pull/20444 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some c

Re: [PR] KAFKA-19174 KAFKA-19591 Gradle version upgrade 8 -->> 9 [kafka]

2025-08-29 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3237287563 Update: I will try to rebase all commits onto upstream/trunk current state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-19174 Gradle upgrade from 8 to 9 (for testing only, do not merge) [kafka]

2025-08-29 Thread via GitHub
dejan2609 commented on PR #20442: URL: https://github.com/apache/kafka/pull/20442#issuecomment-3237242033 Not sure how Github Actions decides when (not) to start full CI build. Closing this PR, will just rebase original. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-19174 Gradle upgrade from 8 to 9 (for testing only, do not merge) [kafka]

2025-08-29 Thread via GitHub
dejan2609 closed pull request #20442: KAFKA-19174 Gradle upgrade from 8 to 9 (for testing only, do not merge) URL: https://github.com/apache/kafka/pull/20442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-19259: Async consumer fetch intermittent delays on console consumer [kafka]

2025-08-29 Thread via GitHub
lianetm commented on code in PR #19980: URL: https://github.com/apache/kafka/pull/19980#discussion_r2298036689 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java: ## @@ -1588,6 +1593,103 @@ private void sendCompressedM

[PR] MINOR: Add Unit test TimingWheel [kafka]

2025-08-29 Thread via GitHub
m1a2st opened a new pull request, #20443: URL: https://github.com/apache/kafka/pull/20443 There is any unit test for TimingWheel, we should add test for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (KAFKA-19656) Investigate stalling share consumer poll when empty response is returned early

2025-08-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-19656: Assignee: Andrew Schofield > Investigate stalling share consumer poll when empty

[PR] KAFKA-19174 Gradle upgrade from 8 to 9 (for testing only, do not merge) [kafka]

2025-08-29 Thread via GitHub
dejan2609 opened a new pull request, #20442: URL: https://github.com/apache/kafka/pull/20442 This is a PR that will be used to resolve issues with flaky tests described here: - https://issues.apache.org/jira/browse/KAFKA-19654 -- This is an automated message from the Apache Git Se

[jira] [Created] (KAFKA-19656) Investigate stalling share consumer poll when empty response is returned early

2025-08-29 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19656: Summary: Investigate stalling share consumer poll when empty response is returned early Key: KAFKA-19656 URL: https://issues.apache.org/jira/browse/KAFKA-19656

[PR] TEST commit to debug Java8 fails [kafka]

2025-08-29 Thread via GitHub
viktorsomogyi opened a new pull request, #20441: URL: https://github.com/apache/kafka/pull/20441 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) [kafka]

2025-08-29 Thread via GitHub
dejan2609 opened a new pull request, #20440: URL: https://github.com/apache/kafka/pull/20440 [This is a helper PR that was created in order to solve some issues with flaky tests. Please not that is was created on top of 4.1.0-rc3 tag/4.1 branch -- This is an automated message from the Apa

Re: [PR] KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) [kafka]

2025-08-29 Thread via GitHub
dejan2609 closed pull request #20440: KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) URL: https://github.com/apache/kafka/pull/20440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-8350 Fix stack overflow when batch size is larger than cluster max.message.byte [kafka]

2025-08-29 Thread via GitHub
knoxy5467 commented on PR #20358: URL: https://github.com/apache/kafka/pull/20358#issuecomment-3237070362 Then the sender which the record accumulator belongs to utilizes it's error handling to resolve the issue. https://github.com/apache/kafka/blob/26fea78ae1001933d910e5f61727e77e

Re: [PR] KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) [kafka]

2025-08-29 Thread via GitHub
dejan2609 commented on PR #20439: URL: https://github.com/apache/kafka/pull/20439#issuecomment-3237055128 Alas, too many conflicts. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) [kafka]

2025-08-29 Thread via GitHub
dejan2609 closed pull request #20439: KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) URL: https://github.com/apache/kafka/pull/20439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-8350 Fix stack overflow when batch size is larger than cluster max.message.byte [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20358: URL: https://github.com/apache/kafka/pull/20358#discussion_r2310172351 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -514,7 +514,12 @@ public int splitAndReenqueue(ProducerBatch bigBatc

[jira] [Commented] (KAFKA-19595) Add configuration validation option to Kafka server startup

2025-08-29 Thread Satya Samal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017022#comment-18017022 ] Satya Samal commented on KAFKA-19595: - Hi , can I work on this ? > Add configuratio

[PR] KAFKA-19174 Gradle upgrade 8 to 9 (work in progress and testing PR) [kafka]

2025-08-29 Thread via GitHub
dejan2609 opened a new pull request, #20439: URL: https://github.com/apache/kafka/pull/20439 This is a helper PR that was created in order to solve some issues with flaky tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] MINOR: Remove default config in creating internal stream topic [kafka]

2025-08-29 Thread via GitHub
lucasbru merged PR #20421: URL: https://github.com/apache/kafka/pull/20421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-19654) [Gradle 9] Parsing JUnit test (flaky/new) results fails (while successful with Gradle 8)

2025-08-29 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017013#comment-18017013 ] Dejan Stojadinović commented on KAFKA-19654: Interestingly enough: but only

[jira] [Updated] (KAFKA-19654) [Gradle 9] Parsing JUnit test (flaky/new) results fails (while successful with Gradle 8)

2025-08-29 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19654: --- Summary: [Gradle 9] Parsing JUnit test (flaky/new) results fails (while successful w

[jira] [Resolved] (KAFKA-19626) Consistency of command-line arguments for remaining CLI tools

2025-08-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19626. -- Fix Version/s: 4.2.0 Resolution: Fixed > Consistency of command-line arguments

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-29 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2309859522 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,23 +716,21 @@ public void testInterceptorConstructorClose(GroupProtocol gr

Re: [PR] MINOR: Add comment to createStreamsInternalTopics [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236381104 > For normal topics, do we need to document the change? yes, it would be good to document it. Making them consistent would probably require a KIP. -- This is an automated messag

Re: [PR] MINOR: Remove default config in creating internal stream topic [kafka]

2025-08-29 Thread via GitHub
lucasbru commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236499690 I would support a little KIP about that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
AndrewJSchofield commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2309952955 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1847,11 +1871,21 @@ private Fetch collectFetch() { *

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-29 Thread via GitHub
AndrewJSchofield commented on PR #20324: URL: https://github.com/apache/kafka/pull/20324#issuecomment-3236694571 > FYI: test failures appear related to the broader flakiness of the tests over the last seven days: > > * `AclControlManagerTest.testDeleteExceedsMaxRecords()`: [10% flaky

Re: [PR] KAFKA-19626: KIP-1147 Consistency of command-line arguments for remaining CLI tools [kafka]

2025-08-29 Thread via GitHub
AndrewJSchofield merged PR #20431: URL: https://github.com/apache/kafka/pull/20431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-8350 Fix stack overflow when batch size is larger than cluster max.message.byte [kafka]

2025-08-29 Thread via GitHub
clolov merged PR #20358: URL: https://github.com/apache/kafka/pull/20358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Updated] (KAFKA-19655) The normal topic auto-creation paths should use num.partitions and default.replication.factor from the controller properties

2025-08-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19655: --- Labels: need-kip (was: ) > The normal topic auto-creation paths should use num.partitions a

Re: [PR] MINOR: Remove default config in creating internal stream topic [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236592946 > I would support a little KIP about that create https://issues.apache.org/jira/browse/KAFKA-19655 and assign it to @brandboat -- This is an automated message from the Apache G

[jira] [Created] (KAFKA-19655) The normal topic auto-creation paths should use num.partitions and default.replication.factor from the controller properties

2025-08-29 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19655: -- Summary: The normal topic auto-creation paths should use num.partitions and default.replication.factor from the controller properties Key: KAFKA-19655 URL: https://issues.apac

Re: [PR] KAFKA-19653: Improve metavariable names in usage messages [kafka]

2025-08-29 Thread via GitHub
Yunyung commented on PR #20438: URL: https://github.com/apache/kafka/pull/20438#issuecomment-3236509184 LGTM. I see the same situation in Agent.java, Coordinator.java, MessageGenerator.java, etc., but it's outside the scope of this KIP. We can improve it in another PR. -- This is an auto

Re: [PR] KAFKA-19645: add a lower bound to num.replica.fetchers [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on code in PR #20414: URL: https://github.com/apache/kafka/pull/20414#discussion_r2309740081 ## server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java: ## @@ -147,7 +147,7 @@ public class ReplicationConfigs { .define(REPLICA_F

Re: [PR] MINOR: Add comment to createStreamsInternalTopics [kafka]

2025-08-29 Thread via GitHub
brandboat commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236369362 > make all of them use the controller configuration for consistency. @chia7712, I agree that this could help reduce confusion. For normal topics, do we need to document the change

[jira] [Updated] (KAFKA-19520) Bump Commons-Lang for CVE-2025-48924

2025-08-29 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-19520: --- Fix Version/s: 3.9.2 > Bump Commons-Lang for CVE-2025-48924 > --

Re: [PR] KAFKA-19520: Bump Commons-Lang for CVE-2025-48924 [kafka]

2025-08-29 Thread via GitHub
mimaison merged PR #20433: URL: https://github.com/apache/kafka/pull/20433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: improve RLMQuotaMetricsTest [kafka]

2025-08-29 Thread via GitHub
chia7712 merged PR #20425: URL: https://github.com/apache/kafka/pull/20425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-19650) Add message key to org.apache.kafka.clients.producer.RecordMetadata

2025-08-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-19650: - Labels: needs-kip (was: ) > Add message key to org.apache.kafka.clients.producer.Record

Re: [PR] MINOR: Add comment to createStreamsInternalTopics [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236341849 > which would create the internal topics using CreateTopic and therefore use the controller config One more thing. That means the `CreateTopic` path and Streams internal topics wi

[PR] KAFKA-19653: Improve metavariable names in usage messages [kafka]

2025-08-29 Thread via GitHub
AndrewJSchofield opened a new pull request, #20438: URL: https://github.com/apache/kafka/pull/20438 This trivial PR improves the so-called metavariable names in the usage messages of the verifiable producer/consumer command-line tools. These are the names of the replacement variables that a

[jira] [Updated] (KAFKA-19654) [Gradle 9] Parsing JUnit test results fails (while successful with Gradle 8)

2025-08-29 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19654: --- Description: See here for more details: [https://github.com/apache/kafka/pull/19513

[jira] [Created] (KAFKA-19654) [Gradle 9] Parsing JUnit test results fails (while successful with Gradle 8)

2025-08-29 Thread Jira
Dejan Stojadinović created KAFKA-19654: -- Summary: [Gradle 9] Parsing JUnit test results fails (while successful with Gradle 8) Key: KAFKA-19654 URL: https://issues.apache.org/jira/browse/KAFKA-19654

Re: [PR] MINOR: Add doc for external schemas in JSONConverter [kafka]

2025-08-29 Thread via GitHub
priyankaku commented on PR #20429: URL: https://github.com/apache/kafka/pull/20429#issuecomment-3236322365 @JimmyWang6 : Thanks for raising this , Looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] MINOR: Add comment to createStreamsInternalTopics [kafka]

2025-08-29 Thread via GitHub
chia7712 commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3236302004 > which would create the internal topics using CreateTopic and therefore use the controller config that is a good point, and the KIP does say "create the internal topics by sendin

Re: [PR] [Work in progress] Kafka 19174 parse junit results issues [kafka]

2025-08-29 Thread via GitHub
dejan2609 closed pull request #20437: [Work in progress] Kafka 19174 parse junit results issues URL: https://github.com/apache/kafka/pull/20437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [Work in progress] Kafka 19174 parse junit results issues [kafka]

2025-08-29 Thread via GitHub
dejan2609 commented on PR #20437: URL: https://github.com/apache/kafka/pull/20437#issuecomment-3236271215 Closing, can't test here (will have to use my own (real) PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-19174 KAFKA-19591 Gradle version upgrade 8 -->> 9 [kafka]

2025-08-29 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3236158518 One (last ?) thing stands as a mystery for now: I just compared two CI builds (Kafka 4.1.0 RC3 vs this one) and same results (for `Parse Junit test` step *only*) yield different outcome

  1   2   >