chia7712 commented on PR #20451:
URL: https://github.com/apache/kafka/pull/20451#issuecomment-3250540921
> had in mind for items 1 and 3.
`leaderEpoch=" + leaderEpoch().orElse(null)` looks good to me
> Were we supposed to add tests for metadata null -> "" normalization too?
sjhajharia commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2320832128
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -19,85 +19,30 @@
import org.apache.kafka.connect.runtime.isol
github-actions[bot] commented on PR #19668:
URL: https://github.com/apache/kafka/pull/19668#issuecomment-3251693693
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19035:
URL: https://github.com/apache/kafka/pull/19035#issuecomment-3251693584
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #20392:
URL: https://github.com/apache/kafka/pull/20392#issuecomment-3251632128
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20384:
URL: https://github.com/apache/kafka/pull/20384#issuecomment-3251632214
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19934:
URL: https://github.com/apache/kafka/pull/19934#issuecomment-3251632825
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19513:
URL: https://github.com/apache/kafka/pull/19513#issuecomment-3251633067
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
dependabot[bot] opened a new pull request, #20473:
URL: https://github.com/apache/kafka/pull/20473
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
Release notes
Sourced from https://github.com/psf/requests/releases";>requests's
releases.
v2.32.4
2
kirktrue commented on PR #20324:
URL: https://github.com/apache/kafka/pull/20324#issuecomment-3251191351
> I definitely like the idea of having a consolidated
`DoEverythingNeededForFetchEvent` that handles the logic that's currently split
up across `PollEvent`, `CheckAndUpdatePositionsEvent
mjsax commented on PR #20470:
URL: https://github.com/apache/kafka/pull/20470#issuecomment-3251162350
Thanks both -- I am still wondering what changes we need to test this
better? Eg, system tests? -- We also need more changes for the release noted /
upgrade guide, and we might even want to
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2320350843
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1350,7 +1355,11 @@ public KStream processValues(
final ProcessorToS
kirktrue commented on code in PR #20324:
URL: https://github.com/apache/kafka/pull/20324#discussion_r2320346572
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ThreadSafeAsyncConsumerState.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Fo
kirktrue commented on code in PR #20324:
URL: https://github.com/apache/kafka/pull/20324#discussion_r2320346572
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ThreadSafeAsyncConsumerState.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Fo
kirktrue commented on PR #20324:
URL: https://github.com/apache/kafka/pull/20324#issuecomment-3250946011
> Thanks for the updates! I'm afraid we are still introducing gaps (comment
below) by splitting the logic of the existing `CheckAndUpdatePositionsEvent`
event into the app thread and bac
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320189450
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node fetchTarg
chia7712 merged PR #20046:
URL: https://github.com/apache/kafka/pull/20046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2320275918
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1350,7 +1355,11 @@ public KStream processValues(
final Processor
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320217963
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -98,7 +98,8 @@ void add(CompletedFetch completedFetch) {
try {
chia7712 commented on code in PR #20283:
URL: https://github.com/apache/kafka/pull/20283#discussion_r2319988221
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##
@@ -1116,19 +1116,23 @@ private boolean processBackgroundEvents() {
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320220634
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node fetchTarg
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320188205
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCompressedM
[
https://issues.apache.org/jira/browse/KAFKA-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-19668:
---
Assignee: Matthias J. Sax
> processValues() must be declared as value-changing oper
[
https://issues.apache.org/jira/browse/KAFKA-19535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19535.
Fix Version/s: 4.2.0
Resolution: Fixed
> add integration tests for DescribeProducer
Yunyung commented on PR #20469:
URL: https://github.com/apache/kafka/pull/20469#issuecomment-3250577602
Great. LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 commented on code in PR #20471:
URL: https://github.com/apache/kafka/pull/20471#discussion_r2319940997
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,14 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
c
chia7712 commented on code in PR #20451:
URL: https://github.com/apache/kafka/pull/20451#discussion_r2320005613
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -553,14 +553,18 @@ private void testInterceptors
MahsaSeifikar commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319986360
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
chia7712 commented on code in PR #20472:
URL: https://github.com/apache/kafka/pull/20472#discussion_r2320011286
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1833,6 +1838,9 @@ public void close(Duration timeout) {
* {@link ConsumerCo
[
https://issues.apache.org/jira/browse/KAFKA-19432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19432.
Fix Version/s: 4.2.0
Resolution: Fixed
> Add an ERROR log message if broker.heartbe
bbejeck commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319992952
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java:
##
@@ -386,20 +392,20 @@ private int getCountOfRepartitionTopicsFound(f
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319983417
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig ext
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319982525
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig ext
lianetm opened a new pull request, #20472:
URL: https://github.com/apache/kafka/pull/20472
Add to the consumer.close java doc to describe the error handling behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
bbejeck commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319932841
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig e
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319958062
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java:
##
@@ -386,20 +392,20 @@ private int getCountOfRepartitionTopicsFound(fin
chia7712 merged PR #20420:
URL: https://github.com/apache/kafka/pull/20420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
JimmyWang6 opened a new pull request, #20471:
URL: https://github.com/apache/kafka/pull/20471
#20390 Replace the -`-producer.config` for the verifiable producer and
`--consumer.config` option by `--command-config` for the verifiable consumer.
However, for e2e tests targeting older broker v
mjsax opened a new pull request, #20470:
URL: https://github.com/apache/kafka/pull/20470
With "merge.repartition.topic" optimization enabled, Kafka Streams tries to
push repartition topics upstream, to be able to merge multiple repartition
topics from different downstream branches together.
Yunyung commented on PR #20469:
URL: https://github.com/apache/kafka/pull/20469#issuecomment-3250370171
Thanks for the PR. I see the same pattern in ReplicaVerificationTool.java;
could you update it as well?
Also, it would be great if you could provide the before and after output
results
ahuang98 commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319808559
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
[
https://issues.apache.org/jira/browse/KAFKA-19011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19011.
Fix Version/s: 4.2.0
Resolution: Fixed
> Improve EndToEndLatency Tool with argument
chia7712 merged PR #20301:
URL: https://github.com/apache/kafka/pull/20301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Matthias J. Sax created KAFKA-19669:
---
Summary: Improve repartition optimization
Key: KAFKA-19669
URL: https://issues.apache.org/jira/browse/KAFKA-19669
Project: Kafka
Issue Type: Bug
apalan60 opened a new pull request, #20469:
URL: https://github.com/apache/kafka/pull/20469
Refactor help and version handling in command-line tools by replacing
duplicate code with `CommandLineUtils#maybePrintHelpOrVersion`.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-19669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-19669:
Issue Type: Improvement (was: Bug)
> Improve repartition optimization
> -
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
chia7712 commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2319744748
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServerConfig.java:
##
@@ -139,12 +139,12 @@ public abstract class RestServerConfig extends
chia7712 merged PR #20435:
URL: https://github.com/apache/kafka/pull/20435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #19498:
URL: https://github.com/apache/kafka/pull/19498#issuecomment-3250160433
the successor is #20435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
chia7712 commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2319705983
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -19,85 +19,30 @@
import org.apache.kafka.connect.runtime.isolat
chia7712 commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319682177
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefau
[
https://issues.apache.org/jira/browse/KAFKA-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-19666:
Component/s: unit tests
> Clean up integration tests related to state-updater
> --
AndrewJSchofield commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2319525684
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,7 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
aheev commented on code in PR #20256:
URL: https://github.com/apache/kafka/pull/20256#discussion_r2319418482
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##
@@ -490,8 +479,8 @@ public void onLeadershipChange(Set
partitionsBecomeLead
omkreddy commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2319391162
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,7 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
cm
Matthias J. Sax created KAFKA-19668:
---
Summary: processValues() must be declared as value-changing
operation
Key: KAFKA-19668
URL: https://issues.apache.org/jira/browse/KAFKA-19668
Project: Kafka
lucasbru merged PR #20172:
URL: https://github.com/apache/kafka/pull/20172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on code in PR #20383:
URL: https://github.com/apache/kafka/pull/20383#discussion_r2319276289
##
server/src/main/java/org/apache/kafka/server/DefaultAutoTopicCreationManager.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
[
https://issues.apache.org/jira/browse/KAFKA-19381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017921#comment-18017921
]
Claude Warren commented on KAFKA-19381:
---
Mailing list discussion:
https://lists.a
AndrewJSchofield commented on PR #20466:
URL: https://github.com/apache/kafka/pull/20466#issuecomment-3249561868
@elmoctarebnou There are some build failures. Please check the logs and
resolve. For example:
```
Error:
/home/runner/work/kafka/kafka/core/src/test/scala/unit/kafka/s
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3249552935
> > Thanks for the PR. Once we have a green build, I'm ready to merge this.
>
> Shouldn't we wait for this? I am trying to run the tests, but running into
some issues
>
[
https://issues.apache.org/jira/browse/KAFKA-19653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-19653.
--
Resolution: Fixed
> Improve metavariable names for verifiable producer/consumer
>
AndrewJSchofield merged PR #20438:
URL: https://github.com/apache/kafka/pull/20438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
lucasbru commented on code in PR #20458:
URL: https://github.com/apache/kafka/pull/20458#discussion_r2315959967
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -185,11 +195,13 @@ private void assignActive(fina
elmoctarebnou commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2319107607
##
.gitignore:
##
@@ -31,6 +31,8 @@ TAGS
Vagrantfile.local
/logs
.DS_Store
+.bloop/
Review Comment:
Thanks for the review, @AndrewJSchofield. I’ve reverted
see-quick opened a new pull request, #20468:
URL: https://github.com/apache/kafka/pull/20468
This PR moves the ScramPublisher class from the server metadata package to
the dedicated metadata module. During refactoring, I found out that I also need
to move the CredentialProvider interface to
MahsaSeifikar commented on PR #20422:
URL: https://github.com/apache/kafka/pull/20422#issuecomment-3249255423
@chia7712 Could you please review this metric KIP when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
lianetm commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318963044
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCompressedMe
Copilot commented on code in PR #20458:
URL: https://github.com/apache/kafka/pull/20458#discussion_r2318899271
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -103,19 +113,19 @@ private void initialize(final G
dajac commented on code in PR #20055:
URL: https://github.com/apache/kafka/pull/20055#discussion_r2318877931
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3089,9 +3111,9 @@ private static boolean isNotEmpty(String value)
shashankhs11 commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2318872382
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -303,16 +304,15 @@ public void sho
lucasbru commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2318823100
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -303,16 +304,15 @@ public void shouldP
AndrewJSchofield commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318806420
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node f
Copilot commented on code in PR #20464:
URL: https://github.com/apache/kafka/pull/20464#discussion_r2318793769
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStreamsRebalanceListener.java:
##
@@ -91,16 +107,21 @@ public Optional onTasksAssigned(fina
[
https://issues.apache.org/jira/browse/KAFKA-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-19417.
-
Resolution: Duplicate
> Clear static member assignment on join with different subscription
> ---
aheev commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3248992064
> Thanks for the PR. Once we have a green build, I'm ready to merge this.
Shouldn't we wait for this? I am trying to run the tests, but running into
some issues
> Since you hav
AndrewJSchofield commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318715441
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCom
[
https://issues.apache.org/jira/browse/KAFKA-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-19417:
---
Assignee: David Jacot (was: Sean Quah)
> Clear static member assignment on join with diffe
[
https://issues.apache.org/jira/browse/KAFKA-18220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-18220.
--
Fix Version/s: 4.2.0
Resolution: Fixed
> Refactor AsyncConsumerMetrics so they
AndrewJSchofield merged PR #20283:
URL: https://github.com/apache/kafka/pull/20283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
ShivsundarR commented on PR #20283:
URL: https://github.com/apache/kafka/pull/20283#issuecomment-3248851776
Thanks @AndrewJSchofield, I used the `consumer-perf-test.sh` and
`share-consumer-perf-test.sh` tools to print the metrics before and after the
changes.
- For `ClassicKafkaConsu
Yunyung commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318573502
##
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManager[T <:
mimaison commented on PR #20178:
URL: https://github.com/apache/kafka/pull/20178#issuecomment-3248674398
Can you also resolve the conflict? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison merged PR #19940:
URL: https://github.com/apache/kafka/pull/19940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
kuoche1712003 commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318536120
##
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManage
mimaison commented on PR #19845:
URL: https://github.com/apache/kafka/pull/19845#issuecomment-3248596607
Thanks for the PR!
This modifies the Kafka Connect public API, so in order to accept this
change we need to have a Kafka Improvement Proposal (KIP). See the process on
https://cwi
sjhajharia commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2318467236
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -45,59 +46,23 @@ public PluginInfo(PluginDesc plugin) {
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3248580711
@aheev Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mimaison commented on PR #17554:
URL: https://github.com/apache/kafka/pull/17554#issuecomment-3248561958
@chia7712 Did you have other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #20408:
URL: https://github.com/apache/kafka/pull/20408#issuecomment-3248423413
> Will hold of merging until 4.1 went out, and I can cherry-pick to AK 4.1
branch
Feel free to merge and backport to 4.1. I've bumped 4.1 to 4.1.1-SNAPSHOT,
it's open to commits
dejan2609 commented on PR #20450:
URL: https://github.com/apache/kafka/pull/20450#issuecomment-3248401370
Much obliged Ken @m1a2st :ok_hand: !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield opened a new pull request, #20467:
URL: https://github.com/apache/kafka/pull/20467
Ensure that metrics are retrieved and displayed (when requested) before
ShareConsumer.close() is called. This is important because metrics are
technically supposed to be removed on ShareC
mimaison merged PR #20077:
URL: https://github.com/apache/kafka/pull/20077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017511#comment-18017511
]
Uladzislau Blok commented on KAFKA-19613:
-
About CRC checksum validation, that's
Kirk True created KAFKA-19665:
-
Summary: Reduce waiting on event completion in
AsyncKafkaConsumer.pollForRecords()
Key: KAFKA-19665
URL: https://issues.apache.org/jira/browse/KAFKA-19665
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-19601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017729#comment-18017729
]
Jhen-Yung Hsu commented on KAFKA-19601:
---
I've started the discussion thread:
[htt
chia7712 commented on code in PR #20267:
URL: https://github.com/apache/kafka/pull/20267#discussion_r2318289086
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -66,45 +69,42 @@ public static void main(String[] args) {
if (!options.hideH
1 - 100 of 146 matches
Mail list logo
