Re: [PR] MINOR: Fix race conditions in KafkaStreams when topic is missing. [kafka]

2025-09-05 Thread via GitHub
chickenchickenlove commented on PR #20362: URL: https://github.com/apache/kafka/pull/20362#issuecomment-3261189175 Gently Ping, could you take a look this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-09-05 Thread via GitHub
chickenchickenlove commented on PR #20159: URL: https://github.com/apache/kafka/pull/20159#issuecomment-3261187335 @AndrewJSchofield @chia7712 @Yunyung @frankvicky Gently ping! When you have time, please take another look 🙇‍♂️ -- This is an automated message from the Apache Git Servi

[PR] MINOR: remove System.out in test [kafka]

2025-09-05 Thread via GitHub
mjsax opened a new pull request, #20494: URL: https://github.com/apache/kafka/pull/20494 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some commen

Re: [PR] KAFKA-19479: at_least_once mode in Kafka Streams silently drops messages when the producer fails with MESSAGE_TOO_LARGE, violating delivery guarantees [kafka]

2025-09-05 Thread via GitHub
shashankhs11 commented on PR #20254: URL: https://github.com/apache/kafka/pull/20254#issuecomment-3261020620 @lianetm @junrao @mjsax tagging as a reminder for follow-up. Since, this is confirmed to be a bug (potentially critical) and I believe may require more discussions within the communi

Re: [PR] KAFKA-13152: Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes" [kafka]

2025-09-05 Thread via GitHub
shashankhs11 commented on PR #20292: URL: https://github.com/apache/kafka/pull/20292#issuecomment-3260929576 @mjsax reminder for review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326391978 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,26 +716,27 @@ public void testInterceptorConstructorClose(GroupProtocol gr

Re: [PR] Kstreams 7247 debug [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] commented on PR #20444: URL: https://github.com/apache/kafka/pull/20444#issuecomment-3260289953 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326391978 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,26 +716,27 @@ public void testInterceptorConstructorClose(GroupProtocol gr

[PR] [WIP] KAFKA-15186 AppInfo metrics don't contain the client-id [kafka]

2025-09-05 Thread via GitHub
m1a2st opened a new pull request, #20493: URL: https://github.com/apache/kafka/pull/20493 All Kafka component register AppInfo metrics to track the application start time or commit-id etc. These metrics are useful for monitoring and debugging. However, the AppInfo doesn't provide client-id,

Re: [PR] KAFKA-19010: Added JVM argument to default configuration [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] commented on PR #19870: URL: https://github.com/apache/kafka/pull/19870#issuecomment-3260306946 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] closed pull request #18987: KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests URL: https://github.com/apache/kafka/pull/18987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] commented on PR #18987: URL: https://github.com/apache/kafka/pull/18987#issuecomment-3260306877 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-19174 Gradle version upgrade 8 -->> 9 [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3260290880 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326416330 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,26 +716,27 @@ public void testInterceptorConstructorClose(GroupProtocol

Re: [PR] KAFKA-3987: Replace MD5 for FIPS 140-3 compliance in Log Cleaner. [kafka]

2025-09-05 Thread via GitHub
github-actions[bot] commented on PR #19035: URL: https://github.com/apache/kafka/pull/19035#issuecomment-3260291086 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326394820 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1906,16 +1906,29 @@ private int deleteSegments(List deletable, SegmentDeletionRe

[PR] MINOR: Followup KAFKA-19112 document updated. [kafka]

2025-09-05 Thread via GitHub
m1a2st opened a new pull request, #20492: URL: https://github.com/apache/kafka/pull/20492 Some sections are not very clear, and we need to update the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326391978 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,26 +716,27 @@ public void testInterceptorConstructorClose(GroupProtocol gr

Re: [PR] KAFKA-15983 Kafka-acls should return authorization already done if repeating work is issued [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on code in PR #20482: URL: https://github.com/apache/kafka/pull/20482#discussion_r2326381997 ## tools/src/main/java/org/apache/kafka/tools/AclCommand.java: ## @@ -106,9 +106,27 @@ private static void addAcls(Admin admin, AclCommandOptions opts) throws Executi

Re: [PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-09-05 Thread via GitHub
chia7712 merged PR #20393: URL: https://github.com/apache/kafka/pull/20393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Add 4.1.0 to system tests [kafka]

2025-09-05 Thread via GitHub
mimaison commented on code in PR #20476: URL: https://github.com/apache/kafka/pull/20476#discussion_r2322447627 ## tests/setup.py: ## @@ -48,7 +48,7 @@ def run(self): license="apache2.0", packages=find_packages(), include_package_data=True, - install_re

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326334741 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1906,16 +1906,29 @@ private int deleteSegments(List deletable, SegmentDeletionRe

Re: [PR] KAFKA-19381: add ConfigDef.ConfigKey.Builder [kafka]

2025-09-05 Thread via GitHub
Claudenw commented on PR #19912: URL: https://github.com/apache/kafka/pull/19912#issuecomment-3258249746 @sjhajharia or @mimaison can either of you merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19668: processValue() must be declared as value-changing operation [kafka]

2025-09-05 Thread via GitHub
mjsax merged PR #20470: URL: https://github.com/apache/kafka/pull/20470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
junrao commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2326299192 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -1906,16 +1906,29 @@ private int deleteSegments(List deletable, SegmentDeletionRe

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on PR #20334: URL: https://github.com/apache/kafka/pull/20334#issuecomment-3259202301 `network_degrade_test.py` and `replica_verification_test.py` remain unstable. Others pass on my local. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-19585: Avoid noisy NPE logs when closing consumer after constructor failures [kafka]

2025-09-05 Thread via GitHub
gensericghiro commented on code in PR #20491: URL: https://github.com/apache/kafka/pull/20491#discussion_r2326111084 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -2029,6 +2030,27 @@ public void testRecordBackgroundEvent

Re: [PR] KAFKA-19661: Streams groups sometimes describe as NOT_READY when STABLE [kafka]

2025-09-05 Thread via GitHub
mjsax commented on code in PR #20457: URL: https://github.com/apache/kafka/pull/20457#discussion_r2325953487 ## core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala: ## @@ -239,7 +239,8 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {

Re: [PR] KAFKA-19550: Integration test for Streams-related Admin APIs [1/N] [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2325557949 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2589,8 +2594,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-19585: Avoid noisy NPE logs when closing consumer after constructor failures [kafka]

2025-09-05 Thread via GitHub
gensericghiro commented on code in PR #20491: URL: https://github.com/apache/kafka/pull/20491#discussion_r2326067987 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -2029,6 +2030,27 @@ public void testRecordBackgroundEvent

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
aheev commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2325882712 ## tools/src/test/java/org/apache/kafka/tools/ConsumerPerformanceTest.java: ## Review Comment: Thanks for catching this. This test was introduced recently -- Thi

[jira] [Created] (KAFKA-19680) NoSuchElementException (again) in Kafka Streams iterator metrics

2025-09-05 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-19680: - Summary: NoSuchElementException (again) in Kafka Streams iterator metrics Key: KAFKA-19680 URL: https://issues.apache.org/jira/browse/KAFKA-19680 Project: K

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
AndrewJSchofield commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2326024172 ## tests/kafkatest/services/performance/share_consumer_performance.py: ## @@ -100,7 +100,7 @@ def start_cmd(self, node): for key, value in self.args()

[jira] [Created] (KAFKA-19679) NoSuchElementException (again) in Kafka Streams iterator metrics

2025-09-05 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-19679: - Summary: NoSuchElementException (again) in Kafka Streams iterator metrics Key: KAFKA-19679 URL: https://issues.apache.org/jira/browse/KAFKA-19679 Project: K

[jira] [Commented] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread ally heev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018465#comment-18018465 ] ally heev commented on KAFKA-19672: --- oops. I thought it was azure's > Producer perfor

[jira] [Created] (KAFKA-19678) Streams open iterator tracking has high contention on metrics lock

2025-09-05 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-19678: - Summary: Streams open iterator tracking has high contention on metrics lock Key: KAFKA-19678 URL: https://issues.apache.org/jira/browse/KAFKA-19678 Project:

Re: [PR] KAFKA-17840: Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module [kafka]

2025-09-05 Thread via GitHub
FrankYang0529 commented on PR #17609: URL: https://github.com/apache/kafka/pull/17609#issuecomment-3258352164 Sorry for that. I reassign `KafkaConfig` (https://issues.apache.org/jira/browse/KAFKA-15853) to @chia7712. We will handle it together. -- This is an automated message from the A

[jira] [Updated] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread ally heev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ally heev updated KAFKA-19672: -- Description: When running benchmark test, some of the producer perf tests are failing in statistics p

[jira] [Assigned] (KAFKA-15853) Move KafkaConfig to server module

2025-09-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-15853: - Assignee: Chia-Ping Tsai (was: PoAn Yang) > Move KafkaConfig to server module > --

[jira] [Updated] (KAFKA-19677) Flaky Test org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest

2025-09-05 Thread Lucy Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucy Liu updated KAFKA-19677: - Description: The test `SmokeTestDriverIntegrationTest` failed many time in recent runs: [https://develo

[jira] [Created] (KAFKA-19677) Flaky Test org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest

2025-09-05 Thread Lucy Liu (Jira)
Lucy Liu created KAFKA-19677: Summary: Flaky Test org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest Key: KAFKA-19677 URL: https://issues.apache.org/jira/browse/KAFKA-19677 Project: Kafka

[PR] KAFKA-19661 [5/N]: Prefer range-style assignment [kafka]

2025-09-05 Thread via GitHub
lucasbru opened a new pull request, #20486: URL: https://github.com/apache/kafka/pull/20486 This is actually fixing a difference between the old and the new assignor. Given the assignment ordering, the legacy assignor has a preference for range-style assignments built in, that is, assigning

[jira] [Reopened] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-09-05 Thread Erik van Oosten (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten reopened KAFKA-18818: - Unfortunately, using Kafka 4.1.0, the [zio-kafka|https://github.com/zio/zio-kafka] unit tes

Re: [PR] KAFKA-19585: Avoid noisy NPE logs when closing consumer after constructor failures [kafka]

2025-09-05 Thread via GitHub
lianetm commented on code in PR #20491: URL: https://github.com/apache/kafka/pull/20491#discussion_r2325603602 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -2029,6 +2030,27 @@ public void testRecordBackgroundEventQueueS

Re: [PR] MINOR: Fix typo for the headers.separator cli option [kafka]

2025-09-05 Thread via GitHub
chia7712 merged PR #20489: URL: https://github.com/apache/kafka/pull/20489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: extend consumer close java doc with error handling behaviour [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on PR #20472: URL: https://github.com/apache/kafka/pull/20472#issuecomment-3259002603 the root cause of flaky is https://github.com/apache/kafka/pull/20244/files#r2325557949 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] MINOR: extend consumer close java doc with error handling behaviour [kafka]

2025-09-05 Thread via GitHub
chia7712 merged PR #20472: URL: https://github.com/apache/kafka/pull/20472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: extend consumer close java doc with error handling behaviour [kafka]

2025-09-05 Thread via GitHub
AndrewJSchofield commented on PR #20472: URL: https://github.com/apache/kafka/pull/20472#issuecomment-3258448421 @lianetm Checkstyle :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] KAFKA-19585: Avoid noisy NPE logs when closing consumer after constructor failures [kafka]

2025-09-05 Thread via GitHub
gensericghiro opened a new pull request, #20491: URL: https://github.com/apache/kafka/pull/20491 If there's a failure in the kafka consumer constructor, we attempt to close it https://github.com/lianetm/kafka/blob/2329def2ff9ca4f7b9426af159b6fa19a839dc4d/clients/src/main/java/org/apache/kaf

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
Yunyung commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2325501796 ## tests/kafkatest/services/performance/share_consumer_performance.py: ## @@ -100,7 +100,7 @@ def start_cmd(self, node): for key, value in self.args().items():

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
Yunyung commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2325500088 ## tests/kafkatest/services/performance/consumer_performance.py: ## @@ -115,7 +115,7 @@ def start_cmd(self, node): for key, value in self.args(node.version).it

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
Yunyung commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2325500088 ## tests/kafkatest/services/performance/consumer_performance.py: ## @@ -115,7 +115,7 @@ def start_cmd(self, node): for key, value in self.args(node.version).it

[jira] [Resolved] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-09-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-19259. Assignee: Kirk True (was: Arpit Goyal) Resolution: Fixed > Async consumer fetch int

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
Yunyung commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2325486332 ## tools/src/test/java/org/apache/kafka/tools/ConsumerPerformanceTest.java: ## Review Comment: Please update messages -> num-records in testMetricsRetrievedBefore

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-09-05 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018434#comment-18018434 ] Arpit Goyal commented on KAFKA-19259: - Thanks [~lianetm] i will have a look . And le

[jira] [Created] (KAFKA-19673) Disallow create too many partitions also in createPartitions

2025-09-05 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-19673: - Summary: Disallow create too many partitions also in createPartitions Key: KAFKA-19673 URL: https://issues.apache.org/jira/browse/KAFKA-19673 Project: Kafka

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-09-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018432#comment-18018432 ] Lianet Magrans commented on KAFKA-19259: Hey [~goyarpit] , the proposed fixed so

[jira] [Resolved] (KAFKA-19659) Wrong generic type for UnregisterBrokerOptions

2025-09-05 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19659. -- Resolution: Fixed > Wrong generic type for UnregisterBrokerOptions > -

Re: [PR] MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes [kafka]

2025-09-05 Thread via GitHub
josefk31 commented on code in PR #20446: URL: https://github.com/apache/kafka/pull/20446#discussion_r2325454643 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ## @@ -57,7 +57,7 @@ private RecordsSnapshotWriter( snapshot.snapshotId().epoc

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-05 Thread via GitHub
lucasbru commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2324756475 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -296,9 +302,13 @@ private boolean hasUnfulfilledQ

Re: [PR] MINOR; Revert "KAFKA-18681: Created GetReplicaLogInfo RPCs (#19664)" [kafka]

2025-09-05 Thread via GitHub
jsancio merged PR #20371: URL: https://github.com/apache/kafka/pull/20371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-14083) Check if we don't need to refresh time in RecordAccumulator.append

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018362#comment-18018362 ] Ksolves India Limited commented on KAFKA-14083: --- As there are no updates h

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-09-05 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018420#comment-18018420 ] Arpit Goyal commented on KAFKA-19259: - Hi [~lianetm]  is this resolved ? I will look

[PR] KAFKA-19659: Wrong generic type for UnregisterBrokerOptions [kafka]

2025-09-05 Thread via GitHub
brandboat opened a new pull request, #20490: URL: https://github.com/apache/kafka/pull/20490 Fix wrong generic type for UnregisterBrokerOptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Reopened] (KAFKA-17840) Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module

2025-09-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reopened KAFKA-17840: > Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to > server module

[jira] [Comment Edited] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018403#comment-18018403 ] 黃竣陽 edited comment on KAFKA-19672 at 9/5/25 2:08 PM: - Hello [~schofi

[jira] [Commented] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018403#comment-18018403 ] 黃竣陽 commented on KAFKA-19672: - Hello [~schofielaj], I think the main reason is that this is

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-05 Thread via GitHub
mimaison commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2325165895 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Commented] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018394#comment-18018394 ] Andrew Schofield commented on KAFKA-19672: -- [~aheev] Just to check, this should

[jira] [Commented] (KAFKA-17840) Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module

2025-09-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018391#comment-18018391 ] Mickael Maison commented on KAFKA-17840: Reopened as https://github.com/apache/k

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
aheev commented on PR #20385: URL: https://github.com/apache/kafka/pull/20385#issuecomment-3257546255 This test seems to be flaky and not related to the changes. It succeeded in a couple of runs in my local. @AndrewJSchofield should we trigger a CI re-run? ``` FAILED ❌ SmokeTestDriverI

[jira] [Commented] (KAFKA-19675) StreamsOnTasksAssignedCallbackNeededEvent could not be completed

2025-09-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018380#comment-18018380 ] Lianet Magrans commented on KAFKA-19675: Hey, in case it helps, assuming the con

Re: [PR] KAFKA-17840: Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module [kafka]

2025-09-05 Thread via GitHub
mimaison commented on PR #17609: URL: https://github.com/apache/kafka/pull/17609#issuecomment-3258319890 No worries. It seems we can't quite move these classes yet, `ClientRequestQuotaManager` still depends on `kafka.network.RequestChannel`. We're pretty much at the point where we're blocke

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-05 Thread via GitHub
mimaison commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2324936446 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -38,9 +38,9 @@ import org.apache.kafka.image.publisher.{ControllerRegistrationsPublisher, Metad imp

Re: [PR] KAFKA-17840: Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module [kafka]

2025-09-05 Thread via GitHub
chia7712 commented on PR #17609: URL: https://github.com/apache/kafka/pull/17609#issuecomment-3258294813 > These classes are still in core, they were just rewritten in Java. Oops, looks like a mistake. Will handle it later -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
m1a2st commented on PR #20385: URL: https://github.com/apache/kafka/pull/20385#issuecomment-3258274562 It seems the failing e2e test is caused by https://github.com/apache/kafka/commit/fba01c42c80ba6983ab920b2005da24a00f7a657 . We can add the `warmup-records` option to these tests. I will f

[jira] [Updated] (KAFKA-19675) StreamsOnTasksAssignedCallbackNeededEvent could not be completed

2025-09-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19675: --- Description: In several tests, for example PlaintextAdminIntegrationTest, we see this excep

[jira] [Resolved] (KAFKA-14086) Cleanup PlaintextConsumerTest.testInterceptors to not pass null record

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited resolved KAFKA-14086. --- Resolution: Fixed > Cleanup PlaintextConsumerTest.testInterceptors to not pa

[jira] [Commented] (KAFKA-14086) Cleanup PlaintextConsumerTest.testInterceptors to not pass null record

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018360#comment-18018360 ] Ksolves India Limited commented on KAFKA-14086: --- As there are no updates h

[jira] [Created] (KAFKA-19675) StreamsOnTasksAssignedCallbackNeededEvent could not be completed before

2025-09-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19675: -- Summary: StreamsOnTasksAssignedCallbackNeededEvent could not be completed before Key: KAFKA-19675 URL: https://issues.apache.org/jira/browse/KAFKA-19675 Project

[PR] [MINOR] Fix typo for the headers.separator cli option [kafka]

2025-09-05 Thread via GitHub
lkokhreidze opened a new pull request, #20489: URL: https://github.com/apache/kafka/pull/20489 [MINOR] Fix typo for the headers.separator cli option. Should be `headers.separator=` instead of `headers.separator=` -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-09-05 Thread via GitHub
aheev commented on PR #20385: URL: https://github.com/apache/kafka/pull/20385#issuecomment-3257270674 > > Here are the results @m1a2st . Three tests failed, all of which are related to producer-perf > > Thanks, Could you file a ticket to trace this issue? https://issues.apache.

[jira] [Resolved] (KAFKA-14083) Check if we don't need to refresh time in RecordAccumulator.append

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited resolved KAFKA-14083. --- Resolution: Fixed > Check if we don't need to refresh time in RecordAccumula

[jira] [Commented] (KAFKA-14085) Clean up usage of asserts in KafkaProducer

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018361#comment-18018361 ] Ksolves India Limited commented on KAFKA-14085: --- As there are no updates h

[jira] [Assigned] (KAFKA-14086) Cleanup PlaintextConsumerTest.testInterceptors to not pass null record

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-14086: - Assignee: (was: Ksolves India Limited) > Cleanup PlaintextConsumerT

[jira] [Assigned] (KAFKA-14086) Cleanup PlaintextConsumerTest.testInterceptors to not pass null record

2025-09-05 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-14086: - Assignee: Ksolves India Limited > Cleanup PlaintextConsumerTest.testInt

Re: [PR] KAFKA-19661 [5/N]: Use below-quota as a condition for standby task assignment [kafka]

2025-09-05 Thread via GitHub
lucasbru commented on code in PR #20458: URL: https://github.com/apache/kafka/pull/20458#discussion_r2319150858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -53,24 +55,19 @@ public GroupAssignment assign(fi

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-05 Thread via GitHub
lucasbru commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2324753920 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -166,7 +166,10 @@ private Map> toCompactedTaskIds

Re: [PR] KAFKA-19661 [5/N]: Use below-quota as a condition for standby task assignment [kafka]

2025-09-05 Thread via GitHub
lucasbru commented on code in PR #20458: URL: https://github.com/apache/kafka/pull/20458#discussion_r2322407061 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -166,17 +174,22 @@ private Map> toCompactedTaskI

[PR] KAFKA-19674 - Disallow create too many partitions in ZK mode [kafka]

2025-09-05 Thread via GitHub
edoardocomar opened a new pull request, #20487: URL: https://github.com/apache/kafka/pull/20487 This PR - is a backporting of https://github.com/apache/kafka/pull/20485 to Kafka 3.9 and - applies the same 1 max new partitions limit when running in ZK mode -- This is an automa

[jira] [Updated] (KAFKA-19674) Disallow create too many partitions in ZK mode

2025-09-05 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19674: -- Summary: Disallow create too many partitions in ZK mode (was: [3.9] Disallow create too many

[jira] [Created] (KAFKA-19674) [3.9] Disallow create too many partitions in ZK mode

2025-09-05 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-19674: - Summary: [3.9] Disallow create too many partitions in ZK mode Key: KAFKA-19674 URL: https://issues.apache.org/jira/browse/KAFKA-19674 Project: Kafka Issue

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-05 Thread via GitHub
Copilot commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2324686649 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -25,6 +25,7 @@ import java.util.HashMap; import

[PR] KAFKA-19673: Disallow create too many partitions also in createPartitions [kafka]

2025-09-05 Thread via GitHub
edoardocomar opened a new pull request, #20485: URL: https://github.com/apache/kafka/pull/20485 Apply the same 1 new partitions limit when creating partitions as it is already done when creating new topics. Cluster unit test. -- This is an automated message from the Apache

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-09-05 Thread via GitHub
lucasbru commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2324653887 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -50,21 +52,122 @@ trait AutoTopicCreationManager { def createStreamsInternalTopics(

Re: [PR] MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols [kafka]

2025-09-05 Thread via GitHub
AndrewJSchofield commented on PR #20466: URL: https://github.com/apache/kafka/pull/20466#issuecomment-3257423068 Requesting review from @dajac since he's most knowledgeable about this config. I'm not certain the change is necessary or worthwhile given that this config is possibly being depr

[jira] [Commented] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-09-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018255#comment-18018255 ] ASF GitHub Bot commented on KAFKA-15307: mjsax merged PR #716: URL: https://gith

[jira] [Created] (KAFKA-19672) Producer performance test failing in parsing aggregate statistics

2025-09-05 Thread ally heev (Jira)
ally heev created KAFKA-19672: - Summary: Producer performance test failing in parsing aggregate statistics Key: KAFKA-19672 URL: https://issues.apache.org/jira/browse/KAFKA-19672 Project: Kafka

[jira] [Commented] (KAFKA-19668) processValues() must be declared as value-changing operation

2025-09-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018250#comment-18018250 ] Matthias J. Sax commented on KAFKA-19668: - Do not break backward compatibility,

Re: [PR] MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols [kafka]

2025-09-05 Thread via GitHub
JimmyWang6 commented on code in PR #20466: URL: https://github.com/apache/kafka/pull/20466#discussion_r2324278765 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1784,15 +1784,15 @@ class KafkaConfigTest { props.put(GroupCoordinatorConfig.GROUP_COORD

  1   2   >