see-quick commented on PR #20468:
URL: https://github.com/apache/kafka/pull/20468#issuecomment-3273960512
FYI: Those failed tests are not related to PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mimaison merged PR #20477:
URL: https://github.com/apache/kafka/pull/20477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 merged PR #20178:
URL: https://github.com/apache/kafka/pull/20178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
mjsax commented on PR #20512:
URL: https://github.com/apache/kafka/pull/20512#issuecomment-3273287116
Oh. While trying to cherry-pick to `4.0` branch, I realize that `4.0.0` is
not affected. We never cherry-picked to fix the "return null" issue
(https://issues.apache.org/jira/browse/KAFKA-1
mjsax commented on PR #20512:
URL: https://github.com/apache/kafka/pull/20512#issuecomment-3273274297
Thanks for the PR @Nikita-Shupletsov! Merged to `trunk` and cherry-picked to
`4.1` branch.
Congrats to your first contribution!
--
This is an automated message from the Apache Git
mjsax merged PR #20512:
URL: https://github.com/apache/kafka/pull/20512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Nikita-Shupletsov commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2334607715
##
streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java:
##
@@ -51,7 +52,10 @@ public void add(final MeteredIterator iterator)
TaiJuWu commented on code in PR #19236:
URL: https://github.com/apache/kafka/pull/19236#discussion_r2335483878
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -381,7 +381,7 @@ public void transitionToResigned(List
preferredSuccessors) {
*/
public
TaiJuWu commented on code in PR #19236:
URL: https://github.com/apache/kafka/pull/19236#discussion_r2335483878
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -381,7 +381,7 @@ public void transitionToResigned(List
preferredSuccessors) {
*/
public
github-actions[bot] closed pull request #17544: KAFKA-17339: LocalLogManager
should support RaftClient#schedulePreparedAppend
URL: https://github.com/apache/kafka/pull/17544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #19882:
URL: https://github.com/apache/kafka/pull/19882#issuecomment-3273056848
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #17544:
URL: https://github.com/apache/kafka/pull/17544#issuecomment-3273205960
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #17826:
URL: https://github.com/apache/kafka/pull/17826#issuecomment-3273206042
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #20456:
URL: https://github.com/apache/kafka/pull/20456#issuecomment-3273055211
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20359:
URL: https://github.com/apache/kafka/pull/20359#issuecomment-3273055707
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-3273057694
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
JimmyWang6 commented on code in PR #20508:
URL: https://github.com/apache/kafka/pull/20508#discussion_r2335273237
##
raft/src/main/java/org/apache/kafka/raft/EpochState.java:
##
@@ -59,4 +59,9 @@ default Optional highWatermark() {
* User-friendly description of the state
mjsax commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2335256270
##
streams/src/test/java/org/apache/kafka/streams/internals/metrics/OpenIteratorsTest.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mjsax commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2335235163
##
streams/src/test/java/org/apache/kafka/streams/internals/metrics/OpenIteratorsTest.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
chia7712 commented on code in PR #17930:
URL: https://github.com/apache/kafka/pull/17930#discussion_r2332115216
##
raft/src/test/java/org/apache/kafka/raft/RaftUtilTest.java:
##
@@ -646,6 +647,30 @@ public void
testAddRaftVoterRequestAckWhenCommittedNotIgnorable() {
);
lucasbru commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330078143
##
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java:
##
@@ -180,8 +180,8 @@ public void
testDescribeStreamsGroupWithStateAndVerboseOpt
mimaison commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2334136106
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataIm
apalan60 commented on code in PR #20496:
URL: https://github.com/apache/kafka/pull/20496#discussion_r2333576169
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2628,20 +2628,23 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
chia7712 commented on code in PR #20508:
URL: https://github.com/apache/kafka/pull/20508#discussion_r2335044297
##
raft/src/main/java/org/apache/kafka/raft/EpochState.java:
##
@@ -59,4 +59,9 @@ default Optional highWatermark() {
* User-friendly description of the state
chia7712 merged PR #20514:
URL: https://github.com/apache/kafka/pull/20514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #20502:
URL: https://github.com/apache/kafka/pull/20502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #20496:
URL: https://github.com/apache/kafka/pull/20496#discussion_r2334938734
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2628,20 +2628,22 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
bbejeck merged PR #20496:
URL: https://github.com/apache/kafka/pull/20496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
bbejeck commented on PR #20496:
URL: https://github.com/apache/kafka/pull/20496#issuecomment-3272428252
Merged #20496 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
chia7712 commented on code in PR #20492:
URL: https://github.com/apache/kafka/pull/20492#discussion_r2334908019
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1658,7 +1658,7 @@ class Partition(val topicPartition: TopicPartition,
def deleteRecordsOnLeader(offset:
AndrewJSchofield commented on code in PR #18611:
URL: https://github.com/apache/kafka/pull/18611#discussion_r2333801620
##
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java:
##
@@ -901,8 +903,10 @@ public void shouldConvertDateValues() {
assertEqua
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2334616174
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataI
ShivramSriramulu opened a new pull request, #20515:
URL: https://github.com/apache/kafka/pull/20515
## Summary
This PR enhances MirrorMaker 2 (MM2) with fault-tolerance capabilities to
address critical data loss scenarios in cross-cluster replication setups.
## Problem Statement
lianetm commented on PR #20514:
URL: https://github.com/apache/kafka/pull/20514#issuecomment-3271687931
Thanks @gensericghiro ! Could you add the MINOR prefix to the title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gensericghiro opened a new pull request, #20514:
URL: https://github.com/apache/kafka/pull/20514
## Summary
Similarly to what was done for AsyncKafkaConsumerTest::testFailConstructor,
[here](https://github.com/apache/kafka/pull/20491)
--
This is an automated message from the Ap
ShivramSriramulu closed pull request #20513: MM2: fail-fast on truncation +
auto-recover on topic reset (MirrorSourceTask)
URL: https://github.com/apache/kafka/pull/20513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
lucliu1108 closed pull request #20444: Kstreams 7247 debug
URL: https://github.com/apache/kafka/pull/20444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
ShivramSriramulu opened a new pull request, #20513:
URL: https://github.com/apache/kafka/pull/20513
## Summary
This PR enhances MirrorMaker 2 (MM2) with fault-tolerance capabilities to
address critical data loss scenarios in cross-cluster replication setups.
## Problem Statemen
mjsax commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2334202269
##
streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java:
##
@@ -51,7 +52,10 @@ public void add(final MeteredIterator iterator) {
Nikita-Shupletsov opened a new pull request, #20512:
URL: https://github.com/apache/kafka/pull/20512
Reapplied the fix https://github.com/apache/kafka/pull/18771 to fix the
regression introduced in https://github.com/apache/kafka/pull/20022
--
This is an automated message from the Apa
mimaison commented on PR #19341:
URL: https://github.com/apache/kafka/pull/19341#issuecomment-3271365467
It might be a good idea to share the link to the KIP here and in the Jira.
Otherwise it can be pretty hard to find it especially after the summer break.
--
This is an automated message
jsancio commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2333615167
##
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java:
##
@@ -17,7 +17,9 @@
package org.apache.kafka.controller.metrics;
+impo
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2333800898
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataI
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2333800898
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataI
chia7712 commented on code in PR #18611:
URL: https://github.com/apache/kafka/pull/18611#discussion_r2333759126
##
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java:
##
@@ -901,8 +903,10 @@ public void shouldConvertDateValues() {
assertEquals(curre
AndrewJSchofield commented on code in PR #18611:
URL: https://github.com/apache/kafka/pull/18611#discussion_r262219
##
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java:
##
@@ -901,8 +903,10 @@ public void shouldConvertDateValues() {
assertEqua
apalan60 commented on code in PR #20496:
URL: https://github.com/apache/kafka/pull/20496#discussion_r2333576169
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2628,20 +2628,23 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
lucasbru opened a new pull request, #20511:
URL: https://github.com/apache/kafka/pull/20511
In the consumer, we invoke the consumer rebalance onPartitionRevoked or
onPartitionLost callbacks, when the consumer closes. The point is that the
application may want to commit, or wipe the state if
TYsewyn opened a new pull request, #20510:
URL: https://github.com/apache/kafka/pull/20510
… and closing (#18752)
To address the issue of not creating a checkpoint file during the restoring
and closing process, called the
GlobalStateUpdateTask.flushState() method in
GlobalStateU
mimaison commented on PR #20359:
URL: https://github.com/apache/kafka/pull/20359#issuecomment-3270065582
Thanks for the PR. The performance gains seem impressive!
I don't think this method is called in particularly hot code paths. In
addition reviewing this kind of code is tricky. Thi
apoorvmittal10 merged PR #20507:
URL: https://github.com/apache/kafka/pull/20507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
mimaison commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2332845189
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataIm
mimaison commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-3269857466
Rebased on trunk to resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #20476:
URL: https://github.com/apache/kafka/pull/20476#issuecomment-3269821565
This is now ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
lucasbru merged PR #20266:
URL: https://github.com/apache/kafka/pull/20266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru opened a new pull request, #20509:
URL: https://github.com/apache/kafka/pull/20509
If a SmokeTestClient fails (enters a terminal ERROR state), the
SmokeTestDriverIntegrationTest currently times out, because it keeps waiting
for state NOT_RUNNING. This makes debugging quite difficul
chirag-wadhwa5 opened a new pull request, #20507:
URL: https://github.com/apache/kafka/pull/20507
The method rollbackOrProcessStateUpdates in SharePartition received 2
separate lists of updatedStates (InFlightState) and stateBatches
(PersisterStateBatch). This PR introduces a new subclass c
chia7712 merged PR #17930:
URL: https://github.com/apache/kafka/pull/17930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #20446:
URL: https://github.com/apache/kafka/pull/20446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #20446:
URL: https://github.com/apache/kafka/pull/20446#issuecomment-3268892847
> If that is the case, on the one hand this is just a refactoring; on the
other hand it's not an area of the code I'm familiar with. Not a huge deal to
change - it seems like other usage
chia7712 commented on code in PR #20491:
URL: https://github.com/apache/kafka/pull/20491#discussion_r2332025981
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -2029,6 +2030,28 @@ public void
testRecordBackgroundEventQueue
github-actions[bot] commented on PR #20450:
URL: https://github.com/apache/kafka/pull/20450#issuecomment-3268714876
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20454:
URL: https://github.com/apache/kafka/pull/20454#issuecomment-3268714780
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20392:
URL: https://github.com/apache/kafka/pull/20392#issuecomment-3268714988
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
mjsax commented on PR #20408:
URL: https://github.com/apache/kafka/pull/20408#issuecomment-3268456014
Thanks for the PR @shashankhs11. Merged to `trunk` and cherry-picked to
`4.1` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mjsax merged PR #20408:
URL: https://github.com/apache/kafka/pull/20408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Yunyung commented on code in PR #20479:
URL: https://github.com/apache/kafka/pull/20479#discussion_r2331457224
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleShareConsumerOptions.java:
##
@@ -58,11 +58,21 @@ public ConsoleShareConsumerOptions(String[] args) throws
TaiJuWu commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2330873629
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1786,13 +1786,12 @@ class KafkaConfigTest {
// This is OK.
props.put(GroupCoordinato
mjsax commented on code in PR #20403:
URL: https://github.com/apache/kafka/pull/20403#discussion_r2331376906
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -1104,11 +1104,18 @@ private void initializeTopology() {
// initiali
mjsax merged PR #20506:
URL: https://github.com/apache/kafka/pull/20506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax opened a new pull request, #20506:
URL: https://github.com/apache/kafka/pull/20506
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commen
TaiJuWu opened a new pull request, #20505:
URL: https://github.com/apache/kafka/pull/20505
Ignore SNAPSHOT_HEADER and SNAPSHOT_FOOTER when reading snapshots to avoid
to log such error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lucasbru commented on PR #20378:
URL: https://github.com/apache/kafka/pull/20378#issuecomment-3264941684
@shashankhs11 can you please close the PRs that we do not want to merge now
or give them a discriptive name and order? There are too many PRs and I don't
know which I should look at
--
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2329636362
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -44,7 +44,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.c
Copilot commented on code in PR #20465:
URL: https://github.com/apache/kafka/pull/20465#discussion_r2329360565
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -110,15 +110,12 @@ SmokeTestDriver.Verificati
josefk31 commented on PR #20446:
URL: https://github.com/apache/kafka/pull/20446#issuecomment-3266994013
> It seems the word `maxBatchSize` is still used in code case. Should we
align them in this PR?
@chia7712 do you mean it's still used
[here](https://github.com/apache/kafka/blob/f
lucasbru commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330103941
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -193,6 +196,9 @@ private void assignActive(final
lucasbru commented on code in PR #20457:
URL: https://github.com/apache/kafka/pull/20457#discussion_r2330119126
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4441,6 +4442,55 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInteg
TaiJuWu commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2330871537
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1786,13 +1786,12 @@ class KafkaConfigTest {
// This is OK.
props.put(GroupCoordinato
kirktrue commented on PR #20324:
URL: https://github.com/apache/kafka/pull/20324#issuecomment-3267125924
I'm closing this PR as we have decided against going any further with this
approach due to thread safety concerns.
cc @lianetm @AndrewJSchofield
--
This is an automated message
lucliu1108 commented on PR #20496:
URL: https://github.com/apache/kafka/pull/20496#issuecomment-3266940973
Added a waitUtilTrue to wait until all groups are stable before validating
the listGroup contents.
--
This is an automated message from the Apache Git Service.
To respond to the mess
lucasbru merged PR #20465:
URL: https://github.com/apache/kafka/pull/20465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
eduwercamacaro commented on code in PR #20403:
URL: https://github.com/apache/kafka/pull/20403#discussion_r2330605579
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -1104,11 +1104,18 @@ private void initializeTopology() {
//
mimaison commented on code in PR #20478:
URL: https://github.com/apache/kafka/pull/20478#discussion_r2330525031
##
release/release.py:
##
@@ -200,12 +200,113 @@ def command_release_announcement_email():
dev_branch = '.'.join(release_version_parts[:2])
docs_release_version = do
lucasbru merged PR #20483:
URL: https://github.com/apache/kafka/pull/20483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #20492:
URL: https://github.com/apache/kafka/pull/20492#discussion_r2330399941
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1658,7 +1658,7 @@ class Partition(val topicPartition: TopicPartition,
def deleteRecordsOnLeader(offset:
m1a2st opened a new pull request, #20504:
URL: https://github.com/apache/kafka/pull/20504
When using the find command, it currently lists all directories and files.
However, if it cannot find a child node, it throws an exception and prevents
the subsequent directories from being printed. I
bbejeck commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330289507
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/LegacyStickyTaskAssignorTest.java:
##
@@ -1263,6 +1263,119 @@ public void
shouldRemain
bbejeck commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330287941
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignorTest.java:
##
@@ -1091,6 +1091,148 @@ public void
shouldHandle
lucasbru commented on code in PR #20457:
URL: https://github.com/apache/kafka/pull/20457#discussion_r2330180515
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -239,7 +239,8 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness
lucasbru commented on code in PR #20457:
URL: https://github.com/apache/kafka/pull/20457#discussion_r2330173867
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -16216,6 +16216,98 @@ barTopicName, computeTopicHash(barTopi
lucasbru commented on code in PR #20457:
URL: https://github.com/apache/kafka/pull/20457#discussion_r2330172947
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -6005,7 +6010,13 @@ public void replay(
if (value ==
lucasbru commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330109103
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/LegacyStickyTaskAssignorTest.java:
##
@@ -1263,6 +1263,119 @@ public void
shouldRemai
lucasbru commented on code in PR #20486:
URL: https://github.com/apache/kafka/pull/20486#discussion_r2330105629
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -296,9 +302,13 @@ private boolean hasUnfulfilledQ
lucasbru commented on PR #20382:
URL: https://github.com/apache/kafka/pull/20382#issuecomment-3264942101
Close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2329654875
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2329645606
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2329659275
##
server-common/src/main/java/org/apache/kafka/server/common/CredentialProvider.java:
##
Review Comment:
Yeah, I think that's a good idea.
--
This is an aut
oertl commented on PR #20359:
URL: https://github.com/apache/kafka/pull/20359#issuecomment-3265152054
@mimaison, is there anything I can do to bring this PR forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
joshua2519 commented on code in PR #20083:
URL: https://github.com/apache/kafka/pull/20083#discussion_r2329424425
##
storage/src/main/java/org/apache/kafka/storage/internals/log/OngoingReassignmentState.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation
1 - 100 of 18802 matches
Mail list logo
