[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1137608147 ## clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java: ## @@ -198,6 +204,35 @@ public void testForgottenTopics(short version) {

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136238469 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136249875 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136238469 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136218503 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May retur

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136021203 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -1436,6 +1441,38 @@ public void testInvalidFetchRequest() throws Exception {

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133007633 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -958,7 +959,10 @@ private CompletableFuture handleFetchRequest( Errors

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133024404 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -144,18 +146,28 @@ public static class Builder extends AbstractRequest.Build

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133007633 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -958,7 +959,10 @@ private CompletableFuture handleFetchRequest( Errors

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132971982 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -1436,6 +1438,28 @@ public void testInvalidFetchRequest() throws Exception {

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r113296 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1272,6 +1274,7 @@ class ReplicaManagerTest { } verify(mockLogMgr).fini

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132965843 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1103,14 +1136,18 @@ class ReplicaFetcherThreadTest { assertProcessPartition

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132957256 ## core/src/test/scala/unit/kafka/raft/KafkaNetworkChannelTest.scala: ## @@ -159,6 +167,29 @@ class KafkaNetworkChannelTest { } } + @ParameterizedTes

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132956895 ## core/src/test/scala/kafka/server/RemoteLeaderEndPointTest.scala: ## @@ -58,7 +58,7 @@ class RemoteLeaderEndPointTest { blockingSend = new MockBlocki

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132937282 ## core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala: ## @@ -105,14 +108,18 @@ class KafkaNetworkChannel( private val correlationIdCounter = new Atomi

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132807275 ## core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala: ## @@ -44,7 +44,10 @@ object KafkaNetworkChannel { case fetchRequest: FetchRequestData =>

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1130321942 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3290,7 +3290,7 @@ class KafkaApisTest { when(clientQuotaManager.maybeRecordAndGetThrot

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1130289064 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -974,7 +974,7 @@ void assertFetchRequestData( assertEquals(epoch, fetchPa

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1130233921 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -103,11 +103,12 @@ class ReplicaFetcherThreadTest {

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128713441 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int throttleTimeM

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128713021 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +315,18 @@ public String toString() { } } +public

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128712574 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest( RaftRequest.I

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123476762 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int throttleTimeM

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123475771 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +315,18 @@ public String toString() { } } +public

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123469847 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest( RaftRequest.I