[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-24 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1303966365 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +614,134 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-24 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1303964994 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +614,134 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-23 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1302833394 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +619,126 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-23 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1302658841 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -478,23 +498,45 @@ void testMetricsUpdateOnCopyLogSegmentsFailure() throws Exception {

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-15 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1294052739 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -72,15 +72,17 @@ public TimeIndex(File file, long baseOffset, int

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-14 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1294052739 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -72,15 +72,17 @@ public TimeIndex(File file, long baseOffset, int

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-08-14 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1293155986 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -574,6 +575,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-07-27 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1276036068 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -574,6 +575,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-07-27 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1276035377 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -599,6 +602,13 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-07-27 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1276033912 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +618,38 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-07-27 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1276033212 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +618,38 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

2023-07-27 Thread via GitHub
Nickstery commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1276033212 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +618,38 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws