[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-09-13 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1717877198 > Hi @OmniaGM, thanks. I left some comments. > > Additionally, this error message is different from previous implementation: > > ```shell > ### OLD > $

[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-09-12 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1716058400 > > java.lang.NoClassDefFoundError: org/apache/kafka/server/log/remote/storage/RemoteStorageException > > Hi @fvaleri, I am getting this error with all branches once I move any

[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-09-11 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1713875320 > java.lang.NoClassDefFoundError: org/apache/kafka/server/log/remote/storage/RemoteStorageException I am getting this error with all branches once I move the tools outside the

[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-08-02 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1661932121 I have updated the PR to use #13158 and #13278. The test checks are failing because of an unrelated class. However the `:tools:compileTestJava` is failing because it doesn't like

[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-07-09 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1627731940 > Hi @OmniaGM. > > > Move TopicFilter out of core. (This is part of https://issues.apache.org/jira/browse/KAFKA-14647 which seems not moving for a while ) > > I think

[GitHub] [kafka] OmniaGM commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-06-18 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1596238230 Hi @divijvaidya I just did rebase this with trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above