[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970668525 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970637424 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -103,42 +101,75 @@ public void addPendingStandbyTasksToCreate(final Map

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-12 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r968443807 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-12 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r968441157 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,96 @@ private void classifyTasksWithoutStateUpdater(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-12 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r968378813 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -52,11 +53,8 @@ class Tasks implements TasksRegistry { // we receive a new

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-12 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r968207039 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966991995 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -817,14 +867,17 @@ private boolean

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966987932 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966978149 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final