chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484622290
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -202,9 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484543835
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484209068
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484164627
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1010,15 +1010,7 @@ class Partition(val topicPartition: TopicPartition,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484163863
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484138649
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484099709
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097948
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097601
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097161
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484039528
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r483897245
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r483552275
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r482753529
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r482743072
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479737358
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479692892
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479692892
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479689694
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -37,7 +37,10 @@ class ActionQueue {
* picks up an action to complete.
*/
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479689838
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479689694
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -37,7 +37,10 @@ class ActionQueue {
* picks up an action to complete.
*/
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479689664
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479689381
##
File path: core/src/main/scala/kafka/server/ActionQueue.scala
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479686517
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -85,6 +85,8 @@ object LogAppendInfo {
* @param validBytes The number of valid bytes
*
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479683036
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -562,6 +564,10 @@ class ReplicaManager(val config: KafkaConfig,
* Append
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479680637
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -134,6 +134,8 @@ class KafkaServer(val config: KafkaConfig, time: Time =
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479679930
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -100,41 +99,22 @@ abstract class DelayedOperation(override val delayMs: Long,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479678653
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -585,6 +591,23 @@ class ReplicaManager(val config: KafkaConfig,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479677889
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -180,6 +181,11 @@ class KafkaApis(val requestChannel: RequestChannel,
case
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r465206257
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r465200508
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r464791414
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463066323
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463066191
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r452755236
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -65,13 +65,24 @@ import scala.compat.java8.OptionConverters._
/*
* Result
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r452754165
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r442337184
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -106,12 +107,29 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r441938393
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -106,25 +97,56 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r441938174
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -106,25 +97,56 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r441289689
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -307,8 +307,14 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r440585314
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -311,37 +317,47 @@ class GroupMetadataManager(brokerId: Int,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r440578202
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -967,7 +967,16 @@ class Partition(val topicPartition: TopicPartition,
}
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r440576071
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -307,8 +307,14 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r439923720
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -967,7 +967,16 @@ class Partition(val topicPartition: TopicPartition,
}
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r439920019
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
##
@@ -536,6 +537,11 @@ class GroupCoordinatorTest {
//
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r439915438
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -967,7 +967,16 @@ class Partition(val topicPartition: TopicPartition,
}
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r439914680
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala
##
@@ -307,8 +307,14 @@ class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431210497
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -65,13 +65,24 @@ import scala.compat.java8.OptionConverters._
/*
* Result
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431209368
##
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##
@@ -33,11 +34,40 @@ import scala.math.{max, min}
*/
private[group] class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431208549
##
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##
@@ -33,11 +34,40 @@ import scala.math.{max, min}
*/
private[group] class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431206147
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/DelayedJoinTest.scala
##
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431003374
##
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##
@@ -33,11 +33,15 @@ import scala.math.{max, min}
*/
private[group] class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431002494
##
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##
@@ -33,11 +33,15 @@ import scala.math.{max, min}
*/
private[group] class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431001869
##
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##
@@ -33,11 +33,15 @@ import scala.math.{max, min}
*/
private[group] class
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r430253921
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -769,20 +813,25 @@ class GroupCoordinator(val brokerId: Int,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r427723802
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r427435780
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r427114083
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -970,7 +970,16 @@ class Partition(val topicPartition: TopicPartition,
}
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r427102729
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r427095614
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -769,20 +813,25 @@ class GroupCoordinator(val brokerId: Int,
60 matches
Mail list logo