[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071531038 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetDeleteResponse.java: ## @@ -44,6 +48,83 @@ */ public class OffsetDeleteResponse extends

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071450200 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp =

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070933822 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2764,37 +2763,170 @@ class KafkaApisTest { val request = buildRequest(offsetDeleteRequest)

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070928680 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp =

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070115003 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2817,14 +2949,18 @@ class KafkaApisTest { .setTopics(topics) ).build() val

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1069967097 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp =

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1068450233 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3110,61 +3110,69 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1067069590 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1065739439 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1065738658 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or