[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276742165 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5567,7 +5600,7 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276739854 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java: ## @@ -764,4 +813,39 @@ public void testNewOffsetCommitTombstoneRecord() {

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276677238 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -440,12 +442,13 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276671418 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -84,14 +85,15 @@ public void addGroupMember(

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276670928 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/SubscribedTopicMetadataTest.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276670286 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -571,4 +716,14 @@ private void assertAssignment(Map>>

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276669652 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java: ## @@ -764,4 +813,39 @@ public void testNewOffsetCommitTombstoneRecord() {

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276668936 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java: ## @@ -612,15 +616,14 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r127851 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5692,12 +5725,60 @@ private void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276663083 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5692,12 +5725,60 @@ private void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276659754 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5692,12 +5725,60 @@ private void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276659754 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5692,12 +5725,60 @@ private void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1276653838 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5567,7 +5600,7 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275243699 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -131,13 +131,24 @@ public static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275242714 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: Hum.. I asked in the other PR if the change was

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1274915017 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java: ## @@ -756,4 +759,24 @@ public void testNewOffsetCommitTombstoneRecord() {

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1274909957 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: Why are we moving this one? -- This is an